- 05 Oct, 2017 40 commits
-
-
Hidehiko Abe authored
BUG=None TEST=Ran cpplint.py to files under chromeos/dbus. Change-Id: Id5ffb9b8dc986cb224df6ac630dc6b3871242572 Reviewed-on: https://chromium-review.googlesource.com/702135Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#506750}
-
Leon Scroggins III authored
Bug: 761608 Bug: 771075 Downloaded from http://libpng.download/src/libpng16 https://github.com/glennrp/libpng/commit/edef058e180be435afd8feebb742a22360a7fa3f (included in this revision) moved the SSE opts directly into the main libpng source, so contrib/intel/intel_sse.patch is no longer necessary, as its changes are already included. Other changes: - README.chromium: - Update version number. - Remove references to cherry-picks from upstream, as the fixes are now included without cherry-picks. - Remove reference to applying intel_sse.patch, which is no longer necessary. - BUILD.gn: - Build the intel code from its new location. - PNGImageDecoderTest.cpp: - Remove unnecessary tests. TestFailureDuringDecode attempted to modify a valid PNG file to have an error, and then verified that it actually had an error, while leaving the FrameCount unchanged. I do not see much value to the test, and the apparently more lenient newer libpng no longer considers this modified file to be broken. Change-Id: I2c7e517403609aed2051b91df47dd9f87f62e1ab Reviewed-on: https://chromium-review.googlesource.com/671029Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506749}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/985e86f297e8..38d0449a02f4 $ git log 985e86f29..38d0449a0 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 art-snake Fix Null-dereference READ in CPDF_Dictionary::GetIntegerFor. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ic00c139e1e4295cbf07651559bb55743e42b5408 Reviewed-on: https://chromium-review.googlesource.com/701327 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506748}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 22de7321. With Chromium commits locally applied on WPT: 57e5929e "Implemented: remove browsing context name on cross origin navigation" Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2575 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley@chromium.org No-Export: true Change-Id: I57ed020f24dc3f1fde97617061692e4c855e422d Reviewed-on: https://chromium-review.googlesource.com/702039 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506747}
-
John Chen authored
Occasionally the ChromeDriver build bots may fail to convert Git revision to commit position due to network or server errors. This cause issues in subsequent build steps, including uploading files with bad file names. This CL modifies the build script to check for such errors. Bug: chromedriver:2012 Change-Id: If0a585761dccc69481e39e276d4e538547d31a6e Reviewed-on: https://chromium-review.googlesource.com/698369 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#506746}
-
Ian Vollick authored
If we set up a scoped task environment in run_all_unittests.cc, we both support ozone (which expects this) and obviate message loop creation by our tests. Bug: 770469 Change-Id: Ibdd803c0d209c721e2c27ed4e6a37210a96f1537 Reviewed-on: https://chromium-review.googlesource.com/702042Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506745}
-
Ian Vollick authored
With this change, we pump frames at 60Hz. Bug: None Change-Id: I9aa814c1ff8d3ae88a85723a4193a2b221493d96 Reviewed-on: https://chromium-review.googlesource.com/702043Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506744}
-
Alex Moshchuk authored
See https://crbug.com/765711#c12 for the description of the race. tldr is that with --site-per-process, we might have two isolated.foo.com processes eligible for reuse if one of them doesn't die in time, and we pick the one that the test doesn't expect for navigating the subframe back to isolated.foo.com. The fix is to wait for the subframe's old isolated.foo.com RFH to be destroyed before navigating it back to isolated.foo.com. This ensures there's only one process that can be reused. Bug: 765711 Change-Id: I23740e1f4e1aa7882f977300a5000630d49d9efe Reviewed-on: https://chromium-review.googlesource.com/701289Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506743}
-
Helen Li authored
Shut down executor in CronetStressTest. Bug: 771366 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Id94e90c22ed2c3760da674f731a4dbcd4c6e5dbe Reviewed-on: https://chromium-review.googlesource.com/702037 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#506742}
-
Mike Klein authored
TBR=fmalita@chromium.org Bug: skia:7114 Change-Id: I3755a177ad5f830868f928df7fe75ea78c51d73c Reviewed-on: https://chromium-review.googlesource.com/701703 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#506741}
-
Robert Sesek authored
The private window animation APIs used by ConstrainedWindow tend to crash the WindowServer when DisplayLink hardware is attached. This change enables the use of the simple animation style when the DisplayLinkFramebuffer is found in the IOKit registry. Bug: 755516 Change-Id: Iae2faa92bb987973f6e94bb3e1ed0d13f3ce3579 Reviewed-on: https://chromium-review.googlesource.com/700424 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#506740}
-
Peter E Conn authored
Bring the UI captured by the test in line with what is seen by default. Bug: 754184 Change-Id: Id18971774dbbd87f14aa701f04ba101d2137d580 Reviewed-on: https://chromium-review.googlesource.com/702262Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#506739}
-
Mikhail Fomitchev authored
The code was added in https://chromium-review.googlesource.com/c/chromium/src/+/616012. Bug: NONE Change-Id: I1cb518459ba08bc3e595440a5dad604ec7b91995 Reviewed-on: https://chromium-review.googlesource.com/701115 Commit-Queue: Mikhail Fomitchev <mfomitchev@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506738}
-
W. James MacLean authored
Bug: 771993 Change-Id: I9d19e5c8103158f83cfbfc5974f9b9e88e8856fc TBR=avi@chromium.org Change-Id: I9d19e5c8103158f83cfbfc5974f9b9e88e8856fc Reviewed-on: https://chromium-review.googlesource.com/702514Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#506737}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96fdef6d..58c1372e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I4c856c4a4ff8b84c33b049bda0b2a8311ae7c995 Reviewed-on: https://chromium-review.googlesource.com/701702Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506736}
-
nagarajan.n authored
1. Always we are setting options.fPriorFrame to SkCodec::kNone when it retries to start the startIncrementalDecode. This patch fixes this issue 2. Move options and image_info variable initialization to before the startIncrementalDecode. Bug: None Change-Id: I606f79c73c7631547e05c2eb828f5d31e761ecca Reviewed-on: https://chromium-review.googlesource.com/700195Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#506735}
-
Avi Drissman authored
BUG=770788 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I5b0f2b2d6668bddfb92b6a452487edf69f817b1f Reviewed-on: https://chromium-review.googlesource.com/696684 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506734}
-
Raphael Kubo da Costa authored
Currently, a significant fraction of imports are practically empty with only WPT_BASE_MANIFEST.json updates. We can stop early in this case and start the next cycle. The main benefit is faster cycle and lower latency. Bug: 768853 Change-Id: If7335ae8a8f9caf56e5b5c3d755264c16992378e Reviewed-on: https://chromium-review.googlesource.com/700595Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#506733}
-
James MacLean authored
This reverts commit dca5651b. Reason for revert: appears to be breaking a bunch of bots, e.g. https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/45778 See also: https://bugs.chromium.org/p/chromium/issues/detail?id=771978 Original change's description: > Make WTF::RefPtr an alias of scoped_refptr > > Bug: 763844 > Change-Id: Id348010e19f90b3042b4193a7641760949a12e50 > Reviewed-on: https://chromium-review.googlesource.com/700334 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506696} TBR=haraken@chromium.org,tzik@chromium.org Change-Id: I09fee4ea6aeec51098bea98509dad262c89cf4f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 763844 Reviewed-on: https://chromium-review.googlesource.com/701269Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#506732}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/01f8e41c1368..3a9305383169 $ git log 01f8e41c1..3a9305383 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 robertphillips Always use draws instead of clears for ANGLE D3D11 Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I0db89d71391f90a8bcdf6422d6cbfa5cc7d2c335 Reviewed-on: https://chromium-review.googlesource.com/701325Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506731}
-
Devlin Cronin authored
The cryptotoken resources aren't currently closure compiled, but probably should be. Add a few of the simple targets to start. Bug: 770263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I41284a7b3e4ec8a1d4ec2394f8cd340150b6e271 Reviewed-on: https://chromium-review.googlesource.com/692983 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506730}
-
Tim Volodine authored
Disable CronetStressTest#testLargeNumberOfUploads because it's failing on the Android Cronet Builder Asan bot. BUG=771366 TBR=xunjieli@chromium.org,kapishnikov@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I3d055872590e89857571c6f9e3135cb1e1d9196e Reviewed-on: https://chromium-review.googlesource.com/702307Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#506729}
-
Henrik Boström authored
Changes: https://webrtc.googlesource.com/src.git/+log/83ccca1..ca95748 $ git log 83ccca1..ca95748 --date=short --no-merges --format=%ad %ae %s 2017-10-05 kthelgason@webrtc.org Add tests for ScopedCFTypeRef. 2017-10-05 danilchap@webrtc.org Revert "Remove deprecated functions from RtcEventLog" 2017-10-05 alessiob@webrtc.org Customizable noise tracks path in APM-QA 2017-10-05 oprypin@webrtc.org Change iOS deployment target to 9.0 2017-10-05 sakal@webrtc.org Always copy output byte buffers in HardwareVideoDecoder. 2017-10-05 sprang@webrtc.org Reduce time between sync frames for temporal layers vp8 screensharing. 2017-10-05 eladalon@webrtc.org Remove deprecated functions from RtcEventLog 2017-10-04 oprypin@webrtc.org Simplify PRESUBMIT.py and check_package_boundaries.py 2017-10-05 kjellander@webrtc.org Revert "Reland "Clean up libjingle API dependencies."" 2017-10-02 phoglund@webrtc.org Reland "Clean up libjingle API dependencies." 2017-10-04 nisse@webrtc.org Update comments for rename of ScalingObserverInterface. 2017-10-05 nisse@webrtc.org Delete in_order argument to RtpReceiver::IncomingRtpPacket 2017-10-05 kjellander@webrtc.org Revert "Disable win_baremetal." 2017-10-04 zhihuang@webrtc.org Change the flag when RtpTransport objects send packet. Always use the PF_SRTP_BYPASS when sending RTP/RTCP packets. 2017-10-04 sakal@webrtc.org Add back loading native library in Logging.java. 2017-10-04 deadbeef@webrtc.org Clarifying Logging.java comment more. 2017-10-04 oprypin@webrtc.org Fix bugs in check_package_boundaries.py presubmit 2017-10-04 ehmaldonado@webrtc.org Fix flag name in low_bandwidth_audio_test.py 2017-09-29 terelius@webrtc.org Don't append the bitrate twice to the outgoing bitrate plot in event_log_visualizer. 2017-10-04 ehmaldonado@webrtc.org Ignore swarming arguments in low_bandwidth_audio_test.py 2017-10-04 sakal@webrtc.org Add JavaI420Buffer to the API. 2017-10-04 solenberg@webrtc.org Reland "Reland "Remove WEBRTC_TRACE."" 2017-10-04 ilnik@webrtc.org Implement ScreenshareTemporalLayersChecker 2017-10-04 denicija@webrtc.org Add availablitity macro to RTCFileVideoCapturer 2017-10-04 terelius@webrtc.org Add simulation of receive-side bandwidth estimate to event_log_analyzer. 2017-10-04 ehmaldonado@webrtc.org Reland "Don't download PESQ and POLQA in the low_bandwidth_audio_test.py script." 2017-10-04 aleloi@webrtc.org Boxplot for APM-QA 2017-10-04 alessiob@webrtc.org No normalization of input and noise tracks in the test data generators of APM-QA 2017-10-04 solenberg@webrtc.org Reland "Remove AudioDeviceObserver and make ADM not inherit from the Module interface." 2017-10-04 kwiberg@webrtc.org RTPPayloadRegistry: Use SdpAudioFormat to represent audio codecs TBR=hbos@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Bug: Change-Id: I24d1872e782a8d0ebe27281ab96ef743018890d1 Reviewed-on: https://chromium-review.googlesource.com/702297Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506728}
-
Samuel Huang authored
This reverts commit 6869b788. Reason for revert: This seems to cause service_unittests flake. Original change's description: > viz: Re-arrange the threads in ui::GpuMain. > > Create a separate thread for the compositor. Use the thread the GpuMain > instance is created on as the thread for the GpuService. This allows > using it in content (in GpuChildThread), where the main thread is used > for the gpu service. > > For the mus window server, until the gpu process-split happens, create > a separate thread for the gpu service from the DefaultGpuHost. After > the process split, the main thread of the new process can be used for > the gpu service (like GpuChildThread in content). > > BUG=730213 > > Change-Id: I02eb4fef21bfbdac92201c35b96ac15473a43567 > Reviewed-on: https://chromium-review.googlesource.com/693075 > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506450} TBR=sadrul@chromium.org,fsamuel@chromium.org,kylechar@chromium.org Change-Id: Ie6daf8a9306da93637d6e69972d4f145192030bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730213 Reviewed-on: https://chromium-review.googlesource.com/701310Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#506727}
-
Michael van Ouwerkerk authored
Delete the video overlay flag, make this part of Chrome Home instead. Bug: 728551,745858, 767638, 740191 Change-Id: I8627ac98102d64a266987d15917550c4f8fb8519 Reviewed-on: https://chromium-review.googlesource.com/700600 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#506726}
-
Jeremy Roman authored
Move InputMethodController, SelectionController and IdleSpellCheckCallback to DocumentShutdownObserver. They do not observe any other kind of change to the document, and so can only register for destruction notification. This saves 5% on an appendChild/removeChild microbenchmark (Linux workstation). Change-Id: I0cc469ae2aff9786a830f717ba9259d0bd132ad9 Reviewed-on: https://chromium-review.googlesource.com/701794Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#506725}
-
Danyao Wang authored
Added a NavigationManagerImpl::SetPreviousItemIndex() API to support the SessionStorageBuilder use case, so that CRWSessionController can be completely hidden behind the NavigationManagerImpl interface. Fixed TabModelTest's dummy session storage creation code; for empty session, lastCommittedItemIndex should be -1. Without this, the DCHECKs in LegacyNavigationManagerImpl::Restore() will fail. This was not a problem before because SessionStorageBuilder::ExtractSessionState() did not check input invariants. Tweaked input DCHECKs in LegacyNavigationManagerImpl::Restore() to allow empty session as valid input. Bug: 734150 Change-Id: I3e773347a8e5798f23888f8b757ae026fb85f2f3 Reviewed-on: https://chromium-review.googlesource.com/695830 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#506724}
-
Dominik Röttsches authored
This reverts commit 4835d56d. Reason for revert: Original CL got reverted due to redness. Original change's description: > Missing baselines for "Avoid using bitmap glyphs for blacklisted fonts" > > Baseline fixes for CL landed in e52a0d6a > > NOTRY=TRUE > TBR=tnagel > > Bug: 707713 > Change-Id: Ic146c44d36f62445abb7ef6702031848e779f898 > Reviewed-on: https://chromium-review.googlesource.com/702480 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506714} TBR=tnagel@chromium.org,drott@chromium.org Change-Id: I9f849efc328182da71f41b9e788492ca81afb29a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 707713 Reviewed-on: https://chromium-review.googlesource.com/701759Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#506723}
-
Takayoshi Kochi authored
Bug: 771111 Change-Id: I7f791cb0c5c32d92adf1e05c6719a37fca871475 Reviewed-on: https://chromium-review.googlesource.com/697190 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#506722}
-
Geoff Lang authored
BUG=770696 TEST=GLReadbackTest.ReadPixelsWithPBOAndQuery TEST=GLES*DecoderPassthroughTest.ReadPixelsAsync* Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5194075c8efe7c6b65830ce89719a1b3e048d7bb Reviewed-on: https://chromium-review.googlesource.com/696022Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#506721}
-
James MacLean authored
This reverts commit e52a0d6a. Reason for revert: This CL looks to be causing a lot of carnage on the WebKit layout tests on various bots. Original change's description: > Avoid using bitmap glyphs for blacklisted fonts > > The Calibri Windows font has bitmap strikes for sizes 12, 13, 15, 16, > 17, 19. When this font is drawn while using subpixel positioning, letter > spacing becomes wonky: Skia/DWrite are not using multiple subpixel > aliased glyph versions. Usually, with subpixel positioning and > antialiasing 3 or 4 versions of an antialiased glyph exist with > different shading and color filtering. Here, only one antialiased glyph > variant is used, which is placed at full pixel boundaries. For bitmap > strike font sizes Skia/DWrite now rounds the glyph positions within the > text to full pixel positions to place this one glyph variant. The result > is that the letter spacing becomes uneven, whith glyphs moving closer or > further away from each other when the horizontal subpixel offset is > changed [1]. > > As a mitigation of this problem, disable the usage of embedded bitmap > strikes for Calibri for now. We have not encountered any other non CJK > script fonts that would expose bitmap _and_ vector outline glyphs. > > The setEmbeddedBitmapText flag of SkPaint mostly controls what to do > with fonts that have outlines and embedded bitmaps. > > [1] https://bugs.chromium.org/p/chromium/issues/detail?id=707713#c5 > [2] https://hg.mozilla.org/mozilla-central/rev/c93381b53df3 > > Bug: 707713 > Change-Id: Iae81803ece1ada49e363ff46e0e06df3a26dbcde > Reviewed-on: https://chromium-review.googlesource.com/623672 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506693} TBR=bungeman@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org,behdad@chromium.org Change-Id: I278899fb8cc929e0e08390b3c7b0a5a1b2289e9d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 707713 Reviewed-on: https://chromium-review.googlesource.com/702494Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#506720}
-
Andy Paicu authored
Bug: 771922 Change-Id: Ie14cdbe6d7e62761a784d94f20087024416da764 Reviewed-on: https://chromium-review.googlesource.com/702474 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#506719}
-
Daniel Vogelheim authored
This reverts commit 76332054. Reason for revert: Original problem was fixed on tree even before the revert landed; so apparently it wasn't this CL. Original change's description: > Revert "Fix spurious DCHECK when WorkStealingInScriptRunner is enabled." > > This reverts commit 22fa13f2. > > Reason for revert: interactive_ui_tests are timing out. Speculative revert (the other CL in the regression range looks like an unlikely culprit to me). > > https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/29628 > > Original change's description: > > Fix spurious DCHECK when WorkStealingInScriptRunner is enabled. > > > > Bug: 754360 > > Change-Id: I8dd792787dcf5835eeb279f5ce535cb871f6d1e0 > > Reviewed-on: https://chromium-review.googlesource.com/660698 > > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#506691} > > TBR=hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,tzik@chromium.org > > Change-Id: Ifad44699988aee7f1a8001897e75b592c7d19ebb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 754360 > Reviewed-on: https://chromium-review.googlesource.com/702336 > Reviewed-by: Thiemo Nagel <tnagel@chromium.org> > Commit-Queue: Thiemo Nagel <tnagel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506706} TBR=tnagel@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,tzik@chromium.org Change-Id: I35841f0e4a5297fc98c5b11e60bb93399005165c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 754360 Reviewed-on: https://chromium-review.googlesource.com/702337Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#506718}
-
Marc-Antoine Courteau authored
Also, behave the same was as on desktop, showing validation error messages in real-time as fields are edited, once they are no longer pristine (i.e., the user has entered and exited the field already). Bug: 768387 Change-Id: I4d8cf605e0e79422e31ca1fc5eda7a9e4161545a Reviewed-on: https://chromium-review.googlesource.com/698905Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#506717}
-
Dianna Hu authored
The compiler can't reliably determine that CHECK(false) terminates the program - the expansion of that macro is fairly complicated on some platforms. HTTP2_BUG and QUIC_BUG solve this problem and are also more readable for humans. This CL also fixes one minor lint nit (missing #include). This CL lands server change 170526551 by durandal and 170955835 by diannahu. BUG=488484 Change-Id: Ib3aecad5c029ee37a03475529fa34e9d0e0dd8f0 Reviewed-on: https://chromium-review.googlesource.com/700075 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#506716}
-
yoshiki iguchi authored
In some case, an infinite loop happens in ArcNotificationContent:: UpdateControlButtonVisiblity() method. The logic is: UpdateControlButtonsVisiblity() tries hiding the control buttons, it generates a mouse exit event, and the event handler calls UpdateControlButtonsVisibility. To prevent that, this patch adds the flag to prevent the calling the method during the method. Bug: 771084 Test: manual Change-Id: I03f9d5c00eb3c7f39bebebec03bfeb51616ca925 Reviewed-on: https://chromium-review.googlesource.com/697406Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#506715}
-
Dominik Röttsches authored
Baseline fixes for CL landed in e52a0d6a NOTRY=TRUE TBR=tnagel Bug: 707713 Change-Id: Ic146c44d36f62445abb7ef6702031848e779f898 Reviewed-on: https://chromium-review.googlesource.com/702480 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#506714}
-
Tim Volodine authored
Disable some carousel tests, because they are failing on the K/L/M Tablet Tester bots (see crbug.com/771955). The following tests are disabled in this patch: ContextualSuggestionsTest#testCardAppearance ContextualSuggestionsTest#testCarouselIsNotShownWhenFlagIsDisabled ContextualSuggestionsTest#testCarouselIsShownWhenItReceivedSuggestions BUG=771955 TBR=dgn@chromium.org,bauerb@chromium.org NOTRY=true Change-Id: I87bb5ae772124268d3400bcfaacd51e4aaa1a647 Reviewed-on: https://chromium-review.googlesource.com/702481Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#506713}
-
Kent Tamura authored
Bug: 770603 Change-Id: Idd9f6ea0c9d2d6ace0af99bd894d7aec7f99e42b Reviewed-on: https://chromium-review.googlesource.com/701816Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#506712}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1ea81e766e1a..01f8e41c1368 $ git log 1ea81e766..01f8e41c1 --date=short --no-merges --format='%ad %ae %s' 2017-10-05 robertphillips Revert "Clean up SkString reference counting a bit." Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ide44641f756c3a69826bc65303f58ca7973f8a38 Reviewed-on: https://chromium-review.googlesource.com/701322Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506711}
-