GitLab

BUG=437701

Review URL: https://codereview.chromium.org/784553002

Cr-Commit-Position: refs/heads/master@{#307167}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/243c625..d579310

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/782963002

Cr-Commit-Position: refs/heads/master@{#307166}

TBR=gunsch@chromium.org
BUG=438110

Review URL: https://codereview.chromium.org/784493002

Cr-Commit-Position: refs/heads/master@{#307165}

Cr-Commit-Position: refs/heads/master@{#307164}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0ed0e91..243c625

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/782153002

Cr-Commit-Position: refs/heads/master@{#307163}

A compositor-driven fling will lock to the first layer that scrolls
after the fling starts. This can often be a different scrolling layer
than was first scrolled, e.g., when a scrolling layer reaches its limit
and the user then initiates a fling.

A recent change (r304898) inadvertently prevents the fling from locking
to the viewport layer after a bubbling touch scroll. Fix this by
ensuring the scrolling layer is always set after the fling's first
scroll animation update.

BUG=439698

Review URL: https://codereview.chromium.org/776943004

Cr-Commit-Position: refs/heads/master@{#307162}

TBR=suzhe@chromium.org
BUG=353034
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/745383008

Cr-Commit-Position: refs/heads/master@{#307161}

BUG=436218

Review URL: https://codereview.chromium.org/771353004

Cr-Commit-Position: refs/heads/master@{#307160}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/28f9c60..f4e0d9e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=halcanary@google.com

Review URL: https://codereview.chromium.org/781313002

Cr-Commit-Position: refs/heads/master@{#307159}

This CL introduces functionality to undo the blacklisting of a URL,
assuming a UI which allows for undo-ing for a few seconds after
blacklisting. The design consists in deffering blacklisted URL uploads
until they can no longer be undone, which is the simplest case.

Changes:
- BlacklistStore now has a concept of time before a URL is candidate for upload
- SuggestionsService now schedules blacklist uploads factoring in the delay

BUG=430949

Review URL: https://codereview.chromium.org/766053010

Cr-Commit-Position: refs/heads/master@{#307158}

BUG=

Review URL: https://codereview.chromium.org/733343005

Cr-Commit-Position: refs/heads/master@{#307157}

I chose to use %Id and a cast rather than %p in order to continue
printing as decimal -- %p typically prints as hex.

%Id is not portable, but this is Windows only code and %zd is not yet
supported in VC++.

BUG=427616

Review URL: https://codereview.chromium.org/786493003

Cr-Commit-Position: refs/heads/master@{#307156}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4e2f10b..0ed0e91

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/767523005

Cr-Commit-Position: refs/heads/master@{#307155}

As the first step, for >=3 displays we always use
horizontal layout and disallow mirroring.

This would allow basic multi-display functionality.

BUG=422161
TEST=trybot

Review URL: https://codereview.chromium.org/657583003

Cr-Commit-Position: refs/heads/master@{#307154}

This adds the a base Application class and defines a few methods
(onConnected, onDisconnected, onError, ...) that remove CRD-specific code
from the base connection code and move it into a CRD-specific file.
app-specific functionality.

BUG=

Review URL: https://codereview.chromium.org/779613003

Cr-Commit-Position: refs/heads/master@{#307153}

This is a reland of https://crrev.com/306659 which was reverted because it
broke Syzygy. The problems have since been resolved in Syzygy so we can reland
this.

This is a much much larger change than the diff suggests. If it breaks
something, please revert first and ask questions later.

TBR=brettw@chromium.org,rsleevi@chromium.org

BUG=338884

Review URL: https://codereview.chromium.org/782843002

Cr-Commit-Position: refs/heads/master@{#307152}

Currently, the GCM heartbeat manager schedules a timer that will always
wake up the system from suspend in order to send a heartbeat message.
This is bad for battery life if the user doesn't actually want to use
the wake on packet feature.  To deal with this problem:

- Add a new function, SetWakeFromSuspend, to the AlarmTimer class so
  that its wake from suspend ability can be changed on the fly.
- Drill a hole through GCM's beautiful abstraction layers so that we can
  get to the HeartbeatManager via the GCMDriver interface.
- Hook up the endpoint in the GCMDriver interface to
  WakeOnWifiManager::OnPreferenceChanged so that the wake from suspend
  property for all the GCM heartbeat timers is changed along with
  shill's settings.

BUG=397328, chrome-os-partner:34142

Review URL: https://codereview.chromium.org/745123002

Cr-Commit-Position: refs/heads/master@{#307151}

This paves the way for having TextureMailbox use SharedBitmaps instead of SharedMemory.

Review URL: https://codereview.chromium.org/783573003

Cr-Commit-Position: refs/heads/master@{#307150}

d3f3dce  libvpx.gyp: try again to fix Clang's -Wstring-conversion warning

BUG=431803

Review URL: https://codereview.chromium.org/782103002

Cr-Commit-Position: refs/heads/master@{#307149}

Make wpr_archive_info property effectively immutable.
Move cloud storage bucket validation logic to page_set_archive_info module.

BUG=439512

Review URL: https://codereview.chromium.org/779383002

Cr-Commit-Position: refs/heads/master@{#307148}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5ae2306..4e2f10b

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/779423003

Cr-Commit-Position: refs/heads/master@{#307147}

- Turn on by default. Enabled flags are useless now but kept so that
  the CL introduces no string changes for about page and could be
  merged to M40.
- Policy is still respected to disable the feature;
- Disable flag takes precedence over policy;
- Remove finch check;

BUG=439583

Review URL: https://codereview.chromium.org/785663003

Cr-Commit-Position: refs/heads/master@{#307146}

BUG=None
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/737093003

Cr-Commit-Position: refs/heads/master@{#307145}

BUG=chromedriver:980
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/782133002

Cr-Commit-Position: refs/heads/master@{#307144}

Since I'm usually the one approving the blink side of input changes which
need changes in event_sender for their tests.

Review URL: https://codereview.chromium.org/774393004

Cr-Commit-Position: refs/heads/master@{#307143}

This CL adds the base class for Bluetooth Audio Sink.

BUG=429016

Review URL: https://codereview.chromium.org/768493006

Cr-Commit-Position: refs/heads/master@{#307142}

BUG=437966

Review URL: https://codereview.chromium.org/786523003

Cr-Commit-Position: refs/heads/master@{#307141}

The new test case reproduces the same stack trace as in the bug, so it's very
probable that this case is causing the crash.

BUG=435600

Committed: https://crrev.com/9391c0e45bc3ae50008d0aebf11437550e7f38c6
Cr-Commit-Position: refs/heads/master@{#306504}

Review URL: https://codereview.chromium.org/754763005

Cr-Commit-Position: refs/heads/master@{#307140}

XP was the only platform that hung last time we tried this and the other
platforms sped up considerably.

BUG=417812

Review URL: https://codereview.chromium.org/752393005

Cr-Commit-Position: refs/heads/master@{#307139}

This is the first step towards making origin information available for RemoteFrames in Blink.  This CL ensures that we pass origin information whenever we create a RemoteFrame, which is currently three cases:
1. New view
2. As part of SwapOut
3. NewFrameProxy message

The origins are tracked on FrameTreeNodes in the browser process and updated when frame navigations commit (in NavigatorImpl::DidNavigate).

This CL doesn't yet address these issues, to be fixed in later CLs:
- situations that will require an explicit "origin update" message, including document.domain changes and certain frame navigations.
- iframe sandbox flags
- RenderFrameProxies aren't created in all cases (crbug.com/423587)
- for now, the origin on the browser side is a url::Origin which doesn't support calls like canAccess.  Eventually, we may need to use a richer origin class (like WebSecurityOrigin from Blink).

More information: https://docs.google.com/a/chromium.org/document/d/1Y0s76YK0ziiL8hddiFlNUyAF4hqRAGpZM8cfnnLsZPg/edit#heading=h.lrzgurbjttfm

The Blink-side of this CL is: https://codereview.chromium.org/520213002/

BUG=426512

Review URL: https://codereview.chromium.org/692973005

Cr-Commit-Position: refs/heads/master@{#307138}

R=wzhong@chromium.org,jar@chromium.org,tsepez@chromium.org,creis@chromium.org
BUG=419909

Review URL: https://codereview.chromium.org/730833004

Cr-Commit-Position: refs/heads/master@{#307137}

BUG=419528

Review URL: https://codereview.chromium.org/620453004

Cr-Commit-Position: refs/heads/master@{#307136}

Removing the top_most_at_end parameter which was always set to false and
was never used.

R=oshima@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/786513003

Cr-Commit-Position: refs/heads/master@{#307135}

CompareDelaySeconds takes two bool parameters when it is clearly
intended to take two int64 parameters. This was found by VC++'s /analyze
which said:

src\components\gcm_driver\gcm_driver_desktop_unittest.cc(1067) : warning
C6323: Use of arithmetic operator on Boolean type(s).

This bug was introduced in:
https://codereview.chromium.org/561943002

BUG=427616

Review URL: https://codereview.chromium.org/772383003

Cr-Commit-Position: refs/heads/master@{#307134}

BUG=425645

Review URL: https://codereview.chromium.org/778543004

Cr-Commit-Position: refs/heads/master@{#307133}

Revert of Make ui::Compositor use ui::Scheduler (patchset #13 id:360001 of https://codereview.chromium.org/638653003/)

Reason for revert:
This appears to be causing crashes on the Windows perf bots.  See the linked bug for a stack trace.

BUG=439649

Original issue's description:
> Make ui::Compositor use ui::Scheduler
>
> Taken from enne's CL 535733002 and rebased. It has been taken out of CL 134623005.
>
> BUG=329552
>
> Committed: https://crrev.com/36b7fc7f8b05ea627873e58a162c1c26784e472d
> Cr-Commit-Position: refs/heads/master@{#298779}
>
> Committed: https://crrev.com/b821b71ff0166e250ae4b30b56c1b7b6d3bd5db6
> Cr-Commit-Position: refs/heads/master@{#306954}

TBR=ben@chromium.org,danakj@chromium.org,piman@chromium.org,sky@chromium.org,weiliangc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329552

Review URL: https://codereview.chromium.org/784653002

Cr-Commit-Position: refs/heads/master@{#307132}

R=aelias@chromium.org
BUG=430702

Review URL: https://codereview.chromium.org/780413003

Cr-Commit-Position: refs/heads/master@{#307131}

Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.

BUG=334090

Review URL: https://codereview.chromium.org/756453003

Cr-Commit-Position: refs/heads/master@{#307130}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c28ac8e..5ae2306

TBR=schenney@chromium.org,dominicc@chromium.org

Review URL: https://codereview.chromium.org/753533003

Cr-Commit-Position: refs/heads/master@{#307129}

It was only by luck that this used to work. After a recent refactoring, the destruction order changed and the AutofillMetrics object no longer outlasts the infobar. AutofillMetrics doesn't need to be an instance object; make the relevant function a static instead.

TBR=sgurun@chromium.org
BUG=439551, 439620

Review URL: https://codereview.chromium.org/780423002

Cr-Commit-Position: refs/heads/master@{#307128}