- 23 Jan, 2020 40 commits
-
-
Mike Wittman authored
Strips the stack_unwinder module interfaces and contents down to the minimal Java required to get the dynamic feature module to work from native code. The module will be providing native code interfaces[1], which will be consumed by native code, so it doesn't make sense to interpose more Java than necessary in between. It's also the case that the parts of the DFM Java API that deal with the Play Store can't be used within the sandboxed renderer process. This change exposes via JNI the StackUnwinderModuleProvider's functions to query and request installation. This is the only Java-provided functionality that will be required for manipulating the module from native code. 1. Design doc: https://docs.google.com/document/d/1QB5IzWuVKfoPdPuiyRok2MUEta1FmRLIQkq1wDATA4k Bug: 1027654 Change-Id: Ie69e687335a753c17206fc6c81ae981118c698b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003298Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734653}
-
Daniel Rubery authored
Since the CheckClientDownloadRequest will no longer be run on deep scanning, we need to check the file size and encryption within the DeepScanningRequest. This CL moves that functionality. Bug: 1041578, 1020215 Change-Id: If134cfb8097b666cdf5f9057e2921f5634bcbf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007972Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#734652}
-
David Bienvenu authored
Bug: 1043481 TBR=bashi@chromium.org Change-Id: Id5c998c8fc81c98fd5ff898d1b953aeddadba19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016351Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734651}
-
Albert Chaulk authored
Current theory is that JS channels can be set before the frame finishes its initialization, and V8 context creation can occur on the Install() path, this violates some assumptions and crashes. So delay any Install() calls until after the main world context has been created. Bug: b/148202893 Test: no crashes seen on device Change-Id: I55255d9afed36a6e4c97dff8bfbea3c20a4a856a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016350 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#734650}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/48655cfdbfd9..40899b279798 git log 48655cfdbfd9..40899b279798 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 487ee81f..c0451968 (734357:734489) 2020-01-23 minyue@webrtc.org Revert "Send absolute capture time through audio coding module." Created with: gclient setdep -r src/third_party/webrtc@40899b279798 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If5c7f63ed8ff5356665d49cc87a624062b305523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017649Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734649}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b20535e..fde258b4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c9225e9bf101b423747dc158fdd715e8cf78342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017105Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734648}
-
James Cook authored
SplitSettingsSync will allow the user to opt-out of browser sync. However, IdentityManager::GetPrimaryAccount() assumes the user has consented to sync. Switch to using the "unconsented" primary account, which exists whether or not the user has consented to sync. This code doesn't add a DCHECK that the unconsented primary account exists because there are managed guest session tests that don't have a primary account but still exercise this code path. and on device Test: existing login browser tests, manual tests of login on linux Bug: 1042400 Change-Id: I14ee7bcc18c294dee31c26fcc9bed537836516b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015589 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734647}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e504fd6a5f25..cd43517dce3c git log e504fd6a5f25..cd43517dce3c --date=short --first-parent --format='%ad %ae %s' 2020-01-23 mandy.chen@microsoft.com Roll protocol changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@cd43517dce3c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2dd291383c97e9018727537092d85a405dd5409b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018024Reviewed-by:
-
Christopher Cameron authored
Change metal_util::TestShader to test either compile or link, and change the default behavior to link. Add inline data for a trivial test shader. Add code to modify the bitcode, to defeat caching. Ensure that the Metal calls for the test are invoked on a thread that has base::TaskPriority::HIGHEST. TBR=jvanverth Bug: 974219 Change-Id: I35e688c3758af2e03f893a1ccbef7aef6b778b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015486Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#734645}
-
ckitagawa authored
This adds UMA metrics for - Capture time in spent in Blink - Total capture time - Usage/Success counters - Frame count to evaluate total frames captured Follow-up CLs will be needed for UKMs and disk-usage. Bug: 1038390 Change-Id: I1b7e0a844da23d23257cb75ad6673ff31a730955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986773Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#734644}
-
Aaron Krajeski authored
The expiration now matches that for other offscreen canvas histograms. Bug: 1041517 Change-Id: Ia42ffd003de64f00ed8d55c866f58b4cc4bc655b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015363Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
-
Eugene But authored
This reverts commit db9b2ce6. Reason for revert: Tests now pass Original change's description: > [ios][eg2] Disable all EG2 tests from SigninInteractionControllerTestCase. > > TBR=jlebel@chromium.org > > Bug: 1037676,1036840 > Change-Id: I552d7cec1cab40b5ef9dae9271bb956a625fd71f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981141 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727312} TBR=eugenebut@chromium.org,jlebel@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037676, 1036840 Change-Id: Ie9c4b650360072c3e916e78d122ae331f55f424c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015408Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#734642}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: I3ff6d274b82325a4a77e71fc5a7aaaa3a0d4e83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017513 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734641}
-
Toni Barzic authored
The app list step introduces the user to the home button, which might be confusing if the home button is not shown, which is the case in tablet mode with kHideShelfControlsInTabletMode feature enabled (the feature removes home/back/overview buttons from shelf in favor of gestural navigation). BUG=1012814 Change-Id: I8621b72a734c08d84774537e962346a74ec3c5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015649Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#734640}
-
Mohamed Heikal authored
Bug: 1045024 Change-Id: Id5f37e284a97c6bb4a77341203df366f1d36ce32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017643Reviewed-by:
-
Avi Drissman authored
This changes expectations based on the macOS SDK used to build Chromium. Chromium has required newer than the 10.12 SDK for years, so remove this. Bug: 1044838 Change-Id: I41deec339d7da73392c410dbdb1439a824c0f81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015361 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734638}
-
Morten Stenshorne authored
Some tests in these virtual test suites were failing due to the form controls refresh (mostly; one of the failing tests was about a text layout difference between NG and non-NG [1]), but it doesn't seem worthwhile to run them (uninteresting combination of features), so rather than rebaselining, let's skip. [1] virtual/web-components-v0-disabled/fast/dom/HTMLMeterElement/meter-boundary-values.html R=ikilpatrick@chromium.org,masonfreed@chromium.org Change-Id: I499cbb69cf54969d6136b441e2ea95bdf5fcfe2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016627Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#734637}
-
Toni Barzic authored
Fixes the histogram values for in-app hotseat gesture and swipe from home to overview gesture to match the values that are actually recorded: * Results of the in-app hotseat gestures are recorded as Ash.HotseatGesture, not Ash.HotseatInAppGesture as was specified in histograms.xml * Ash.SwipeHomeToOverviewGesture histogram reports an enum value, not a boolean Change-Id: Ie3d64d9727d2288071eb1a3fe52a451212a702be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015554 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#734636}
-
Aaron Tagliaboschi authored
A fairly long overdue rework of the client hint WPTs. Most of the renaming is on it's own patchsets, so look through each one individually if there's too much to see anything useful. Tests deleted because of other coverage: * accept_ch.tentative.https.html: accept-ch-stickiness/same-origin-navigation.https.html * http_equiv_accept_ch.tentative.https.html: accept-ch-stickiness/http-equiv-same-origin-subresource.https.html * http_equiv_accept_ch.tentative.sub.https.html: accept-ch-change.https.html Bug: 1042828 Change-Id: Ie52abfac485b8e974f4a93a06f3d6d3b845a2010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003338 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#734635}
-
Simeon Anfinrud authored
The "data" list was pointing to a file that did not exist (the path omitted the "resources" prefix). Bug: Internal b/144577042 Test: check that each file from gn desc runtime_deps exists Change-Id: I2eb03db75cf3a8e7608d71446acfbf518074e00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016907 Auto-Submit: Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734634}
-
Nate Chapin authored
This will make it easier to eventually not use SecurityContextInit in Document, and just use it for ExecutionContext/SecurityContext. Bug: 1029822 Change-Id: I6eb6c01756d2a9c3e28fe6e833bdd65e54acedb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015549Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#734633}
-
Brian Salomon authored
This will be used by Skia for async YUV420 readbacks with ES2 ANGLE contexts. Bug: 1040643 Change-Id: Ifcc0bff78efcf75764902e8a2910aea7266bf327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015645Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#734632}
-
Dale Curtis authored
Some loads are done from an in memory cache and won't trigger the typical mixed content warnings, so explicitly tell MixedContentChecker about our loads to ensure the proper notifications are generated. Fixed: 868145 Change-Id: I4df0ac3db1f2584c2ef44b5e3606acff314bc4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008396 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#734631}
-
Dominic Mazzoni authored
Android accessibility was using a different code path than other platforms to compute the bounding box of accessibility objects. In particular, we were ignoring the root scroll offset from the accessibility tree and using the offsets from RenderCoordinatesImpl instead. It looks like this is causing problems with ImplicitRootScroller, and furthermore it looks like this code is no longer necessary. Switching back to use the scroll offsets from the accessibility tree seems to fix the problem. A follow-up change will remove UseRootScrollOffsetsWhenComputingBounds entirely. This change is minimal in order to be considered for merging. Bug: 1005121 Change-Id: I82e97f046cee6b8b08238fcd4368228da368b92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017662Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734630}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: I952ce3ca773ec0d693bd4aa31ff4526e55a29f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017484 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=michaeldo@chromium.org Bug: 1042208 Change-Id: I1d4ecec8dc16e169bca7ebd6697e16db57821d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017482 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#734628}
-
Aga Wronska authored
This is a reland of c78cd05f Bug: 1044733 Original change's description: > Parse PerAppTimeLimits policy > > Parse PerAppTimeLimits policy received from the server and store > app limits data in AppActivityRegistry. > This will be followed up by processing app limits. > > Bug: 1015654 > Test: AppTimeTest > Change-Id: I29691e0c801762a73f01cce217826423359957eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001411 > Reviewed-by: Yilkal Abe <yilkal@chromium.org> > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734123} Bug: 1015654 Change-Id: I5fde631303ca519501220f60d5bd2fdc53759e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017184 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734627}
-
Toni Barzic authored
Should prevent animating background from popping up on the lock screen (there is no point in animating shelf for hotseat changes on lock screen given that neither hotseat nor in-app shelf are visible). Change-Id: I2422f94bab1db9e25b775e36b023db5bbc0b26e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016358 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#734626}
-
Mathias Carlen authored
This patch adds unit tests and a integration / UI test for the recently added auto expand/collapse sheet behavior for prompt actions. Note that there are two sides to this, Prompt has a disable_force_expand_sheet option now to prevent prompt from auto expanding when entering that state. The other part is ConfigureBottomSheet, which now has a oneof (expand, collapse) to automatically update the bottom sheet to the expected state. Bug: b/145204744 Change-Id: I857a2be13e090d9e5d663419ead60497102cb897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007721 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#734625}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=jlebel@chromium.org Bug: 1042208 Change-Id: I5e8b4cd2b7991f40cde7e450a598a835813c3796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014975 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 1042208 Change-Id: I3d4fe29485a1d7c554c2a811e23df22d21514f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015094 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#734623}
-
Ioana Pandele authored
Bug: 1044930 Change-Id: I9c480c56f0aeb97074964545c732c0d427cdad7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015052 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#734622}
-
Bo Liu authored
Bug: 1042063 Change-Id: Icd092cbaa08951d90813e97ed869e91ac2af2672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016850Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#734621}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bdd89366d34e..684096347b67 git log bdd89366d34e..684096347b67 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 contact@yannic-bonenberger.com Improve git cl split Created with: gclient setdep -r src/third_party/depot_tools@684096347b67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:998922 Tbr: agable@chromium.org Change-Id: Iaddfb7db52842f4b5d7d0b2b876e5f84ea8bdfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015633Reviewed-by:
-
Jonathan Freed authored
This includes the following changes: https://chromium.googlesource.com/feed/+/39fe4a79d4144e2e1eb170a7ba0a49b7510162f8 Change-Id: I462cf19eef5374e8aad4bc4b203e1fba03f73f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018142Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734619}
-
Sebastien Lalancette authored
TBR=anastasi@google.com Bug: 1045075 Change-Id: Ib269f054857ee483faef51c52e476764faa08f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016859Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734618}
-
Avi Drissman authored
MAC_OS_X_VERSION_10_12 is true if Chromium is being built with the macOS 10.12 SDK or newer, as it’s been since mid 2017. MAC_OS_X_VERSION_10_12 is not a runtime check for macOS 10.12 and cannot be used as such. Bug: 1044838 Change-Id: Ia8e40d0f3aab0405e423847dcf9ea1ea2f535091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016846 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9ad78aa7dba2..a4f9acedf3c0 git log 9ad78aa7dba2..a4f9acedf3c0 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 rharrison@google.com Big cleanup to normalize API behaviour (#967) Created with: gclient setdep -r src/third_party/shaderc/src@a4f9acedf3c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I63e1ccddd1831d15caec16c72b2b74b6a666e984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017653Reviewed-by:
-
Manu Cornet authored
Split out some helper classes into their own files in the process: HotseatStateWatcher, OverviewAnimationWaiter, ShelfLayoutManagerTestBase. This is a pure (albeit large) refactoring and does not modify any of the actual test semantics. Change-Id: Ica79e3dcead839daa83022de329b5aca8f636c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015672 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#734615}
-
Sebastien Lalancette authored
I apparently misunderstood how the test expectations framework works. Follow-up from: https://chromium-review.googlesource.com/c/chromium/src/+/2016857 TBR=chenwilliam@chromium.org Change-Id: I23d99c45c172cd6849b02b33313c7a0c3e4c033f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015431 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
