GitLab

Revert of [GN] Add JSON project writer (patchset #11 id:200001 of https://codereview.chromium.org/2064533002/ )

Reason for revert:
Broke Win8 GYP (dbg) builder:
[822/12249] LINK_EMBED gn.exe
FAILED: gn.exe gn.exe.pdb
E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True gn.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:gn.exe @gn.exe.rsp" 1 mt.exe rc.exe "obj\tools\gn\gn.gn.exe.intermediate.manifest" obj\tools\gn\gn.gn.exe.generated.manifest ..\..\build\win\compatibility.manifest
gn_lib.lib(gn_lib.command_desc.obj) : error LNK2019: unresolved external symbol "public: static class std::unique_ptr<class base::DictionaryValue,struct std::default_delete<class base::DictionaryValue> > __cdecl DescBuilder::DescriptionForTarget(class Target const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool,bool,bool)" (?DescriptionForTarget@DescBuilder@@SA?AV?$unique_ptr@VDictionaryValue@base@@U?$default_delete@VDictionaryValue@base@@@std@@@std@@PBVTarget@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@3@_N22@Z) referenced in function "bool __cdecl commands::`anonymous namespace'::PrintTarget(class Target const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool,bool,bool,bool)" (?PrintTarget@?A0x51180473@commands@@YA_NPBVTarget@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@_N222@Z)

gn_lib.lib(gn_lib.command_desc.obj) : error LNK2019: unresolved external symbol "public: static class std::unique_ptr<class base::DictionaryValue,struct std::default_delete<class base::DictionaryValue> > __cdecl DescBuilder::DescriptionForConfig(class Config const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?DescriptionForConfig@DescBuilder@@SA?AV?$unique_ptr@VDictionaryValue@base@@U?$default_delete@VDictionaryValue@base@@@std@@@std@@PBVConfig@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@3@@Z) referenced in function "bool __cdecl commands::`anonymous namespace'::PrintConfig(class Config const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool)" (?PrintConfig@?A0x51180473@commands@@YA_NPBVConfig@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@_N@Z)

gn_lib.lib(gn_lib.command_gen.obj) : error LNK2019: unresolved external symbol "public: static bool __cdecl JSONProjectWriter::RunAndWriteFiles(class BuildSettings const *,class Builder const *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,bool,class Err *)" (?RunAndWriteFiles@JSONProjectWriter@@SA_NPBVBuildSettings@@PBVBuilder@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@222_NPAVErr@@@Z) referenced in function "bool __cdecl commands::`anonymous namespace'::RunIdeWriter(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class BuildSettings const *,class Builder *,class Err *)" (?RunIdeWriter@?A0x1eff038c@commands@@YA_NABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PBVBuildSettings@@PAVBuilder@@PAVErr@@@Z)

gn.exe : fatal error LNK1120: 3 unresolved externals

Traceback (most recent call last):

  File "gyp-win-tool", line 323, in <module>

    sys.exit(main(sys.argv[1:]))

  File "gyp-win-tool", line 29, in main

    exit_code = executor.Dispatch(args)

  File "gyp-win-tool", line 71, in Dispatch

    return getattr(self, method)(*args[1:])

  File "gyp-win-tool", line 179, in ExecLinkWithManifests

    subprocess.check_call(ldcmd + add_to_ld)

  File "E:\b\depot_tools\python276_bin\lib\subprocess.py", line 540, in check_call

    raise CalledProcessError(retcode, cmd)

subprocess.CalledProcessError: Command 'E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:gn.exe @gn.exe.rsp gn.exe.manifest.res' returned non-zero exit status 1120

Original issue's description:
> [GN] Add JSON project writer
>
> Output is a JSON file containing information about targets. The generator
> can also optionally invoke a python script on generated file.
>
> Example:
> gn gen --ide=json ./out-json --json-ide-script=//scripts/custom-ide-generator.py \
>     --ison-ide-script-args="additional script arguments"
>
> Also implements --format=json for gn desc as described in https://bugs.chromium.org/p/chromium/issues/detail?id=620132
>
> BUG=
>
> Committed: https://crrev.com/d2edeb9a743ad5a2046e655997277d3bb630db03
> Cr-Commit-Position: refs/heads/master@{#406064}

TBR=brettw@chromium.org,matej.knopp@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2160533004
Cr-Commit-Position: refs/heads/master@{#406074}

Include normal user-reported bug template and version number in link
to file bug in MD Settings appeal banner.

Result looks like crbug.com/628951.

BUG=none
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2155063003
Cr-Commit-Position: refs/heads/master@{#406073}

Revert of gn: Remove unnecessary v8 defaults (patchset #7 id:120001 of https://codereview.chromium.org/2058033002/ )

Reason for revert:
Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1

Original issue's description:
> gn: Remove unnecessary v8 defaults
>
> Remove chromium defaults for v8_optimized_debug and
> v8_use_external_startup_data.
>
> This is not needed after v8 provides these defaults:
> https://codereview.chromium.org/2025803003/
> https://codereview.chromium.org/2024833002/
>
> It also interferes if somebody tries to override the gn args
> with a different value.
>
> BUG=chromium:616034
> TBR=alokp@chromium.org, brettw@chromium.org
>
> Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
> Cr-Commit-Position: refs/heads/master@{#406067}

TBR=jochen@chromium.org,dpranke@chromium.org,vogelheim@chromium.org,alokp@chromium.org,brettw@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616034

Review-Url: https://codereview.chromium.org/2160663003
Cr-Commit-Position: refs/heads/master@{#406072}

BUG=627306

Review-Url: https://codereview.chromium.org/2153153003
Cr-Commit-Position: refs/heads/master@{#406071}

Smaller font and light grey background.

BUG=626442
TEST=manual

Review-Url: https://codereview.chromium.org/2152243002
Cr-Commit-Position: refs/heads/master@{#406070}

Also fix a bug where the drop shadow offset did not account for scale in this
matrix (e.g. due to high DPI).

BUG=600821
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2114303002
Cr-Commit-Position: refs/heads/master@{#406069}

TBR=dalecurtis@chromium.org
BUG=629147

Review-Url: https://codereview.chromium.org/2159953002
Cr-Commit-Position: refs/heads/master@{#406068}

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Review-Url: https://codereview.chromium.org/2058033002
Cr-Commit-Position: refs/heads/master@{#406067}

This is a follow up to the fix in r405892. Also cleanup some nits.

BUG=628086

Review-Url: https://codereview.chromium.org/2153763005
Cr-Commit-Position: refs/heads/master@{#406066}

Then size is scaled in both axes, so the declared parameter name is confusing.
This changes it to "scale", which matches the parameter name in the definition.

Review-Url: https://codereview.chromium.org/2159723003
Cr-Commit-Position: refs/heads/master@{#406065}

Output is a JSON file containing information about targets. The generator
can also optionally invoke a python script on generated file.

Example:
gn gen --ide=json ./out-json --json-ide-script=//scripts/custom-ide-generator.py \
    --ison-ide-script-args="additional script arguments"

Also implements --format=json for gn desc as described in https://bugs.chromium.org/p/chromium/issues/detail?id=620132

BUG=

Review-Url: https://codereview.chromium.org/2064533002
Cr-Commit-Position: refs/heads/master@{#406064}

So that it can be removed in a followup CL.

This CL also fixes saving/restoring incognito cookie stores
on Android, which was not being done correctly.

BUG=620770,627256

Review-Url: https://codereview.chromium.org/2103863003
Cr-Commit-Position: refs/heads/master@{#406063}

* Add the ability to bold parts of a label.

* Add the ability to show a tertiary label in the PaymentOption, which
  will later be used for phone number display.

* The phone number is passed in to the PaymentOption using the new constructor
  via the AutofillAddress class.

See crbug.com/626833 for screenshots.

BUG=603635,626833

Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f
Review-Url: https://codereview.chromium.org/2135573004
Cr-Original-Commit-Position: refs/heads/master@{#405900}
Cr-Commit-Position: refs/heads/master@{#406062}

Revert of [DevTools] Always report encodedDataLength in Network.ResponseReceived. (patchset #1 id:1 of https://codereview.chromium.org/2101073002/ )

Reason for revert:
Decided to try another approach, see discussion in issue 622018

Original issue's description:
> [DevTools] Always report encodedDataLength in Network.ResponseReceived.
>
> Currently, we only send encodedDataLength for redirects. However, we already know how much we read when sending ResponseReceived. This will improve reporting for failed requests, as they don't get loadingFinished with full encodedDataLength.
>
> BUG=622018
>
> Committed: https://crrev.com/00f8f6c17d27799700974e599d6003b7f376071c
> Cr-Commit-Position: refs/heads/master@{#402543}

TBR=allada@chromium.org,mmenke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622018

Review-Url: https://codereview.chromium.org/2158073002
Cr-Commit-Position: refs/heads/master@{#406061}

TBR=thestig@chromium.org
BUG=484351,484852

Review-Url: https://codereview.chromium.org/2156123003
Cr-Commit-Position: refs/heads/master@{#406060}

git grep'd for "more then", "less then", "greater then".
(Interestingly, no hits for "fewer then".)

BUG=none
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2157963002
Cr-Commit-Position: refs/heads/master@{#406059}

BUG=628054
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2149153003
Cr-Commit-Position: refs/heads/master@{#406058}

It was being silently ignored thanks to the catch-all try block, but we
should fix it.

BUG=none

Review-Url: https://codereview.chromium.org/2149173002
Cr-Commit-Position: refs/heads/master@{#406057}

Password manager uses a switch to allow the user to override the
auto-detection of the appropriate password store. OSCrypt should
respect this switch as well.

The switch value is read and passed to OSCrypt at a very early
point in Chrome's start, before any of OSCrypt's dependents
use it.

I also reworked OSCrypt's build to make it simpler for chrome to
deduce whether the linux implementation of OSCrypt will be used.
 - Previously, os_crypt_linux was used only if we also decided to
   link at least one linux backend. Otherwise we used os_crypt_posix.
 + Now, we always use the linux implementation for linux. If no
   KeyStorage is linked, the linux implementation defaults to the
   same behavior as for posix.

This CL is a fixed version of https://codereview.chromium.org/2118443002/

BUG=602624

Review-Url: https://codereview.chromium.org/2159743002
Cr-Commit-Position: refs/heads/master@{#406056}

This is a followup to https://codereview.chromium.org/1838333004/ where
it was added to the history WebUI.

Folio: https://folio.googleplex.com/chromenarnia/Clear%20Browsing%20Data%20&%20History/MD%20Update
What's not seen on Folio, but was discussed offline: Although it's
positioned in the side bar, the footer should not behave like
a paper-item. Only the link itself should be clickable.

Update: https://screenshot.googleplex.com/s2yAqZ05yXT - this is
a new screenshot after the side-bar layout changed (used to be static,
after https://codereview.chromium.org/2020963002/ it's hidden
under the hamburger menu.

BUG=595332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2088093004
Cr-Commit-Position: refs/heads/master@{#406055}

This patch rolls protocol descriptor copies in the front_end folder,
which are used by the hosted mode.

BUG=none
TBR=dgozman

Review-Url: https://codereview.chromium.org/2159883002
Cr-Commit-Position: refs/heads/master@{#406054}

CONTINUE_ON_SHUTDOWN means the thread running the task will not be
joined on shutdown and may not have a valid singleton/lazy_instance
at that moment.

Also made DhcpcsvcInitSingleton explicitly leaky to avoid
the AssertSingletonAllowed() dcheck.

BUG=478209

Committed: https://crrev.com/de7e9038663d69356e558764d5a7b215e8b49b5b
Review-Url: https://codereview.chromium.org/1904273002
Cr-Original-Commit-Position: refs/heads/master@{#390125}
Cr-Commit-Position: refs/heads/master@{#406053}

Since protocol split, the generate_protocol_externs.js CLI has to accept
both protocol files as input.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2158063002
Cr-Commit-Position: refs/heads/master@{#406052}

De-duplicate; narrow a condition; fix a method that did the opposite of
its name; add comments, etc.

No new tests because there _should_ be no behavior changes.

BUG=613728

Review-Url: https://codereview.chromium.org/2153283002
Cr-Commit-Position: refs/heads/master@{#406051}

BUG=

Review-Url: https://codereview.chromium.org/2147223005
Cr-Commit-Position: refs/heads/master@{#406050}

https://chromium.googlesource.com/angle/angle.git/+log/4c32feb..5bc93c4

BUG=621031,628052,612066
TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2158003002
Cr-Commit-Position: refs/heads/master@{#406049}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3b4db493..9b382ab2

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2158943002
Cr-Commit-Position: refs/heads/master@{#406048}

BUG=628987
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2158043002
Cr-Commit-Position: refs/heads/master@{#406047}

With this CL, the following histograms are recorded with a suffix
indicating the number of startups with the same version:
- Startup.BrowserMainToRendererMain
- Startup.BrowserMessageLoopStartTime
- Startup.BrowserMessageLoopStartTimeFromMainEntry
- Startup.BrowserOpenTabs
- Startup.BrowserWindowDisplay
- Startup.FirstWebContents.MainFrameLoad2
- Startup.FirstWebContents.MainNavigationFinished
- Startup.FirstWebContents.MainNavigationStart
- Startup.FirstWebContents.NonEmptyPaint2
- Startup.LoadTime.ExeMainToDllMain
- Startup.LoadTime.ProcessCreateToDllMain
- Startup.LoadTime.ProcessCreateToExeMain
- Startup.SystemUptime
- Startup.TimeSinceLastStartup

BUG=580211

Review-Url: https://codereview.chromium.org/2117373003
Cr-Commit-Position: refs/heads/master@{#406046}

* Change BlobChannel PutBlob() Mojo IDL to use shared memory handles
  instead of a byte array.
* Create "SharedMemoryBlob" class for encapsulating Mojo shared
  memory initialization and lifetime management semantics.
* Add BlobChannelSenderProxy class, which manages interactions with the renderer side of the BlobChannel IPC interface.
* Add Blimp-specific run_all_unittests.cc, which bootstraps the Mojo environment before executing unittests.

R=wez@chromium.org
CC=maniscalco@chromium.org
BUG=600719,614564

Review-Url: https://codereview.chromium.org/2033013003
Cr-Commit-Position: refs/heads/master@{#406045}

Allows widget close animations to use the scale assigned
to shell surface at the time it is destroyed.

BUG=628932, b/29082277

Review-Url: https://codereview.chromium.org/2157863002
Cr-Commit-Position: refs/heads/master@{#406044}

This fixes a race condition where:
1. We get a ConfigureNotify event that tells us the window was resized
   and as a result post a delayed resize task
2. The window is resized
3. The delayed resize task runs and resizes the window to the old size

The symptom experienced by this bug could be seen with tooltips which
reuse the same window for each tooltip.  If a window was resized to be
larger, we would only render in the smaller area and garbage data
would fill the rest.

BUG=442111

Review-Url: https://codereview.chromium.org/2154483002
Cr-Commit-Position: refs/heads/master@{#406043}

BUG=628046

Review-Url: https://codereview.chromium.org/2149163002
Cr-Commit-Position: refs/heads/master@{#406042}

ExternalDataUseReporter class is created with the data use reporting
logic. ExternalDataUseReporter is created in IO thread and moved to UI
thread. It is owned by ExternalDataUseObserver.

BUG=570884

Review-Url: https://codereview.chromium.org/2145863002
Cr-Commit-Position: refs/heads/master@{#406041}

Changes the parent of search widget labels and close buttons in overview
mode to be kShellWindowId_StatusContainer which is still above all
windows but below menus and screen overlays.

BUG=629039

Review-Url: https://codereview.chromium.org/2154323002
Cr-Commit-Position: refs/heads/master@{#406040}

We've seen a sharp augmentation of renderer hangs on Android. This histogram is
meant to help identify the root cause of this renderer hangs, since it's
currently hard to distinguish whether this is happening during normal browsing
or during beforeunload/unload/when the page is closing.

BUG=621303
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2136173003
Cr-Commit-Position: refs/heads/master@{#406039}

BUG=None

Review-Url: https://codereview.chromium.org/2149873002
Cr-Commit-Position: refs/heads/master@{#406038}

BUG=None

Review-Url: https://codereview.chromium.org/2159763002
Cr-Commit-Position: refs/heads/master@{#406037}

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
Review-Url: https://codereview.chromium.org/2116583002
Cr-Original-Commit-Position: refs/heads/master@{#405876}
Cr-Commit-Position: refs/heads/master@{#406036}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d2b666834a28..3c2ec02098fa

$ git log d2b666834..3c2ec0209 --date=short --no-merges --format='%ad %ae %s'

BUG=628239

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2162583002
Cr-Commit-Position: refs/heads/master@{#406035}