GitLab

Last instrumentations showed that:
SSL_do_handshake call is 17 jph (I mean janks per startup-hour)
This excludes all callbacks that SSL_do_handshake can invoke.

SSLClientSocketOpenSSL::UpdateServerCert is 5.8 jph.

Adding instrumentations to differentiate the cert from no-cert cases.
Also instrumenting SSLClientSocketOpenSSL::UpdateServerCert.

BUG=424386

Review URL: https://codereview.chromium.org/787913003

Cr-Commit-Position: refs/heads/master@{#309590}

A lot of SideEffectWhiteListPrefixSet related code was mostly a duplicate
 of the other PrefixSet code in the same file.

Only logical side-effect this has is grouping histograms for all PrefixSets
in the same bucket. This will be addressed as a follow-up in
https://codereview.chromium.org/815863002/ where relevant histograms will be
split once again.

This cleanup makes it easier to progress on issue 440517.

BUG=440517
TBR=jwd

Review URL: https://codereview.chromium.org/790703003

Cr-Commit-Position: refs/heads/master@{#309589}

GN bots are having trouble picking up the changes to the resouce ID
range, which was changed in https://codereview.chromium.org/734243003/.

BUG=444902
R=eroman@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/821303002

Cr-Commit-Position: refs/heads/master@{#309588}

Revert of Fix Flaky EncryptedMediaTest (patchset #1 id:1 of https://codereview.chromium.org/823743002/)

Reason for revert:
This changes introduces a new problem that is breaking the builds (e.g. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Browser%20%281%29/builds/3905).

Original issue's description:
> Fix Flaky EncryptedMediaTest
>
> Tests are flaky as setMediaKeys() was not completing before the
> "encrypted" event was generated. Change delays setting the video
> source until setMediaKeys() completes.
>
> BUG=444683
> TEST=Failing tests run fine locally
>
> Committed: https://crrev.com/37edfbac393c04549884ec15ce612a376a5be6ff
> Cr-Commit-Position: refs/heads/master@{#309568}

TBR=xhwang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=444683

Review URL: https://codereview.chromium.org/826603002

Cr-Commit-Position: refs/heads/master@{#309587}

Revert of Revert "Update legacy Tuple-using code." (patchset #1 id:1 of https://codereview.chromium.org/826573002/)

Reason for revert:
The tests should have failed with this. Undoing the revert.

Original issue's description:
> Revert "Update legacy Tuple-using code."
>
> This reverts commit 12f4b983
>
> BUG=440675, 444827
>
> Committed: https://chromium.googlesource.com/chromium/src/+/85748694f2a119a057088f77f70b97f11607473c

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=440675, 444827

Review URL: https://codereview.chromium.org/794073003

Cr-Commit-Position: refs/heads/master@{#309586}

Revert of Re-enable failing EncryptedMediaTests. (patchset #1 id:1 of https://codereview.chromium.org/826583002/)

Reason for revert:
Oops!

These tests _should_ be disabled; see bug 444683.

Original issue's description:
> Re-enable failing EncryptedMediaTests.
>
> BUG=444827, 440675
>
> Committed: https://crrev.com/77195a8ae23b1d8084907b304a440acd10e3b3ad
> Cr-Commit-Position: refs/heads/master@{#309584}

TBR=eroman@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=444827, 440675

Review URL: https://codereview.chromium.org/822713003

Cr-Commit-Position: refs/heads/master@{#309585}

BUG=444827, 440675

Review URL: https://codereview.chromium.org/826583002

Cr-Commit-Position: refs/heads/master@{#309584}

This reverts commit 12f4b983

BUG=440675, 444827

Review URL: https://codereview.chromium.org/826573002

Cr-Commit-Position: refs/heads/master@{#309583}

Review URL: https://codereview.chromium.org/796933006

Cr-Commit-Position: refs/heads/master@{#309582}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/73483d9..0e9ab4e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/818263002

Cr-Commit-Position: refs/heads/master@{#309581}

BUG=438476

Review URL: https://codereview.chromium.org/788183006

Cr-Commit-Position: refs/heads/master@{#309580}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/825513002

Cr-Commit-Position: refs/heads/master@{#309579}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/815503005

Cr-Commit-Position: refs/heads/master@{#309578}

Let WebContents to be created independantly of setting up the
window tree in CastContentWindow. Allow the window tree to be
created at a later time.

R=gunsch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/823763002

Cr-Commit-Position: refs/heads/master@{#309577}

* Change the wake on wifi pref to a boolean. Eventually we will need to worry about packets, but for now having an integer pref makes things too complicated, partially because if/when we do add the packets feature, we don't want to overwrite user settings.
* Make the WakeOnWifiFeatures enum bitfield-like for easier setting of the options now and in the future.
* Set the pref to enabled by default.
* Add the --disable-wake-on-wifi kill switch to WakeOnWifiManager.
* --wake-on-packet still works unless --disable-wake-on-wifi is also specified.

BUG=424719
R=stevenjb@chromium.org,asvitkine@chromium.org
CC=dbeam@chromium.org

TBR=asvitkine@chromium.org
# asvitkine OOO, but this complies with his past reviews

Review URL: https://codereview.chromium.org/811973002

Cr-Commit-Position: refs/heads/master@{#309576}

BUG=439055
TEST=In Launcher, drag app to solitary folder on second page

Earlier versions of this CL included a unit test...
https://codereview.chromium.org/780023002/
https://codereview.chromium.org/792883006/
...but the slowness of valgrind kept screwing up the timing of the drag/drop,
so I'm giving up on the unit test (which didn't actually test this bug anyway).

Review URL: https://codereview.chromium.org/823763003

Cr-Commit-Position: refs/heads/master@{#309575}

R=byungchul@chromium.org,servolk@chromium.org
TBR=lcwu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/822803002

Cr-Commit-Position: refs/heads/master@{#309574}

This reverts commit 09eafe73.

TBR=tommycli@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/790123003

Cr-Commit-Position: refs/heads/master@{#309573}

BUG=

Review URL: https://codereview.chromium.org/812133003

Cr-Commit-Position: refs/heads/master@{#309572}

validate the sanity of the WebContentsObserver invocations, but which hopefully
will grow to include other too-heavy-for-production-code bug detection logic.

The currently supported check, WebContentsObserverSanityChecker, is a fleshed-
out version of the FrameLifetimeConsistencyChecker previously used in
RenderFrameHost unittests.

This sanity check managed to identify the root cause for bug 438951, so it's
already proved itself useful. Enabling it on all tests should prevent future
regressions of that kind.

To install this on all WebContentses, we need to un-deprecate the
WebContentsImpl::AddCreatedCallback/RemoveCreatedCallback mechanism. To make
that safer, the dangerous methods are moved to the FriendZone (get it?) which is
what I call what Dr. Dobbs calls, stodgily, the "C++ attorney/client idiom"
http://goo.gl/13oS7e. They also now have, cleverly, ForTesting in their names.

Lastly, we change the invocation time of the g_created_callbacks to be at the
end of WebContents::Init, instead of at the end of the ctor, so we're not
inviting tests to muck around with a half-inflated WebContents.

BUG=438951, 444722, 444717
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/803873004

Cr-Commit-Position: refs/heads/master@{#309571}

Fix forward declarations in cc/animation/

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/826453002

Cr-Commit-Position: refs/heads/master@{#309570}

If a connection is not going to succeed, the user shouldn't be prompted to allow it.

BUG=442497

Review URL: https://codereview.chromium.org/800853006

Cr-Commit-Position: refs/heads/master@{#309569}

Tests are flaky as setMediaKeys() was not completing before the
"encrypted" event was generated. Change delays setting the video
source until setMediaKeys() completes.

BUG=444683
TEST=Failing tests run fine locally

Review URL: https://codereview.chromium.org/823743002

Cr-Commit-Position: refs/heads/master@{#309568}

This reverts commit 5abc69b1.

Reason for revert:

The Linux GN bot failed compile:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20GN&number=19568

Due to error running grit:
KeyError: 'Duplicate keys: [18500]'

We have seen this error before, and it should have already been fixed
in grit's resource_ids....

I expect the problem is with GN since this failure isn't happening on
any other bot, however reverting in the meantime to make the tree green
until this is sorted out.

TBR=tommycli@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/825753002

Cr-Commit-Position: refs/heads/master@{#309567}

TBR=dgozman@chromium.org
NOTRY=true
BUG=444827

Review URL: https://codereview.chromium.org/821263002

Cr-Commit-Position: refs/heads/master@{#309566}

Tested with:
out/GN/mojo_shell
http://<host>/LayoutTests/media/encrypted-media/encrypted-media-playback-setmediakeys-before-src.html
--args-for='mojo://html_viewer --v=3 --enable-encrypted-media'

TBR=jamesr@chromium.org
BUG=444205
TEST=See above.

Review URL: https://codereview.chromium.org/815293002

Cr-Commit-Position: refs/heads/master@{#309565}

This needs to be set in order to build properly from the bisect script.

BUG=

Review URL: https://codereview.chromium.org/815083004

Cr-Commit-Position: refs/heads/master@{#309564}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f11ba2b..73483d9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/820073002

Cr-Commit-Position: refs/heads/master@{#309563}

BUG=441446

Review URL: https://codereview.chromium.org/818053003

Cr-Commit-Position: refs/heads/master@{#309562}

This is a partial fix for 41, but this part can be merged to 39 and 40.
This should be merged to 39 and 40.

BUG=444524

Review URL: https://codereview.chromium.org/822823002

Cr-Commit-Position: refs/heads/master@{#309561}

r302898 made FontRenderParams avoid calling FcFontMatch()
for empty queries, instead just sticking to the default
pattern. Many users don't have sane default patterns,
though, so instead call FcConfigSubstituteWithPat() to load
settings that aren't tied to particular font families.

Also use scoped_ptr to simplify FcPattern management and add
myself as an owner for font_render_params*.

BUG=442443,435277,423056

Review URL: https://codereview.chromium.org/811123002

Cr-Commit-Position: refs/heads/master@{#309560}

BUG=418375

Review URL: https://codereview.chromium.org/820063003

Cr-Commit-Position: refs/heads/master@{#309559}

In the fill on account select password manager experiment, the enabled
setting still highlights the fields that can be autofilled. This adds an
experimental group where the fields will not be highlighted even if they
can be autofilled until after a choice has been selected.

R=gcasto@chromium.org
TBR=isherman@chromium.org

BUG=410963

Review URL: https://codereview.chromium.org/788183004

Cr-Commit-Position: refs/heads/master@{#309558}

Cr-Commit-Position: refs/heads/master@{#309557}

Cr-Commit-Position: refs/heads/master@{#309556}

BUG=405361

Review URL: https://codereview.chromium.org/783663003

Cr-Commit-Position: refs/heads/master@{#309555}

BUG=444827
TBR=eroman
NOTRY=true

Review URL: https://codereview.chromium.org/821093006

Cr-Commit-Position: refs/heads/master@{#309554}

BUG=419373
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/822913002

Cr-Commit-Position: refs/heads/master@{#309553}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/825663002

Cr-Commit-Position: refs/heads/master@{#309552}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2db2f35..ce0377c

TBR=gavinp@chromium.org,johnme@chromium.org

Review URL: https://codereview.chromium.org/819283002

Cr-Commit-Position: refs/heads/master@{#309551}