- 23 May, 2017 40 commits
-
-
fdoray authored
SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2876213002 Cr-Commit-Position: refs/heads/master@{#473979}
-
Jason Chase authored
Crashes are being observed in the Origin Trials token validation flow. The crashes seem occur during service worker startup, trying to validate stored tokens. This path uses ChromeOriginTrialPolicy, which is lazily created. That creation path does not look thread-safe, so the theory is there is a race during initialization causing the crash. This CL implements a lock on creation/access to the policy object, to prevent a race. Bug: 714992,721144 Change-Id: I7e842f68af54d58857d8b43b592a7125c0daecab Reviewed-on: https://chromium-review.googlesource.com/506509Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#473978}
-
rdevlin.cronin authored
The chrome.runtime API has a method called `getPackageDirectoryEntry` which has custom bindings to retrieve the app's directory entry (a la HTML5 filesystem) and return it. The custom bindings for this are quite strange, since it needs to be done from the app's background page. Move this to the file_entry_binding_util.js file, where the similar getFileBindingsForApi() function is implemented. In addition to grouping similar logic, this solves a native bindings issue where with trying to require an API directly (which is disallowed). BUG=653596 TBR=michaelpg@chromium.org (moving a resource) Review-Url: https://codereview.chromium.org/2895493004 Cr-Commit-Position: refs/heads/master@{#473977}
-
ekaramad authored
The IPC message BrowserPluginHostMsg_ImeFinishComposingText does not have a parameter for the instance ID of BrowserPlugin and therefore, is dropped on the browser side inside BrowserPluginMessageFilter. This causes a regression in (Japanese) IME where clicking during an ongoing composition does not commit. BUG=720023 Review-Url: https://codereview.chromium.org/2887973002 Cr-Commit-Position: refs/heads/master@{#473976}
-
danakj authored
Pass it directly to RecordPaintCanvas and ToSkPicture, and other skia methods which is where it is used. This allows us to more easily get rid of cc::DisplayItem and its subclasses, replacing them with a PaintOpBuffer in DisplayItemList directly instead. The difficulty I faced with that was that if DisplayItemList has a single PaintOpBuffer, then it has a single cull rect. However when painting, each "batch" of PaintOps can have a different cull rect (corresponding to the PaintOps that would have been in a single DisplayItem before). So, instead the cull rect should be a property of recording at the RecordPaintCanvas level, which is a temporary object. As such, creators of cc::RecordPaintCanvas (mostly thru cc::PaintRecorder) need to manage the cull rect themselves to pass to things that want to use it with the cc::PaintOpBuffer (aka cc::PaintRecord at this time). Original code review was done on gerrit: https://chromium-review.googlesource.com/c/503472 R=chrishtr@chromium.org, enne@chromium.org, pdr@chromium.org BUG=671433, 646010, 724367 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2889653002 . Cr-Original-Commit-Position: refs/heads/master@{#472917} Committed: https://chromium.googlesource.com/chromium/src/+/c5f1b6126a7657234b9abc0c4359cbab45850b69 Review-Url: https://codereview.chromium.org/2889653002 Cr-Commit-Position: refs/heads/master@{#473975}
-
afakhry authored
The previously generated skiafied 2x icon of the ON status of NightLight was misaligned with the OFF status icon. BUG=721952 TEST=Test on kevin, or on the emulator with --force-device-scale-factor=2. Make sure the ON and OFF icons are aligned. Review-Url: https://codereview.chromium.org/2900083002 Cr-Commit-Position: refs/heads/master@{#473974}
-
zmo authored
conformance2/textures/image_data/'tex-3d-rgb565-rgb-unsigned_short_5_6_5.html fails on Linux AMD R7 240 BUG=725556 TEST=WebGL2 Conformance / Linux AMD R7 240 bot turns green TBR=kbr@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2900103002 Cr-Commit-Position: refs/heads/master@{#473973}
-
Rune Lillesveen authored
Should fix the stack overflow issue for selectors with an excessive amount of compound selectors. R=meade@chromium.org BUG=719374 Change-Id: I2a1cfb8cb2d00d96f8d46a6e7317c5871020c6cd Reviewed-on: https://chromium-review.googlesource.com/506020Reviewed-by:
Eddy Mead <meade@chromium.org> Commit-Queue: Rune Lillesveen <rune@opera.com> Cr-Commit-Position: refs/heads/master@{#473972}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4eb9e4f0..03172a0f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2904553002 Cr-Commit-Position: refs/heads/master@{#473971}
-
robertshield authored
BUG=679905 Review-Url: https://codereview.chromium.org/2900053002 Cr-Commit-Position: refs/heads/master@{#473970}
-
thakis authored
https://chromium.googlesource.com/external/github.com/google/googletest/+log/8c7f93fed..42bc671f4 Almost all no-ops. Pulling this in for https://chromium.googlesource.com/external/github.com/google/googletest/+/b2cbbec04c141801dc9f648dc92b26bac5bad0da BUG=550065 Review-Url: https://codereview.chromium.org/2901773003 Cr-Commit-Position: refs/heads/master@{#473969}
-
tedchoc authored
There was an off by one error that was making it 49 chars. The previous solution wouldn't work if the base ID was less than 25 chars either. This solution should work for any non-empty ID. TBR=yusufo@chromium.org TEST=DCHECK doesn't fail BUG= Review-Url: https://codereview.chromium.org/2900963004 Cr-Commit-Position: refs/heads/master@{#473968}
-
qyearsley authored
Hi bokan@, what do you think of this possible rename? Review-Url: https://codereview.chromium.org/2895863003 Cr-Commit-Position: refs/heads/master@{#473967}
-
thomasanderson authored
Gtk2 did not have a global window scaling setting (so the only way to scale up widgets was with a custom theme). However, it did allow font scaling with gdk-xft-dpi (backed by XSetting Xft/DPI). Gtk3 adds (non-fractional) global window scaling with gdk-window-scaling-factor (XSetting Gdk/WindowScalingFactor). To ensure that fonts were not scaled up twice (once from gdk-window-scaling-factor and once from gdk-xft-dpi), a new setting was added in [1] that overrides gdk-xft-dpi: gdk-unscaled-dpi (XSetting Gdk/UnscaledDPI). gdk-xft-dpi was kept around for compatibility with apps like Chromium that still need it. When modifying these settings, an invariant should be maintained: gdk-xft-dpi = gtk-window-scaling-factor * gdk-unscaled-dpi. Chromium should have been able to keep using gdk-xft-dpi, but this invariant is violated when changing the settings using gnome-tweak-tool, where I have gdk-window-scaling-factor = 2, gdk-unscaled-dpi = 98304, and gdk-xft-dpi = 98304 (gdk-xft-dpi should be 196608). [2] changed Gtk builds to use the window scaling factor, which is incorrect because it did not consider font scaling, making fractional scaling impossible. This CL takes gdk-unscaled-dpi into the calculation as well, and continues to fallback on using gdk-xft-dpi if the other variables are unavailable, which can happen on Gtk2. [1] https://git.gnome.org/browse/gtk+/commit/?id=4b9c08f48d6f5be43b0795d3eee462d60b5f9e1f [2] https://codereview.chromium.org/2869763004 BUG=723931 R=erg@chromium.org,chris.coulson@canonical.com CC=oshima@chromium.org Review-Url: https://codereview.chromium.org/2899943002 Cr-Commit-Position: refs/heads/master@{#473966}
-
csashi authored
Fixes hintWidth calculation when we reverse animation. BUG=724624 Review-Url: https://codereview.chromium.org/2897753002 Cr-Commit-Position: refs/heads/master@{#473965}
-
rhalavati authored
Syntax error corrected in network traffic annotations of: chrome/browser/extensions/install_signer.cc extensions/browser/updater/extension_downloader.cc BUG=656607 Review-Url: https://codereview.chromium.org/2900953002 Cr-Commit-Position: refs/heads/master@{#473964}
-
spqchan authored
When a secondary UI dialog is opened, the omnibox icon it's anchored to need to set its state as active. When the dialog is dismissed, the icon is set to inactive. BubbleAnchorHelper provides functions to retrieve the omnibox icons and sets the active state. BUG=715863 Review-Url: https://codereview.chromium.org/2882533003 Cr-Commit-Position: refs/heads/master@{#473963}
-
c.padhi authored
SupportsWeakPtr's weak pointers are invalidated only after derived class members are destroyed which may lead to use-after-destroy issues. This CL removes SupportsWeakPtr from GLES2Decoder and adds a WeakPtrFactory instance to each of its subclasses. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2898953002 Cr-Commit-Position: refs/heads/master@{#473962}
-
dtrainor authored
The rectangle highlight was mostly faded out, with an occasional pulse to fade in. The spec calls for the opposite. Switching the animation. BUG=724996 Review-Url: https://codereview.chromium.org/2902573002 Cr-Commit-Position: refs/heads/master@{#473961}
-
dmazzoni authored
The automation API specifies the hit test coordinates should be integers which is fine since there's no reason for sub-pixel precision. However, it crashes if you pass it a non-integer, which is not good! It should just convert to an integer. BUG=725159 TBR=aboxhall Review-Url: https://codereview.chromium.org/2900803003 Cr-Commit-Position: refs/heads/master@{#473960}
-
estark authored
Requiring quoted URLs was cargo-culted from the HPKP implementation. The HPKP spec does not actually say that report-uris must be quoted -- it's simply that all the examples quote them. So it's possibly a bug that Chrome's HPKP implementation requires quoted report-uris. The Expect-CT spec doesn't say anything about quoting report-uris nor do I see a reason that it should, so Chrome's implementation shouldn't require them. BUG=679012 Review-Url: https://codereview.chromium.org/2895373002 Cr-Commit-Position: refs/heads/master@{#473959}
-
lfg authored
Review-Url: https://codereview.chromium.org/2894203002 Cr-Commit-Position: refs/heads/master@{#473958}
-
fgorski authored
* Adds an OS upgrade check to the BackgroundTaskScheduler * Adds OS version tracking to BackgroundTaskSchedulerPrefs * Ensures GCMNetworkManager based upgrades only happen on supported OSs * Calls OS version check from DeferredStartupHandler BUG=710630 R=nyquist@chromium.org Review-Url: https://codereview.chromium.org/2819703002 Cr-Commit-Position: refs/heads/master@{#473957}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1b02d0180403..c4ecd7b2e10e $ git log 1b02d0180..c4ecd7b2e --date=short --no-merges --format='%ad %ae %s' 2017-05-23 dsinclair Cleanup default values and methods in CXFA_Widgetdata Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ia13f388997d6d9d2926a3bac899831f2447fa092 Reviewed-on: https://chromium-review.googlesource.com/512224 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#473956}
-
hongchan authored
This CL applies layout-test-tidy to the entire WebAudio layout test files. Some of expected files needed to be updated because of the change of the console logging line number. BUG=725234 TEST=(after the application all tests still passes.) Review-Url: https://codereview.chromium.org/2895963003 Cr-Commit-Position: refs/heads/master@{#473955}
-
dimu authored
Cr-Commit-Position: refs/heads/master@{#473954} -
weidongg authored
- Background: Updates over cellular is blocked by Chrome UI by default, but we now allow so if user is actively checking for updates (e.g clicking 'check for updates' button). But auto-updates over cellular is still not supported. - Changes in this CL: Add a |interactive| parameter to IsUpdateOverCellularAllowed(), which indicates whether user is actively checking for updates. Show proper warning message when user is over cellular connection. - Design doc: go/cros-cellular-updates BUG=chromium:691108 TEST=go/about_chrome_os_err_msg for screenshots of different messages shown in different situations. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2897773002 Cr-Commit-Position: refs/heads/master@{#473953}
-
jamescook authored
This fixes flake in ash_unittests in tests that record and read back histograms, in particular PointerMetricsRecorderTest. This is similar to the initialization in ComponentsTestSuite, ContentTestSuiteBase, etc. BUG=725287 TEST=run ash_unittests locally, PointerMetricsRecorderTest doesn't retry Review-Url: https://codereview.chromium.org/2901703002 Cr-Commit-Position: refs/heads/master@{#473952}
-
Rouslan Solomakhin authored
Before this patch, the desktop web payments UI omitted sorting code and dependent locality when constructing labels for shipping addresses. That would confuse users located in such countries as France, where sorting code is used. This patch moves the iOS functions to create labels for shipping and billing address labels into components/payments/core/strings_util.h and uses these functions from both iOS and desktop. After this patch, the shipping addresses on desktop show i18n addresses from all countries correctly. Bug: 725182 Change-Id: I9d1fcc513d11914b54553644f82743d2685972c0 Reviewed-on: https://chromium-review.googlesource.com/511102Reviewed-by:
mahmadi <mahmadi@chromium.org> Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#473951}
-
mek authored
Revert of Add ScopedTaskEnvironment::ExecutionControlMode. (patchset #6 id:100001 of https://codereview.chromium.org/2891363005/ ) Reason for revert: Is causing consistent test failures on the main waterfall in net_unittests URLRequestSimpleJobTest.CancelAfterFirstReadStarted, for example: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests%2F41620%2F%2B%2Frecipes%2Fsteps%2Fnet_unittests%2F0%2Flogs%2FURLRequestSimpleJobTest.CancelAfterFirstReadStarted%2F0 [1130:771:0523/094643.091773:30621298248173:FATAL:scoped_task_environment.cc(178)] Check failed: !task_queue_empty_closure_. 0 net_unittests 0x0000000102d4603c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 net_unittests 0x0000000102d5db70 logging::LogMessage::~LogMessage() + 224 2 net_unittests 0x000000010302df97 base::test::ScopedTaskEnvironment::RunUntilIdle() + 183 3 net_unittests 0x000000010205f824 net::URLRequestSimpleJobTest_CancelAfterFirstReadStarted_Test::TestBody() + 260 4 net_unittests 0x00000001022adf56 testing::Test::Run() + 246 5 net_unittests 0x00000001022ae9f0 testing::TestInfo::Run() + 288 6 net_unittests 0x00000001022aef57 testing::TestCase::Run() + 263 7 net_unittests 0x00000001022b5057 testing::internal::UnitTestImpl::RunAllTests() + 871 8 net_unittests 0x00000001022b4cc3 testing::UnitTest::Run() + 163 9 net_unittests 0x00000001030309b3 base::TestSuite::Run() + 163 10 net_unittests 0x000000010303e176 base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 134 11 net_unittests 0x0000000101fdf008 main + 440 12 libdyld.dylib 0x00007fff8d4495fd start + 1 13 ??? 0x0000000000000007 0x0 + 7 Original issue's description: > Add ScopedTaskEnvironment::ExecutionControlMode. > > This enum controls whether tasks posted within the scope of a > ScopedTaskEnvironment can run as they are posted or have to wait > until a call to RunUntilIdle() to run. > > BUG=724077 > TBR=gab@chromium.org > > Review-Url: https://codereview.chromium.org/2891363005 > Cr-Commit-Position: refs/heads/master@{#473925} > Committed: https://chromium.googlesource.com/chromium/src/+/fc7b5ec521b29a97e63a7cda5921aa5ed793679a TBR=gab@chromium.org,robliao@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=724077 Review-Url: https://codereview.chromium.org/2903633003 Cr-Commit-Position: refs/heads/master@{#473950}
-
jam authored
Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows 10 with PlzNavigate. The tests were loading a tab that would be closed. The test code was waiting for both a didstop IPC (inside InProcessBrowserTest::AddTabAtIndexToBrowser) and for the extension-unloaded notification (what the test is really testing). With PlzNavigate, the didstop IPC is sent later and it's racy whether the renderer will send it before the tab is closed. So remove the first wait. BUG=699437 Review-Url: https://codereview.chromium.org/2896853005 Cr-Commit-Position: refs/heads/master@{#473949}
-
cfroussios authored
BUG=725470 NOTRY=TRUE TBR=shinyak Review-Url: https://codereview.chromium.org/2902753002 Cr-Commit-Position: refs/heads/master@{#473948}
-
ymalik authored
on x86/c64 bots. The problem was that VrShellDelegate.java depends on VrFeedbackStatus.java which was only available when enable_vr was set to true. This CL build VrFeedbackStatus as part of chrome_java_sources instead of chrome_vr_java_sources. Original CL: https://codereview.chromium.org/2887383002/ Revert: https://codereview.chromium.org/2896933002/ Revert "Revert "Show an infobar prompting the user to enter feedback when they exit VR"" This reverts commit 007ec6f3. TBR=mthiesse BUG=706438 Review-Url: https://codereview.chromium.org/2899013002 Cr-Commit-Position: refs/heads/master@{#473947}
-
John Budorick authored
TBR=wychen@chromium.org,yusufo@chromium.org,mlamouri@chromium.org Bug: 725534 Change-Id: Ifc0696d08d82d0ea41fc96c7ef09e54cf161b3f2 Reviewed-on: https://chromium-review.googlesource.com/512365Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#473946}
-
Rouslan Solomakhin authored
Before this patch, typing "3103106000" into a phone number field in web payments UI on desktop would leave the field as-is, which is difficult to read. This patch extends ValidationDelegate to also handle text field formatting. Formatting happens only when the user is typing at the end of the field or when user has left the field (blur). Typing in the middle of the field does not cause reformat because Views does not have functionality to position the cursor, which is required to make auto-formatting feel natural. After this patch, typing "3103106000" into a phone number field in web payments UI on desktop will format-as-you-type this number into "+1 310-310-6000". Bug: 725161 Change-Id: Id39de49e2a79a681ff2615541489be057b37d2de Reviewed-on: https://chromium-review.googlesource.com/511422Reviewed-by:
-
mek authored
Revert of Why do we have this line when it makes sliders look editable? (patchset #2 id:20001 of https://codereview.chromium.org/2893963002/ ) Reason for revert: Is causing test failures such as https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/67395 DumpAccessibilityEventsTest.AccessibilityEventsAriaSliderValueTextChange c:\b\c\b\win\src\content\browser\accessibility\dump_accessibility_browsertest_base.cc(363): error: Value of: is_different Actual: true Expected: false [4988:5300:0523/092002.409:37981750:ERROR:dump_accessibility_browsertest_base.cc(388)] Diff: * Line Expected - ---- -------- * 1 EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_EDITABLE,IA2_STATE_VERTICAL 2 <-- End-of-file --> Actual ------ EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_VERTICAL <-- End-of-file --> Original issue's description: > Why do we have this line when it makes sliders look editable? > > BUG=None > > Review-Url: https://codereview.chromium.org/2893963002 > Cr-Commit-Position: refs/heads/master@{#473911} > Committed: https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b670d893883cfe TBR=dmazzoni@chromium.org,aleventhal@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2900953004 Cr-Commit-Position: refs/heads/master@{#473944}
-
sczs authored
UI screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgSUJKeTBQMndhbnc Constraints screenshot: https://drive.google.com/open?id=0Byo6-Nuda2jgYnZ3SnRPdERxQzA BUG=682880 Review-Url: https://codereview.chromium.org/2901663002 Cr-Commit-Position: refs/heads/master@{#473943}
-
robertshield authored
BUG=724491 Review-Url: https://codereview.chromium.org/2895693002 Cr-Commit-Position: refs/heads/master@{#473942}
-
jkrcal authored
This CL adds metrics that report success for downloading favicons on demand (both for existing code for PopularSites and for the new code for MostLikely). BUG=536988 Review-Url: https://codereview.chromium.org/2888393002 Cr-Commit-Position: refs/heads/master@{#473941}
-
sdefresne authored
BUG=None Review-Url: https://codereview.chromium.org/2886763003 Cr-Commit-Position: refs/heads/master@{#473940}
-
