- 20 Aug, 2019 40 commits
-
-
Dirk Pranke authored
This reverts commit 6e49ee86. Reason for revert: Apparently we use --gtest_repeat to retry failures :(. See, e.g., https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8904608481037328864/+/steps/webkit_layout_tests__without_patch_/0/stdout Original change's description: > Remove obsolete --gtest* flags to run_web_tests. > > run_web_tests supported the --gtest_repeat, > --gtest_also_run_disabled_tests, and --gtest_filter flags for > compatibility with FindIt; however FindIt eventually moved > to using the --isolated-script-test flags instead, and these > flags should no longer be used or needed, so this CL removes them. > > This is a prelude to cleaning up and implementing proper support > for multiple --isolated-script-test-filter args. > > Bug: 893235, 994943 > Change-Id: Id7a8ef5f43855b54eeb76193ceca45310b426890 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759138 > Reviewed-by: Chan Li <chanli@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688190} TBR=dpranke@chromium.org,chanli@chromium.org,robertma@chromium.org,rmhasan@google.com Change-Id: Iefbc7390a69046bd0ab3205f090f003944d9874c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893235, 994943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761638Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#688563}
-
Dominik Röttsches authored
Tbr: schenney@ Change-Id: I2be033328741a747e94beca1b61ca9fd4a6a7841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762218Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#688562}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/90c00916229f..210fac8904dc git log 90c00916229f..210fac8904dc --date=short --no-merges --format='%ad %ae %s' 2019-08-20 zoddicus@users.noreply.github.com Rolling 4 dependencies (#779) Created with: gclient setdep -r src/third_party/shaderc/src@210fac8904dc The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I757bb9bc0714db0f9a84abcb349e25a1bd9c7d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688561}
-
Nicolás Peña Moreno authored
This CL fixes the UseCounter for LargestContentfulPaint by moving it to the PerformanceObserver::observe() method. Before, it would be triggered in Performance::getEntriesByTypeInternal(), which would be triggered only when requesting LCP entries with the buffered flag. While at it, we move ElementTiming UseCounter to this method too (no important change). We do not move the EventTiming UseCounter because if 'event' is observed then we will add to the UseCounter even though it's not shipped yet. Once issue 994332 is fixed, we could move the UseCounter logic. This CL also adds a UseCounter for calling observe() with the buffered flag. We trigger it with any call to observe() where the buffered flag is set to true. Bug: 995455 Change-Id: Id8c443b8403cbc4b909c5815213fef8e97623715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760981Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#688560}
-
John Abd-El-Malek authored
The latter didn't originally exist, but most of these methods have a NetworkContext associated with them so we should route it there. Change-Id: I7d1bfbea4a36cc1b851725531c841ddd799797dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759297Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#688559}
-
Sanket Joshi authored
Currently, if the color picker or color suggestion picker is open and the type of the owning input element changes from color to something else, the popup to choose a new color remains open even though the type of the input has changed. This can be seen in the color-picker-appearance-set-type test, when run with the form controls refresh flag enabled. This change is fixing this issue, which results in the popup being dismissed when the input's type is changed. This behavior is not spec'ed and neither is there consistency between browsers on how this scenario should behave - Firefox does not dismiss popups on type change, while Edgehtml-based Edge does. However, from a user's perspective, it is strange to see the old popup once the type of the input has changed. Additionally, in the case of the date control, the picker does get dismissed when a type change occurs. Hence, it makes sense to do the same for the color control, so that there is consistent behavior across controls in Chromium. Note that this change is not limited to the form controls refresh flag as the color suggestion picker, which pre-dates the form controls refresh project, is also being fixed. A test is being added for this case to validate the new behavior. Bug: 985889 Change-Id: Idcf7c5ad056b21bf59870496a8fe618ee2309d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759226Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sanket Joshi <sajos@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688558}
-
Julie Jeongeun Kim authored
This CL converts CookieChangeListenerPtr and CookieChangeListenerRequest to new Mojo types. It updates AddChangeListener from restricted_cookie_manager.mojom, AddCookieChangeListener and AddGlobalChangeListener from cookie_manager.mojom. Bug: 955171, 978694 Change-Id: I315979060078f10b8b73827b9a42a3b705d0a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753371 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688557}
-
Vasilii Sukhanov authored
The flow of the crash - PasswordManager::OnGeneratedPasswordAccepted is called when a generated password is accepted. - It can bring up the "Update Password?" bubble - Focus lost event is happening, the dropdown is closed, the controller is destroyed. - PasswordManager::OnGeneratedPasswordAccepted finishes. - PasswordGenerationPopupControllerImpl tries to hide the UI again but everything is gone already. Bug: 995321 Change-Id: I791c969ea6af1b6fc305219a5c22d49424ab38ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762214Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688556}
-
Lan Wei authored
Because test_driver Action API created a "none" type for "pause" action not just adding "pause" action in the pointer action sequence, we need to not include "none" type for pointer action index. Bug: 606367 Change-Id: I503327c41f76b0587ee84cdea4a1313f6fa572f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752350 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688555}
-
Pavel Shmakov authored
This CL builds the implementation of Web Share Target for TWAs on top of the previous one (http://crrev.com/c/1715374): - Adds TwaIntentHandlingStrategy for TWA-specific logic of intent handling. It sends the intent to TwaSharingController to check whether it's a sharing intent. - Adds TwaSharingController that parses share target json, constructs and launches GET requests, and delegates handling POST requests to WebApkPostShareTargetNavigator. - Adds unit tests for share target parsing, and a few integration tests for the whole sharing process. Bug: 985331 Change-Id: Ifa98e46a5e5c681a30442aecfbd6df57a60d9e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724686 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#688554}
-
Stephen Chenney authored
R=pdr@chromium.org Bug: None Change-Id: Ia263c5503c93fffcb913fa5bfc58bf23edac2e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760882 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688553}
-
James Forshaw authored
This CL removes the old renderer appcontainer flag from about:flags. It also removes the old command line switch to enable or disable, instead replacing it with a feature. This feature is disabled by default but the expectation is to enable by default in the next milestone. Bug: 501975 Change-Id: If9b7425624d60243e998958d31e53d5607a3424e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761471Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#688552}
-
Robert Ogden authored
Bug: 971918 Change-Id: Icb952b211e066f7c70f283f6156ed4e279b4013b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738676Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#688551}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: I05ccc92ea5ccdd70e10ae916cb826bb554ed3eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762233 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#688550}
-
Brian White authored
Updates the expires_after attribute for 316 histograms that show frequent access in the past 90 days. These are the 60% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-02-16. Change-Id: Id9e82848066a4df330e9e185c020bd0916e0c39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762307 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#688549}
-
Alex Chau authored
- Propagate various HTTP error code as SendWebPushMessageResult - Remove device from preference for SendWebPushMessageResult::kDeviceGone - Surface subset of SendWebPushMessageResult as SendMessageResult to UI classes - Actual UI update will be done separately Bug: 966022 Change-Id: Ide932198221fdd854a844a08a32811634179e730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751209 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688548}
-
Niels Möller authored
To enable removal of most default implementations in PeerConnectInterface, see https://webrtc-review.googlesource.com/c/src/+/140860 Bug: webrtc:10716 Change-Id: Ic0480552678fbc5935864b5d36dafecd0e6c2490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753928Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#688547}
-
Nico Weber authored
- The CLs created by this script are mininmal and none of the changes done by the script affect presubmits. - It's a tiny bit faster. - It allows running the script in a checkout that didn't run `gclient sync`; as-is a presubmit tries to read build/config/gclient_args.gni which doesn't exist then. TBR=hans Bug: none Change-Id: I5801810e9f04f3436e84230cd6559f68b0a77451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758910Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#688546}
-
Tricia Crichton authored
Changed test code to use 'browserVersion' instead of 'version' as key to retrieve and compare Chrome versions. Bug: chromedriver:3015 Change-Id: I8f4dc5a26e433f2d0e2adc4f0f088e5d8d7f0316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761474Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#688545}
-
Tricia Crichton authored
This test creates 2 Chrome instances, which is not supported on Android. The functionality is sufficiently tested by desktop tests, so the test was added to the Android negative filter. Change-Id: I5fdcae8e50d6be27ab020d2337daa3f5e35bfca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761611Reviewed-by:
-
Elly Fong-Jones authored
This directory was renamed which broke the old suppressions. TBR=marinaciocea@chromium.org Bug: 783800 Change-Id: Id7ea5283357bca9c277f2cd454b9aae1316b3a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757362Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#688543}
-
Konrad Hofbauer authored
Bug: 951299 Change-Id: I5b27fa435bd8c81c1e3a76967a870ee3495f5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762080 Auto-Submit: Konrad Hofbauer <hofbauer@chromium.org> Reviewed-by:
-
Vladislav Kuzkokov authored
Make |PrintingContext::settings_| null before settings are created or after ownership is passed to PrinterQuery. Bug: 964948 Change-Id: I0cff0b5b460ecb3424ff0cb07e5849bed3ffe51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678182Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#688541}
-
Rouslan Solomakhin authored
Before this patch, HasEnrolledInstrumentQueryQuotaTest.QueryQuota would fail or succeed depending on whether per-method quota flag was enabled in the test environment. This patch breaks up the QueryQuota test into several tests, each one explicitly setting the "strict autofill data check" and "per method quota" flags at the start to best replicate all possible execution environments. After this patch, HasEnrolledInstrumentQueryQuotaTest passes in all test environments. Bug: 995728 Change-Id: I1c6812b5ae8b464c7f121bc0ce2ca0fcc5258503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760881 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#688540}
-
Yaron Friedman authored
These files don't see much change but we haven't worked on it in a while. Reviews should be handled by sync team. Change-Id: I34bfe50795e65ac1ce87f74eea26c8f42b5b9011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758301 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#688539}
-
Javier Ernesto Flores Robles authored
Screenshot: https://drive.google.com/file/d/1crTpGA9Isl6O4L9I2zPcCqu18fqzpLv6/view?usp=sharing Bug: 976675 Change-Id: Id795ea1896507d3b1e5bbbd5cd84f083e2c0df42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762213 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#688538}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5288d5c6c2d9..b88012e339bf Created with: gclient setdep -r src-internal@b88012e339bf The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9b5f332acad845d83dc1b81fa52f2e595dd400c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762267Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688537}
-
John Delaney authored
This CL implements the per top-frame origin throttling for the heavy ad intervention. Because this intervention leaks some amount of information cross-site, we need to only allow a certain number of triggers per-day so that this intervention does not create an abusable side channel attack. Metrics show that a per-origin per-day cap of 5 interventions covers 90% of heavy ad cases. This CL re-introduces a similar framework used by PageLoadCapping and makes use of the blacklist component to handle the persistent storage to memory. The blocklist is gated behind a different feature than the heavy ad intervention to maintain that field trials are only activated for heavy ads when a user has seen a heavy ad. Change-Id: Iee38eaa3064f37b1b5a7258a31221527345d4b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645142 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#688536}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ida5a058fa81bc1c4ca8a0c40a80cd13e7e9fa5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700906Reviewed-by:
Philippe Hamel <hamelphi@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Philippe Hamel <hamelphi@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688535}
-
Umesh Patil authored
Bug: b/139693028 Change-Id: Ic9c135ce012cdf7b85d81f23824ee6e12ca15553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761648Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Umesh Patil <upatil@google.com> Cr-Commit-Position: refs/heads/master@{#688534}
-
James Cook authored
Make the first row of the People section not clickable when the account manager is disabled (e.g. via flags or Finch). Bug: 950007 Test: added to browser_tests Change-Id: Ib9720f55fb60b526afe3ae40566678f603423320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760463Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#688533}
-
Yann Dago authored
Bug: 995251 Change-Id: I2c268a4def6e1ef8a13bd661b15bc96fe63bde29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761148Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#688532}
-
Henrik Boström authored
This was reported as flaky. I am unable to reproduce, which could mean that the issue is fixed, or it could mean that it only flakes on certain setups (OS, builds, hardware, etc). To aid investigation I am speculatively re-enabling it; worst case it gets disabled again. Bug: 754684 Change-Id: I866679464fce4facde927652751046e062ca1c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761602Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688531}
-
Javier Ernesto Flores Robles authored
Replace brand image and logo with versions containing alpha. Remove unused 1x image. Add dark mode to brand image. This requires to be compiled with Xcode 11 (iOS SDK 13). Bug: 976640 Change-Id: Id19d571d8e6fd85ad616329616c0eb3319867164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713538Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#688530}
-
Henrik Boström authored
This was reported as flaky. I am unable to reproduce, which could mean that the issue is fixed, or it could mean that it only flakes on certain setups (OS, builds, hardware, etc). To aid investigation I am speculatively re-enabling it; worst case it gets disabled again. Bug: 993020 Change-Id: I31920b14d1ec02b8cc0eaeb86d93caa8c6226d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762075Reviewed-by:
-
Saman Sami authored
This will help us compare Skia's readback to GLRendererCopier during the finch trial. Bug: 898595 Change-Id: I94abef58951662480a6e5573fad616bf8724b863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652200Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688528}
-
Alexander Hendrich authored
This CL updates the config dir policy loader to also apply the loaded extension policy to login screen extensions. Bug: 928334 Change-Id: If16447393f05f9d9fb78e885eaa50478d4d342ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728587 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#688527}
-
Peng Huang authored
Bug: 995343 Change-Id: Id9638c41db2c208ba8f12fa0a8d90610aae574f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761062Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#688526}
-
Elly Fong-Jones authored
It is not just flaky on Mac. TBR=marinaciocea@chromium.org Bug: 988248 Change-Id: Iad51b21d0f85900f2fd0fabe3da1f21a6ea21862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761145Reviewed-by:
-
Javier Ernesto Flores Robles authored
Sets the tint color of the cell so when the accessory view is created it is tinted with the right color. Sets the tint color of the table view to blue so the index uses it. Screenshots: https://drive.google.com/file/d/1xfOJVT6ZqqOiSb_pEX_uWqeLeEcxpc2F/view?usp=sharing https://drive.google.com/file/d/1-HwGeIh1d-vk3fSDfsLVxWTm0y64kRfG/view?usp=sharing Bug: 976675 Change-Id: I3f1b4990060a1db29eb119c271d3402c8e1706b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749010 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
