- 02 May, 2018 40 commits
-
-
Stephen McGruer authored
This CL adds a check to help investigate crbug.com/826627. The assumption is that merge_.start_interpolable_value is turning out to be nullptr in the TransitionInterpolation constructor. Working this backwards, it appears that the only way this could happen is if SetValue was called with a TypedInterpolationValue that had no interpolable value stored within it. Bug: 826627 Change-Id: I3c5159fa0314bf5651bdbda68ef9c97b5a1a567c Reviewed-on: https://chromium-review.googlesource.com/1032874Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555352}
-
Ryo Hashimoto authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/43880122c4f3..d45ce7d90232 $ git log 43880122c..d45ce7d90 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 emaxx cryptohome: Delete obsolete challenge-response APIs 2018-04-19 hashimoto Add constants for ArcAppFuseProvider Created with: roll-dep src/third_party/cros_system_api BUG=837161 BUG=806788 Change-Id: I31ebc9bd3b5338fcd69a61848054ab50ec0d63b7 Reviewed-on: https://chromium-review.googlesource.com/1039306Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#555351}
-
https://chromium.googlesource.com/angle/angle.git/+log/57d9cbb67f2d..9aef81c7cec0 $ git log 57d9cbb67..9aef81c7c --date=short --no-merges --format='%ad %ae %s' 2018-04-30 oetuaho Validate blitFramebuffer for overflows on all platforms 2018-04-26 oetuaho Clean up BlitGL Created with: roll-dep src/third_party/angle BUG=chromium:830046,chromium:830046 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If5d19b20e6dc7096d7724d9fac6702427f560351 Reviewed-on: https://chromium-review.googlesource.com/1039067Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555350}
-
Alexis Hetu authored
Ran into an "unimplemented" message from RenderWidgetHostViewBase::GetCaptureSequenceNumber() when trying to run Layout Tests using SwiftShader on MacOS. The implementation for RenderWidgetHostViewMac is a copy of the implementation done in RenderWidgetHostViewAura. It appears to work properly. Bug: chromium:726075 Change-Id: I45f3a9f213e9f1c1d3f733ca9238c80c2b94dd22 Reviewed-on: https://chromium-review.googlesource.com/1035142Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555349}
-
Steven Bennetts authored
The solution to this was kind of subtle. Here are some notes for posterity: * ash::Shell::local_state_ (the device PrefService used by Ash) is loaded asynchronously, after Shell::Init. * Display preferences need to be initialized synchronously; there are currently too many dependencies to make asynchronous initialization robust. * Thus for 'classic' mode, we need to provide initial display prefs from the synchronously loaded browser local state prefs to ash::Shell::Init. * Registering prefs has to occur early (before feature flags are loaded), so using different registration for classic/mus/mash would be complicated. Instead we always register display prefs in chrome and treat them as foreign prefs in ash (except for tests). * Because of the complications of pref registration, accessing a second, synchronously loaded, PrefService instance in Ash would be difficult. Instead we extract a base::Value dictionary of display prefs and pass that in ShellInitParams. This fixes 'classic' mode, but does not solve the problem for mus/mash (which has never worked). Potential long term solutions: (a) Store display prefs in an Ash specific value store that is synchronously loaded (along with other similar prefs). (b) Initialize Shell::local_state_ with the initial state before the Mash process forks (solving any registration issues this entails). (c) Make initial display configuration work asynchronously. Bug: 834775 Change-Id: I75e561394c817e7c93d8c724bdadcaa37ef868af Reviewed-on: https://chromium-review.googlesource.com/1028479Reviewed-by:Dominic Battré <battre@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555348}
-
Guido Urdaneta authored
This reverts commit 40ba1dc5. Reason for revert: Does not fix the problem. Original change's description: > Disable caching of video-device enumerations on Mac. > > There is an issue with the Mac video device monitor that is causing > cache inconsistencies. > > Bug: 834581 > Change-Id: Idc1a0d953509fee7787fb07d19376d4800f76939 > Reviewed-on: https://chromium-review.googlesource.com/1023855 > Reviewed-by: Henrik Boström <hbos@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552689} TBR=hbos@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834581 Change-Id: I7e46c1a336d03511d97b2c7a02192e3474c9693a Reviewed-on: https://chromium-review.googlesource.com/1033732 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#555347}
-
Gauthier Ambard authored
This CL changes the background color of the selected items of the Popup Menu, displayed when the cell is highlighted. Bug: 834201 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I704837ded09d5bbd35c4beabb188216dc27383ed Reviewed-on: https://chromium-review.googlesource.com/1039365 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555346}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef4142a9bc5f..3fef39d94d2a $ git log ef4142a9b..3fef39d94 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 angle-skia-autoroll Roll third_party/externals/angle2/ 57d9cbb67..47155b171 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Iaa49f817fe3b794f02f5bf030a9c2e50a2e9caf5 Reviewed-on: https://chromium-review.googlesource.com/1039069Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555345}
-
David Roger authored
The correct value is kMaxValue, not kLast. Change-Id: I8abbf39f86818cf2f6b185ee20c27c2396d05c0b Reviewed-on: https://chromium-review.googlesource.com/1032992Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#555344}
-
Guido Urdaneta authored
Bug: 835332 Change-Id: Iceff1dcd64b2273e54097fb6a9e75becd156052a TBR: emircan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1039189Reviewed-by:
-
Patrik Höglund authored
This reverts commit 46bf6346. Reason for revert: New webcam plugged in; let's see if they're still flaky. Original change's description: > Disable flaky capture unittests on Linux. > > The tests went flaky when we replaced the bot and get VIDIOC_STREAMON > errors about 25% of the builds. I have no idea to fix that; we tried > replacing the webcam and moving it around in the USB ports and that > didn't help. See http://crbug.com/828568 for discussion. > > Bug: chromium:831514 > Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9 > Reviewed-on: https://chromium-review.googlesource.com/1016301 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552165} TBR=phoglund@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:831514, chromium:828568 Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745 Reviewed-on: https://chromium-review.googlesource.com/1039425Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#555342}
-
Marc Treib authored
SyncPrefs has a global "sync everything" pref, plus an individual pref for every datatype. The datatype-specific prefs are all disabled by default (which is fine because the global pref is enabled), except for BOOKMARKS and DEVICE_INFO which were enabled by default for unknown reasons. This CL removes the special treatment for BOOKMARKS. Bug: 837260 Change-Id: Ia5369596f8d9a5142eb51659d4418e492464b924 Reviewed-on: https://chromium-review.googlesource.com/1032443Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#555341}
-
Christopher Cameron authored
Separate out the code that is responsible for drawing a ui::Compositor's content from the ui::AcceleratedWidgetMac interface. Put that code into the ui::DisplayCALayerTree interface (this is a complement of the ui::CARendererLayerTree which is used to construct the CALayer tree in the GPU process, via the viz::DirectRenderer interface). The ui::DisplayCALayerTree is to be instantiated inside whatever process owns the NSView that is being displayed (current the browser, but soon the AppShim process as well). To that end, for RenderWidgetHostViewMac, instantiate a ui::DisplayCALayerTree in the RWHNSViewBridgeLocal, which is instantiated in the AppShim process. With this change, the ui::AcceleratedWidgetMac is only used to provide a mapping between gfx::AcceleratedWidget and NSView*, and so some resize-related bookkeeping. Update RWHVMac, BrowserCompositorViewMac, and BridgedNativeWidgetMac to use the ui::DisplayCALayerTree interface. Bug: 821651 Change-Id: I97b8de898e76dba8ef3a66d51c3887033e000e23 Reviewed-on: https://chromium-review.googlesource.com/1037145 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555340}
-
Jan Krcal authored
This CL removes another piece of dead-code after the successful launch of the USS autocomplete implementation. This was unintentionally omitted in the main cleanup CL (https://chromium-review.googlesource.com/c/chromium/src/+/921621). Bug: 702711 Change-Id: I4eb5ee4d81a87457ea978d9ee15df22bb2b8aaae Reviewed-on: https://chromium-review.googlesource.com/1028231Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#555339}
-
Koji Ishii authored
This patch changes floats to push lines down only if the container autowraps. This behavior is not defined, but all 4 impls do (Gecko checks parent style instead of block style though.) In breaking_context_inline_headers.h says: If the container autowraps but the current child does not (fit?) then we still need to ensure that it wraps and moves below any floats. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id1f9f4e8fe15d9951c225ce8742ac63f8ca13786 Reviewed-on: https://chromium-review.googlesource.com/1038083Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#555338}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6bb4189a..2194d161 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I41df87e5dad65e77097200b13acf23134ace88e9 Reviewed-on: https://chromium-review.googlesource.com/1038911Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555337}
-
Tim Schumann authored
Mention the use case of server-side provided data which usually goes into priority preferences as these are never encrypted. Change-Id: I4023db57b87749f411fafd72d4f45a14b7348338 Reviewed-on: https://chromium-review.googlesource.com/1033734Reviewed-by:
-
Kush Sinha authored
Implement a new OAuth2 delegate for Chrome OS which uses Chrome OS Account Manager as the source of truth for OAuth credentials. Bug: 820046 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I5b9dde8bc988f3aa1edf27b06691b07d2a7d5939 Reviewed-on: https://chromium-review.googlesource.com/1014041Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#555335}
-
Gauthier Ambard authored
This CL changes the direction of the arrow pointing from the bubble tip to its anchor based on the toolbar mode (split or unsplit) when the UI Refresh is enabled. Bug: 804760 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8de0cb833004c646fd7578d6421aa4dbe0810c0f Reviewed-on: https://chromium-review.googlesource.com/1015022Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#555334}
-
jdoerrie authored
This change implements static extents in base::span. These spans can be automatically created from array types, where the size is known at compile time. Furthermore, they allow for compile time checks when invoking templated first(), last() and subspan(). Bug: 828324 Change-Id: Ice309ab8d377a91331170bfba8ac82a31dad7cd1 Reviewed-on: https://chromium-review.googlesource.com/1021735 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555333}
-
Peter E Conn authored
This is the chromium side change that goes with: https://chromium-review.googlesource.com/c/custom-tabs-client/+/951306 Bug: 800424 Change-Id: Id0937ca2bd310312927ed5326701150c34105835 Reviewed-on: https://chromium-review.googlesource.com/978126Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#555332}
-
Max Morin authored
Stuff of note: - Code is for the UI thread. All the state we care about (permissions, frame/WebContents events, UI indicators, ...) is on the UI thread, and there are some tricky ordering problems with having the code on the IO thread if we want to observe frames/wc. As a bonus, we can get rid of a bunch of code posting to the UI thread in permissions and monitoring code. - In order to not need helper WebContentsObservers that proxies to the ContentAudioStreamFactoryClient, we have one ContentAudioStreamFactoryClient per WebContents. This also simplifies keeping the group id for the WebContents (just instantiate it in the constructor. - State is put in AudioOutputStreamBroker (and AudioInputStreamBroker, LoopbackStreamBroker, ...). We can have super simple per-frame factories thread that just checks permissions and forwards the request to the FactoryClient. - AudioOutputController errors are sent to content/ through the AudioOutputStreamObserver interface, so that it knows if we had a real error, service crash, or the client terminated the stream peacefully. content/ then forwards the error to the client. This also eliminates the AudioOutputStreamClient interface, simplifying a bit. This is done in the dependency CL. Next up, a RendererAudioOutputStreamFactory implementation (living in RenderFrameHost) which propagates requests to the ForwardingStreamFactory will be added. Class diagram involving some of these things: https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit Bug: 830493 Change-Id: I7e3804fa4a6ec6de8a2d0a971ecd5be69d267b1c Reviewed-on: https://chromium-review.googlesource.com/982058Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555331}
-
Hitoshi Yoshida authored
For V8ContextEnabled feature, we create and update function templates of some interfaces in some places. This test tests if the prepared templates for default contexts are set up correctly. Bug: 834642 Change-Id: I387cc5c8f451fb8b81c59618a95aa47701ea0196 Reviewed-on: https://chromium-review.googlesource.com/1038925Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#555330}
-
Xiaocheng Hu authored
InlineBoxTraversal encapsulates some common traversal logic for bidi adjustment. This patch applies the class in LayoutText, replacing traversal code by calling InlineBoxTraversal's member functions, to reduce code duplication. Bug: 811502 Change-Id: I027e7e69f225873a89a20a193e7591465b29ad71 Reviewed-on: https://chromium-review.googlesource.com/1036462 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#555329}
-
Greg Thompson authored
BUG=837562 Change-Id: I0f78d94137ad8875e18fe4ce44e6b03ddc9bcb97 Reviewed-on: https://chromium-review.googlesource.com/1033738Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#555328}
-
Gauthier Ambard authored
This CL fixes the side swipe animation when the flag to make BrowserContainer fullscreen is enabled. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3b5a70135e91dd630e9c9052957347f790cafe16 Reviewed-on: https://chromium-review.googlesource.com/1032435Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#555327}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa6b64e1..6bb4189a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5e7ccaafa356540368753fc0267e48421246ba1a Reviewed-on: https://chromium-review.googlesource.com/1038910Reviewed-by:
-
Alan Cutter authored
This CL updates GetPageInfoAnchorView() to check visibility of the view hierarchy instead of just single view elements. In Linux/Windows fullscreen the ToolbarView is not visible while its children's visibility are still set to true so it's not enough to only check their visibility. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=337120&signed_aid=2W8EBRpI7WsrXmCDI0TVEA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=337121&signed_aid=aiaQuXt1dB53LM_ahvCL7Q==&inline=1 Bug: 838079 Change-Id: I223f5f78f61e80f7873347ff77ed21949b405949 Reviewed-on: https://chromium-review.googlesource.com/1036964 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555325}
-
Ramin Halavati authored
Network traffic annotation's FYI bot time out is increased to 4hrs to comply with the unfiltered tests. Bug: 690323 Change-Id: I1d96b693e062d702ba0a018c3512f380f10d9ecd TBR: dpranke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1039184Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#555324}
-
Matt Giuca authored
Introduced in r555244. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835950, 838793 Change-Id: I32f4aaf40b36884a5f9972d8921b76a070515967 Tbr: crouleau@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1039210Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#555323}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c86c5c0144b8..ef4142a9bc5f $ git log c86c5c014..ef4142a9b --date=short --no-merges --format='%ad %ae %s' 2018-05-01 khushalsagar fonts: Bandaid fix for desc mismatch in SkRemoteGlyphCache. 2018-05-01 angle-skia-autoroll Roll third_party/externals/angle2/ ad3aaeba3..57d9cbb67 (4 commits) Created with: roll-dep src/third_party/skia BUG=chromium:831354 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I2eaec4a83a8936edf0b814259456d4a1846f6008 Reviewed-on: https://chromium-review.googlesource.com/1038822Reviewed-by:
-
Matt Giuca authored
This reverts commit 92d45797. Reason for revert: Suspect cause of crash in WebKit layout tests on Windows (https://crbug.com/838782). Original change's description: > Media Controls: remove window event listener and listen to event on popup. > > This is moving the logic to hide the popups to the popup element class. > It will hide when the popup no longer has focus, when the window is > resized or scrolled. It slightly improves memory usage by only creating > the event listener object on demand. > > Bug: 833461 > Change-Id: I979f0882108fcd89fdf84b2612437209b080eb95 > Reviewed-on: https://chromium-review.googlesource.com/1023345 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555083} TBR=mlamouri@chromium.org,beccahughes@chromium.org Change-Id: Ic0bdd6a3422447424c4c00037e57005c9ba1de05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833461, 838782 Reviewed-on: https://chromium-review.googlesource.com/1039116Reviewed-by:
-
Koji Ishii authored
This patch stops removing trailing collapsible spaces at the end of inline formatting contexts. CSS defines to remove trailing collapsible spaces for each line. Before this patch, CollectInlines() removes them before line break as an micro-optimization because the end of an inline formatting context is also the end of lines. It turned out that this may prevent the re-use of NGInlineItem (CL:986982) in some common cases, and since the re-use is a great performance win, this micro-optimization turned out to harmful. Note, there are 19 tests that have 1px differences, probably because we don't reshape when removing trailing spaces. Since we already do this in HandleTrailingSpaces, rebaseline in this patch but I'll work in following patches. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iff30d0cb05b4b80950c0d6da10ce8f6eff23a61a Reviewed-on: https://chromium-review.googlesource.com/1022191 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#555320}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I99b9e618704b04e55d15115f40787193411d69cc Reviewed-on: https://chromium-review.googlesource.com/1038894Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555319}
-
Khushal authored
Add an instance of SoftwareImageDecodeCache for image decoding for non-accelerated canvas. This can potentially be used for any other use-case requiring image decoding on the main thread in blink. R=chrishtr@chromium.org Bug: 791828 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1df793ea00e8e5df26878d6ca8e0769a9ca0c500 Reviewed-on: https://chromium-review.googlesource.com/858570 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#555318}
-
Zhiling Huang authored
Bug: 838692 Change-Id: Ie253322a5d3b76ad63e8d5d6819fdd5ef8db887f Reviewed-on: https://chromium-review.googlesource.com/1038645 Commit-Queue: Zhiling Huang <hzl@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#555317}
-
Eugene But authored
Old test was loading http://mock/bad and because this URL did not exist the load was failing because of DNS resolution error. New test uses EmbeddedTestServer, which closes the socket to simulate ERR_INTERNET_DISCONNECTED error. Bug: 694662 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaca523e8153a2c4cca0e1f174652ed48f22cabd3 Reviewed-on: https://chromium-review.googlesource.com/1035610 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555316}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e896f838. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" 7dea9b2c "[css-grid] Subtract scrollbar in ComputeReplacedLogicalHeightUsing()" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16662 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-ui TBR=lukebjerring No-Export: true Change-Id: I5580c18f03b90fa23d84d3f210b0d62e775e7e17 Reviewed-on: https://chromium-review.googlesource.com/1038909 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555315}
-
Morten Stenshorne authored
A float always needs to be positioned by its block parent, so passing them around to children, parents or siblings really shouldn't be necessary (and it *was* somewhat confusing, since nobody but the direct float parent is allowed to touch them anyway, apart from placing them into temporary exclusion spaces). The main reason for passing them around like that, was for other blocks to determine, based on the list of floats being empty or not, the need for relayout once the BFC offset was resolved. Instead, confine the list of unpositioned floats to the block parent of those floats, and introduce the concept of adjoining float types (none, left, right, both). Adjoining floats occur when the BFC offset is unknown, meaning that their position may be affected by the current layout algorithm. Adjoining float types will now be the thing that's both input to and output from the layout algorithms. Having something other than "none" means that a block's BFC offset is unknown, but that doesn't automatically mean that we have to abort and re-layout if the BFC offset gets resolved. If the "floats BFC offset" is known, for instance, those adjoining floats may be positioned right away. Still we need to know about them (positioned or not), to get clearance correct. We're going to need to treat adjoining floats specially when applying clearance. Will deal with that in a later CL. For now, we just keep track of the adjoining float types, so that the clearance machinery can tell that there are floats there that may not yet be positioned. That used to be taken care of the list of unpositioned floats, but, as previously stated, adjoining floats are special, and we need to know about them, whether they are positioned or not. This is a preparatory CL for that. Each time we add an unpositioned float, we need to update the types of adjoining floats, so that these can be returned from the algorithm if necessary. Whether they end up being positioned right away or not isn't relevant. Adjoining is adjoining. Note that we don't have to #include the header file for unpositioned floats as much as before now, but I'll clean that up in a follow-up CL, because it turned out that there were quite a few translation units that got stuff for free via that header file, instead of explicitly including what they need. Had to rewrite how we deal with floats in HandleNewFormattingContext() and LayoutNewFormattingContext(), since those depended on a list of all preceding unpositioned floats to place them into a temporary exclusion space, to figure out whether to let the child's margin be adjoining with the current margin strut or not. Instead of using a temporary exclusion space, we now position floats via the regular mechanisms, and initially assume that the child's margin is going to be adjoining. This means that we have to abort and roll back if there are preceding unpositioned floats. This is no different from how we lay out regular blocks, though. What *is* different is that if it turns out that the child's margin has to be separated from the strut, we'll have to abort and roll back once *again* (but only once). The algorithms now need to keep track of whether they need to abort if the BFC offset *changes*, rather than if it is *resolved*. We only allow the offset to resolve and optionally change *once* afterwards, though. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie527d659213049f180ebedc764e1d7f4926a5876 Reviewed-on: https://chromium-review.googlesource.com/1030191 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Noel Gordon authored
Auto formatting and line length limits can produce the unreadable. In a business where code is read way more than it is writ, making a reader's eye dance left, right, and back again is tiresome and unnecessary. Re-write this code for humans: it is both shorter and clearer. Bug: 833834 Change-Id: I64535fdf6b4cccbc02029d594543d6719fe3c79f Reviewed-on: https://chromium-review.googlesource.com/1039164Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555313}
-
