- 11 Nov, 2020 40 commits
-
-
Antonio Gomes authored
EXO tags the associated wayland/ShellSurface as being of AppType::LACROS. void SetLacrosAppType(aura::Window* window) { window->SetProperty(aura::client::kAppType, static_cast<int>(ash::AppType::LACROS)); } BUG=1113900 R=jamescook@chromium.org Change-Id: Id83fb6d851009068b0e080515d27c1a5c9d3038e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533334 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#826535}
-
Rakina Zata Amni authored
When a page is in the back-forward cache, we still want to handle network requests and response body loading. To support this, we need to return an unfreezable task runner for GetTaskRunnerForBodyLoader. Bug: 1137682 Change-Id: I68cdd66fd9f5afa2638fb77435c4cd087e697a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525801 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#826534}
-
Jordan Taylor authored
This work is the first step in implementing upcoming spec change in: https://github.com/w3c/csswg-drafts/issues/4862 Converted AnimationTimeline::currentTime() to CSSNumberish Added AnimationTimeline::duration Bug: 1140602 Change-Id: I5c9b8b7130b91faae5f172493ba5f55d77b4bdd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476900 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#826533}
-
David Black authored
This feature flag allows previews of holding space items to be shown in the shelf tray. The user is able to enable/disable previews at runtime via context menu. This flag is exposed via chrome://flags and only has effect if the holding space feature is also enabled. Bug: 1142572 Change-Id: I5f93a0c1b2105a50434d30b3a615ebbf581cb41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533028 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826532}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfff133590c2..d3f0d0cc3810 2020-11-11 treehugger-gerrit@google.com Merge "perfetto-ui: Fix selecting incomplete slice" 2020-11-11 fmayer@google.com Be consistent about java_heap_dump parameters. 2020-11-11 taylori@google.com Merge "perfetto-ui: Fix CSP" 2020-11-11 lalitm@google.com Merge "tp: symbolize function field in workqueue events" 2020-11-11 treehugger-gerrit@google.com Merge "processor: Replace FilterInto in ExportJson() for smaller binary size" 2020-11-11 taylori@google.com Merge "Roll trace processor" 2020-11-11 primiano@google.com Merge "ipc: fix crash when OnEnableTracingResponse() is rejected" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5cdcb4ff93a8d69e451a9ae2f00f40298bd6eee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826531}
-
Robbie McElrath authored
This CL fixes a missing close() call in VariationsSeedLoader by using ScopedFD instead of a raw int when opening the seed file. Bug: 1138713 Change-Id: I547769c6385507cbe8fc876eb233dd0eacdb2d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519741Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#826530}
-
adoneria authored
This change propagates changes to waterfall created in crrev.com/c/2530896. Bug: 1136981 Change-Id: I69fb6fd9f8c980de9d7373ca02b6a41ce3bd7214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531065Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#826529}
-
Elad Alon authored
Bug: 1136942 Change-Id: Ia21e9ad0b35fb9e552137606801750fab35d6c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532560Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#826528}
-
Leonid Baraz authored
This change is to match Keystore definition. Also, assigned a symbolic name to it, so further changes (if any) will only need to touch one line in the code. Bug: b:170054326 Change-Id: I8e33afb9252fa17acb527453b0ecc3535ee72318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533175 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#826527}
-
Max Curran authored
trigger decision with TranslateMetricsLogger More details on trigger decision: https://docs.google.com/document/d/11TJqU_YyJoxJE1huEqKECBa_OZ05O4WESXMJ2WeT4F0/edit?usp=sharing Bug: 1114868 Change-Id: Ic04f56bf39771564ecab162e60d1677b068f166f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520316Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#826526}
-
Sergey Poromov authored
As Clipboard and OnScreen content restrictions are going to be launched in M88 (crbug/1105991, crbug/1105980), we are enabling the policy parsing by default. Bug: 1105991, 1105980 Change-Id: Ibe08f323e392101db320b0103f0a1b43822a84c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529095Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#826525}
-
Joel Hockey authored
In linux-chromeos, $HOME/Downloads rather than profile_path is used as the FilesApp MyFiles directory, and currently these files cannot be opened in a browser since they are not within the allowed paths. https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/file_manager/path_util.cc;l=247-249;drc=c2dbbeb2f40590e1696e6c853f9e814404be6471 Since linux-chromeos is a testing-only system, we can allow any paths to be accessed which is helpful for testing such as the current drag and drop work I am doing. Bug: 1144138 Change-Id: I34253192270c982bd54c0d1bba33bd81e3532042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531073Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#826524}
-
Nina Satragno authored
When tapping escape on an authenticator dialog with an "interesting" OnCancel() behaviour (i.e. not immediately terminating the request), the dialog is closed without calling OnCancel(). This can leave requests hanging in the background. This patch handles the press of the escape key on the dialog's contents to call OnCancel() on the model instead. Fixed: 1145724 Change-Id: I019c614cd0b40f7384944c56eab0afe45d76c8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530795 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#826523}
-
Nate Chapin authored
Bug: 1147612 Change-Id: If2ee105a33a04edca62b3777f93d963b04962d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523495 Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#826522}
-
Chris Sharp authored
Make this a required field for new main/bool policies. Since the item field isn't always copied over from main policies, also add a warning check that the policy descriptions describe the various cases. Add items to MediaRecommendationsEnabled and BlockThirdPartyCookies. BUG: 1139306 Change-Id: I2894cefa52437eddb51b75c58d320b878c8688ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522236Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#826521}
-
Dave Tapuska authored
Move the implementation of this method into the base class. BUG=1097816 Change-Id: I87fefb34168331ea7225fb3a7a6e9b4040e804b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533029Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#826520}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ib22b024d196853341d9e218e7ec999a6115a8386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826519}
-
Tim Song authored
BUG=1111153 Change-Id: I01bc854f83660cfb9237174673bc20a0f1ee54a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531813Reviewed-by:
Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#826518}
-
Nate Chapin authored
Change-Id: I37961a93296714a9f378b6b963105673deb97dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528166 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#826517}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a4b8f58ae03..be42c94ff748 2020-11-11 yiorsi@gmail.com Fix CSS custom properties are blocked by underline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147750 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icce07c583d26997a942ddcfe4605957adc07105a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826516}
-
David Bienvenu authored
Bug: 1007805 Change-Id: I8e0136335d880ce1897d75e70a81dddd2e016d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522397Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826515}
-
Nate Chapin authored
Change-Id: Ic9adc4348e51e831b6a4eba184a7438512774546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527776 Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#826514}
-
Jarryd authored
This change cleans up the flag, which expired in M85. Bug: 1129119 Change-Id: I964e7b2a44fc7c7386cbf589d83e6b78520b8e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446551Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826513}
-
Luke Sorenson authored
Bug: 1147978 Test: Not necessary. Only updating two constants. Change-Id: Id2717ec8e56a0b6721798a0de1bfb9a799d4e172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533142Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#826512}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I35c97e9ef668442cd4a8c1bffdaabd4d527e8c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533673Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826511}
-
Alex Turner authored
chrome-ads-uma@google.com is fixed to the correct group (chrome-ads-histograms@google.com) for SubresourceFilter.* histogram owners. Change-Id: Ibc044a226e264e6905ca88a470d23f710dc8f44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529709 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#826510}
-
Sean Gilhuly authored
ColorSpace::Contains() can be called a few times per frame for tile operations. The result of the call is deterministic, and called consistently on a small set of color spaces in gfx::DisplayColorSpaces, so store the results in a small MRUCache. Bug: 1073962 Change-Id: I61e2a8ff34291b686ed79ae4c301adb1c0792b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504051Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#826509}
-
Lloyd Pique authored
Set up an overlay manager that allows an exo::ShellSurface to become an overlay on top of a different window. The initial use case is for a Android Play Billing popup to overlay a Trusted Web App, when the app invokes a Payments API. The shell surface must use the revised aura_shell_surface::set_client_surface_str_id request to set a valid overlay token. The code to have the payment component hook into the overlay manager is in a followup CL. Bug: b:172592701 Test: Test Payment app shows the Play Store overlay Change-Id: I7929b0a28ac4f4dd6e069632ada3419062f1b794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519929 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Auto-Submit: Lloyd Pique <lpique@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#826508}
-
Henrique Nakashima authored
Metadata was added recently, but older graphs do not contain it. Avoid errors when reading these graphs. Change-Id: Ib5c6eb01d53a1e67a0fb5b7451875e891fe3184d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522240Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#826507}
-
Bailey Berro authored
This change adds the average CPU Temperature to the CpuUsage struct. Bug: 1128204 Change-Id: I62e335f163df94b0d53027692f3ae4960e9c48f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527825 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826506}
-
Eric Willigers authored
The ExecuteScriptAndExtractBool calls in HasMinimalUiButtons tests were sometimes failing. We now wait for navigation, and close app windows when they are no longer required. Bug: 1120504 Change-Id: Ifd869e6ec9e480edd9e85fbd9116b237e38e70e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532480 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#826505}
-
Darin Fisher authored
Introduces web_page_metadata.mojom that defines mojom::WebPageMetadata as the subset of fields from WebApplicationInfo that the renderer currently extracts from a web page and sends to the browser. WebApplicationInfo is moved into chrome/browser and taught how to be initialized from a mojom::WebPageMetadata. Bug: 993189 Change-Id: Ieac278c9a99d5f4c962a52d9bd4455ab35d00c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522125 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826504}
-
Andre Le authored
Add tooltip texts for signal icon, battery icon and continue browsing chips. Bug: 1106937,1126208 Change-Id: I2dfd71a84b735c311825dc74c5713ca7457bc0f7 Fixed: 1147083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527585Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#826503}
-
Ahmed Fakhry authored
Initial implementation of the recording service, which currently supports capturing fullscreen, and region capture. Window capture doesn't capture any video frames at the moment (will be handled in later CLs). Audio of the default audio input source is captured. BUG=1126586 TEST=Manually, Added browser_tests --gtest_filter=RecordingService* Change-Id: I0dfdd6acc2b46b85e75355824b2d3915655d4bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404145 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#826502}
-
Evan Stade authored
Bug: 1146058 Change-Id: I1a1edd86cc077816f233fc9a9abde2399800009f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526734 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826501}
-
Majid Valipour authored
Previously when using the Auto backend no user prompt would be shown. This patch changes this logic to treat the Auto backend the same as the verification backend. Note that the Auto backend may use either of the GMS APIs which may or may not require the user prompt. A follow up patch [1] changes the prompt decision to be made per otp request and based on the actual API used instead of once based on the switch value. However treating the Auto similar to the Verification makes sense as a quick fix since Auto is most likely to use the Verification method anyway for the vast majority of cases. Worst case if the other backend is used we show two prompts (one native, one chrome) which is still better than no prompt. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2530272 Bug: 1141024 Change-Id: I64ada09187281f99fe97770d7cfcaca8f5867adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532874 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#826500}
-
Maggie Chen authored
This is to notify DirectCompositionSurfaceWin if there are display metrics change(s) such as desktop resolution on the monitor(s). DirectCompositionSurfaceWin needs the current monitor size. Bug: 1027046 Change-Id: I0df02aa4a566723468219d9333b5f26379688700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523903Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826499}
-
Bartek Nowierski authored
Continuation of crrev.com/c/2517220 For Android, machines don't have CPU dimensions, so specifying arm64 results in matching nothing. For Windows, machines only have x86-64 dimension. Use those machines even for x86 case, because the binary built for x86 can be run on x64. Bug: 1121427 Change-Id: I0c3d86804903fba2ebca02e22eecba536d48eca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532018Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826498}
-
Mark Mentovai authored
dec31e17 (https://chromium-review.googlesource.com/c/2523446) was supposed to make memory allocations use MAP_JIT on macOS ≥ 10.14 whenever the hardened runtime wasn’t active, but a serious goof inverted the logic, causing MAP_JIT to be used whenever the hardened runtime was active. This is only feasible for processes that have the JIT entitlement, and not all do. Attempts to allocate memory in this way in affected processes would fail, which would appear as an out-of-memory condition, which isn’t quite accurate, but it’s definitely a memory allocation problem. Bug: 1144200, 1147831 Change-Id: I9c8f925ec7b311b2d655dd3a5f367fd01e80d7e2 CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532728 Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#826497}
-
Clark DuVall authored
Change-Id: I26dbdb4de0232900aac095fc22c67beb7b7bdd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532868Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826496}
-