- 18 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1f7c370eb0d..dda9c164cb3b 2020-11-17 fmayer@google.com Merge "Do not wrap unwindstack::FrameData." 2020-11-17 treehugger-gerrit@google.com Merge "Skip reading peer credentials from IPC clients" 2020-11-17 fmayer@google.com Merge "Allow to delay free in mulithreaded_alloc." 2020-11-17 midaschieh@google.com Merge "Add dpu and g2d ftrace event in gfx category" 2020-11-16 rsavitski@google.com Merge changes Ie70f0117,I05ef7862,I80c51246 2020-11-16 fmayer@google.com Revert "Update NDK to r21." 2020-11-16 fmayer@google.com Update NDK to r21. 2020-11-16 primiano@google.com Merge "Reland "Add version consistently in all build configs and UI"" 2020-11-16 treehugger-gerrit@google.com Merge "metrics: Force modified_rail_slices to be empty if not valid" 2020-11-16 treehugger-gerrit@google.com Merge "metrics: Refactor RAIL Mode power queries" 2020-11-13 ccross@android.com Revert "Add version consistently in all build configs and UI" 2020-11-13 ccross@android.com Revert "bazel: fix for google3 import" 2020-11-13 primiano@google.com bazel: fix for google3 import 2020-11-13 rsavitski@google.com Merge "PRESUBMIT.py: update arg name to avoid warnings on newer depot_tools" 2020-11-13 primiano@google.com Merge "Add version consistently in all build configs and UI" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3fec7490c6cc5084352aeba23586d2dab2598e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828677}
-
Nohemi Fernandez authored
Bug: 1043080 Change-Id: I7bd96ba2327ce5bc292990cf863f968c4029a4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538214Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#828676}
-
Sean Harrison authored
Gettings icons is taking longer than expected, so pushing back flag expiration milestone, also removes ex-intern from flag owners. Bug: 1113642 Change-Id: I9cab96d6119c7ac33a18dfc46bd8c81911bd33ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545307 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#828675}
-
Christoph Schwering authored
This CL launches the AutofillSkipFillingFieldsWithChangedValues experiment that fixes a common cause of Autofill overriding user-filled fields. Bug: 966873, 949094, 1075533, 1150167, 1121552 Change-Id: I14cd67a33ad15a32b7be1e88105c83f72ed2007e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545305Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#828674}
-
Avi Drissman authored
The completion callback for Rosetta installation has an NSError* parameter. Fixed: 1150273 Change-Id: I2e07537d1973005dd2322748a57b24bad43df973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546474 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#828673}
-
Antonio Gomes authored
The class will be used by both ash/chrome and lacros/chrome builds. For more details, see [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org TBR=jamescook@chromium.org Change-Id: I0f2ba56f07042cc06fb8ba5651f008d393def9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545210 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#828672}
-
Ioana Pandele authored
[Sheriff] Mark http/tests/security/inactive-document-with-empty-security-origin.html as flaky with timeout This test has been recently marked as slow, but it still times out. See https://analysis.chromium.org/p/chromium/flake-portal/flakes?flake_filter=test%3A%3Ahttp%2Ftests%2Fsecurity%2Finactive-document-with-empty-security-origin.html and https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20758. TBR=masonfreed@chromium.org Bug: 1095379 Change-Id: I955a51d0db9e265f00016a164e5d41009d75b5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546009Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#828671}
-
Roman Sorokin authored
Bug: 1104861 Change-Id: Ib4932966a31cfb7ccd2fa4301a6001c46406428d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537673Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828670}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4892cc595ba..99c5551368ff 2020-11-18 bmeurer@chromium.org [sdk][bindings] Introduce DebuggerModel._expandCallFramesCallback. 2020-11-18 szuend@chromium.org [ts] TypeScript-ify ui/UIUtils part 1 2020-11-18 petermarshall@chromium.org [surveys] Make survey link accessible If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1083146,chromium:1112738,chromium:1126943,chromium:1150029 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia7d45d01a2e76272d4bbed1b3451f23f21606304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546637Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6823afb28ceb..145e22d4d49f 2020-11-18 tsepez@chromium.org Remove CFXJSE_Value from CFXJSE_FormCalcContext::DotAccessorCommon(). 2020-11-17 tsepez@chromium.org Remove CFXJSE_Value from CFXJSE_FormCalcContext::oneOf() 2020-11-17 vmiklos@collabora.co.uk Add FPDFAnnot_GetInkListPath() API 2020-11-17 thakis@chromium.org Stop setting mac_xcode_version in DEPS 2020-11-17 nigi@chromium.org Roll base/trace_event/common/ 23ef5333a..eb94f1c7a (5 commits) 2020-11-17 nigi@chromium.org Roll v8/ e1e716fb8..e05d24f98 (834 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147839 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I21f8ae7d12fdf645e617ebb44517b2aabffedf24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546780Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a0758a1aef12..55f251dffe05 2020-11-18 cwallez@chromium.org RefBase: remove implicit conversion to bool. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I0015294271a10f4342dae9cb5ee28da8f4bbc300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545992Reviewed-by:
-
Omar Morsi authored
Bug: None Change-Id: Ic88c98f0ebd887644ff451004a8e9506850fb495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534892Reviewed-by:
Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828666}
-
Jan Krcal authored
This CL changes the logic to load the startup profile whenever the profile picker should be loaded. It instead loads the guest profile to indicate the picker should be open. This speeds up showing the picker when the last profile used is heavy to load. The CL also unifies the logic to decide whether to show the new picker (or the old user manager) into one function, GetStartupProfile(). There is one behavioral difference: the new code directly opens browser windows if the user had multiple profiles open last time. This is desired because having multiple profiles open simultaneously the last time is a strong signal the user wants to continue this way. Note that having multiple profiles open the last time happens only in limited situations, e.g. via chrome://restart or via session restore (when logging out / switching off the machine with multiple profiles' windows open). Bug: 1150330 Change-Id: Iae9744f44bc242e9aaaf8f287cc29e1089326786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532460 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#828665}
-
Alice Wang authored
This CL adds a test for the method AccountPickerDelegate#isIncognitoModeEnabled(). Bug: 1149866 Change-Id: I81518ee322d7942ff2482e85683c04a2acf216e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544943Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828664}
-
Fergus Dall authored
CL:2374267 renames most crostini tests, so update the list of disabled tests to match. This CL retains both old and new versions to avoid breaking things while waiting for an LKGM uprev. Bug: 1128743 Change-Id: I168bfce067611be7ae8ac7b081c1cb347ff8d05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462964 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828663}
-
Omar Morsi authored
This cl records the number of times the arc usage flags update started as well as the number of times it succeeded and failed. Bug: 1140105 Change-Id: I01acabb9d34b3c643db5d63773ad268c9339db51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541522Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828662}
-
Roman Sorokin authored
The function is not called. Bug: 1100910 Change-Id: Ib014f5bb88e542c0e5663c3fd01b34a7e34edddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546761 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#828661}
-
Kuo Jen Wei authored
To preload image assets used by css, this CL add new BUILD.gn target generating images into a js file under '/js/preload_images.js'. When launching camera app, wait until images are loaded to show camera view. Bug: b/172342439 Test: ./cca deploy <DUT> Test: pass closure compiler Test: Manually on DUT Change-Id: I9ee8f73d0eed56c0002180259951235b6d0e642e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531439 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#828660}
-
Xiaocheng Hu authored
The class will become more complicated with counter text generation algorithm included. Hence, this patch moves it into its own files for a better file structure. Bug: 687225 Change-Id: Id6bc85929bbf182c74e9eb9ceb85155b5e07fb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545488 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#828659}
-
Swapnil authored
There are several browsertest related to browsing history and SSL error overriding policy. This CL splits these tests to new file. Bug: 1148745 Change-Id: I6d8eb679aa84289694cdcb534ebf836dbde4e7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544944Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#828658}
-
Jasmine Chen authored
Removes the DCHECK in CameraHalDispatcherImpl::RegisterClient. This is failing DCHECK because ArcCameraBridge would call RegisterClient on its own thread directly. Bug: b/173577612 Test: Build simplechrome Change-Id: I919a717765aef085b58552de5cf3f9dd167388d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546309 Commit-Queue: Jasmine Chen <lnishan@google.com> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Jasmine Chen <lnishan@google.com> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#828657}
-
Makoto Shimazu authored
The test sometimes fails due to timeout on Windows. This CL splits the test into two to mitigate the workload. Bug: 1002377, 1150000 Change-Id: I1cfb2198b304cc21e3aeb9dc00b4db66e7eeb4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546145 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828656}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aaee0317d442..c4892cc595ba 2020-11-18 szuend@chromium.org Properly export 'rangeOfWord' as a standalone function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I028ca61c4c89762c8291494d33c5b7c4cce2721b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545372Reviewed-by:
-
Alice Wang authored
This CL moves the incognito interstial instrumentation test to its own module. Bug: 1149867 Change-Id: If4b8bc80580c925d015e7ca896ce7eb070e74fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544683 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#828654}
-
Omar Morsi authored
Bug: 1129764 Change-Id: I72d681f60e666b8c53b1bc5b3e03737b0abb1891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544725Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#828653}
-
Roman Sorokin authored
Use ShowGaiaDialog instead. Bug: none Change-Id: I645e5b1d1c013dc1597a4f5291f10429a834c147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536633 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Antonio Sartori authored
X-Frame-Options violations are logged via a console message in the parent frame. To avoid leaking sensitive data to the parent frame, let's report as "blocked url" just the origin of the blocked frame's url, as we are already doing for the frame-ancestors CSP directive. Bug: 1146651 Change-Id: If5e5ac62f7e44e714b109e6adc389f11999e0f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534851 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828651}
-
Asami Doi authored
This CL adds a test case to the existing WPT to check if clients.claim() for a blob URL worker works well. Currently, the test fails when the PlzDedicatedWorker feature is enabled. It will be fixed in another CL. Bug: 1017034 Change-Id: I39adf7364f6f60ea50efa28b96b27b7e67bc2b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531805Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828650}
-
Robbie McElrath authored
This CL removes the fake FragmentActivity from SiteSettingsFragmentImpl and MediaRouteDialogFragmentImpl, replacing them with a Context that hosts the fragments instead. This is possible now that we've landed the bytecode rewriting that changes the return type of Fragment.getActivity() from FragmentActivity to Activity. Bug: 1123216 Change-Id: I98c2c07eb348d6833ca2e5d976110f7f29b5359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523751 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#828649}
-
Roman Sorokin authored
Instead of triggerring Gaia IME on the Gaia async load - which might happen even if the dialog is hidden. Also fixed ExistingUserControllerAuthFailureTest.CryptohomeMissing test which had a wrong expectations. Should show Gaia reauth page for the missing cryptohome user. Bug: 1140239 Fixed: 1150142 Change-Id: Idc722bfbd4f5b6418f6f2751b32e4bd9cc8ebf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536872Reviewed-by:
-
Kim-Anh Tran authored
Bug: chromium:1110202 Change-Id: Iae6728a93d012704838306ff6824a41b399e24ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545306Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828647}
-
Peter Boström authored
Adds a missing checkbox->SetChecked() call to set the initial state on the views side. Bug: 1150027 Change-Id: I2fcf4d26ccd5358efbd7247c9533877da6643853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546188 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828646}
-
Dan McArdle authored
Currently, DnsHTTPAttempt does not set the accept-encoding header. URLRequestHttpJob::AddExtraHeaders() has been stepping in, typically choosing "gzip, deflate, br". If the DoH provider honored this request for compression, it would effectively strip padding from the DNS response, which is a privacy leak. To be clear, I have not observed any DoH providers compressing their response. It just seems prudent not to request compression that we do not want. Bug: 1051615 Change-Id: I0cad558f76298b7ed58de70b70b1954cd42b88f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546476Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#828645}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6e353680e14310488251bd90249579e2d1a2d81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546263Reviewed-by:
-
Robbie McElrath authored
This CL updates the bytecode modifications we perform on Fragment.getActivity() to have it call ContextUtils.activityFromContext( getContext()), and modifies compile_java.py to detect compilation errors related to this change and print a message pointing you to documentation about the bytecode modifications. A compilation error will now print: ../...../PasswordEntryEditor.java:144: error: cannot find symbol getActivity().getSupportFragmentManager(), ^ symbol: method getSupportFragmentManager() location: class Activity Expecting a FragmentActivity? See docs/.......md Bug: 1123216 Change-Id: I04016e30fba46c7d5c592e9ab2c5e5fa4c4cfde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508352 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828643}
-
Matthias Körber authored
Change-Id: I9b1467d5f34d9381c8f944009b8f7511063fa30e Bug: 1150004, 1148749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544706 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#828642}
-
Hirokazu Honda authored
Original V4L2VideoEncodeAccelerator checks that the natural size of every VideoFrame with the dimension to be encoded. They must be the same in single cast case, but can be different in multicast case. The correct check is to compare it with the natural size of the first VideoFrame. In other words, the natural_size must be unchanged during encoding in the same VideoEncodeAccelerator instance. Bug: b:172223525 Test: meet.google.com on trogdor Change-Id: I3c21782b86cddaa788d4daf785793f73ec49db9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541942Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#828641}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605657601-ef8205b17022e19a0e2738465ae8904490a43974.profdata to chrome-linux-master-1605679120-9f3476b66a4fad3e32e51dc995f45ad61750f20a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib50c20fbe04914b339a8de85585ddab0f6263066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546640Reviewed-by:
-
Maggie Cai authored
This CL updates the intent picker bubble view code to close and clear the existing intent picker bubble if the code trying to show another intent picker bubble. During testing, I found out that showing a new intent picker bubble when there is already a bubble showing will crash the browser. And there are suspected crash report that possibly relate to this. BUG=1148517, 853604 Change-Id: Ibf720342acf73602608278ca48f71435a9e61e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539808 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Jaeyong Bae authored
This patch enables applying style to pseudo-elements when a property is defined on ::first-line. Currently, the properties on the ::after and ::before pseudo-elements are not applied on the first-line. So, we support kPseudoIdFirstLineInherited for the ::before/::after elements. Bug: 862423, 892983 Change-Id: I9474eece66921b8073091459cc254d5d1e27a9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517339Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
