- 27 Aug, 2020 40 commits
-
-
Mike Wasserman authored
Only fire screenschange for frames with the Window Placement permission. Fire isMultiScreen changes for all visible frames (e.g. 1 <-> 2 screens) (obviates pollling isMultiScreen(), which is exposed without permission) Add a TODO to postpone events instead of dropping, and refine criteria. Update test expectations and add TODO to test events with permission. Bug: 1080690, 1109989 Test: event only fires for permissioned sites or isMultiScreen changes. Change-Id: I5b46bd6944bc4b923b6357e9b370c80ce14a09b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375671Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#802356}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c08c71bedfbb..7d98e228f836 2020-08-27 glenrob@chromium.org Allow 'main' as a local main branch name. 2020-08-27 sweilun@chromium.org Also Pretty print the split histogram_suffixes_list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1121852 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ifb50a0b64aa1c8594a4ad9755baed24ec08fae4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802355}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1f580a97e55f..3cdde9771d8f 2020-08-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 824b4e64..55f2a783 (802144:802244) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8bee58ed2e937bf4303176b1773a4fd8bf987059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380336Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
- Add news strings for eSim UI - Adds new UI elements to esim_flow_ui.html - Current UI: https://imgur.com/zdfcmbx - UI spec https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g921c12802d_0_1 Bug: 1093185 Change-Id: Iadf0b8a411d93d59c1782d103f34c96442092481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351392 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#802353}
-
Jonathan Backer authored
There are crash reports and performance issues that remain uninvestigated. Disable for now until we can fix that. Bug: 1122650 Change-Id: I09fb05de39b5e3b5e3c26a8e0dbb90cbcffea4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380374 Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#802352}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cc61e5a98324..ed2e4739280f 2020-08-27 treehugger-gerrit@google.com Merge "Fix missing include." 2020-08-27 oksamyt@google.com Merge "[trace processor] Add core type distribution to WV power metric" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0f5260bda2fb427909033989f1df4156d5dcef4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380373Reviewed-by:
-
Xianzhu Wang authored
This is because this blink runtime feature doesn't work by itself. It's controlled by the corresponding Chromium feature which needs to be enabled to make the whole feature work. We'll continue to use the virtual test suites to test the feature. Bug: 1121839 Change-Id: I902cf87e8fba8e1123dd4a6f5e6fe8c7f821f524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378631Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802350}
-
Rouslan Solomakhin authored
Before this patch, if WebAuthn returned an error when creating an assertion, Web Payment called into ShowErrorMessage(), which called into OnCancel(), which rejected the PaymentRequest.show() promise, but kept the secure payment confirmation UI open. This patch makes sure that the dialog is closed in OnCancel(). After this patch, if WebAuthn returns an error, then the secure payment confirmation UI is closed. Bug: 1122696 Change-Id: I99fae1d7b0b903338fca8cd03ecf57646dd78699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380550 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#802349}
-
Sebastien Marchand authored
This ensures that child processes don't die before flushing their profile data to disk. This is supposed to happen automatically at shutdown but it doesn't always have a chance to complete (probably because we tend to fast kill processes). This affects mostly the utility processes, and as they end up writing their data into the same file as the renderer they can sometime end up corrupting these files and make us lose some precious profiling data. This only affects profile instrumented builds (PGO profiling builds and coverage builds). Bug: 1119887 Change-Id: Ib50e876e7637a670ad05982c5ff03a898dc84ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378272Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#802348}
-
Torne (Richard Coles) authored
Some apps appear to pass null for one or more of the header names/values in WebView.loadUrl(url, extra_headers). Check for null before trying to validate the header format as Matcher doesn't permit null arguments. Fixed: 1122574 Bug: 1108405, 1105745 Change-Id: Ib2675efa78266d97b5e2c5c63b4b7f6182e089d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380269 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#802347}
-
Dave Tapuska authored
The "prefer compositing to LCD text" moves into the callback notification where other screen properties adjust the settings. This is ok because after the screen bounds are updating a Resize of the Widget will occur. BUG=1097816 Change-Id: I9b27af51386cb85ab8f0ecc87f60cf5ad5dd7226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366669 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#802346}
-
Richard Knoll authored
This is a reland of fb578abb Original CL (in PS1) had a conflict with crrev.com/c/2375250. The fix is in PS2 of this CL which was to update the API of FileAttachment to use only the |file_path| as input. Original change's description: > [Nearby] Refactor NearbySharingService Send* methods > > Instead of SendText and SendFiles methods this now has one unified > SendAttachments methods to make it easier to handle Attachments coming > in from the UI. Also hooks it up through the DiscoveryManager all the > way to NearbySharingService. File URLs coming from the ShareSheet on > ChromeOS are converted to FileAttachments. > > Bug: 1085067 > Change-Id: I61ce93842920ffa303ee71f4373c237b113948bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378026 > Reviewed-by: Alex Chau <alexchau@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802242} Bug: 1085067 Change-Id: Ia0ecb446bf926ecf1f8a497cb0e50504f5eff899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379862Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802345}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598529464-36870a872fe98f9e50202a2a325506fd4bcc24c9.profdata to chrome-mac-master-1598550957-d21440687343c81b6a2048a74a0e183994baca81.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I5e2f34c02e0112b3cce135883194de748bfe78e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380379Reviewed-by:
-
Wez authored
There is no longer a need to use E1000 under x64, and Fuchsia defaults to virtio-net-pic for both architectures. Bug: fuchsia:59041 Change-Id: I817bc69e84e4b024db6b9e3d8ee8fabe2502a552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379718Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802343}
-
Ben Pastene authored
This: - Moves the dict-building bits of CmdExport() into a func called _ToJsonish(), which can be used for crbug.com/1117577. - Includes args_files in the dict that gets built. - Uses 'seperators=' arg in json.dumps() to avoid trailing whitespaces. Bug: 1117577 Change-Id: I7c6f501d75969b76cc0e684417befb41e1f40a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378759Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#802342}
-
Michael Crouse authored
The browser test times outs and causes flakes. There are 2 wait events that could cause timeouts: blocklist loaded and a histogram check. This CL uses the updated blocklist loaded provided by the delegate which which more clearly marks when the blocklist is loaded. This CL also shifts the tab closing later to remove potential race of the hint check logic with the tab closing. A future change will remove the tab closing logic that may improve this further. Bug: 1122603 Change-Id: I898096f3350c057a14661163a8b99ac04fedd299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380153Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#802341}
-
James Vecore authored
This namespace rewrite got missed in the move of nearby_share_page to be CrOS only. Change-Id: I394bbed07d9515f6c63f0468201168250e397ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380257 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
-
Alice Wang authored
This CL handles the account picker bottom sheet backpress - When account list is expanded, backpress leads to collapsed account list; - In other cases, backpress dismisses the bottom sheet. Bug: 1113653 Change-Id: I4d380cf7ae27b3da03a828960224efde72857f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374650Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#802339}
-
Joshua Pawlicki authored
It was accidentally added the default archive in https://chromium-review.googlesource.com/c/chromium/src/+/2374513 Bug: 1058102, 1122538 Fixed: 1122538 Change-Id: I18ba7213aa72800a234a29576c5163820890c2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380133 Commit-Queue: Michael Moss <mmoss@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#802338}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.8-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5f00d9f761a3f18cb997d3c0834bda3d9261c2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380202Reviewed-by:
-
Xianzhu Wang authored
Previously composited scrollbars were always placed above all descnedants if they were not reordered, causing the scrollbars to cover non-scrolling stacked descendants. Now place non-overlay scrollbar layers at the bottom of the child layers, which is the same as how we paint non-composited scrollbars in the background paint phase. Bug: 984167 Change-Id: I1cd9b0bcd1559ad0811bc83af8959b33b3739b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370716Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#802336}
-
Ana Salazar authored
Holding space keyed service now observes downloads. As new downloads are completed, they are added to the holding space model. Bug: 1111995 Change-Id: Id45b276a3ada06d94f7efd42bc35cf89cc3fe070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378648 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#802335}
-
Robbie McElrath authored
This CL replaces the PreferenceFragmentCompat and PreferenceDialogFragmentCompat classes in the AndroidX preference library with the version from master, which has a change needed for WebLayer. The preference library maintainers say they won't create a new release just for this fix, so to get it we'll have to pull it in ourselves. Bug: 1092986 Change-Id: I0e1c936f6372cb541cabfa29c2aea0d0ee7225fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253029 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#802334}
-
Jérôme Lebel authored
FirstRunTestCase.testTermsAndConditions doesn't close correctly FRE at the end of the test. This patch adds the right taps to close correctly the FRE at the end of FirstRunTestCase.testTermsAndConditions. Fixed: 1122680 Change-Id: I5ef93c30df91941c63eae7a5dcefc5e52d228a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379837 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802333}
-
Andrew Comminos authored
Adds basic tests for continuous and discrete pointer events being detected by isInputPending with same-origin and cross-origin frames. Note that these do not currently work with content_shell (see crbug.com/893480). Bug: 910421 Change-Id: I93a0b2f7c47d7444069b157dcc55f9f04856eba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236693Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#802332}
-
rbpotter authored
From https://chromium-review.googlesouce.com/c/chromium/src/+/2368821 by dpapad@ Adding these hooks will be used to run tests with the PDFViewerUpdate flag on or off in future CLs. Bug: 1120279 Change-Id: I2e85e156e71f4e95db8754e13ca9c0bb944a81e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380260 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802331}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.8-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I56a5c61478d3b6188f1743ae39c6386df4811ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380046Reviewed-by:
-
Alfonso Garza authored
Note that the icon disappearing while editing and a non-empty text is working as inteded from TableViewTextEditItem logic. https://drive.google.com/file/d/1DOpGNuQI2dTOmniSvUHvcYYpmtdOfESJ Bug: crbug.com/1121563 Change-Id: I5c659da440d1bb655a47cc6895318a7688def407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377417Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#802329}
-
Alex Gough authored
Change-Id: I235813405df5f0b8ea0f1bee97b826977ce11215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379416 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802328}
-
Michael Thiessen authored
native_java_unittests are going away, so these tests need to be migrated to javatests. Bug: 1103344 Change-Id: I1a987b6fbacd2464a9a3113282accdde1eb2e500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364699 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#802327}
-
Sammie Quon authored
First CL to allow chaining keyboard shortcuts. This CL adds chaining of keyboard shortcuts behind a feature flag. 1. With flag disabled, desk animations work as they do today 2. When jumping back and forth between the original start and end desk, animation works as expected. 3. When the animation involves a third or forth desk that was not the original start or end desk, the animation is funky (as expected as that part is not changed in this CL), but at animation end the correct target desk is set. Modifies RootWindowDeskSwitchAnimator to support storing screenshot layers and replacing animations. More will be added in the future to make 3. work. For example, while we take a new screenshot when a new desk is targeted, we do not yet stitch it onto the animation layer, nor do we try to realign the animation layer. Unit tests to be done in a follow up. Test: manual Bug: 1111445 Change-Id: I84f7e7559dfe1f19f1aded4754b1bea5a76820db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354798 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#802326}
-
Thomas Anderson authored
This reverts commit c332bdd0. Reason for revert: needed to fix linux-lacros-rel Original change's description: > Roll sysroots > > This is needed after [1] changed the libwayland-client symbols file. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2379674 > > R=msisov > > Change-Id: Iffada22847663b5a9ca3973d45f7a0a2c93fedd5 > Bug: 1116384 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380370 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#802266} TBR=thomasanderson@chromium.org,msisov@igalia.com Change-Id: Icd1f62117bab878a63af1e1fdb5670444394db0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380432Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#802325}
-
Tim Song authored
BUG=1115697 Change-Id: If6de4e180b482f58244125a7344f0c506d088219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351949Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#802324}
-
Haiyang Pan authored
This reverts commit 4d9450df. Reason for revert: Likely caused the test PartitionAllocTest.DumpMemoryStats failing consistently in android x86 builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1084 * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1992 Original change's description: > [PartitionAlloc] Use reciprocal multiplication to speed up GetSlotOffset > > Currently, the "get offset of a pointer within its allocated slot" > functionality, which is used extensively by several MiraclePtr > implementations, performs an expensive modulo operation. This commit > replaces it with a cheaper sequence of multiplications and bit shifts. > > Bug: 1092288 > Change-Id: I866689a79fff704b5f83fc07d8f28b3386ef644d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335443 > Commit-Queue: Sergei Glazunov <glazunov@google.com> > Reviewed-by: Benoit L <lizeb@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802194} TBR=haraken@chromium.org,lizeb@chromium.org,bartekn@chromium.org,glazunov@google.com Change-Id: Iaed8d78231201dd69a880e8a30028ddd64bead94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380107Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#802323}
-
Fredrik Söderqvist authored
Reduces the estimated size from ~9.28M to ~2.14M. Bug: 242216 Change-Id: Ibfa4ba9f9ecd57e97a0efffb553d153402abed84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379756 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#802322}
-
Andrew Grieve authored
This reverts commit 69a6e031. Reason for revert: Producing bad dex (crbug.com/1122436) Original change's description: > Android: Enable vertical class merging in R8 > > Bug: 1040534 > Change-Id: Ic9873612462612e510b91d713c24c046e017cafb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368510 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801359} TBR=agrieve@chromium.org,smaier@chromium.org Bug: 1040534, 1122436 Change-Id: Ib4e204210ddcb0c41cb5ba9cdedca69036064fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380081Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11944f7122cf..8e6246dafe61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I59cb325cb42f920331435941152f097c62cf2886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380190Reviewed-by:
-
Scott Little authored
This reverts commit f1d35ca2. Reason for revert: Looks like this broke the linux-lacros-rel bot: https://ci.chromium.org/p/chromium/builders/try/linux-lacros-rel?limit=200 Original change's description: > linux sysroot: fix libwayland-client-symbols file. > > I initially generated it by myself and made a huge mistake by > setting base version to a single version. However, some symbols > only appeared after certain version. Thus, fix that problem by > copying and using the symbols file from wayland packages > in https://git.launchpad.net/ubuntu/+source/wayland. > > Bug: 1116384 > Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674 > Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802226} TBR=thomasanderson@chromium.org,msisov@igalia.com Change-Id: Ia285ce4239ba8e9841476fd5dc890252a713f8fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380105Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802319}
-
Liquan (Max) Gu authored
Reason for revert: The tests were disabled on Marshmallow because they were caused by crbug.com/1094008. Now that the root issue has been fixed, I am reenabling the tests. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2376465 Bug: 1102320 Change-Id: I687d099b28815518348650a3a24cb19e3b511acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380091Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#802318}
-
Austin Eng authored
Currently, this callback is processed entirely on the client, so it doesn't require a flush. It will be updated to be server-side for consistent callback ordering. In order to ensure the server receives the callback in finite time, we force a flush after the command is sent. Bug: dawn:516 Change-Id: Ibfa64b142331663e818c1142021ec2db1eeb9f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380026Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#802317}
-
