GitLab

This change widens the current suppression rule for bug 47949 and adds a new rule for it.

TBR=timurrrr,jhawkins
BUG=47949
TEST=make the "Webkit Mac (valgrind)" bot green.

Review URL: http://codereview.chromium.org/8564025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8136027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110056 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of http://codereview.chromium.org/8351048/ with minor changes
to fix the compilation errors on the shared builders.

BUG=102446
TEST=See bug description.

Review URL: http://codereview.chromium.org/8528053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104265
TBR=jeremya@chromium.org

Review URL: http://codereview.chromium.org/8528055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110054 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=none
TEST=Starting to drag a tile on NTP4 works when bubble is showing (and hides the
bubble without issue).


Review URL: http://codereview.chromium.org/8565014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8538002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8527018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82857
TEST=manual

Review URL: http://codereview.chromium.org/8526017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8463009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110049 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Remove unneeded forward declarations from chrome/browser/ui/gtk and chrome/browser/ui/cocoa.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8536004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110047 0039d316-1c4b-4281-b951-d872f2087c98

Task Manager:  Right click on the task manager list box when no item is selected should display column selection menu. But when any item is selected, the table context menu is displayed.

BUG=103649
TEST=None


Review URL: http://codereview.chromium.org/8510045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110046 0039d316-1c4b-4281-b951-d872f2087c98

This patch is 1 of 3 splitted patches made from http://codereview.chromium.org/8386031
cros_disks_client.cc is made by mixing and refactoring chromeos_mount.cc of libcros and chrome/browser/chromeos/cros/mount_library.cc
Added code is still not used.

BUG=chromium-os:16556
TEST=build success


Review URL: http://codereview.chromium.org/8499007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110045 0039d316-1c4b-4281-b951-d872f2087c98

with the download manager.  This change should have no effect on
when the user sees a warning or not.

BUG=102540
TEST=No visible change yet.


Review URL: http://codereview.chromium.org/8536041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unittests


Review URL: http://codereview.chromium.org/8533028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110043 0039d316-1c4b-4281-b951-d872f2087c98

Use correct definition introduced in http://codereview.chromium.org/8051010

BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8566002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110042 0039d316-1c4b-4281-b951-d872f2087c98

Revert 109813 - Revert 109777 - Request power status update from power manager when power button view gets created.

Also, prepare PowerManagerDbusClient for change in power manager for bug chromium-os:21360

TEST=manual
BUG=chromium-os:20832

Review URL: http://codereview.chromium.org/8491054


It broke some ui_tests on linux chromeos

TBR=tbarzic@chromium.org
Review URL: http://codereview.chromium.org/8551005

ui_tests should be happy now

TBR=tbarzic@chromium.org
Review URL: http://codereview.chromium.org/8564041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110041 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.

Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
  picking up from whatever the previous selected option was.
  Now, "Custom" remembers the specified margins. To test this
  select "Custom", do some dragging, then change to another
  option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
  then print. Open print preview again, the last used custom
  margins are remembered.
- There was a bunch of messages sent from JS to get various
  info/settings (initiator tab title, measurement system and
  number format, last used margin settings, default printer).
  I created a single message "getInitialSettings" to get all
  at once (they are needed before the 1st preview is is
  requested).

BUG=102446
TEST=See bug description.


Review URL: http://codereview.chromium.org/8351048

TBR=dpapad@chromium.org
Review URL: http://codereview.chromium.org/8564040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110040 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110039 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=trybots


Review URL: http://codereview.chromium.org/8532002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110038 0039d316-1c4b-4281-b951-d872f2087c98

change from

input
label

to

label
  input
  span
/label

This is better because there are no blank spaces that are unclickable (the offsetting start padding and margin was attempting to get around this). Also we need it to be consistent with settings so we can make css rules that apply to both equally well.

I removed aria-hidden attributes because those divs /should/ be using display:none when not visible. aria-hidden fixes it for screen readers but not for tab order.

BUG=103688
TEST=manual


Review URL: http://codereview.chromium.org/8566025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8537020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110036 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes "Custom" margins sticky across different preview sessions but also within the same preview session.

Here is a summary of all changes.
- Within same preview session: So far selecting "Custom" was
  picking up from whatever the previous selected option was.
  Now, "Custom" remembers the specified margins. To test this
  select "Custom", do some dragging, then change to another
  option and back to "Custom".
- Across preview sessions: Select "Custom", do some dragging,
  then print. Open print preview again, the last used custom
  margins are remembered.
- There was a bunch of messages sent from JS to get various
  info/settings (initiator tab title, measurement system and
  number format, last used margin settings, default printer).
  I created a single message "getInitialSettings" to get all
  at once (they are needed before the 1st preview is is
  requested).

BUG=102446
TEST=See bug description.


Review URL: http://codereview.chromium.org/8351048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8555029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22051
TEST=Enable spoken feedback and focus on battery icon on the status area.  Press down arrow key twice and ensure that it speaks "Charging Battery full" or something like that.


Review URL: http://codereview.chromium.org/8511004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110033 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110032 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110029 0039d316-1c4b-4281-b951-d872f2087c98

The sync UMA logging logic that is in place first checks to see if the sync config has changed before logging a user's choices. This logic was broken by the implicitly enabled preferences that are currently behind a flag, resulting in more logging than necessary.

This patch changes the UMA logging logic to include only the datatypes that are explicitly listed on the preferences page. It also does the actual logging prior to applying the config via OnUserConfigured(), and adds extra checks that will remind anyone who adds a new datatype to also add UMA logging for the datatype.

BUG=96507
TEST=Change your sync config in a bunch of ways and look at about:histograms

Review URL: http://codereview.chromium.org/8566023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110028 0039d316-1c4b-4281-b951-d872f2087c98

Allow JSONWriter and JSONValueSerializer to ignore binary values when instructed to do so.

Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c

BUG=None
TEST=base_unittests


Review URL: http://codereview.chromium.org/8505033

TBR=ericdingle@chromium.org
Review URL: http://codereview.chromium.org/8528051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110027 0039d316-1c4b-4281-b951-d872f2087c98

Actually, the interface is currently known as PPB_Flash_TCPSocket.

BUG=103993
TEST=ui_tests OutOfProcessPPAPITest.TCPSocketPrivate
TBR=dmichael@chromium.org

Review URL: http://codereview.chromium.org/8564034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110026 0039d316-1c4b-4281-b951-d872f2087c98

The new interface defines functionality common between SSLClientSocket 
and SSLServerSocket.

TEST=None
BUG=None


Review URL: http://codereview.chromium.org/8515026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104039
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8555013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110023 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.
TEST=DesktopEventFilter.AddtionalFilters test should pass.


Review URL: http://codereview.chromium.org/8565018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110022 0039d316-1c4b-4281-b951-d872f2087c98

Design discussion is available here: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/967eb64325c24f9c

BUG=None
TEST=base_unittests


Review URL: http://codereview.chromium.org/8505033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110021 0039d316-1c4b-4281-b951-d872f2087c98

This is the second preliminary change for the support of global keyboard shortcut.
This CL depends on
http://codereview.chromium.org/8508055/

BUG=97255
TEST=None


Review URL: http://codereview.chromium.org/8508056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110020 0039d316-1c4b-4281-b951-d872f2087c98

Change the "source location" column on about:profiler to only display the filename (rather than the full path). Since those values are now clickable, users can just click on the filename+linenumber to see more information, including the full source path and relevant source code.

BUG=100992
Review URL: http://codereview.chromium.org/8555028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8137002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110018 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8542001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110017 0039d316-1c4b-4281-b951-d872f2087c98

untrusted.gypi. Ninja has a different layout, which this was breaking.

BUG=None
TEST=None
R=noelallen@google.com,wez@google.com
Review URL: http://codereview.chromium.org/8510068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110015 0039d316-1c4b-4281-b951-d872f2087c98

WM_DEVICECHANGE is sent when there's been a change to devices or the computer;
specifically when a USB device is connected or disconnected. This is intended
for use in support of Gamepads for more performant polling and
connect/disconnect testing. Currently only on Windows, though seems reasonable
to add for other platforms in the future.

BUG=79050


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109960

Review URL: http://codereview.chromium.org/8523021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110014 0039d316-1c4b-4281-b951-d872f2087c98