- 10 Dec, 2019 40 commits
-
-
Trent Apted authored
This is to prepare for writable files support in the next release. These changes were reviewed under go/media-app, but copies are needed in the chromium source tree for integration testing. Bug: 996088 Change-Id: I2fc2b19ef53c78fc54e69b41934b5b03cd53f24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959201 Commit-Queue: Trent Apted <tapted@chromium.org> Auto-Submit: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#723554}
-
jorgegil@google.com authored
Implements TouchSelectionMenuClient functions required to request Smart Text Selection actions and to open the Quick Menu on cross-process subframes. Bug: 1020334 Change-Id: Iba3e6139db266a3ed1ea5dfbbf49c83ea7d5f3b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954405Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Jorge Gil <jorgegil@google.com> Auto-Submit: Jorge Gil <jorgegil@google.com> Cr-Commit-Position: refs/heads/master@{#723553}
-
Findit authored
This reverts commit bf48f734. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 723529 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JmNDhmNzM0MGJmN2QwY2NiMjg4MmNjZDI2MmRmMTE3YWJhNmJiM2EM Sample Failed Build: https://ci.chromium.org/b/8894421463503746800 Sample Failed Step: compile Original change's description: > Android: Remove obsolete comments in javac.py > > Now that we have migrated to using the javac binary in third_party/jdk > and only turning on the errorprone plugin when it is enabled, we no > longer need this comment. > > Bug: 1030676 > Change-Id: I27a3d8ea19da698fa74e869fdcd878ca922956c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959901 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723529} Change-Id: Ieaa827f4029ddc0154ab848e3f7f12e0f17e3dd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961065 Cr-Commit-Position: refs/heads/master@{#723552}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb7c3388a50c..8ed7ae4c8e9b git log bb7c3388a50c..8ed7ae4c8e9b --date=short --first-parent --format='%ad %ae %s' 2019-12-10 amaiorano@google.com Fix REACTOR_DEFAULT_OPT_LEVEL not actually applying Created with: gclient setdep -r src/third_party/swiftshader@8ed7ae4c8e9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If5a921a6809f04a7e5be04984eda623ce7e1a499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723551}
-
Sven Zheng authored
Added in crrev.com/c/1919544 trying to fix the bug. But it didn't work and I've fixed the bug in crrev.com/c/1956145. So it's time to delete these lines. Bug: 956016 Change-Id: I73e7c89068652db2976a00cef106f644dbbfbd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958697Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#723550}
-
Xida Chen authored
Right now the PaintRenderingContext2D::setTransform that takes a DOMMatrix would crash because it is NOTREACHED(). This CL implements that and add a layout test. Bug: 1029362 Change-Id: I1038dbe1bfcee14e128c46f73606fabcf3923caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951566 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#723549}
-
Gavin Williams authored
There are three main changes needed to improve the ChromeVox experience for the settings OS language page: -Apply aria-hidden to the language labels to remove them from ChromeVox navigation. Instead only navigate to the associated buttons -When a user chooses a language to display the system text in, a Restart button is displayed on the screen. That Restart button needs a label to better describe/announce its purpose. -Each item in the "Input method" keyboard list used two ChromeVox navigation stops instead of one. Applying aria-hidden to the inner div then aria-label to the outer div fixed this behavior Screen captures: Before: https://bugs.chromium.org/p/chromium/issues/detail?id=976452#c15 After: https://bugs.chromium.org/p/chromium/issues/detail?id=976452#c16 Bug: 976452 Change-Id: I90a70f3c4197a3b0f6eea3f8696d36766eba373d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952091 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#723548}
-
Yun Liu authored
Bug: 1025725 Change-Id: I7a3a7762289ba482093c4847c9406e1238e7081d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957329 Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: Yun Liu <yliuyliu@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#723547}
-
Ken Rockot authored
Moves these classes into Storage Service, including unit tests. No behavioral changes. Bug: 1000959 Change-Id: Icf444ef0e631237340ef6705d5f883c752138823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960808Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#723546}
-
Michael Thiessen authored
Introduces LibraryLoader#ensureMainDexInitialized, which registers MainDex jni, and runs native library initialization, allowing MainDex classes to use the native library earlier during startup. In testing on a Nexus 5 running Kitkat, typical runtimes are: -loadMainDexAlreadyLocked: ~70-100ms (includes loadlibrary call) -loadNonMainDexAlreadyLocked: ~50-75ms -initializeAlreadyLocked: ~3ms So this change allows any classes wanting to use native libraries earlier to block startup by ~50-75ms less on M and below :) Otherwise this should have no effect on startup. Bug: 783819 Change-Id: I410137c004257430acf85960000385247ab0fd71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890496 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#723545}
-
Robert Liao authored
Clang-Tidy performed all of the transformations in this change except for the following: * components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm Protected instance variable reference from ConstrainedWindowAnimationBase. BUG=1030028 Change-Id: I1088576034cad4e758d53ed1bfc2c6aaafaf8706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959850Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723544}
-
Clark DuVall authored
This is no longer needed after http://crrev.com/c/1949403. We now have special handling for redirects that restart the loader. Bug: 1029944 Change-Id: I4c4bf3c5cb108e7428c9a047e1071dd3f7f2db04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956387Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#723543}
-
minch authored
Create a GestureProvider for back gesture, then the gesture sequence can be generated and handled in OnTouchEvent. This can avoid tap down event be used by the window that is underneath to do other things (e.g, highlight a menu item) instead of going back. Bug: 1022474 Change-Id: Ib72f5346afad5abfe44f898cbe9f443fdfe008c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955173 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#723542}
-
sczs authored
Moves bookmarks_egtest helpers into a new file BookmarkEarlgreyUtils. Change-Id: Ib03473684b160090428960d6b6b2437d4b748c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956226 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723541}
-
Ian Clelland authored
Bug: 993790 Change-Id: If427b1a27cbd4e67f6296c91936389eb3d8c6215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960515 Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#723540}
-
Hector Carmona authored
Bug: 1031008 Change-Id: I4aece44c572589531cc34aae023ea62dc14f381f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960183Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#723539}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f013e8b39651..e0582c36727b Created with: gclient setdep -r src-internal@e0582c36727b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1032272,chromium:1032343 Tbr: jbudorick@google.com Change-Id: Ieb93e5b3f78af7e5b75ed05db323911a01cc6449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723538}
-
Toni Barzic authored
Shelf orientation changes also change the space available for app list layout, and may cause app list layout/config changes. Generally, when not in tablet mode, this is addressed by dismissing app list when the shelf orientation changes (and updating layout when the app list is shown again). This cl adds similar handling for the case when tablet mode is started (which is expected to cause shelf orientation change for side-shelf) - the app list is dismissed, and then reshown again (with proper is_side_shelf() value). BUG=1031681 Change-Id: Ic7f1c442362e3aab6f544768d2cddaa8e042294e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955923Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#723537}
-
Liquan (Max) Gu authored
Why: Currently, PageInfo shows the page-info dialog for Tab only. Since we would like the dialog works for WebContents in general. We want to refactor PageInfoController to depend on WebContents rather than Tab. This patch is part of the effort. Change: * getOfflinePage() depends on Tab -> WebContents * isShowingTrustedOfflinePage() depends on Tab -> WebContents * TabImpl.getProfile() -> Profile.fromWebContents() * Activity -> ChromeActivity, because ConnectionInfoPopup.show() depends on ChromeActivity. Bug: 999196 Change-Id: Idb432edbbdb839d1b3cae2bfced6a4343861e7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960565Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723536}
-
chrome://conflictsDemetrios Papadopoulos authored
Also adding JS type checking. Bug: 1028829 Change-Id: Ib8b6c924a74495bde4b649a1bc10f308a717bebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957901Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#723535}
-
Becca Hughes authored
This reverts commit d4147193. Reason for revert: Suspect CL for tree closure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/150698 Original change's description: > Add presubmit check to ensure histograms do not have both units and enum > > Bug: 1004564 > Change-Id: I6b013baa1deae61956daf0675e8ebd4e8ffb66cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959414 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Tina Lu <ltina@google.com> > Cr-Commit-Position: refs/heads/master@{#723528} TBR=mpearson@chromium.org,isherman@chromium.org,ltina@google.com Change-Id: I7634c47832c9fdea5d1b557ba223273d8744f594 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960895Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#723534}
-
Maksym Onufriienko authored
Parent cl - http://crrev/c/1940752 Bug: 1940752, 1032184 Change-Id: Ie22a25dcc9c5fd318f522326fd0bc6acfb817c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949291Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#723533}
-
Trevor Perrier authored
This CL uses the refactor in two previous CLs [1][2] to add "af" as a as a locale to Android bundles (trichrome). This is the first step in testing if locales can be added just to Android bundles. This is done by: 1) adding "af" to locales when compiled on Android 2) adding "af" .xml and .pak exports to all .grd files used by Android. It also refactors many hardcoded grit output lists in BUILD files so that future language changes do not need to edit as many files. Note on size increase: SystemWebView does not support bundles so languages can not be split. This means that even in APK builds that do not use the new locales have a size increase. Since SystemWebView should support all languages that Android does this size increase is unavoidable. [1] https://crrev.com/c/1939962 [2] https://crrev.com/c/1940949 Bug: 812837 Change-Id: Id0143cc39bb08715b9b8036c56409b58623eeea1 Binary-Size: Size increase is unavoidable (see above). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941058 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#723532}
-
Lily Chen authored
This adds the domain and path of the cookie (in addition to the name which is already logged) to the NetLog entries for COOKIE_INCLUSION_STATUS. Since the name, domain, and path of a cookie uniquely identify the cookie, this information is helpful for debugging. Bug: 1005217 Change-Id: I74d1a77212c40a096ea76ff0b041bdab0fb31f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959659Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#723531}
-
David Benjamin authored
If c.example has HSTS with includeSubDomains and b.c.example has HSTS *without* includeSubDomains, we currently treat a.b.c.example as *not* HSTS. The b.c.example masks off the c.example entry. This behavior was, at one point, relied on by a corporate deployment per https://crbug.com/469957. However, the analysis in the bug that it matches the spec was incorrect. RFC 6797 sections 8.2 and 8.3 spell out the matching rules explicitly and they do not include the shadowing behavior. The analysis that it matches all other browsers was also incorrect. Chrome and Firefox have the shadowing behavior while Edge and Safari do not. This behavior is also surprising and increases the risk of a misconfigured site losing HSTS's security properties, particularly around cookie injection. As the first step towards fixing this, measure how often this makes a difference, Bug: 469957, 821811 Change-Id: I22cb443cd1f1a378ec1794575b9082905f74150c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955334 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723530}
-
Peter Wen authored
Now that we have migrated to using the javac binary in third_party/jdk and only turning on the errorprone plugin when it is enabled, we no longer need this comment. Bug: 1030676 Change-Id: I27a3d8ea19da698fa74e869fdcd878ca922956c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959901 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#723529}
-
Tina Lu authored
Bug: 1004564 Change-Id: I6b013baa1deae61956daf0675e8ebd4e8ffb66cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959414Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tina Lu <ltina@google.com> Cr-Commit-Position: refs/heads/master@{#723528}
-
delima02 authored
Add method to all implementing classes. See go/hotrodsethome for more details. Bug: b:139706624 Change-Id: I7d884e259135b46715e1dbceda6e8aa85a7c32fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917970 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Cr-Commit-Position: refs/heads/master@{#723527}
-
Victor Hsieh authored
Test: build Bug: N/A Change-Id: I7818335d0245bfdab391d1c9384e58a25a40a79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960573 Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723526}
-
Dave Tapuska authored
Move FrameMsg_SetHasReceivedUserGestureBeforeNavigation and FrameHostMsg_SetHasReceivedUserGestureBeforeNavigation to RemoteFrame and LocalFrameHost mojo interfaces respectively. BUG=1008432 Change-Id: I7dd476bd5b9475f82497c722f26d1176353cfac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957833Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#723525}
-
David Bienvenu authored
Bug: 960245 Change-Id: Ied12e6e129388e4c7a342a8ea84f163970ef8741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838212Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#723524}
-
Brian Salomon authored
Previously this was tested using SkSLCompiler. However, that type should remain private to Skia. SkRuntimeColorFilterFactory is quasi-public. ("Public" to Chrome but eventually to all). Change-Id: I9b523001c7bfce9660f86e0430e164b883e07b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958785Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#723523}
-
Matt Reynolds authored
This CL updates the expiry dates for two Gamepad API histograms: Gamepad.KnownGamepadConnectedWithId Gamepad.UnknownGamepadConnected These histograms are used to measure gamepad device compatibility with Chrome and are actively in use. I've updated the expiry dates to a year from now per the advice here: https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Expired-Histogramshttps://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Histogram-Expiryhttps://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#how-to-choose-expiry-for-histograms BUG=1018792 Change-Id: Ie675be6f54981e1ee0bb291224a0d32372a80051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958421Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#723522}
-
Michael Thiessen authored
Just added all of the src paths I could find with: find -wholename "*/java/src" -type d find -wholename "*/javatests/src" -type d find -wholename "*/junit/src" -type d And sorted the list (thanks sortmylist.com). Change-Id: I2532b28bea42c149e75bd614818e5d689b6e00f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959660 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#723521}
-
Clark DuVall authored
This change makes it so we no longer need to add asset paths to the applications context, and instead we wrap the context in a ContextWrapper which overrides getAssets() and getResources() to directly return the implementation assets and resources. This means we can no longer use WebViewFactory.getProviderClass(), since it adds asset paths internally. Instead we load the context from the WebView provider using WVF.getWebViewContextAndSetProvider() on N+, which takes care of signature verification, and load manually using createPackageContext() below N. We also need to make sure the native library is loaded so we can use the WebView shared relro implementation. Change-Id: I082107a71d1bf71069e498843a9ecc00470e6cb8 Bug: 1032662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931617Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#723520}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4c855c79362924fb96e04ef171c61f7363a82909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960178Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#723519}
-
Kevin Qin authored
Current OpenXr implementation has DXGI_FORMAT_R8G8B8A8_UNORM format, but DXGI_FORMAT_R8G8B8A8_UNORM_SRGB should be used. OpenXR's swapchain format expects to describe the texture content. The result of a swapchain image created from OpenXR API always contains a typeless texture. On the other hand, WebGL API uses CSS color convention that's sRGB. The RGBA typelss texture from OpenXR swapchain image leads to a linear format render target view (reference to function D3D11TextureHelper::EnsureRenderTargetView in d3d11_texture_helper.cc). Therefore, the content in this openxr swapchain image is in sRGB format. Fixed: 1020392 Change-Id: Id1526e4b3061c81dfb48b5b9fd4bdced7831fd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894049 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#723518}
-
Scott Haseley authored
This CL removes the priority-based anti-starvation logic from TaskQueueSelector. Anti-starvation has been disabled both in the browser and for the main thread in Blink, so this CL should not result in any additional behavior changes. This CL also replaces the backing data structure (SmallPriorityQueue) with a simplified ActivePriorityTracker, which is a wrapper around an integer representing which priorities are active. This also cleans up various unit tests: - Remove parameterized tests (with/without anti-starvation) - Fix PrioritizeCompositingAndLoadingInUseCaseLoadingTest in main thread scheduler unit tests. This was not running because it was missing an INSTANTIATE_TEST_SUITE_P, and the test was missing a comma causing it to fail. - Replace the TaskQueueSelector starvation unit tests and test for different orders of posted tasks. These were modified to be a bit more future proof/general and to test all priorities. - Remove the unit tests that test the starvation score logic. Bug: 1031336 Change-Id: I1ff8d83617d33c7510c33c08b78b1abc1a148683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954760 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#723517}
-
shrekshao authored
TBR=kbr@chromium.org Bug: 1027776 Change-Id: I5c3b6003187fcebc8e32c9d1a3d760b8d4091353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959934Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#723516}
-
Erik Chen authored
memlog_browsertests is now run as part of android_browsertests. There is no need to run these same tests in chrome_public_test_apk. Change-Id: Id058589bb87d0acf2d121f66f27b3f090b67a945 Bug: 970205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959052 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723515}
-