GitLab

Extension background page is only allowed for the incognito profile
on sign-in screen, so in order to run the app on sign-in, the app
must be run in split incognito mode.

To avoid having two background pages per user (for original and otr
profile) in regular user session, set split incognito mode only for the
app running on signin screen (by using different manifest than for a
regular session)

TEST=
1. Make sure easy sign-in works
2. Lock screen with an incognito window open.
   Verify that the screen can be unlocked using Smart Lock
BUG=448634,445048

Review URL: https://codereview.chromium.org/834233005

Cr-Commit-Position: refs/heads/master@{#311543}

- Fix defaultControl to return ok button for error screen;
- Add aria-live and aria-atomic to content div so that it is read out
  when the screen state is changed and all contents are updated;

BUG=413766
TEST=Test enable-debugging flow with ChromeVox and verify that title and message gets read on each step.

Review URL: https://codereview.chromium.org/788953005

Cr-Commit-Position: refs/heads/master@{#311542}

BUG=448025

Review URL: https://codereview.chromium.org/845993002

Cr-Commit-Position: refs/heads/master@{#311541}

BUG=448876
TEST=
TBR=mlamouri@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/831903008

Cr-Commit-Position: refs/heads/master@{#311540}

R=erikwright@chromium.org
BUG=412384

Review URL: https://codereview.chromium.org/846383003

Cr-Commit-Position: refs/heads/master@{#311539}

NormalSpdyTransactionHelper constructor is often (approximately 70 times) called
with a temporary BoundNetLog() argument.  Its log_ member currently takes
reference of that, which becomes dangling right after the constructor returns.

This is not an issue if there are no NetLog events, nor in the NetLog test which
creates a named CapturingBoundNetLog object that it keeps in scope.  The
dangling reference only became problematic in the HTTP11RequiredProxyRetry test,
and curiously enough, only for 64 bit Andoid builds.

This CL changes the NormalSpdyTransactionHelper.log_ member type from reference
to value to fix this issue.

BUG=447837

Review URL: https://codereview.chromium.org/852053002

Cr-Commit-Position: refs/heads/master@{#311538}

BUG=417532

Review URL: https://codereview.chromium.org/799323003

Cr-Commit-Position: refs/heads/master@{#311537}

BUG=446267

Review URL: https://codereview.chromium.org/840763003

Cr-Commit-Position: refs/heads/master@{#311536}

BUG=

Review URL: https://codereview.chromium.org/831453004

Cr-Commit-Position: refs/heads/master@{#311535}

test cases.

The multi profiles tests creates multiple profiles each in different user data
dirs and signs in each one separately. Then each profile performs sync related
operations and verifies results on the other sync'ed profile.

The CL also adds some helper functions to force a client to do a sync cycle.

Note: These tests are DISABLED and do not run on the normal bots.

BUG=431366

Review URL: https://codereview.chromium.org/772513004

Cr-Commit-Position: refs/heads/master@{#311534}

fyi and chromium_athena.json will be removed in separate CL

BUG=448472

Review URL: https://codereview.chromium.org/851743005

Cr-Commit-Position: refs/heads/master@{#311533}

This reverts commit a63c0394.

BUG=448829
R=knn@chromium.org

Review URL: https://codereview.chromium.org/841443005

Cr-Commit-Position: refs/heads/master@{#311532}

This cl updates the checker.py script in /third_party/closure_compiler to
add an option to process a set of JS files at once rather than one at a
time (the current default). It also adds a flag to enable additional compiler
checks (since Chromoting wants all checks enabled).

It also updates the Chromoting .gyp files to make use of the new compiler.

The remaining changes were motivated by the errors reported by the new
closure compiler.

BUG=

Review URL: https://codereview.chromium.org/803653004

Cr-Commit-Position: refs/heads/master@{#311531}

Test code that's used downstream needs to live in
chrome/test/android/javatests (which is included in the
chrome_java_test_support target), not chrome/android/javatests (which is
included only in the chrome_shell_test_apk target).

BUG=444675

Review URL: https://codereview.chromium.org/788163006

Cr-Commit-Position: refs/heads/master@{#311530}

Wikipedia now assigns a fallback classname to its 'tex' img nodes. ChromeVox, reading the className directly, needs to split the space delimited string.

BUG=448544
TEST=math now reads on wikipedia

Review URL: https://codereview.chromium.org/828373007

Cr-Commit-Position: refs/heads/master@{#311529}

Strict virtual annotation checks were enabled on Mac in r311365.

This gets toolkit_views for Mac on board.

BUG=417463

Review URL: https://codereview.chromium.org/850843003

Cr-Commit-Position: refs/heads/master@{#311528}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/854643002

Cr-Commit-Position: refs/heads/master@{#311527}

BUG=421063,439661

Review URL: https://codereview.chromium.org/826083004

Cr-Commit-Position: refs/heads/master@{#311526}

BUG=447732
TEST=Manually inspect chrome:histograms.

Review URL: https://codereview.chromium.org/847223002

Cr-Commit-Position: refs/heads/master@{#311525}

Since map<Key, Value>::value_type is std::pair<const Key, Value>, we
need to ensure that we use this type to avoid an extra copy/temporary
creation. This patch does this by explicitly using value_type where
it is clear what the type is, and adding const to the key where it's not.

Review URL: https://codereview.chromium.org/853533002

Cr-Commit-Position: refs/heads/master@{#311524}

In r311421 a test was modified that called into
XkbKeyboardLayoutEngine::ParseLayoutName but this function was not exposed in
the header file. This change exposes this method in the header file and fixes
the build.

Original CL that introduced issue: https://codereview.chromium.org/848833002

BUG=None
TEST=Compile of events_unittests completes

Review URL: https://codereview.chromium.org/812613004

Cr-Commit-Position: refs/heads/master@{#311523}

Review URL: https://codereview.chromium.org/842113004

Cr-Commit-Position: refs/heads/master@{#311522}

BUG=448768

Review URL: https://codereview.chromium.org/852803002

Cr-Commit-Position: refs/heads/master@{#311521}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b47bba7..7c348a8

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/854663002

Cr-Commit-Position: refs/heads/master@{#311520}

It makes MultiResolutionImageResourceFetcher uses FRAME_ASSOCIATED_LOADER
instead of PLATFORM_LOADER and set the loader options to allow
cross origin fetching and passes credentials.

Amongst other things, using the Blink loader will show the load in the
developer tools. For example, it does expose a bug while trying to fetch
the favicon in https://www.gmail.com/intl/en/mail/help/about.html

The load allows cross origin because many websites uses CDN for favicon
and it allows credentials because the last attempt to not pass cookies
to the favicon request failed, see bug 114082. This CL is not
changing any credential/cross-origin behaviour but makes it
explicit.

Furthermore, this CL changes some special favicon requests handling in
resource_dispatcher_host_impl.cc and instead explicitly bypass service
workers when setting up the request.

BUG=110449

Review URL: https://codereview.chromium.org/840553003

Cr-Commit-Position: refs/heads/master@{#311519}

Include fixes: https://code.google.com/p/googletest/source/detail?r=701
MinGW specific: https://code.google.com/p/googletest/source/detail?r=702

The reason I want this: Fixing compiling the gmock header in .mm files
with new clang revisions that have clang r220714:
https://code.google.com/p/googletest/source/detail?r=703
https://code.google.com/p/googletest/source/detail?r=704

BUG=444089
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/838933003

Cr-Commit-Position: refs/heads/master@{#311518}

chrome_shell.gypi is only included if OS=="android" so there is no reason
to test it again.

BUG=none

Review URL: https://codereview.chromium.org/810193006

Cr-Commit-Position: refs/heads/master@{#311517}

Add a cancellation callback so that the active import task is cancelled when the user clicks on the cancel button in the progress notification.

BUG=420680
TEST=browser_test: FileManagerJsTest.MediaImportHandlerTest

Review URL: https://codereview.chromium.org/846903004

Cr-Commit-Position: refs/heads/master@{#311516}

This patch is part of an ongoing process to unbundle memory_inspector
and make it a chrome app. It replaces multiprocessing, which is
currently not supported by naclports/python, with threading.

BUG=448399

Review URL: https://codereview.chromium.org/836933004

Cr-Commit-Position: refs/heads/master@{#311515}

This removes the additions in chrome/, but not the underlying content/
dom_storage changes.

BUG=440539

Review URL: https://codereview.chromium.org/797443002

Cr-Commit-Position: refs/heads/master@{#311514}

Move files from chrome/browser/history that have no dependency on
chrome or content to components/history.

BUG=370850

Review URL: https://codereview.chromium.org/813503003

Cr-Commit-Position: refs/heads/master@{#311513}

These tests iterate over 10000 frames, and with debug mode
being 13+ times slower than release mode, this ends up taking
too long. Hopefully we won't loose much coverage by reducing
the number of iterations in debug mode.

BUG=448035, 448511

Review URL: https://codereview.chromium.org/832293003

Cr-Commit-Position: refs/heads/master@{#311512}

This test is taking too long to run on the bot and preventing other
tests to be run.

BUG=427529

Review URL: https://codereview.chromium.org/850083002

Cr-Commit-Position: refs/heads/master@{#311511}

When probing for new displays we create new snapshots. We need to make
sure that existing ones will contain the same state as the old ones
otherwise the state between the Browser and GPU process will be out of
sync.

BUG=434115
NOTRY=true

Review URL: https://codereview.chromium.org/845383002

Cr-Commit-Position: refs/heads/master@{#311510}

Clarify that packets originating on Chrome OS are intercepted by the API,
not packets reaching the device from outside.

BUG=407541

Review URL: https://codereview.chromium.org/804363002

Cr-Commit-Position: refs/heads/master@{#311509}

BUG=448147

Review URL: https://codereview.chromium.org/849933002

Cr-Commit-Position: refs/heads/master@{#311508}

This patch is part of an ongoing process to unbundle memory_inspector
and make it a chrome app. It removes the dependency of www_server.py
on the dateutil module, which is not part of the Python Standard
Library.

BUG=448399

Review URL: https://codereview.chromium.org/850033002

Cr-Commit-Position: refs/heads/master@{#311507}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
TBR=qinmin@chromium.org

Review URL: https://codereview.chromium.org/841453006

Cr-Commit-Position: refs/heads/master@{#311506}

BUG=401598
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/806693009

Cr-Commit-Position: refs/heads/master@{#311505}

Set max_num_reorder_frames to allow the decoder to output pictures early.

BUG=446627
TEST=video_encode_accelerator_unittest

Review URL: https://codereview.chromium.org/794433005

Cr-Commit-Position: refs/heads/master@{#311504}