- 21 Nov, 2020 17 commits
-
-
Patrick Noland authored
Testing a smaller (included) fix for a crash in updateMicButtonState revealed a few other post-destruction issues that were previously hidden by LocationBarLayout never being nulled out. So this CL * Null checks VoiceRecognitionHandler in updateMicButtonState * Guards against post-destruction callback/delegate invocation in URLBar * Prevents a post-destruction call to onSuggestionsReceived in AutocompleteMediator (and fixes incorrect documentation) Bug: 1151225, 1151080, 1146585 Change-Id: Iae295a7629c35aeae8ce357e414b05e6847d62e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552570Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#829885}
-
Stephen Roe authored
and Linux distro. This supports running tests on x64 Ubuntu and on arm64 Ubuntu 16.04 and arm64 Ubuntu 18.04. Bug: 1131647 Change-Id: Ie75adcb775bc32601fb4001720e960b17607edee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517991 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829884}
-
Adam Langley authored
Add support version=2 caBLE extensions with a sessionPreKey that carries the same information that would be sent via a QR code. This allows a server to create a caBLEv2 link. BUG=1002262 Change-Id: I0dc1e40a2beee927f4fa4faef243b350e017cc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548123 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829883}
-
Sophie Chang authored
Bug: 1146151 Change-Id: If63c626ce0ef01d86d7465a0715cfea7470a3ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552886Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829882}
-
Sorin Jianu authored
This change is just renaming files, changing header guards, include directives, and build files to match the new names. Bug: 1151106 Change-Id: Ia52ff972d3cee0d6623cfd051be7cababafbdce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551852Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829881}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f47910c9ce3..8f8e2dc7d50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie497ccb48973ce970c63471df0cbe68c3d90826f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829880}
-
Steven Bennetts authored
This property is unused in Shill and Chrome. Bug=b:173635024 Change-Id: Ie28c18a959ec9a279794ecf5c30d8f856aeea89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552891Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829879}
-
Andrew Xu authored
This CL implements the menu item presenting the copied file, called `ClipboardHistoryFileItemView`. This new menu item is applied to the clipboard history data whose display format is `kFile`. Bug: 1134392 Change-Id: I48ad2b8e88ae8a6a5fa56b4c1f31af1e5a5ebea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552082 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#829878}
-
Ahmed Fakhry authored
If the muxer expects audio frames, and doesn't get any, it will discard video frames. This causes tests to be flaky on the bots as no audio is captured there. See https://crbug.com/1151167. This CL adds the ability to tell the service not to record audio. There are plans to expose this in the UI too (See https://crbug.com/1145273). BUG=1151418 TEST=Manually, existing tests. Change-Id: I9f5552e54cecb949f6ceb746de56b9fee7d7e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552921 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#829877}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/afaca889d46b..ce4be1e64050 2020-11-20 mbonadei@webrtc.org Revert "Enable FlexFEC as a receiver video codec by default" 2020-11-20 natim@webrtc.org Defining API result types on VoIP API 2020-11-20 philipel@webrtc.org Don't use VP9 specific concepts to combine spatial layer frames in FrameBuffer2. 2020-11-20 philipel@webrtc.org Remove unused includes from RtpFrameReferenceFinder. 2020-11-20 alessiob@webrtc.org AGC2 limiter stats + config ToString missing param 2020-11-20 asapersson@webrtc.org Enable initial frame drop for one active simulcast layer. 2020-11-20 philipp.hancke@googlemail.com dont allocate a payload type for rtp data channels when using sctp 2020-11-20 mbonadei@webrtc.org Trigger bots for FYI waterfall. 2020-11-20 mbonadei@webrtc.org Reland "Add protobuf-py2_py3 3.13.0 to .vpython." 2020-11-20 mbonadei@webrtc.org Revert "Add protobuf-py2_py3 3.13.0 to .vpython." 2020-11-20 jonaso@webrtc.org Add feature to not discard candidates after connection is established 2020-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 98d2d358..7ffc87db (829346:829478) 2020-11-19 tommi@webrtc.org Remove dependency on AsyncInvoker in SctpTransport 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3e59a753..98d2d358 (829209:829346) 2020-11-19 philipel@webrtc.org Removed superfluous check in FrameBuffer2. 2020-11-19 mbonadei@webrtc.org Add protobuf-py2_py3 3.13.0 to .vpython. 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9e2395c8..3e59a753 (829108:829209) 2020-11-19 nisse@webrtc.org Delete objc RTCRtpFragmentationHeader 2020-11-19 hmaniar@nvidia.com Enable FlexFEC as a receiver video codec by default 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20d9ad23..9e2395c8 (828982:829108) 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 80346697..20d9ad23 (828632:828982) 2020-11-18 landrey@webrtc.org Reduce test flakiness because of upload issues 2020-11-18 mbonadei@webrtc.org Reland "Rename FATAL() into RTC_FATAL()." 2020-11-18 landrey@webrtc.org Fix address of checking the Dashboard upload status 2020-11-18 mbonadei@webrtc.org Disable flaky test. 2020-11-18 landrey@webrtc.org Log responce of the Dashboard before start using it at upload script 2020-11-18 philipel@webrtc.org Make video scalability mode configurable from peerconnection level. 2020-11-18 jakobi@webrtc.org Allow temporal based switch if temporal layers are undefined. 2020-11-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 921d7ed3..80346697 (828216:828632) 2020-11-18 phancke@nvidia.com guard flexfec usage with fieldtrial 2020-11-18 mbonadei@webrtc.org Revert "Rename FATAL() into RTC_FATAL()." 2020-11-17 bradpugh@google.com Add support for turn logging id in ios sdk. 2020-11-17 jonaso@webrtc.org Add TURN server to Emulated Network infrastructure 2020-11-17 natim@webrtc.org Locating input audio level before TaskQueue. 2020-11-17 jakobi@webrtc.org Remove resolution limited max bitrate for simulcast screenshare. 2020-11-17 garth.judge@8x8.com Fixed incorrect assertion when performing iLBC decoder packet loss concealment 2020-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 27f19de5..921d7ed3 (828088:828216) 2020-11-17 mbonadei@webrtc.org Rename FATAL() into RTC_FATAL(). 2020-11-17 nisse@webrtc.org Add transition define RTC_OBJC_HAVE_LEGACY_RTC_RTP_FRAGMENTATION_HEADER 2020-11-17 philipp.hancke@googlemail.com stats: add transportId to codec stats 2020-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3a3815b9..27f19de5 (827982:828088) 2020-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20a633fc..3a3815b9 (827865:827982) 2020-11-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 32410c4f..20a633fc (827734:827865) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1024965 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d721597ac3deac4005f47ba1c1f3613ad7477c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552808Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829876}
-
Leo Zhang authored
Store connector instances inside a map of InputMethodManager then remove the instance of ime service connector from InputMethodManager::State. Test: Test IME service on VM (betty). Bug: 1139328 Change-Id: I32057af4ac75fa5f3392741e87004559290f4494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509071Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#829875}
-
Kramer Ge authored
linux_explicit_synchronization can cause crash due to a bug in earlier exo version. Underlying issue can be fixed from lacros side. Re-enable once fix is landed. Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 Bug: 1151012 TBR=rjkroege@chromium.org Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552854Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#829874}
-
Bo Liu authored
Currently viz is using the LocalSurfaceId in RenderWidgetHostViewAndroid as the surface to submit a root renderer frame to. This doesn't always work because renderer side change to LocalSurfaceId may not have been committed yet for that frame, which then can cause a mismatch in viz. Due to webview having a shortcut to resize the root renderer compositor viewport without commit [1], it's also not ok to use the LocalSurfaceId of the renderer compositor, since renderer can resize before the new Id is committed. This technically breaks surface sync, though it doesn't matter to webview in practice. However this does need to be solved for IsUsingVizFrameSubmissionForWebView. Instead, just generate LocalSurfaceId in HardwareRendererViz and check the frame size and scale to generate new Ids instead. [1] https://source.chromium.org/chromium/chromium/src/+/master:cc/trees/layer_tree_frame_sink_client.h;drc=7cfc49943853b0c361223b47ddeb01f7e9fa7ff3;l=73 Bug: 1145412 Change-Id: I0ac5934e214ca2667bf71fc610dceddc343d0e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551788 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829873}
-
Matt Menke authored
Instead, use the shiny new one that takes net::SchemefulSites instead of url::Origins. Bug: 1145294 Change-Id: Id552fdb5f7711c5835d2551d5851d01d111c8b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545484Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829872}
-
Curt Clemens authored
Instead of a generic failure message, show a specific error string that depends on the TransferMetadata::Status. Change-Id: I86b6549c4f6de0477f9a63ef71f9298796f10065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551078Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#829871}
-
Daniel Cheng authored
This ensures that the speculative RFH is deleted even when it is already ready to commit and has sent a CommitNavigation() IPC to the renderer. Bug: 838348 Change-Id: Id834274219c3f8b4d837cce2a3d54148e938a0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536794 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#829870}
-
Xianzhu Wang authored
This reverts commit 6b916224. Reason for revert: Caused crbug.com/1150781. Original change's description: > Check Layer::SafeOpaqueBackgroundColor() is opaque when contents_opaque() > > Bug: 936906 > Change-Id: Ibbb8fad9bd4680a91e0a595e10db9b752c1450a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538330 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828829} TBR=wangxianzhu@chromium.org,vmpstr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 936906, 1150781 Change-Id: I6a880b97b48a5842ef00008d6ac75c00731024b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552986Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829869}
-
- 20 Nov, 2020 23 commits
-
-
Haiyang Pan authored
If it runs fine, it will be removed from MM-arm64-rel & MM-x86-rel-non-cq, and run on MM-x86-rel formally. Bug: 1127110 Change-Id: I55bdfece736a2ce00864be4b42e2ee1df1a6b777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552676Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#829868}
-
Christoph Schwering authored
Bug: 1142413, 1150277 Change-Id: I19a5f90933e5da7e9d2ea79e7c1fff7c48002cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550383Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#829867}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2340291. After that change went in, we are still seeing crashes in BrowserAccessibility::AccessibilityPerformAction where the anchor and/or focus nodes are not found, stemming from setSelectionRanges. Based on code inspection, I was able to come up with this variation, where the anchor and focus nodes are in the same tree as each other, but in a different tree than the caller. The crash dumps I have available not have enough data to prove that this is the root cause of those specific crashes, but the unit test added here is sufficient to show that this crash is possible. Rather than returning an error in this scenario, when the anchor and focus nodes are in in the same tree as each other, but a different tree than the node calling setSelectionRanges, the tree that the anchor and focus nodes reside in is used for looking up the manager and setting the selection. AX-Relnotes: n/a Bug: 1110522 Change-Id: I28cb18e87bcd0cfa2abd3220878d4b04ac70f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504630 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829866}
-
Dan Sanders authored
Without access to the shared main thread context, VideoFrame.createImageBitmap() is unable to handle texture-backed frames. This CL does not fix the issue, but it does change it from a check failure to a DOMException. Bug: 1148849 Change-Id: I3f8c292022dc3cb8fd6625591d2384511e253ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552901 Commit-Queue: Dan Sanders <sandersd@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#829865}
-
Rakib M. Hasan authored
Bug: 1041619 Change-Id: I530267388d8409f7e5c3e0f3a087e1fa5784607b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551674 Auto-Submit: Rakib Hasan <rmhasan@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#829864}
-
Josh Nohle authored
Upload the user's contact list and allowlist to the Nearby Share server every 24 hours to ensure that the server has the information needed to distribute certificates. This upload supplements the current strategy of uploading contacts whenever the contact list or allowlist changes. This ensures that, if the device record is removed from the Nearby Share database--after 9 days of inactivity, for example--the client will resend the contact list even if the contact list has not changed. Manually tested and verified. Fixed: 1151498 Change-Id: I9d4669ff1bafc3ac22c385cc8ef4aaf6f9dc355b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553035 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#829863}
-
Joe Downing authored
This CL adds the class which logs any ETW events received to the Windows event log. Bug: 1144185 Change-Id: I3972e2c5ef91ace511f5bebfa41fa00ff68ac521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545564 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#829862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/108b4ee97ef9..a08962107ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbansal@google.com,waffles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150459 Tbr: tbansal@google.com,waffles@google.com Change-Id: Ie8f08aad9287c6452ddebfcfbb98e17a944773d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552887Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829861}
-
Olivier Yiptong authored
This implements the content interface for embedders to enumerate fonts in the upcoming chooser UI, which can be found at https://crrev.com/c/2543603. Bug: 1138621 Change-Id: Iae647eb04417a865590595b8bb1b1f1e1e3a3c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531180Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829860}
-
Chris Palmer authored
Also fix a bug: `PCHECK` may itself allocate, creating re-entrancy problems, so we can't use it as a way to learn the `errno`. Instead, create a `PA_PCHECK` macro that uses `base::debug::Alias`. Bug: None Change-Id: Ic17e7c09d620e8f1f38da8b64a45fbfeeeac3b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546084 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#829859}
-
Ken Rockot authored
Upstream Chromium no longer uses an InterfaceProvider to expose browser interfaces to render frames. Cast Shell still does this for a small handful of interfaces registered by downstream internal-only logic. In order to support the transition of the internal repository away from this mechanism, this CL introduces a bit of redundancy: interfaces registered with CastWebContents through either of its two registration mechanisms will now be exposed to *both* InterfaceProvider consumers as well as BrowserInterfaceBroker. Once this lands, internal renderer code can simply be rewritten to use RenderFrame::GetBrowserInterfaceBroker instead of RenderFrame::GetRemoteInterfaces(), and then upstream Chromium can completely remove all its gnarly support for a browser-exposed InterfaceProvider. Bug: 977637 Change-Id: I21ae1fc31b35b0ca77ab2a00645feafe0ac67a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547054Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#829858}
-
Garrett Beaty authored
This will reduce the amount of manual change that must be made when updating configuration for a branch and put more values inline in the config. Change-Id: I033beff961f1d88a30795e12ca7f784abd0c331a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551668 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#829857}
-
Jimmy Gong authored
cr-card-radio-button does not properly implement the paper-ripple effect and as a result the paper-ripple effect is at the root of the document. This results in a ripple effect to appear in the top left of the page. More details in the attached bug. Bug: 1150617 Fixed: 1148515 Change-Id: I60363c440f792d24f4b7e5957e89f156906164ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548366Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829856}
-
Maria Kazinova authored
Unlike login forms, change password forms are often kept on page after successful submission. This CL allows to detect submission for change password forms that are cleared field by field with HTMLInputElement::SetValue(), by setting an empty value. Bug: 1149948, 1147363 Change-Id: Ia5d8e27f91b4a9e36784517e87fff41167551ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537697 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#829855}
-
Andrew Xu authored
This CL is a part of the efforts to create multipaste menu items for copied files. This CL does the following jobs: (1) Create a new type for `ClipboardHistoryDisplayFormat` called `kFile`. (2) Move the code related to the text label out of ClipboardHistoryText- ItemView. Instead, create `ClipboardHistoryLabel` for the text label used by the multipaste menu. Right now a `ClipboardHistoryTextItemView` instance is built for a clipboard data whose display format is `kFile`. So this CL does not introduce any visual difference. Bug: 1134392 Change-Id: I7fb4b9ce5d37fcd298b5cfefcd9dcee0ad160c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547225 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#829854}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7a005c70ab6fad58e5fc014efc62fa2dca978f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829853}
-
Khushal Sagar authored
Bug: 1056730 Change-Id: I0515616e5524d002859d4f1c8ce7b8f8c930a119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299535 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829852}
-
Sophie Chang authored
This matches the enum checked into google3 Bug: 1146151 Change-Id: I934ae52656e765992c755733f4108773d6446f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552760 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#829851}
-
James Hawkins authored
This change fixes a crash where the device name is fetched from the DeviceNameStore, which is not initiatlized when the flag is off. R=khorimoto@chromium.org Bug: 1151252 Test: none Change-Id: I314b6bd27f3bfe1ff7bce9ebf9ebd7c28edf8188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552671Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#829850}
-
Jing Wang authored
This is required for cl/342559961 Bug: 1137621 Change-Id: Ic7fffc07a2ec9c62c4b92c894e0d961ab6d56382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536427Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#829849}
-
Kyle Milka authored
Subclass ScreenshotCoordinator to create LongScreenshotCoordinator. For now this class only overrides captureScreenshot() to launch the bottom bar after capture instead of directly launching the editor. Bug: 1142520 Change-Id: I378f1809ed1cf9a74df2f028a6a6ca0d75a06d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542924Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#829848}
-
Alison Maher authored
This change overrides the ColorIncludingFallback() function for fill, stroke, -internal-visited-fill, and -internal-visited-stroke. This allows us to use ComputedStyle::VisitedDependentColor() instead of ComputedStyle::ResolvedColor(). This change shouldn't result in any functional difference. Bug: 970285 Change-Id: I6a5b85cdbf1abe8dc9d255ba73c7f6c6e8530a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519272 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#829847}
-
Clark DuVall authored
Feed V2 has fragment classes that are not retained, so on configuration changes these are recreated using reflection. This change keeps track of isolated split ClassLoaders that were created for inflation, and checks if fragment classes can be loaded with these. Bug: 1151456 Change-Id: I46a64a1959e8879680babdb94fa33f4e928ff863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552205 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#829846}
-