- 05 Mar, 2018 26 commits
-
-
Christopher Cameron authored
It used to be a valid assumption that ui::Compositors would be destroyed before BrowserCompositorMac::DisableRecyclingForShutdown was called, but changes to NSWindows' lifetimes have made that assumption no longer valid. Destroy all BrowserCompositorMac instances at that call. Make relevant methods on RenderWidgetHostViewCocoa and RenderWidgetHostViewMac early-out when the BrowserCompositorMac is gone. Bug: 805726 Change-Id: I429b6b546344a23cd93e64dae4a004065328d5a6 Reviewed-on: https://chromium-review.googlesource.com/947813 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#540798}
-
Alex Clarke authored
Change-Id: I17932c9db2e9c42ca0cef4eccd063cb61b9ff123 Reviewed-on: https://chromium-review.googlesource.com/947943Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540797}
-
Kent Tamura authored
Generated files in these directories are often identical to other checked-in files. It's difficult to make move_blink_source.py workable in such situation. So, this CL renames these generated files beforehand. This CL has no behavior changes. Bug: 770603 Change-Id: I3bf2312b7a238fe605e33a9217959d84d43ffb4f Reviewed-on: https://chromium-review.googlesource.com/947546Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#540796}
-
Yutaka Hirano authored
TBR=grt@chromium.org Bug: 818167 Change-Id: I2b32ad5308e51f4da39947d1f3b631587b2fe2d3 Reviewed-on: https://chromium-review.googlesource.com/948402Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540795}
-
https://webrtc.googlesource.com/src.git/+log/12c8110e8c71..3ba7a57f8fff $ git log 12c8110e8..3ba7a57f8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib2e051f77dad5c01e99f97abf8d3212d09419f21 Reviewed-on: https://chromium-review.googlesource.com/948269 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540794}
-
Bence Béky authored
Change-Id: I2c14a7c94d55b38b303a6b827fd5d1d06a8feca4 Reviewed-on: https://chromium-review.googlesource.com/946151 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540793}
-
Max Morin authored
fuchsia_audio_manager_free should be called, I think. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I58bc4b9fb00fcd1d9d074752ddc8d59777911d6a Reviewed-on: https://chromium-review.googlesource.com/945913Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540792}
-
Tien-Ren Chen authored
The paint rect for background in scrolling content layer should be expanded to the full scrollable rect, i.e. layout overflow rect. This CL fixes a bug in BoxPainter and BoxPaintInvalidator that we forgot to convert LayoutBox::LayoutOverflowRect() from flipped coordinates to physical coordinates for painting and invalidation. BUG=787666 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4b4c45e910ea1d860e61eece6005263d0a8c708e Reviewed-on: https://chromium-review.googlesource.com/942485 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#540791}
-
Mikel Astiz authored
Trivial change, no behavioral differences. Bug: 681921 Change-Id: Id512b11a574afcf902d35553bb10a1a85cbcdea7 Reviewed-on: https://chromium-review.googlesource.com/940134Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540790}
-
Yutaka Hirano authored
The test has succeeded unexpectedly, so this CL also adds an expectation file. Bug: 812667 Change-Id: I649a7663c54f83ccb951c5a4bf075b588908b088 Reviewed-on: https://chromium-review.googlesource.com/948184 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#540789}
-
Ned Nguyen authored
Owners no longer use this benchmark Change-Id: Ic544da522fb68ffe85da5cd777da2dc314f82fc8 Reviewed-on: https://chromium-review.googlesource.com/948245Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#540788}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I807f89abb3cc9a7896ae7c5252a124ce4e1afbb7 Reviewed-on: https://chromium-review.googlesource.com/948265 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540787}
-
Zhuoyu Qian authored
IsAmbiguousBoundaryCharacter() only used in SpellChecker.cpp, move it from EditingUtilities to SpellChecker.cpp for better code structure. Bug: 802922 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ie86aed1551481312544c2471dac2068199e5cd65 Reviewed-on: https://chromium-review.googlesource.com/945350Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#540786}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 533c6272. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13319 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley No-Export: true Change-Id: Ib7f68d4e9b7a3ad2e9141d02804f70df9c05ccd9 Reviewed-on: https://chromium-review.googlesource.com/947837 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#540785}
-
Zhuoyu Qian authored
This patch makes EditorParagraphSeparator to be an enum class for better type safety. Bug: Signed-off-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540784}
-
Makoto Shimazu authored
This reverts commit ace9aca7. The test actually crashes only when DCHECK is on. The difference from the original patch is adding -expected.txt file and changing [ Crash ] to [ Crash Pass ]. TBR=falken@chromium.org Bug: 771815 Change-Id: I9354c80c6e1478160214151065f6f0cbf25ad862 Reviewed-on: https://chromium-review.googlesource.com/948242Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540783}
-
Peter Collingbourne authored
Bug: 749784 Change-Id: I8ae48e1b1080ddeef87faafc7fad8f40ddb01126 Reviewed-on: https://chromium-review.googlesource.com/947715Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#540782}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I8fdb21a1682cbb9e2937556d521db77b6b410f55 Reviewed-on: https://chromium-review.googlesource.com/947838Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#540781}
-
Hitoshi Yoshida authored
REASON OF RELAND: The issue was out of Chromium repository, and run on only Chrome official build. Hence I revert the chagne in merger.py, not to check v8_context_snapshot.bin. Original CL is https://chromium-review.googlesource.com/c/chromium/src/+/923683 This CL makes it possible to create and use V8 context snapshot files on Android, if a developer puts "use_v8_context_snapshot=true" The V8 context snapshot feature is currently supported and enabled on Windows, MacOSX, and Linux (not ChromeOS), and its Finch experiment showed 20% reduction of time to create V8 contexts. On local Android machine, this feature shows 50% time recution. Beside it, in order to enable the feature on cross-build platforms like Android, we have to build Blink twice. So this CL does not flip the flag |use_v8_context_snapshot|. FYI, some numbers with the feature are written in the next CL; https://chromium-review.googlesource.com/c/chromium/src/+/923623 TBR=caitkp,kuniko,nyquist,rockot,haraken,mkwst Bug: 764576, 817288 Change-Id: Id819aa2d4762e04bd7a9b4f700603d89ee0fe5dd Reviewed-on: https://chromium-review.googlesource.com/945248Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#540780}
-
Koji Ishii authored
Following bot results are included. 4034 4035 4036 4040 4041 4044 4045 4046 4047 4048 4049 4050 4051 4052 4053 4054 25 lines were removed and 18 lines were deflaked by consecutive results since 3993. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I32758809317e7fe8a2504de939f1620775f30076 Reviewed-on: https://chromium-review.googlesource.com/945038 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540779}
-
Tatsuhisa Yamaguchi authored
This will protect mounted zip file caches from the disk cleanup logic. Bug: 816928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I73d36a2317d643fdbbc74c342960b027b99dddb0 Reviewed-on: https://chromium-review.googlesource.com/940645 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540778}
-
Matt Falkenhagen authored
CompositorImageAnimation changed some timings and the resource was not yet cached when the test was expecting it to be. I've rearranged the test and it seems to pass reliably now on Linux: it passes 100 iterations whereas it would fail within 10 iterations previously. R=nhiroki Bug: 813468 Change-Id: I5b76353f90e728981922c325486fa1700e85f73e Reviewed-on: https://chromium-review.googlesource.com/945708 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#540777}
-
Yutaka Hirano authored
It's flaky with --enable-features=NetworkService. Bug: 818445 Change-Id: I42bcd27471d03f497989ee8181208e2c043c6099 Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/948162Reviewed-by:
-
Gyuyoung Kim authored
Most of the callers of ReleaseFreeMemory() have been usually invoking ClearMemory() together. So it would be good if we call ClearMemory() inside ReleaseFreeMemory(). It will help to return more free memory through ReleaseFreeMemory(). This CL makes ReleaseFreeMemory() purge more free memory through calling ClearMemory(). But this CL just calls SkGraphics::PurgeAllCaches() directly, since ClearMemory() doesn't do much stuff. And, this CL removes ClearMemory() that is no longer needed. The test case is implemented by referring to RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeDiscardableMemory(). It calls RenderThreadImpl::ReleaseFreeMemory through a fake memory pressure notification. Besides RenderThreadImplClearMemoryBrowserTest.MAYBE_ClearMemory should be also removed because ClearMemory() is removed. Test: RenderThreadImplDiscardableMemoryBrowserTest.ReleaseFreeMemory() Bug: None Change-Id: If82e204b6d8785e8d97cd57fe7eac9f0f852a7a8 Reviewed-on: https://chromium-review.googlesource.com/945748 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
-
Jinsuk Kim authored
The API was used to collect UMA stat on mobile-friendly pages for DOM distiller (reader mode) project. It can now be deleted. Bug: 598880 Change-Id: Ia922743fc6294bd57c7a92d71dc1678ce651c843 Reviewed-on: https://chromium-review.googlesource.com/945348Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#540774}
-
Will Harris authored
BUG=803621 Change-Id: I2a028ce864808a88f71c0b0a0e0d3f493e0f1f77 Reviewed-on: https://chromium-review.googlesource.com/940616Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#540773}
-
- 04 Mar, 2018 7 commits
-
-
Rune Lillesveen authored
Intent-to-ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6UNwnk97lrE Bug: 660265 Change-Id: I459d8aacb1defdc5aa1aee9e1958fd0831f9d60a Reviewed-on: https://chromium-review.googlesource.com/946468Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#540772}
-
Thomas Tangl authored
This CL adds a tooltip text to the DiceSigninButton dropdown arrow to make it more accessible. Bug: 814986 Change-Id: I65f6fea3bf6d3466425ab7a5e19955e9db9b938c Reviewed-on: https://chromium-review.googlesource.com/946093 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#540771}
-
Tien-Ren Chen authored
Extreme clip path values can create numerical issues including integer overflow, which is undefined behavior. This CL clamps clip path bounds to some sane value early in the pipeline. BUG=813340 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie35ea2899b7103ed36ba42f0c78711811b253e60 Reviewed-on: https://chromium-review.googlesource.com/942303Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540770}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If741f657bc9bdc777c0e4a12b2b07a1da7d4294c Reviewed-on: https://chromium-review.googlesource.com/947845 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ib547969af6403ed8fe12c68b76e0f202196cba0a Reviewed-on: https://chromium-review.googlesource.com/947766Reviewed-by:
-
Sadrul Habib Chowdhury authored
BUG=none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I11a4b83406a888660dbd8a4885fcfd862b20734f Reviewed-on: https://chromium-review.googlesource.com/946126Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#540767}
-
Luke Zielinski authored
This adds the values from the experiment to the codebase, in preparation for ad sampler launch. Bug: 744869 Change-Id: I4f89b3821d7b8b480a8865adf936ab64449c7139 Reviewed-on: https://chromium-review.googlesource.com/943701Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540766}
-
- 03 Mar, 2018 7 commits
-
-
Fan Yang authored
In QUIC, free MemSlices in stream send buffer out of order. Protected by FLAGS_quic_reloadable_flag_quic_free_mem_slice_out_of_order. Merge internal change: 187322087 R=rch@chromium.org Change-Id: Ic43ef75d6155e36934e634cce056217d4fbd1992 Reviewed-on: https://chromium-review.googlesource.com/946328Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540765}
-
Scott Violet authored
no code change, just moves definition to match declaration for WindowTreeClient. BUG=none TEST=none TBR=jamescook@chromium.org Change-Id: I232363402b059af48671a7002656f8515123f15e Reviewed-on: https://chromium-review.googlesource.com/947893Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#540764}
-
Michael Lippautz authored
Tbr: haraken@chromium.org Bug: chromium:757440 Change-Id: I878f3f9f59488046ec0907f198ee6cd5e7cd2d13 Reviewed-on: https://chromium-review.googlesource.com/947965Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540763}
-
Scott Violet authored
These make construction slightly clearer in that only arguments that are needed can be supplied. BUG=none TEST=covered by tests Change-Id: Ie4029896ff24957b1f7264ef6fb64fba018625ab Reviewed-on: https://chromium-review.googlesource.com/946882 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#540762}
-
Jeremy Roman authored
A fairly direct copy of CoerceJavaScriptListToArray, including adding the "do not coerce to string" behavior for elements. CoerceJavaScriptDictionaryToArray has the same behavior, so hopefully this distinction can be left out of the Java-side code. Bug: 794320 Change-Id: Ib9decbe9cbc332ac59b1590b10ff310057ee8544 Reviewed-on: https://chromium-review.googlesource.com/946872Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#540761}
-
David Grogan authored
When a table has a specified fixed height that is more than needed by its rows chrome only distributes the extra height to the first table body, ignoring thead, tfoot, and other tbody elements. Note this only contains tests, not a fix. Bug: 708345 Change-Id: Ib477306459a2f49feffe354e2cf3fed9b27e74e1 Reviewed-on: https://chromium-review.googlesource.com/942040 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#540760}
-
Jeremy Roman authored
std::make_unique is the more usual way to do this, and Blink doesn't even have WrapArrayUnique anymore for this reason. Bug: 755727 Change-Id: I9dc78827b8ef84da7c297ebc147a3ef157d0acc1 Reviewed-on: https://chromium-review.googlesource.com/946125Reviewed-by:
-
