Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 28 Jul, 2016 11 commits
    • changwan's avatar
      Overhaul WebView IME test · 5a6c5bf0
      changwan authored 
      There are some problems with existing WebView IME test.

First off, the example is misleading. Creating a selection range in
JavaScript is not straightforward and is not representative of what
WebView developers should be doing. Focusing on editor is a better use
case.

Also, it was flaky in some old device that we deprecated. As found in
crbug.com/621049, we actually need to wait for document focus before
we can focus on content-editable body.

The reason is that Android's view focus gets propagated to the renderer
process as input message while JavaScript execution gets propagated to
the renderer process as frame message, so JavaScript may be executed
before document gets focused, and focusing on content-editable body
is an invalid operation when document isn't yet focused. I suspect that
this is the reason why some OEM email client was using selection range
trick in the first place.

Finally, we were testing against real input method, which can be another
cause of flakiness, so it's fixed by a fake input method manager.

BUG=621049, 611928

Review-Url: https://codereview.chromium.org/2180853002
Cr-Commit-Position: refs/heads/master@{#408291}
      5a6c5bf0
    • sungmann.cho's avatar
      [Win] CustomFrameView::IconSize() should return the value in dip unit · bfff1719
      sungmann.cho authored 
      CustomFrameView::IconSize() returns the size of the window icon. On Windows,
the value is obtained from GetSystemMetrics(SM_CYSMICON) call, but the problem
is that the value returned is in pixel, not in dip. This leads to a wrong sized
window icon if an user is using a higher scale ratio. This CL replaces
GetSystemMetrics() with display::win::GetSystemMetricsInDIP() to fix this.

BUG=631488
TEST=See the bug page for the reproduce steps

Review-Url: https://codereview.chromium.org/2190593002
Cr-Commit-Position: refs/heads/master@{#408290}
      bfff1719
    • danakj's avatar
      cc: Post the missed BeginFrame to a new stack · e15b5e85
      danakj authored 
      When the UI compositor (or any compositor with a Display attached to it
in process - such as layout tests) does SwapBuffers, it submits the
CompositorFrame to the SurfaceFactory.

The SurfaceFactory pokes the DisplayScheduler, which can lead to it
doing the Display::DrawAndSwap immediately, in the same callstack. In
that case, the callback to the SurfaceDisplayOutputSurface (or the
TestDelegatingOutputSurface) that it drew happens inline also, which
was previously calling out to the OutputSurfaceClient.

The problem is, the compositor expects SwapBuffers() to return before
it hears that DidSwapBuffersComplete(). To avoid this, and similar
problems, we prevent DisplayScheduler from running a new BeginFrame
inside an external call to DisplayScheduler::SurfaceDamaged() which
prevents re-entrancy for its clients.

We do this by posting the missed BeginFrame to respond to it on a new
stack (and cancelling it if another BeginFrame comes in the meantime
since it was already posted).

For TestDelegatedOutputSurface synchronous composites, we simply
post the SwapBuffersComplete message to get it on a new call stack.

R=jbauman
BUG=495650
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2183333003
Cr-Commit-Position: refs/heads/master@{#408289}
      e15b5e85
    • boliu's avatar
      sync compositor: Set display viewport for software draw · 4dae5229
      boliu authored 
      After switching to using cc::Display for software draw, this fixes the
case where the viewport is not at the origin of the surface.

BUG=631276
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2187563006
Cr-Commit-Position: refs/heads/master@{#408288}
      4dae5229
    • pfeldman's avatar
      DevTools: remove release mode from runtime. · c7499c30
      pfeldman authored 
      Review-Url: https://codereview.chromium.org/2191473005
Cr-Commit-Position: refs/heads/master@{#408287}
      c7499c30
    • erikchen's avatar
      Allow Core Animation compositor to use some scaled filter effects. · 40f907ea
      erikchen authored 
      Filter scaling has no effect on filter effects that are not BLUR or DROP_SHADOW.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2188523006
Cr-Commit-Position: refs/heads/master@{#408286}
      40f907ea
    • creis's avatar
      Revert of Don't clear pending NavigationParams until didStopLoading. (patchset... · d356ae14
      creis authored 
      Revert of Don't clear pending NavigationParams until didStopLoading. (patchset #5 id:80001 of https://codereview.chromium.org/2140393002/ )

Reason for revert:
This caused a regression (https://crbug.com/631617).  We'll need to look for a safer way to clear the pending_navigation_params_ and try again.

Original issue's description:
> Don't clear pending NavigationParams until didStopLoading.
>
> Clearing them at the end of NavigateInternal causes problems when a
> ScopedPageLoadDeferrer is in use.
>
> Credit to thestig@ for the test framework changes.
>
> BUG=626838
> TEST=See bug for repro steps.
>
> Committed: https://crrev.com/275d69fc4e8af8ab4a8e7d8fe621ca5b408c134d
> Cr-Commit-Position: refs/heads/master@{#407239}

TBR=avi@chromium.org,thestig@chromium.org,csharrison@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=626838

Review-Url: https://codereview.chromium.org/2190463006
Cr-Commit-Position: refs/heads/master@{#408285}
      d356ae14
    • sky's avatar
      Moves handling of toggling applist back to common code · 6d4038f3
      sky authored 
      Implementation is no longer aura specific.

BUG=612331
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2183993005
Cr-Commit-Position: refs/heads/master@{#408284}
      6d4038f3
    • lushnikov's avatar
      DevTools: fix inspector/elements/css-rule-hover-highlights-selectors.html · 7727d401
      lushnikov authored 
      The test should wait until overlay gets repainted.

BUG=563650
R=dgozman

Review-Url: https://codereview.chromium.org/2182373002
Cr-Commit-Position: refs/heads/master@{#408283}
      7727d401
    • dpranke's avatar
      Make sure PDB files are in runtime_deps for GN builds. · f79ed9d1
      dpranke authored 
      Before r407890, we had no good way to make sure that
we were including the .pdb files for executables and
shared libraries in the runtime_deps for a target.
Now that GN has a `runtime_outputs` option, we can
use that and list the PDBs. This should fix issues
for debugging and also packaging the NaCl files as
part of an official build.

R=brettw@chromium.org, sebmarchand@chromium.org
BUG=624478, 629709

Review-Url: https://codereview.chromium.org/2192643002
Cr-Commit-Position: refs/heads/master@{#408282}
      f79ed9d1
    • xingliu's avatar
      Blimp settings UI integration for Chrome, everything still lives in Blimp. · 27752d3e
      xingliu authored 
      Previously Blimp code is in blimp/app, this CL port settings UI code to core, and reuse Java resources files in blimp/app.(We can setup new one in core or somewhere if needed)

In this way, all UI resources, and code live in Blimp so we don't leak things to Chrome at the moment.

For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=624451

Review-Url: https://codereview.chromium.org/2173563003
Cr-Commit-Position: refs/heads/master@{#408281}
      27752d3e
  3. 27 Jul, 2016 29 commits