1. 13 Mar, 2011 16 commits
    • rwlbuis@webkit.org's avatar
      2011-03-13 Rob Buis <rwlbuis@gmail.com> · 5a706f3b
      rwlbuis@webkit.org authored
              Reviewed by Dave Hyatt.
      
              REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
              https://bugs.webkit.org/show_bug.cgi?id=53470
      
              Prefer !important over normal properties when dealing with duplicate properties in style rules.
      
              Test: fast/css/duplicate-property-in-rule-important.html
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80963 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5a706f3b
    • levin@chromium.org's avatar
      Add expectation (and bug) for test that has failed with an image · bfebc573
      levin@chromium.org authored
      mismatch ever since it was added in r80867.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80962 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bfebc573
    • levin@chromium.org's avatar
      Update test expections due to the OSX specific ex size change done in r80755. · 906f4e99
      levin@chromium.org authored
      * platform/chromium-mac/fast/lists/008-expected.checksum: Added.
      * platform/chromium-mac/fast/lists/008-expected.png: Added.
      * platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
      * platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
      * platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
      * platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
      * platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
      * platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
      * platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
      * platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
      * platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
      * platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
      * platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
      * platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80961 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      906f4e99
    • levin@chromium.org's avatar
      Fix test expectations due to bad update: · 3f207187
      levin@chromium.org authored
        r80820 which limited to win/mac when it still regularly fails on Linux
        and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
        as well as occaisionally pass.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80960 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3f207187
    • levin@chromium.org's avatar
      Added the following expectations: · 1793bfd1
      levin@chromium.org authored
        fast/backgrounds/background-position-parsing.html new test in r80868
        fast/css-generated-content/table-row-before-after.html new test in r80871
        fast/table/dynamic-descendant-percentage-height.html new test in r80878
      
      Updated test_expectation to cover a failure due to a missing layout test feature
      and added an appropriate bug.
      
      * platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
      * platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
      * platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
      * platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
      * platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
      * platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
      * platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
      * platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
      * platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
      * platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
      * platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
      * platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
      * platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
      * platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
      * platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
      * platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
      * platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
      * platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
      * platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
      * platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
      * platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80959 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1793bfd1
    • levin@chromium.org's avatar
      Update test results due to r80755. All of these tests started failing · 8dd75503
      levin@chromium.org authored
      on that check in and were given new baselines in that check in.
      
      * platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
      * platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
      * platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
      * platform/chromium-mac/css1/units/length_units-expected.png: Added.
      * platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
      * platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
      * platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
      * platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
      * platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
      * platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
      * platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
      * platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
      * platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
      * platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
      * platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
      * platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
      * platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
      * platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
      * platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
      * platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
      * platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
      * platform/chromium-mac/editing/selection/caret-ltr-expected.png:
      * platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
      * platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
      * platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
      * platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
      * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
      * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
      * platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
      * platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
      * platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
      * platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
      * platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
      * platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
      * platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
      * platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
      * platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
      * platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
      * platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
      * platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
      * platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
      * platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80958 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8dd75503
    • commit-queue@webkit.org's avatar
      2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com> · 57c27877
      commit-queue@webkit.org authored
              Unreviewed, rolling out r80895.
              http://trac.webkit.org/changeset/80895
              https://bugs.webkit.org/show_bug.cgi?id=56261
      
              Causing crashes in several tests including
              t1202-counters-16-c.html (see
              http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
              (Requested by dave_levin on #webkit).
      
              * rendering/CounterNode.cpp:
              (WebCore::CounterNode::CounterNode):
              (WebCore::CounterNode::create):
              (WebCore::CounterNode::resetRenderer):
              (WebCore::CounterNode::resetRenderers):
              (WebCore::CounterNode::recount):
              (WebCore::CounterNode::insertAfter):
              (WebCore::CounterNode::removeChild):
              (WebCore::showTreeAndMark):
              * rendering/CounterNode.h:
              (WebCore::CounterNode::renderer):
              * rendering/RenderCounter.cpp:
              (WebCore::findPlaceForCounter):
              (WebCore::RenderCounter::~RenderCounter):
              (WebCore::RenderCounter::originalText):
              (WebCore::RenderCounter::invalidate):
              (WebCore::destroyCounterNodeWithoutMapRemoval):
              (WebCore::RenderCounter::destroyCounterNodes):
              (WebCore::RenderCounter::destroyCounterNode):
              (WebCore::updateCounters):
              (showCounterRendererTree):
              * rendering/RenderCounter.h:
              * rendering/RenderObjectChildList.cpp:
              (WebCore::invalidateCountersInContainer):
              (WebCore::RenderObjectChildList::invalidateCounters):
              * rendering/RenderObjectChildList.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80957 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      57c27877
    • levin@chromium.org's avatar
      Add results for newly added test in r80883. · 70efca6a
      levin@chromium.org authored
      The differences appear to be very small in keep with the typical
      font drawing differences.
      
      * platform/chromium-linux/fast/multicol/scrolling-overflow-expected.checksum: Added.
      * platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png: Added.
      * platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
      * platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png: Added.
      * platform/chromium-win/fast/multicol/scrolling-overflow-expected.checksum: Added.
      * platform/chromium-win/fast/multicol/scrolling-overflow-expected.png: Added.
      * platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80956 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      70efca6a
    • darin@apple.com's avatar
      * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: · 548fb14f
      darin@apple.com authored
      (WebKit::WebDragClient::startDrag): Fixed typo in a comment.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80955 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      548fb14f
    • levin@chromium.org's avatar
      r80743 updated the main baseline due to a jsc change. · 4a4769a7
      levin@chromium.org authored
      chromium isn't affected by the change.
      
      * platform/chromium/fast/js/regexp-caching-expected.txt: Added.
      chromium already had a specific baseline for this but it was in chromium-win,
      so I moved this result to the more general chromium direction.
      * platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80954 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4a4769a7
    • levin@chromium.org's avatar
      Remove bad test_expectation updates. · 88391066
      levin@chromium.org authored
      I fixed both of these already:
        http://trac.webkit.org/changeset/80911
        http://trac.webkit.org/changeset/80904
      so it is unclear why they were added.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80953 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      88391066
    • darin@apple.com's avatar
      2011-03-12 Darin Adler <darin@apple.com> · 8f12c58f
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
              https://bugs.webkit.org/show_bug.cgi?id=56258
      
              No tests because the wrong hashing is mostly harmless. The only symptom
              we have seen is an occasional assertion in debug builds about the size
              not being a multiple of two. But a worse hash is worse for performance too.
      
              * platform/cf/BinaryPropertyList.cpp:
              (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
              than the number of array entries.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80952 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8f12c58f
    • cwzwarich@webkit.org's avatar
      Not reviewed. · 7d7a56dc
      cwzwarich@webkit.org authored
      Fix the build with newer GCCs and remove some extra whitespae.
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::uint8_t):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80951 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7d7a56dc
    • cwzwarich@webkit.org's avatar
      Rubber-stamped by Oliver Hunt. · c234e475
      cwzwarich@webkit.org authored
      Removed unused ARMv5 code. The ARMv5 case now falls under the general
      unaligned accessed case.
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::CloneDeserializer::readLittleEndian):
      (WebCore::CloneDeserializer::readString):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80950 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c234e475
    • cwzwarich@webkit.org's avatar
      Reviewed by Oliver Hunt. · 5bf63c34
      cwzwarich@webkit.org authored
      WebCore fails to build with Clang on ARM
      https://bugs.webkit.org/show_bug.cgi?id=56257
      
      Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
      namespace scope, since explicit specializations are not allowed at class scope.
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::writeLittleEndian):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80949 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5bf63c34
    • darin@apple.com's avatar
      2011-03-11 Darin Adler <darin@apple.com> · caf9248c
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              Dragging image to desktop gives webloc instead of image file in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=56193
      
              * WebCore.exp.in: Added some additional exports. Re-sorted.
      2011-03-11  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Dragging image to desktop gives webloc instead of image file in WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=56193
      
              * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
              (WebKit::convertImageToBitmap): Added. Factored out from startDrag to
              make the startDrag code clearer.
              (WebKit::WebDragClient::startDrag): Streamlined code a bit.
              (WebKit::cachedImage): Added. Helper for function below.
              (WebKit::arrayForURLsWithTitles): Added. Helper for function below.
              (WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file
              promises and removed a log of uneeded code.
              (-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added.
              (promisedDataClient): Added.
              (-[WKPasteboardOwner clearImage]): Added.
              (-[WKPasteboardOwner initWithImage:]): Added.
              (-[WKPasteboardOwner dealloc]): Added.
              (-[WKPasteboardOwner finalize]): Added.
              (-[WKPasteboardOwner pasteboard:provideDataForType:]): Added.
              (-[WKPasteboardOwner pasteboardChangedOwner:]): Added.
              (matchesExtensionOrEquivalent): Added.
              (-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added.
              Much of the new code above came from the WebKit1 drag code.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
              * WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
              * WebProcess/WebPage/mac/WebPageMac.mm:
              (WebKit::WebPage::setDragSource): Added.
              (WebKit::WebPage::platformDragEnded): Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80948 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      caf9248c
  2. 12 Mar, 2011 24 commits
    • mitz@apple.com's avatar
      <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures · 37fa9f1e
      mitz@apple.com authored
      DumpRenderTree is being built for.
      
      Reviewed by Mark Rowe.
      
      * DumpRenderTree/mac/PerlSupport/Makefile:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80947 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      37fa9f1e
    • mrowe@apple.com's avatar
      Fix the 32-bit build. · 9eea7d4b
      mrowe@apple.com authored
      Source/WebKit/mac:
      
      * Carbon/CarbonWindowAdapter.mm:
      (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
      (-[CarbonWindowAdapter _carbonWindowClass]): Ditto.
      
      Source/WebKit2:
      
      This involves hacking around some HIToolbox headers that do things of dubious correctness,
      and fixing the usual CGRect vs NSRect issues.
      
      * UIProcess/mac/WKFullScreenWindowController.mm:
      (-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.
      * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
      (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80946 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9eea7d4b
    • andersca@apple.com's avatar
      * WebProcess/WebPage/WebFrame.cpp: · eccbfd32
      andersca@apple.com authored
      (WebKit::WebFrame::url):
      Get the URL from the loader, not from the document.
      
      Reviewed by Sam Weinig.
      
      (WebKit::WebFrame::suggestedFilenameForResourceWithURL):
      Return the correct suggested filename for the main resource.
      
      (WebKit::WebFrame::mimeTypeForResourceWithURL):
      Return the correct mime type for the main resource.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80945 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      eccbfd32
    • mitz@apple.com's avatar
      Suggested by Mark Rowe. · 433cdb1a
      mitz@apple.com authored
      * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
      as they were before r80915.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80944 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      433cdb1a
    • andersca@apple.com's avatar
      2011-03-12 Anders Carlsson <andersca@apple.com> · 11947c47
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Should be able to download a PDF to the Downloads folder
              https://bugs.webkit.org/show_bug.cgi?id=56256
      
              * UIProcess/API/C/WKPage.h:
              Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.
      
              * UIProcess/API/mac/PDFViewController.h:
              * UIProcess/API/mac/PDFViewController.mm:
              (-[WKPDFView _applyPDFPreferences]):
              (-[WKPDFView _updatePreferences:]):
              Use new PDFViewController::page getter.
      
              (-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
              Call PDFViewController::savePDFToDownloadsFolder.
      
              (WebKit::releaseCFData):
              (WebKit::PDFViewController::savePDFToDownloadsFolder):
              Create a WebData that wraps the CFData, then pass it along to
              WebPageProxy::saveDataToFileInDownloadsFolder.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
              Call WebUIClient::saveDataToFileInDownloadsFolder.
      
              (WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
              * UIProcess/WebUIClient.h:
              Call the UI client callback function.
      2011-03-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              Should be able to download a PDF to the Downloads folder
              https://bugs.webkit.org/show_bug.cgi?id=56256
      
              * MiniBrowser/mac/BrowserWindowController.m:
              (-[BrowserWindowController awakeFromNib]):
              * WebKitTestRunner/TestController.cpp:
              (WTR::TestController::createOtherPage):
              (WTR::TestController::initialize):
              Update for API changes.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80943 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      11947c47
    • andersca@apple.com's avatar
      2011-03-12 Anders Carlsson <andersca@apple.com> · ac117046
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              WebData should be able to wrap already existing data
              https://bugs.webkit.org/show_bug.cgi?id=56254
      
              * Shared/WebData.h:
              (WebKit::WebData::createWithoutCopying):
              (WebKit::WebData::create):
              (WebKit::WebData::~WebData):
              (WebKit::WebData::bytes):
              (WebKit::WebData::size):
              (WebKit::WebData::WebData):
              (WebKit::WebData::fastFreeBytes):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80942 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ac117046
    • jer.noble@apple.com's avatar
      2011-03-12 Jer Noble <jer.noble@apple.com> · 96b54de2
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
              https://bugs.webkit.org/show_bug.cgi?id=56250
      
              * UIProcess/API/mac/WKView.mm:
              (-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80941 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      96b54de2
    • loislo@chromium.org's avatar
      2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · bc7f1a56
      loislo@chromium.org authored
              Unreviewed. Update chromium expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80940 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bc7f1a56
    • loislo@chromium.org's avatar
      2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 7df08ce4
      loislo@chromium.org authored
              Unreviewed. Update chromium test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80939 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7df08ce4
    • loislo@chromium.org's avatar
      2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com> · 8d4e1e89
      loislo@chromium.org authored
              Unreviewed, rolling out r80919.
              http://trac.webkit.org/changeset/80919
              https://bugs.webkit.org/show_bug.cgi?id=56251
      
              all windows bots failed to compile this change (Requested by
              loislo on #webkit).
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * bytecode/StructureStubInfo.cpp:
              * interpreter/Register.h:
              (JSC::Register::withInt):
              (JSC::Register::withCallee):
              (JSC::Register::operator=):
              (JSC::Register::i):
              (JSC::Register::activation):
              (JSC::Register::function):
              (JSC::Register::propertyNameIterator):
              (JSC::Register::scopeChain):
              * jit/JIT.h:
              * jit/JITCall.cpp:
              (JSC::JIT::compileOpCallInitializeCallFrame):
              (JSC::JIT::compileOpCallVarargs):
              (JSC::JIT::compileOpCall):
              * jit/JITCall32_64.cpp:
              (JSC::JIT::compileOpCallInitializeCallFrame):
              (JSC::JIT::compileOpCallVarargs):
              (JSC::JIT::compileOpCall):
              (JSC::JIT::compileOpCallSlowCase):
              * jit/JITInlineMethods.h:
              (JSC::JIT::emitPutToCallFrameHeader):
              * jit/JITOpcodes.cpp:
              (JSC::JIT::privateCompileCTINativeCall):
              (JSC::JIT::emit_op_get_pnames):
              (JSC::JIT::emit_op_next_pname):
              (JSC::JIT::emit_op_load_varargs):
              (JSC::JIT::emitSlow_op_load_varargs):
              * jit/JITOpcodes32_64.cpp:
              (JSC::JIT::privateCompileCTINativeCall):
              (JSC::JIT::emit_op_get_pnames):
              (JSC::JIT::emit_op_next_pname):
              * jit/JSInterfaceJIT.h:
              (JSC::JSInterfaceJIT::payloadFor):
              * jit/SpecializedThunkJIT.h:
              (JSC::SpecializedThunkJIT::returnJSValue):
              (JSC::SpecializedThunkJIT::returnDouble):
              (JSC::SpecializedThunkJIT::returnInt32):
              (JSC::SpecializedThunkJIT::returnJSCell):
              * runtime/ArgList.cpp:
              * runtime/DateConversion.cpp:
              * runtime/GCActivityCallbackCF.cpp:
              * runtime/Identifier.cpp:
              * runtime/JSActivation.h:
              (JSC::asActivation):
              * runtime/JSLock.cpp:
              * runtime/JSNumberCell.cpp:
              * runtime/JSObject.h:
              * runtime/JSPropertyNameIterator.h:
              * runtime/JSValue.h:
              * runtime/JSZombie.cpp:
              * runtime/MarkedBlock.cpp:
              * runtime/MarkedSpace.cpp:
              * runtime/PropertyNameArray.cpp:
              * runtime/ScopeChain.h:
              (JSC::ExecState::globalThisValue):
              * wtf/DateMath.cpp:
      2011-03-12  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r80919.
              http://trac.webkit.org/changeset/80919
              https://bugs.webkit.org/show_bug.cgi?id=56251
      
              all windows bots failed to compile this change (Requested by
              loislo on #webkit).
      
              * bridge/c/c_class.cpp:
              * bridge/c/c_runtime.cpp:
              * bridge/jni/JavaMethod.cpp:
              * plugins/PluginViewNone.cpp:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80938 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8d4e1e89
    • paroga@webkit.org's avatar
      2011-03-12 Patrick Gansterer <paroga@webkit.org> · a280c104
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r80900.
      
              * CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80937 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a280c104
    • abecsi@webkit.org's avatar
      2011-03-12 Andras Becsi <abecsi@webkit.org> · cda0e1cc
      abecsi@webkit.org authored
              Unreviewed typo fix.
      
              No new tests needed.
      
              * WebCore.pro: Fix typo in header name.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80936 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cda0e1cc
    • loislo@chromium.org's avatar
      2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 56edeb96
      loislo@chromium.org authored
              Unreviewed. Update chromium test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80935 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      56edeb96
    • pfeldman@chromium.org's avatar
      2011-03-12 Pavel Feldman <pfeldman@chromium.org> · d2a997b6
      pfeldman@chromium.org authored
              Not reviewed: Inspect Element action regression fix.
      
              * inspector/front-end/inspector.js:
              (WebInspector.inspect):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80934 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d2a997b6
    • loislo@chromium.org's avatar
      2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · e4f9f510
      loislo@chromium.org authored
              Unreviewed. One line fix for inspector/dom-breakpoints.html
      
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
      
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80933 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e4f9f510
    • loislo@chromium.org's avatar
      2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 6ac44bb2
      loislo@chromium.org authored
              Unreviewed build fix.
      
              Almost all inspector tests are crashing after r80928.
      
              * inspector/front-end/inspector.js:
      
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80932 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6ac44bb2
    • pfeldman@chromium.org's avatar
      2011-03-11 Pavel Feldman <pfeldman@chromium.org> · 16c67e25
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: follow up to error reporting, fixing multiple regressions.
              https://bugs.webkit.org/show_bug.cgi?id=56243
      
              * inspector/elements/elements-panel-search.html:
      2011-03-11  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: follow up to error reporting, fixing multiple regressions.
              https://bugs.webkit.org/show_bug.cgi?id=56243
      
              * inspector/InjectedScript.cpp:
              (WebCore::InjectedScript::setPropertyValue):
              * inspector/InjectedScript.h:
              * inspector/Inspector.idl:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getChildNodes):
              (WebCore::InspectorDOMAgent::getOuterHTML):
              (WebCore::InspectorDOMAgent::getEventListenersForNode):
              * inspector/InspectorDOMAgent.h:
              * inspector/InspectorRuntimeAgent.cpp:
              (WebCore::InspectorRuntimeAgent::setPropertyValue):
              * inspector/InspectorRuntimeAgent.h:
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMNode.prototype.setNodeName):
              (WebInspector.DOMNode.prototype.setNodeValue):
              (WebInspector.DOMNode.prototype.getChildNodes):
              (WebInspector.DOMNode.prototype.getOuterHTML):
              (WebInspector.DOMNode.prototype.setOuterHTML):
              (WebInspector.DOMNode.prototype.removeNode):
              (WebInspector.DOMNode.prototype.copyNode):
              (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
              (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
              (WebInspector.EventListeners.getEventListenersForNode):
              * inspector/front-end/DOMStorage.js:
              (WebInspector.DOMStorage.prototype.getEntries):
              (WebInspector.DOMStorage.prototype.setItem):
              (WebInspector.DOMStorage.prototype.removeItem):
              * inspector/front-end/DOMStorageItemsView.js:
              (WebInspector.DOMStorageItemsView.prototype.update):
              (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
              (WebInspector.ElementsTreeElement.prototype.updateChildren):
              ():
              * inspector/front-end/EventListenersSidebarPane.js:
              (WebInspector.EventListenersSidebarPane.prototype.update.callback):
              (WebInspector.EventListenersSidebarPane.prototype.update):
              * inspector/front-end/ObjectPropertiesSection.js:
              (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression.callback):
              (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
              * inspector/front-end/PropertiesSidebarPane.js:
              (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
              * inspector/front-end/RemoteObject.js:
              (WebInspector.RemoteObject.prototype.setPropertyValue):
              (WebInspector.RemoteObject.prototype.evaluate):
              * inspector/front-end/inspector.js:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80931 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      16c67e25
    • jer.noble@apple.com's avatar
      Unreviewed build fix. · ecf0ac52
      jer.noble@apple.com authored
      Fix GTK+ builds by wrapping sections of full screen code in USE(ACCELERATED_COMPOSITING)
      checks.
      
      * dom/Document.cpp:
      (WebCore::Document::webkitWillEnterFullScreenForElement):
      (WebCore::Document::webkitDidEnterFullScreenForElement):
      (WebCore::Document::webkitWillExitFullScreenForElement):
      (WebCore::Document::webkitDidExitFullScreenForElement):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80930 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ecf0ac52
    • commit-queue@webkit.org's avatar
      2011-03-12 Ryuan Choi <ryuan.choi@samsung.com> · 163de04e
      commit-queue@webkit.org authored
              Unreviewed build fix.
      
              [EFL] Fix build break because of several reason.
              https://bugs.webkit.org/show_bug.cgi?id=56244
      
              * CMakeLists.txt: Add missing files.
              * platform/posix/FileSystemPOSIX.cpp: Add PLATFORM(EFL).
      2011-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
      
              Unreviewed build fix.
      
              [EFL] Fix build break because of several reason.
              https://bugs.webkit.org/show_bug.cgi?id=56244
      
              * ewk/ewk_settings.cpp:
              (ewk_settings_icon_database_path_set):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80929 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      163de04e
    • yurys@chromium.org's avatar
      2011-03-11 Yury Semikhatsky <yurys@chromium.org> · 2a013d51
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move profiler related methods from inspector agent to profiler agent
              https://bugs.webkit.org/show_bug.cgi?id=56204
      
              * inspector/Inspector.idl:
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
              (WebCore::InspectorAgent::setFrontend):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::populateScriptObjects):
              (WebCore::InspectorAgent::showProfilesPanel):
              * inspector/InspectorAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::profilerEnabled):
              (WebCore::InspectorController::startUserInitiatedProfiling):
              (WebCore::InspectorController::stopUserInitiatedProfiling):
              (WebCore::InspectorController::isRecordingUserInitiatedProfile):
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::profilerEnabledImpl):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::create):
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::enable):
              (WebCore::InspectorProfilerAgent::disable):
              (WebCore::InspectorProfilerAgent::setFrontend):
              (WebCore::InspectorProfilerAgent::clearFrontend):
              (WebCore::InspectorProfilerAgent::restore):
              (WebCore::InspectorProfilerAgent::restoreEnablement):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
              (WebCore::InspectorProfilerAgent::start):
              (WebCore::InspectorProfilerAgent::stop):
              * inspector/front-end/ProfileView.js:
              (WebInspector.CPUProfileType.prototype.buttonClicked):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype._registerProfileType):
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/inspector.js:
              (WebInspector._createPanels):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80928 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2a013d51
    • commit-queue@webkit.org's avatar
      2011-03-11 Anton D'Auria <adauria@apple.com> · 9a09687f
      commit-queue@webkit.org authored
              Reviewed by Brady Eidson.
      
              Adding StorageTracker tests to skip lists of platforms that don't support it.
              https://bugs.webkit.org/show_bug.cgi?id=51878
      
              * platform/gtk/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80927 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9a09687f
    • jer.noble@apple.com's avatar
      2011-03-11 Jer Noble <jer.noble@apple.com> · b081236a
      jer.noble@apple.com authored
              Reviewed by Anders Carlsson.
      
              WebCore::Document should notify ChromeClient when the full screen renderer's backing changes.
              https://bugs.webkit.org/show_bug.cgi?id=56226
      
              * dom/Document.cpp:
              (WebCore::Document::webkitWillEnterFullScreenForElement): Call setRootFullScreenLayer().
              (WebCore::Document::webkitDidEnterFullScreenForElement): Ditto.
              (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
              (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
              (WebCore::Document::setFullScreenRendererSize): Layout after setting the renderer's size.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80926 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b081236a
    • jer.noble@apple.com's avatar
      2011-03-11 Jer Noble <jer.noble@apple.com> · 169ed869
      jer.noble@apple.com authored
              Reviewed by Anders Carlsson.
      
              Add full screen animation code to WebFullScreenManager.
              https://bugs.webkit.org/show_bug.cgi?id=56220
      
              * WebProcess/FullScreen/WebFullScreenManager.cpp: .
              (WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
              (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
              (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
              (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
              (WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
              (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
              * WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
                  concrete subclass.
              * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
              * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
              (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
              (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
              (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
              (-[WebFullScreenManagerAnimationListener invalidate]): Added.
              (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
              (WebKit::WebFullScreenManagerMac::create): Added.
              (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
              (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
              (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
              (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
                  which will animate the full screen renderer from its initial position to its final one.
              (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80925 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      169ed869
    • jer.noble@apple.com's avatar
      2011-03-11 Jer Noble <jer.noble@apple.com> · 48762dae
      jer.noble@apple.com authored
              Reviewed by Anders Carlsson.
      
              Add full screen animation code to WebFullScreenManager.
              https://bugs.webkit.org/show_bug.cgi?id=56220
      
              * WebProcess/FullScreen/WebFullScreenManager.cpp: .
              (WebKit::WebFullScreenManager::~WebFullScreenManager): Added.
              (WebKit::WebFullScreenManager::exitFullScreenForElement): Remove ASSERTs.
              (WebKit::WebFullScreenManager::willEnterFullScreen): Set the full screen renderer's background color.
              (WebKit::WebFullScreenManager::didEnterFullScreen): Ditto.
              (WebKit::WebFullScreenManager::willExitFullScreen): Ditto.
              (WebKit::WebFullScreenManager::didExitFullScreen): Ditto.
              * WebProcess/FullScreen/WebFullScreenManager.h: Make a few functions pure virtual to be implemented in a
                  concrete subclass.
              * WebProcess/FullScreen/mac/WebFullScreenManagerMac.h: Added.
              * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: Added.
              (-[WebFullScreenManagerAnimationListener initWithManager:WebKit::began:finished:]): Listener for CAAnimations.
              (-[WebFullScreenManagerAnimationListener animationDidStart:]): Added.
              (-[WebFullScreenManagerAnimationListener animationDidStop:finished:]): Added.
              (-[WebFullScreenManagerAnimationListener invalidate]): Added.
              (WebKit::WebFullScreenManager::create): Now creates a WebFullScreenManagerMac.
              (WebKit::WebFullScreenManagerMac::create): Added.
              (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): Added.
              (WebKit::WebFullScreenManagerMac::~WebFullScreenManagerMac): Added.
              (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Set up the remote layer host.
              (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Create a CATransform3D
                  which will animate the full screen renderer from its initial position to its final one.
              (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80924 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      48762dae