- 02 Oct, 2018 40 commits
-
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /content/renderer. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=haraken@chromium.org Bug: 890902 Change-Id: I50debb7aaf123e76bb03925e7720ab5be5dd16a8 Reviewed-on: https://chromium-review.googlesource.com/c/1257906Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596050}
-
Lan Wei authored
In order to improve the performance and eliminate the issues that the fake mouse move events cause to the testing and web developers, we should not send fake mouse move events during scroll. This is implemented behind a flag. We will update the hover effect after scroll finishes in a following patch. Bug: 877132 Change-Id: Iee838f50e0a52b5048081d79f91442ddf0467e8f Reviewed-on: https://chromium-review.googlesource.com/c/1211907 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596049}
-
Sam McNally authored
Run with DriveFS enabled: - Drive-related context_menu.js tests. - Drive-related metadata.js tests. - folder_shortcuts.js tests. - fileDisplayDrive in tablet mode with DriveFS enabled. In order to make those tests pass: - Pass capabilities metadata to FakeDriveFs in SetMetadata() and return it in GetMetadata(). - Populate croppedThumbnailUrl so metadata cache doesn't retry fetching metadata, trying to get a value for it. - Remove two unused and incomplete tests in context_menu.js. - Only perform early-init for the downloads volume for the "user" profile. Bug: 891197 Change-Id: I8ddcbd75b74258b6988ad5c70c4e70c707d18f70 Reviewed-on: https://chromium-review.googlesource.com/c/1255086Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596048}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 890902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id50b106729a64268795a4ca170c62573fae65abc Reviewed-on: https://chromium-review.googlesource.com/c/1257846Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596047}
-
James Cook authored
This avoids some cases where code in //chrome/browser is directly poking into //ash to copy around tree IDs. It will also make it easier to support multiple remote tree IDs, since we're not just storing a single one in ash::AccessibilityController any more. Bug: 888147 Test: covered by tests, manually use Select-to-speak and ChromeVox with keyboard shortcut viewer, spoken feedback and focus work as expected Change-Id: Ica5c856ed8378a69fda86a2111b97bff1ee8a441 Reviewed-on: https://chromium-review.googlesource.com/c/1252905 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596046}
-
Shakti Sahu authored
With this CL, select/share/share all context menu options will be disabled when we don't have any completed items. Delete/delete all will be always enabled and will cancel the incomplete downloads. Bug: 890537 Change-Id: I7a8cd4b5a8fea2e6daeae7a10b79a023c7f0b5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1257680 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596045}
-
Matt Swartwout authored
Bug: None Test: Build no longer fails with linker errors for this function. Change-Id: I0b126ae80f01b659dbc679f34f465322eecb7282 Reviewed-on: https://chromium-review.googlesource.com/c/1258210Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Swartwout <mwswartwout@google.com> Cr-Commit-Position: refs/heads/master@{#596044}
-
Fabio Tirelo authored
Bug: 882525 Change-Id: I4eec6fca2f24fc50a9004d3f2e2aa816b0a9951c Reviewed-on: https://chromium-review.googlesource.com/c/1240393Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596043}
-
Paul Jensen authored
Previously it was always initialized to CONNECTION_NONE, so if the first transition is to CONNECTION_NONE, it would not send out a notification. Bug: 883208 Change-Id: I583003a8d2d7160c88165a72194ca84eb9f42925 Reviewed-on: https://chromium-review.googlesource.com/c/1256285Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596042}
-
siyua authored
In the migration dialog, previously the user could click the save button if the user decided to upload no cards, in which case, we would still send a no-op Rpc call to Payments. This was not an ideal situation. Instead, we would disable the save button and the user can click the cancel button to quit the flow. Bug: 852904 Change-Id: I6a1e005a63b19046728568b4ce08755616361e08 Reviewed-on: https://chromium-review.googlesource.com/c/1255608 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596041}
-
Jun Mukai authored
The reported bug (tab-dragging to snap to left/right on tablet mode with Mash) happens due to the timing of ClearTabDraggingInfo(), it clears ash::kTabDroppedWindowStateTypeKey but this property is used on IsSnapped() function. To have this property, this CL moves invocation of ClearTabDraggingInfo() slightly later in EndDragImpl, so that CompleteDrag() can use the values. BUG=880635 TEST=existing test passes, assuming this break nothing Change-Id: I8ba34c793dade6462fb1ee9470851cf8f066c4ad Reviewed-on: https://chromium-review.googlesource.com/c/1256006 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596040}
-
Patrick Noland authored
Bug: 888627 Change-Id: Ibb73ce82d983aa9a4e7493352b7469ac00e85d69 Reviewed-on: https://chromium-review.googlesource.com/c/1257815Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#596039}
-
John Abd-El-Malek authored
Change-Id: I314cfd4e5e9e8ffab588a9beb53d0538eaf4c557 Reviewed-on: https://chromium-review.googlesource.com/c/1258248Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#596038}
-
Antoine Labour authored
They are not used anywhere any more. Some of them never ever were. Bug: 889651 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I81e4746927dfd763a80b215788e1690a4728ff59 Reviewed-on: https://chromium-review.googlesource.com/c/1252855Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596037}
-
Ted Choc authored
BUG=881659 Change-Id: Ib1ad439d73b7951603a35fb9760d9cec943f0acd Reviewed-on: https://chromium-review.googlesource.com/c/1257666 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596036}
-
Dale Curtis authored
This is only used during building, there's not a good reason to have the sanitizers enabled since it will significantly slow down the actual build process and seems to try to allocation nearly a terabyte of memory at some points. BUG=861418 TEST=none Change-Id: I8d2116fbcee6dff2f1ecc422fbca5ef506fad6dd Reviewed-on: https://chromium-review.googlesource.com/c/1257671Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#596035}
-
Jun Mukai authored
HostedAppAshInteractiveUITest.MenuButtonClickable is flaky with SingleProcessMash, and I think it could be the case of unstable mouse location. When mouse move events occur during the test, then the last mouse location could change and then further mouse clicks occur on an unexpected location. UIControlsFactoryOzone can remember the last specified location and can use the remembered location for clicks. This will stabilize the HostedAppAshInteractiveUITest.MenuButtonClickable, and I hope others will get benefits. BUG=890953 TEST=locally interactive_ui_tests --enable-features=SingleProcessMash Change-Id: I3542a5a961dd4e7e8819e924d1d0c170c4dfaff1 Reviewed-on: https://chromium-review.googlesource.com/c/1255607 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Varun Khaneja authored
Bug: 881605 Change-Id: I55eba01698b7504420cd4c3a6e58f01e98cbad25 Reviewed-on: https://chromium-review.googlesource.com/c/1257811Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596033}
-
David Black authored
It was previously assumed that the WebViews owned by ManagedWebContents would not be deleted before the Assistant view hierarchy in ash. As it turns out, this is not always the case as identified by the reproduction steps outlined in the attached bugs. As such, we need to perform clean up safely whether ManagedWebContents WebViews are destroyed before or after Assistant views in ash. Bug: b:116821400, b:116814451 Change-Id: I982b327d45b22bcacef6e07489cb967eb36bcaf1 Reviewed-on: https://chromium-review.googlesource.com/c/1249569Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#596032}
-
David Trainor authored
This includes adding AspectRatioFrameLayout instead of SquareAsyncImageView (more properly handles the requirements of making Views square). This should be removed once we get proper support for ConstraintLayout. BUG=890530 Change-Id: I8a8dc7ae0772785a4cd0e11f555dfde53036a407 Reviewed-on: https://chromium-review.googlesource.com/c/1252332 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596031}
-
Mitsuru Oshima authored
Running CtsAccessibilityTestCases doesn't leave wide frame. Bug: 881672 Test: covered by unit test. Change-Id: Id9f9ee4b9a99b3f0e468458cb970c731a339ba93 Reviewed-on: https://chromium-review.googlesource.com/c/1257146 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#596030}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:789139 Change-Id: I0510481873b518b9465e7f7a54c859c666d666c0 Reviewed-on: https://chromium-review.googlesource.com/c/1258249Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596029}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df836ff8f17d..607f907d47b0 git log df836ff8f17d..607f907d47b0 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 tobine@google.com Vulkan: Add 565 configs for Android 2018-10-02 jmadill@chromium.org Optimize resolveLink. Created with: gclient setdep -r src/third_party/angle@607f907d47b0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I0ba4ccfaf6f728d8528564895d084bf128dbf5cd Reviewed-on: https://chromium-review.googlesource.com/c/1257712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596028}
-
Mustafa Emre Acer authored
LookalikeUrlNavigationObserver uses DidFinishNavigation event to observer navigations. This event is generated for all frames, so we need a proper check instead of a DCHECK in it. Bug: 889815 Change-Id: I699c32e45cc4f538fec515d22b3e5118d89a3d79 Reviewed-on: https://chromium-review.googlesource.com/c/1258062Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#596027}
-
Kevin Marshall authored
The NetworkChangeNotifier is ready to use, now let's actually use it. :) TEST=Exercised change event detection on Ethernet w/Acer Switch 12. Bug: 843443 Change-Id: I23c4ebbcb536dba55ee6b5b86ecdef775f90bd2f Reviewed-on: https://chromium-review.googlesource.com/c/1257548Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#596026}
-
bsheedy authored
Replaces characters that are unsupported by the performance dashboard with underscores in benchmarks that use WebVR and WebXR sample pages. This is so that the name reported on the dashboard can actually be used as a story filter when bisecting. Bug: 881017 Change-Id: Ifae260815a1382ce5dcab9e393ad8b0344ab0f86 Reviewed-on: https://chromium-review.googlesource.com/c/1252848Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596025}
-
Jun Choi authored
This prepares for https://crrev.com/c/1239621 Bug: 877344 Change-Id: Id857841551cf659c14747da36f91b9e848ae9c3e Reviewed-on: https://chromium-review.googlesource.com/c/1247142 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596024}
-
Kyle Milka authored
The declaration and reference of the variable used two different names resulting in a console error, and presumably incorrect behavior. Bug: None Change-Id: I94503c1dfa28b02efaf78f52762554d32672dff5 Reviewed-on: https://chromium-review.googlesource.com/c/1257664Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#596023}
-
Antonio Gomes authored
InitDataReductionProxySettings constructs DataReductionProxyService, which later on is provides data to DataReductionProxyIOData to construct DataReductionProxyConfig. Ultimately, DataReductionProxyConfig constructs WarmupURLFetcher instances. This CL is a preparation CL for [1], where we migrate WarmupURLFetcher from URLFetcher to SimpleURLLoader. In [1], |url loader factory| is mandatory to be non-null. Passing an actual instance at the beginning of the call chain now has no immediate effect, but is harmless too. [1] https://crrev.com/c/1251641 BUG=879777 Change-Id: I5165506e34e31b62a511d02b6e157f3554cc6594 Reviewed-on: https://chromium-review.googlesource.com/c/1256982Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Eric Roman authored
Bug: 759230 Change-Id: Ic94211a04bc97afd01097b099a42ad7d365f09cc Reviewed-on: https://chromium-review.googlesource.com/c/1244297Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#596021}
-
Rouslan Solomakhin authored
Bug: 891371 Change-Id: Iea90f598eac5693b6797efa9ca91cabf7b097326 Reviewed-on: https://chromium-review.googlesource.com/c/1258023 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#596020}
-
Douglas Creager authored
This adds test cases that verify that NEL reports are actually generated and uploaded when NEL is activated. We test both when the NEL policy is received through HTTPS response headers, and when they're preloaded in the Cronet experimental options config. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Id00f9095b04471a3adacc58f1fbf72b5c7848503 Reviewed-on: https://chromium-review.googlesource.com/c/1174564 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
-
sczs authored
-Moves c/b/ui/ntp/recent_tabs to c/b/ui/recent_tabs -Some small renaming. Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Idd006b4d7872a222aecd2d62b585b1d43ee42b89 Reviewed-on: https://chromium-review.googlesource.com/c/1237528 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596018}
-
John Chen authored
Update atoms with the latest version from Selenium, to fix several bugs, including fixing Clear Element for several input element types. Bug: chromedriver:1319 Change-Id: Ic6141712ba914f7b97d341dc9d4123fc25b05e50 Reviewed-on: https://chromium-review.googlesource.com/c/1258244Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#596017}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e8b02fb54234..7f47c50227fb git log e8b02fb54234..7f47c50227fb --date=short --no-merges --format='%ad %ae %s' 2018-10-02 thestig@chromium.org Use smart pointers in CPDF_PageRenderCache. 2018-10-02 thestig@chromium.org Remove dead code in CPDF_PageRenderCache::ResetBitmap(). 2018-10-02 thestig@chromium.org Fix nits in gold.py. 2018-10-02 thestig@chromium.org Retry fetching Gold JSON data. 2018-10-02 thestig@chromium.org Normalize widget bounding boxes when flattening. Created with: gclient setdep -r src/third_party/pdfium@7f47c50227fb The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:890322 TBR=dsinclair@chromium.org Change-Id: If12a958b7b098357410d253584fa959db17fd135 Reviewed-on: https://chromium-review.googlesource.com/c/1257708Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55b66b22475b..64ba5a302bf0 Created with: gclient setdep -r src-internal@64ba5a302bf0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: Iaecadef1d4ea85fafb88c1be040d565c29c8399b Reviewed-on: https://chromium-review.googlesource.com/c/1257611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596015}
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: If0224229b2bb6c6c848aba716cfc7faf89f34383 Reviewed-on: https://chromium-review.googlesource.com/c/1258054 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#596014}
-
Christopher Cameron authored
All mojo interfaces that manipulate NSViews need to be associated (for example, adding an NSView as a child of another requires that the parent NSView be in a known state -- each NSView has its own interface, and so they all need to be associated to the same pipe). Also change all bindings to use ui::WindowResizeHelperMac's task runner. This task runner is used to pump a nested run loop inside a Cocoa resize function (for smooth resize). All bindings on the same associated connection need to use that task runner (otherwise, all messages will be blocked behind any un-handled message). Change BridgeFactoryHost to not assign a new host id, but take one in the constructor (just because the logic is easier to follow that way). R=domonickn TBR=avi (for content/ OWNERship) Bug: 821651 Change-Id: Ifb6aff292187b340d144d29ffe1258bb8d501267 Reviewed-on: https://chromium-review.googlesource.com/c/1253561 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#596013}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/20afd180cccb..8775060263d6 git log 20afd180cccb..8775060263d6 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 saklein@chromium.org cros_sdk_lib: remove unused command. 2018-10-02 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8775060263d6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4f8a747ceac10257f943585db9cbec8cd04789e5 Reviewed-on: https://chromium-review.googlesource.com/c/1257711Reviewed-by:
-
Henrique Nakashima authored
OpenActions that navigate to URIs are going to be blocked when https://pdfium-review.googlesource.com/c/pdfium/+/42731 relands. It was reverted because this test was breaking and blocking the pdfium roll into chromium. The test will now click on a link in the PDF that navigates to the URI. Bug: 851821 Change-Id: I49853e99de7b989858b1962ad4a92a4168d4c2db Reviewed-on: https://chromium-review.googlesource.com/c/1244367 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596011}
-
