- 21 Jan, 2021 40 commits
-
-
Peter Kasting authored
Bug: 1159562 Change-Id: I701ebd786a6dcdb8a105fbb288eb74962b53b5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638086 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#845503}
-
Bartek Nowierski authored
Currently, on realloc expansion, GetSize() bytes are copied. This is the maximum size that an allocation can be stretched to within a slot, not the actual size available to the application at the moment. These are equivalent for small buckets, but not for single-slot slot spans where extras can be glued immediately after the allocation. The added test would fail without this fix. Change-Id: Ic83e79c11e0a5b3b70f5c90a0bd1f157cbeae703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636101Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845502}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd069a9188cc..08f5311ae142 2021-01-21 adlai@google.com Detemplatize render task clustering 2021-01-20 brianosman@google.com Remove "death" functions from particle system 2021-01-20 csmartdalton@google.com Reland "Disable the MSAA atlas mode for CCPR" 2021-01-20 bsalomon@google.com GrQuadUtils: Handle degenerate persp quads where edges intersect outside quad 2021-01-20 reed@google.com Enable new virtuals in flutter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1167277 Tbr: scroggo@google.com Change-Id: I6d4c48612388b777e423c24828c945bdc0efb2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641254Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845501}
-
Theo Johnson-kanu authored
Bug: 1093185 Change-Id: Id98b43b42586d3a858c3b40b86871a0664936451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641086Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#845500}
-
Takuto Ikuta authored
This reverts commit 78d95924. Reason for revert: This fixes previous failure and has a test Original change's description: > Revert "trigger_scripts: support go client in chromeos_device_trigger" > > This reverts commit 3fd9ba25. > > Reason for revert: > https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071 > > Original change's description: > > trigger_scripts: support go client in chromeos_device_trigger > > > > This scripts needs json conversion similar to > > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62 > > when using go client. > > > > This is fix for breakage like > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 > > > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > > Bug: 1127205 > > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275 > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#844979} > > TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com > > Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1127205 > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844987} # Not skipping CQ checks because this is a reland. Bug: 1127205 Change-Id: I6b408eed0dbf16608b6ee7084ec093ff4ab51233 Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639441 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845499}
-
Hayato Ito authored
A follow-up to https://crrev.com/c/2617167. Note that the test fails in the current implementation. See the https://crbug.com/1168449 for details. The test is now marked as Timeout. Bug: 1149816, 1168449 Change-Id: I2552f64ea12ac5030c9740f30a94edef2760986c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639337Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#845498}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3c06205b28b..477bd92472cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2ed90df686df83d6c6ce167e08e2efcc24dd168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641338Reviewed-by:
-
Yuta Hijikata authored
This change is a mechanical change replacing is_chromeos with is_chromeos_ash. This is in preparation to switching lacros from target_os="linux" to target_os="chromeos". More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I1324b2733d438d2fe62eaa54363b364ad0257862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628631Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#845496}
-
Timothy Loh authored
This CL factors out the duplication for file sharing and USB sharing to Crostini and Plugin VM into a new GuestOsBrowserProxy. To make this work, the new proxy requires the VM name for all operations now, and the USB devices changed observer event no longer determines which devices are shared with the specific VM but instead returns which VM devices are shared with (if any). The duplication between the html and js pages will be dealt with in later CLs. Bug: 1167980 Change-Id: Ieeebb01318c25b299773c216da86112e049e1b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635387 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845495}
-
Ian Kilpatrick authored
As above. This patch implements the core content alignment logic. E.g. determining the offset at which the tracks should start, and the space between them (gutter-size - this include the grid-gap if any). Creates a new struct "TrackAlignmentGeometry" which contains these two values. Effectively the process is now: GridGap -> TrackAlignmentGeometry -> SetOffsets. The most significant difference is that TrackAlignmentGeometry includes the grid-gap, and the BorderScrollPadding start offset. Bug: 1045599 Change-Id: Idb4d550f0d8b2aca306945a46d41b5a30a20bca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622586 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845494}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611165592-f4f825a470f7704c21486baf150746af41ae52eb.profdata to chrome-linux-master-1611187144-41a088ce50b040cc139b89be9e9a13dad4a09053.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4eba22a7de49019b128ce8aa8def4768c34a383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641529Reviewed-by:
-
edchin authored
This CL makes it easier/clearer to split up PasswordProtectionRequest in a future CL. Android-only code that depends on WebContents is extracted to a standalone method - SetReferringAppInfo. The content derived class implementation of PasswordProtectionRequest will have access to WebContents and the method will be moved there in a future CL. Bug: 1147967 Change-Id: Ic38c933cb8d633bbef77c7b36460aa140bc55a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637403 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#845492}
-
paulzhchen authored
pass browser_tests --gtest_filter=ApplicationLaunchBrowserTest*, pass browser_tests --gtest_filter=All/SystemWebAppManagerNonResizeableWindowTest*, Bug: b/175974902, b/176472645 Test: Tested that SWA is not resizeable, Change-Id: I9a69d16ce6b7b85ed5b14ed340bf99fe75793308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620923 Commit-Queue: Paulz Chen <paulzchen@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Daniel Nishi <dhnishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845491}
-
Tibor Goldschwendt authored
Makes the logo Finch-configurable. Flag is enabled by default. Bug: 1168361 Change-Id: Ie9fbeebb5f88fcf6ca2d6a418759f65e61d3231e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639153 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845490}
-
Yuke Liao authored
This CL fixes errors where cros_is_vm and is_tast are undefined in an ebuild environment. Bug: 1168623, 1158590 Change-Id: I75ee6a9ed0b558787092bd6194a41515b1b0b50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639309 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#845489}
-
Aaron Colwell authored
RenderViewHost::GetSiteInstance() is being removed from the codebase so this change replaces the calls in the NaCL code with equivalent calls on the RenderFrameHost. This should not introduce any behavior changes since the SiteInstances for these two objects are always the same. Bug: 1166021 Change-Id: I0bf0c875e0734c986298f1578604a87a994fe020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631986Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#845488}
-
Jimmy Gong authored
This flag is used to convey whether external PCI devices are allowed. It is disabled by default. Bug: b:176763484 Change-Id: I51b596b3508816d7a43867e986ed9536524bc18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638525 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#845487}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611165592-ce7a0617ff859a9176e865c0be149d7728639a62.profdata to chrome-mac-master-1611187144-39ea136b6ebfd3c490dd8e8da57ed07347596a8e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia1fec695aa30a9ad0e09cccc6303507dd113bc4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641526Reviewed-by:
-
Ye Kuang authored
Bug: 1141780 Change-Id: Ia382cbd802155af3a2fa75da7040e12a6cffd97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639716Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#845485}
-
Jinsuk Kim authored
Omnibox is an element of the toolbar. The toolbar knows about elements, has references to them for instantiation/use. But each element doesn't need to know the toolbar, which is also desirable for the modularization's sake. This CL removes omnibox's references to toolbar. - Moves toolbar.NewTabPageDelegate to omnibox/ - Moves/duplicates some constants Bug: 1127732 Change-Id: I91488977f74cc8a97d23a4924ae2ed5644f9eb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636822 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#845484}
-
Nancy Wang authored
Modify FullRestoreReadHandler to get the window information from the restore data read from the full restore file. BUG=1146900 Change-Id: Idf18d6ba486011f63e0893ff7c9bb8078b9c9e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639425 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#845483}
-
Toni Barzic authored
When rolling default set of apps pinned to shelf, chrome_launcher_prefs would check whether it's safe to do so using IsSafeToApplyDefaultPinLayout(). One of conditions was verifying that the app list sync has already started (to avoid getting default pinned apps getting later overridden by an update from app list sync). This does not work if sync is disabled for the profile, as in that case sync would never start, so default apps roll would be delayed indefinitely. For example, this may happen when logging in using a fake user (by bypassing full login flow in test environments, or on linux-chromeos). This updates the logic in IsSafeToApplyDefaultPinLayout() to allow rolling default pinned apps if sync is disabled. This matches the logic that's already in place for OS settings with split settings feature enabled. TEST=Run linux-chromeos with a fresh user data dir, and with no --login-manager flag. Verify that both Chrome and Files app are pinned to the shelf by default (both with SplitSettingsSync feature enabled and disabled). BUG=1166063,1154486 Change-Id: I8293b7a26447e5b5299b447984ce63417ead7653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640308Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845482}
-
Leonid Baraz authored
The tests were unstable before, now we only check resources at the test fixture tear down, not upon every storage reset (some uploads may still be ongoing at that time). Bug: b:159361496 Change-Id: Iec90ca2c994a019abfc66cfb70dee77b2ce627f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641087 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#845481}
-
Hui Yingst authored
OutOfProcessInstance::OnGeometryChanged() recalculates the available area and background parts upon geometry changes, then notifies the pdf engine and updates accessibility information for the viewport. Since PdfViewWebPlugin needs to share the functionality of recalculating areas and notifying the pdf engine, this CL wraps the shared code into RecalculateAreas() and migrate it into PdfViewPluginBase. This change also allows mutable_available_area() to be removed since `available_area_` now can be accessed directly in PdfViewPluginBase. Bug: 1140629 Change-Id: Ie0196908fa4f2b948298beb5194757134ec4ba19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626036Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845480}
-
Xianzhu Wang authored
TEST=http/tests/inspector-protocol/page/page-captureScreenshot-clip.js TEST=headless_browsertests Bug: 1164610 Change-Id: I58c2c27d6793cd59605c42600060801e67127743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636883Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845479}
-
Michael Crouse authored
This is a reland of a4df03d0 This addresses the revert by removing neon from the TFLite build for chromeos. Original change's description: > [TFLite] Enable tflite in build for android and desktop. > > Bug: 1165517 > Binary-Size: Expected increase due to inclusion of TFLite in binary. > Change-Id: I1c4c7b26f257c152d9477855ad32a77c0d30b85f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616241 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845026} Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Bug: 1165517 Binary-Size: Expected increase due to inclusion of TFLite in binary. TBR: Andrew Grieve <agrieve@chromium.org> TBR: Tarun Bansal <tbansal@chromium.org> Change-Id: I4b6b21b4a23a0c6978bfbb57150e9bf81300059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639648 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#845478}
-
Will Cassella authored
The previous logic for what intrinsic size to give to a video element was based on outdated spec text, this CL updates it to prevent the poster image from resizing between starting playback and the first video frame being rendered. Bug: 1154296 Change-Id: I41a91f6672d8ccf4e3069afe581fac39f1a58820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617870 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845477}
-
Martin Kreichgauer authored
This changes the ChromeOS platform authenticator to be available in Incognito mode (but not Guest modes), same as the macOS platform authenticator already behaves. During makeCredential requests, an extra interstitial is shown that prompts the user to confirm that the credential will outlive the Incognito session. Strings in that dialog are changed to be platform agnostic. (They also outdatedly referred to the macOS platform authenticator as "Touch ID"). UXW doc: https://docs.google.com/document/d/19zW_FbD8mLBMc-Tfvg6GT632UQaC9IGn2kqQkI_FaxM/edit Bug: 1157651,1111095 Change-Id: I3aca0e7e16fd763e39190536d63bcfcc0cb5dc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587789 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#845476}
-
Josh Nohle authored
Log whether or not a remote device is able to be discovered from a given advertisement. We also log the candidate remote device's device ID and beacon seeds to ensure that the remote device record is not stale. We log times in human-readable format. Bug: 1157278 Change-Id: I202f9f1a13deba998ddff06dd9ca82b92737abae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639649 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845475}
-
Alison Maher authored
When investigating CL:2627779, I had noticed a few other color properties we weren't adjusting for in forced colors mode: stop-color, flood-color, and lighting-color. In most cases, this shouldn't make a difference since SVG elements are set to 'forced-color-adjust: none' by default, but I figured these would be good to include for consistency. Bug: 1166911 Change-Id: I47d16b20309565d28e24e1410115b5a36f22a662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633944Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845474}
-
Olivier Yiptong authored
This change restricts the fonts displayed to the user when a chooser is shown. This constraint to the list is implemented as an exact-match with items supplied in a list with the postscript names of the available fonts. Fixed: 1164077 Change-Id: If3e3e0cba91de83bc0a39ffe382f13cb38f7be35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626117 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845473}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/124f532d052d..ec4d81245d2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harringtond@google.com,keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968 Tbr: harringtond@google.com,keishi@google.com Change-Id: Idc72ac2fe7dd1d1710b431a0327a487b6790e6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641274Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845472}
-
Peter Kasting authored
Bug: 1159562 Change-Id: Iff9c81a9b640255d4e5c22c0a42cfc44c37607d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634011 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
David Black authored
Insets and child spacing were off by a little. Bug: 1168813 Change-Id: I5b0d80d5d255aeda6ba103d43645465cc4125864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641337Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#845470}
-
Aaron Krajeski authored
(Hopefully) the final part of the greater effort to migrate the paint_op_buffer away from SkMatrix, which is 3x3 and relatively slow, towards to SkM44. Two functions were added to paint op buffer in previous Cls, Concat44 https://chromium-review.googlesource.com/c/chromium/src/+/2577704 SetMatrix44 https://chromium-review.googlesource.com/c/chromium/src/+/2562783 Each of these take an SkM44 as an argument instead of an SkMatrix. This CL changes the implementation of RecordPaintCanvas::setMatrix so that it always ends up sending an SkM44 to the paint op buffer and removes the older implementation of SetMatrixOp (that used an SkMatrix). Now there is only one setMatrix operation in the paint op buffer. Bug: 1155544, 1167153, 1140535 Change-Id: I1112bf9a4e429a80c9f5c4265959c84aaf1633d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640814Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#845469}
-
Victor Costan authored
* Fix potential data races while accessing the `QuotaManagerProxy::manager_` pointer. Also add GUARDED_BY_CONTEXT() annotations to prevent similar issues in the future. * Remove the friendship between QuotaManager and QuotaManagerProxy. This was needed for direct access to the `QuotaManagerProxy::manager_` pointer, which is replaced with an explicit API restricted to QuotaManager via base::PassKey. * Replace the browser-specific `io_thread_` member name with the more semantically useful `quota_manager_task_runner_`. * Reduce the space of possible states by requiring that the TaskRunner member is always non-null. No functional changes are introduced, asides from the data race fixes. Bug: 1168597 Change-Id: Ia0831a9c68a215084a65013296e5749948081d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637953 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#845468}
-
Harvey Yang authored
As IIO Service won't close Mojo connections without a valid reason, the code should assume IIO Service crashes on Mojo disconnects instead of trying to reconnect. BUG=b:172414302 TEST=unit tests and run on kohaku Change-Id: I12b6a6ed7d0b044196505116acd662b6de330cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599682Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845467}
-
Jan Krcal authored
This is a reland of bedb24da Original change's description: > [Profile creation] Add {back,reload} accelerators for navigation > > This CL adds two accelerators into the profile creation flow to improve > accessibility and usability: > - the back action for screens that actually show the back button > - the reload action for the sign-in flow that happens over the internet > and thus loading of the page can fail. > > Bug: 1126913, 1167675 > Change-Id: I3c197dea2859c0136db62249064249e0569a93da > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627403 > Auto-Submit: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844695} Bug: 1126913 Bug: 1167675 Change-Id: I1763dcd1663cddcfce901a6954381a40142c705e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637475 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845466}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc0d6b82f912..beb8370c49f2 2021-01-21 fancl@chromium.org E-Divisive: Improve permutation test and Estimator If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: Id3b347011455a9473a7d1ff098b265cc656886b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640835Reviewed-by:
-
David Tseng authored
Do this to address possible issues with document.body availability. R=katie@chromium.org Test: manual. Change-Id: I42a727829a8552de1609bdc8b3af2f10503c4121 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640730Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845464}
-
