- 18 Jun, 2019 40 commits
-
-
Alex Ilin authored
This CL makes it possible to disable the checkbox for extended Safe Browsing reporting from Java. Bug: 938902 Change-Id: I82eaa03094cd75cd3da4dc3235dfc7bd681d29f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660862 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#670011}
-
Koji Ishii authored
This patch fixes |ClearNeedsLayout| for CR (U+000D) and FF (U+000C). These were overlooked when |ClearNeedsLayout| was moved from |NGInlineItemsBuilder| to |NGLineBreaker| and |NGInlineLayoutAlgorithm|. Bug: 971811 Change-Id: Ie3d9d3d11e35a7ed3458bb8b96d2fa68bf9c37a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663478Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#670010}
-
Raphael Kubo da Costa authored
This CL contains the permission handling parts while not making the Wake Lock API implementation in Blink connect to them yet. * On the Blink side, add WakeLockPermissionDescriptor from the spec, and make the Permissions API support it. It extends PermissionDescriptor with a |type| member indicating the wake lock type. * The two different wake lock types are represented in content/ as PermissionType::WAKE_LOCK_SCREEN, PermissionType::WAKE_LOCK_SYSTEM, CONTENT_SETTINGS_TYPE_WAKE_LOCK_SCREEN and CONTENT_SETTINGS_TYPE_WAKE_LOCK_SYSTEM. The actual policy right now is very simple: * None of the wake lock types show any sort of permission UI. * Screen lock requests are always granted (since they are similar to e.g. screen locks acquired for video playback which currently do not require any user consent). * System locks are currently always denied while we figure out the best way to request permission to the user. Bug: 967669 Change-Id: I9d404ff7c5430ae1e4cec2140ee51abd83ce44ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652939Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#670009}
-
Michael Starzinger authored
R=titzer@chromium.org,jwd@chromium.org BUG=chromium:969997 Change-Id: I687f0280d2900dcc1f01a6ca5802d78b52901ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660337Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#670008}
-
Sam McNally authored
Change-Id: Ia1448bb7943e66099e655779b47cd143f4714cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662101 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#670007}
-
Dominik Röttsches authored
As preparation for ramp up in beta, start exposing the feature on performance bots across all platforms now that the Windows 7 & 8 indexing implementation seems to be solid in terms of indexing performance and scheduling. Bug: 828317 Change-Id: Iae4722f7e19feb4e46f5f5507483e50751e448a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662555Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#670006}
-
Kunihiko Sakamoto authored
This fixes a crash bug where cancellation of font loading causes promise rejection inside a ScriptForbiddenScope, when the loading is cancelled inside Document::Shutdown(). To prevent this, this patch adds an early return to RemoteFontFaceSource::NotifyFinished() when the document is not active. This is a short term fix to be merged for M76. Bug: 960290 Change-Id: I9f8b18fe489c2224ebbf445ad25445b7769c3336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661313 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#670005}
-
Jochen Eisinger authored
Bug: 971854 Change-Id: I6c580687e4f3705469c52f2372810c71635c2feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664072Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#670004}
-
Alan Cutter authored
This parameter is never true. Bug: 904566 Change-Id: Icef0fd3d416f3c41062bea03e05aa09a96055bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638203 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#670003}
-
Clemens Arbesser authored
http://crrev/c/1614967 moved Image fetcher, one of our dependencies, to the lib/ layer, without modifying our DEPS files. This CL adds the missing entries. Change-Id: I0e7425d39e4ad558f6943b34f9c1b6399b912958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660561Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#670002}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d579c0a7d45a..a9b00ac5d588 git log d579c0a7d45a..a9b00ac5d588 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 johnkslang@users.noreply.github.com Merge pull request #1806 from KhronosGroup/nan-clamp 2019-06-18 johnkslang@users.noreply.github.com Merge pull request #1698 from jeffbolznv/private_storage_variables Created with: gclient setdep -r src/third_party/glslang/src@a9b00ac5d588 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I57cc0a084d927f0a82c4912b738c31a957fcf6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662954Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670001}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1dee91aec9a6..61d8ee10b611 git log 1dee91aec9a6..61d8ee10b611 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2ce8c837..6ae0f0cd (669595:669703) 2019-06-17 srte@webrtc.org Adds SortedByReceiveTime to TransportPacketsFeedback. 2019-06-17 terelius@webrtc.org Fix event_log_visualizer help text and default profile. 2019-06-17 sprang@webrtc.org Add TrySendPacket() method to RTP modules. 2019-06-17 eladalon@webrtc.org Add Clone() to Vp8FrameBufferControllerFactory Created with: gclient setdep -r src/third_party/webrtc@61d8ee10b611 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0895508a9ce60390930662bb5edfcb9403a239bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663912Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670000}
-
Mohamed Abdelhalim authored
Replace NavigationController::GetVisibleEntry with NavigationController::GetLastCommittedEntry when it is safe. Bug: 853705 Change-Id: I3aa0fa65b14a4cab401c4a9037c4e8a911072f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631283 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#669999}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2baf86e86ee2..396982cd6b1e git log 2baf86e86ee2..396982cd6b1e --date=short --no-merges --format='%ad %ae %s' 2019-06-18 treehugger-gerrit@google.com Merge "trace_processor_shell: Clean up formatting of --help" Created with: gclient setdep -r src/third_party/perfetto@396982cd6b1e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9cd4c0ec6231fe0c3cd3d38d9a3e00f876f5dcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663915Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669998}
-
Mario Sanchez Prada authored
Don't include that internal header from identity_manager.h (which is public) and simply include oauth2_token_service_observer.h instead, which does not pose any problem since the methods that will allow adding / remover O2TS observers will not be exposed publicly anyway. Bug: 967619 Change-Id: I0f31eca66a2ad56669f78bc201c09125364a66a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660344Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#669997}
-
Wei-Yin Chen (陳威尹) authored
A ViewResourceAdapter is used to show the Grid Tab Switcher (GTS) in the background when playing the Tab-to-Grid transition animation. After the animation is done, the Java-side bitmap is released in https://crrev.com/c/1636833 and https://crrev.com/c/1639150, but the native-side bitmap is kept, wasting ~3MB of native memory on high-end phones (assuming downsampling scale = 0.5). The effects on performance (frame rate, max frame interval, etc) are within error margin. Bug: 971281 Change-Id: I9b29a91cb593c46505f1d2be29f7d3dd5e12feb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645458 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669996}
-
Takuto Ikuta authored
bots are added in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1397329 Bug: 954450, 956776 Change-Id: I1e7d92c4ee23e6d96cc327410b1cb8083ceea101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662248 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#669995}
-
Mario Sanchez Prada authored
Make sure we use identity::ScopeSet everywhere so that we don't need to depend on oauth2_token_service.h anymore, allowing us to remove that include in a follow-up CL. Also, normalize the way we refer to this definition without using the namespace qualifier, instead of having half of the places specifying it and the other half not doing it. Bug: 967619 Change-Id: I86f6426b4489f5ce7e856fe3e1cadc6885c8b336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662554 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#669994}
-
Christopher Cameron authored
Add three very large crash keys (8k each) for - the shader source during -[MTLDevice newLibraryWithSource...] - the vertex and fragment shader source during -[MTLDevice newRenderPipelineStateWithDescriptor...] We are seeing an alarming number of GPU process hangs inside these functions. A theory is that there are particular shaders that cause pathological compile times. This should give is some visibility into the validity of this theory. Bug: 974219 Change-Id: I328fa8ccf732cf2d0d96a58d6d6d68b280322b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662504Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669993}
-
Julie Jeongeun Kim authored
This CL removes "fetch" prefixes from URLRequest members. It renames types in //services/network/public/mojom/fetch_api.mojom, FetchRequestMode to RequestMode, FetchRedirectMode to RedirectMode and FetchCredentialsMode to CredentialsMode and members in URLRequest, network::ResourceRequest, blink::ResrouceRequest, fetch_request_mode to mode, fetch_redirect_mode to redirect_mode and fetch_credentials_mode to credentials_mode. It also renames their accessors and variables together. TBR=xhwang@chromium.org,blundell@chromium.org Bug: 966705 Change-Id: Ie9d6958c613efa7afeac067fd09c577fcd2612f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660393 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#669992}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9b4c88672fd..a07feb5445f0 Created with: gclient setdep -r src-internal@a07feb5445f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I49871516b3c79a80404bbebd75a8347a77423c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669991}
-
Sam McNally authored
Change-Id: I00b15eff07ec1867bf2c2fa5bcf27c363ac076e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662982Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#669990}
-
Kouhei Ueno authored
Bug: 972960, 961674 Change-Id: Iff5c464dcc5227f211462f0e1b70c938fab452c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654370 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#669989}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2935638a1b16..f1dd7a174af8 git log 2935638a1b16..f1dd7a174af8 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8c12f564113c..9283b2559c05 (14 commits) 2019-06-18 herb@google.com Remove all global mutexes 2019-06-18 mtklein@google.com enable SkVM JIT testing on x86-64 Linux bots 2019-06-18 mtklein@google.com centralize and force-inline unaligned_{load,store} 2019-06-17 csmartdalton@google.com Add a "preferredInternalSampleCount" cap 2019-06-17 reed@google.com add motion blur params to skottie2movie 2019-06-17 brianosman@google.com Add some precision back to timestamps when using --trace 2019-06-17 brianosman@google.com Shuffle SkSL sources around so compiler and bytecode can be used w/o GPU 2019-06-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-06-17 benjaminwagner@google.com Omit build number for LenovoYogaC630 os dimension Created with: gclient setdep -r src/third_party/skia@f1dd7a174af8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:974542 TBR=bsalomon@google.com Change-Id: I9ddd27b313a8eb5fc3e590c8fa1e55891b883cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663822Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669988}
-
Alan Cutter authored
This reverts commit 8fa57643. Reason for revert: Broke MSAN build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13546 AccessibilityFocusRingControllerTest.SetFocusRingCorrectRingGroup ==677==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55ee18481b14 in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) Original change's description: > mash cleanup: Remove accessibility_focus_ring_controller.mojom > > Replace mojom with an abstract singleton controller, c++ struct & enums. > Update impl & tests, expose a protected static helper for simplicity. > Remove an unnecessary test subclass, unit test passes without this. > > Bug: 958129 > Test: Automated; no accessibility focus ring regressions. > Change-Id: I34acd91fa9e093309a89edf74e2395d5de5ec2c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660107 > Auto-Submit: Michael Wasserman <msw@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669869} TBR=sky@chromium.org,msw@chromium.org,tsepez@chromium.org Change-Id: I8a566ffc0cef5bd828c8be3ce1ce5dd1624d8b33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662985Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#669987}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6c289da452c..0c9a952c8f7d git log f6c289da452c..0c9a952c8f7d --date=short --no-merges --format='%ad %ae %s' 2019-06-18 a-v-y@yandex-team.ru Fixed symbolize of win traces with breakpad syms performed on linux Created with: gclient setdep -r src/third_party/catapult@0c9a952c8f7d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:797843 TBR=eyaich@google.com Change-Id: Idef6eb6f006a1c663062d63d342d9561092e9cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663827Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669986}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/83ce6ba1..2edb1963 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6c88c4611d2e6f62704f39fefb75539e91818cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663041Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669985}
-
Nicholas Hollingum authored
We originally created the wayland aux dir to store the tools used to interface with wayland, however later on we moved to Jinja which made it more convenient to keep the wayland tools closer to the source. This CL replicates the historic functionality of wayland_aux under the fuzzer/ directory and removes the old aux tools. Bug: 961564 Change-Id: I60394f66fb6399fd1e2bd3dfe2d6d051006f3409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662091 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#669984}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9db72785beb3..d579c0a7d45a git log 9db72785beb3..d579c0a7d45a --date=short --no-merges --format='%ad %ae %s' 2019-06-18 cepheus@frii.com Bump revision. Created with: gclient setdep -r src/third_party/glslang/src@d579c0a7d45a The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ib9577bd05b682250467055f29b77b4af3abe95df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663821Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669983}
-
Jérôme Lebel authored
Removing the deprecated API to open Account Settings Manager. Related to: crrev.com/c/1349969 (Adding new API in ChromeIdentityService) crrev.com/i/721689 (Implementation in ChromeIdentityServiceImpl) crrev.com/c/1350630 (Switching to the new API) crrev.com/i/721693 (Removing old implementation in ChromeIdentityServiceImpl) Bug: 905680 Change-Id: Id3d95331035290a80f32fd139c499430e53243c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1350185 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#669982}
-
Joel Einbinder authored
select elements were incorrectly relying on chromeSelect.svg, which doesn't exist yet. Simimlarly, code folding was relying on the png version of treeoutline triangles. Change-Id: Id2f27a1800a5070e5eaa607260328f14cb06c582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663322Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#669981}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c211c2f5b59d..b1c8dbf3fad8 git log c211c2f5b59d..b1c8dbf3fad8 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 syoussefi@chromium.org Vulkan: Correct synchronization for buffer readback Created with: gclient setdep -r src/third_party/angle@b1c8dbf3fad8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I5a5bb3ab00d4c069894ad4315a3a624a3be2ed30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663820Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669980}
-
Gayane Petrosyan authored
This CL also adds add placeholder for the text. example: https://screenshot.googleplex.com/6V9VX9WBywe.png https://screenshot.googleplex.com/U1MUKZJcFeO.png Bug: 960982 Change-Id: I88b5f6410590219282952593c1ba5060d67dc972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662637Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#669979}
-
Nikita Podguzov authored
Bug: 848942 Change-Id: Ibfb613229cc004c64d98ccf58d37c34d566a0be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662453Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#669978}
-
Antonio Gomes authored
... as it is not specific to webrtc. BUG=577874,704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I4357d66c198acb2911a6ea3ec1e65bb443ca23c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661609 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#669977}
-
Alex Danilo authored
This CL implements a summary panel that shows progress of any progress panel items being hosted by the display panel. The display panel can host any number of child panel items, so the summary panel shows the number of hosted panel items, and the average progress of them in it's summary progress indicator. The summary panel is created and destroyed as a result of adding or removing progress panel items. This CL also adds a listener to allow the panel items to be hidden or expanded into view, and stores the parent display panel reference as 'parent' in each panel item when it's instantiated. Bug: 947388 Change-Id: I90105415d5171063a970631d7f9208564a12a47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657081Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669976}
-
Khushal authored
This reverts commit bf62d746. Reason for revert: Failing build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-rel/13861 Original change's description: > [ChromeDriver] Element Send Keys: support content editable; fix text input type > > The email input type being considered a text input caused bugs and crashes. > In this commit it is removed from textControlTypes and thus no longer > considered a text input. > > Also added support for content editable > elements in compliance with the following W3C procedure: > "Set the text insertion caret after any child content." > Added test to run_py_test to test correct functionality. > > R=crouleau@chromium.org, johnchen@chromium.org > > Bug: chromedriver:2704 > Change-Id: I95bb9ff2396aa0e6bdfa35dde33f338be83607b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658966 > Commit-Queue: Julian Kung <juliankung@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669828} TBR=crouleau@chromium.org,johnchen@chromium.org,juliankung@google.com Change-Id: I170529bb765a3a7f8c2c2290ac9fcf2052199077 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:2704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663207Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#669975}
-
Christopher Cameron authored
Serialization of blink::WebInputEvent failed to take into account needs_wheel_event. It also appears to drop a bunch of other information on the floor as well. There is a comment in web_gesture_event.h that // Note that for the pinch event types, |needs_wheel_event| and // |zoom_disabled| are browser side implementation details for // touchpad pinch zoom. From the renderer's perspective, both // are always false. Implementing this renderer assumption by not faithfully serializing the events seems inappropriate. Bug: 957334 Change-Id: I4095bc4d4cff9dedf752fc0a09b391f5aa4ed72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657079Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669974}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99a2bf5facef..b9b4c88672fd Created with: gclient setdep -r src-internal@b9b4c88672fd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I77a613bc7d669d3375dc4496681b85b3a41049a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663873Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669973}
-
Christopher Cameron authored
A number of bugs have come out of the fact that content::NativeWebKeyboardEvent appears to provide a mechanism to pass an NSEvent across processes via NSEvent -> content::NativeWebKeyboardEvent -> (mojo) -> content::NativeWebKeyboardEvent -> NSEvent In practice, the NSEvent reconstructed after the content::NativeWebKeyboardEvent was passed over mojo is not even remotely accurate. Add helper functions to serialize NSEvents using the OS-provided CGEventCreateData and CGEventCreateFromData functions. When passing a content::NativeWebKeyboardEvent over mojo, pass the serialization alongside it, and replace the result's os_event. Use this approach instead of updating the mojo serialization for content::NativeWebKeyboardEvent because we don't want to be calling CGEventCreateFromData on data sent from the renderer process. Remove the accumulated workarounds for these issues. R=dominickn TBR=avi (content/ OWNERship) Bug: 919167, 943197, 964052, 942690 Change-Id: Ie7321229daf34629ddc9037ab733b40828bc62c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659662 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#669972}
-