- 23 Jan, 2018 40 commits
-
-
Dominic Mazzoni authored
It's not necessary, as a role of "button" with the "has pop up" state is fully supported and sufficient. The button_drop_down role wasn't even being mapped correctly on Windows, leading to inconsistent feedback with some screen readers. Bug: 766856 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib7f631a759ab44ffc3307204bcc74a9471afc22a Reviewed-on: https://chromium-review.googlesource.com/842475Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531363}
-
Doug Arnett authored
Logs when a previews type is committed or the Cache-Control:no-transform directive is seen to the intervention-internals page Log tab. Bug: 799653 Change-Id: Ia796cbfa086a723bfe205303d0c53d19c98b6975 Reviewed-on: https://chromium-review.googlesource.com/874490Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#531362}
-
bsheedy authored
Ports most of WebVrInputTest to WebXrInputTest. Currently does not port testControllerClicksRegisteredOnDaydream, testScreenTapsRegisteredOnCardboard, or testFocusUpdatesSynchronously since they rely on things in WebVR that don't currently have an implemented equivalent in WebXR (input and autopresent). Bug: 804043 Change-Id: I028de411cd7bf6d9ecc931a276052961d96864d4 Reviewed-on: https://chromium-review.googlesource.com/881834Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531361}
-
Kayce Basques authored
Bug: 801271 Change-Id: I4dd17eb097e9d5992717a9127df8d5f7995dace4 Reviewed-on: https://chromium-review.googlesource.com/862364Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Kayce Basques <kayce@chromium.org> Cr-Commit-Position: refs/heads/master@{#531360}
-
Weidong Guo authored
This is a reland of f44d3b6d. Original change's description: > Reland "New style app launcher folder" > > This is a reland of 14bacdda. > > Original change's description: > > New style app launcher folder > > > > Changes: > > 1.Enable pagination in folder > > * Maximum 16 items in one page and maximum 3 pages. > > * Make PageSwitcher support growing both vertically and horizontally. > > * Add PageSwitcher in folder view. > > > > 2.Add a invisible FolderBackground so that the user can tap/click > > outside folder to exit it. > > > > 3.Make folder size dynamically change based on items number within it > > * Shape the folder close to a square (cols_num := sqrt(apps_num - 1) + 1). > > * Align the opened folder’s center with the closed folder’s (folder icon) > > center. Then adjust the folder bounds to fit inside its parent view. > > > > 4.Change other small UIs based on specs. > > > > 5.Add test coverage: > > * Click folder background to exit folder. > > * Page resets to 0 when reopen a folder. > > * Folder cols and rows for different number of items within it. > > > > 6.Fix test for focus movement inside folder and maximum number of apps > > within a folder. > > > > Design doc: > > go/applist-folder > > > > Specs: > > Please check crbug.com/796370 > > > > Implementation video: > > https://www.youtube.com/watch?v=E-LyaZLoS90 > > > > Bug: 796370 > > Change-Id: I33250b40b3c5021301d71c8e877e9d1f73afa100 > > Reviewed-on: https://chromium-review.googlesource.com/835283 > > Commit-Queue: Weidong Guo <weidongg@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#530803} > > TBR=xiyuan@chromium.org > > Bug: 796370 > Change-Id: Icfc08e87b929a4a2eec9c9bb592df00289be2f7d > Reviewed-on: https://chromium-review.googlesource.com/878983 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530920} Bug: 796370 Change-Id: I746c2c7552b96561344c974cbe65daa70aa80e44 Reviewed-on: https://chromium-review.googlesource.com/881275 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531359}
-
Scott Violet authored
This is a precursor to loading local state, about flags and field trials earlier, before BrowserProcess has been created. BUG=800358 TEST=none Change-Id: I647643d81702d6520401729916ed0a9f8311e5af Reviewed-on: https://chromium-review.googlesource.com/879029Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#531358}
-
Mohamad Ahmadi authored
Bug: 799031, 684139 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3dbb7c648c4ac1ceebba4e6ff819a032287cddbc Reviewed-on: https://chromium-review.googlesource.com/876999Reviewed-by:
Mike Baxley <baxley@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531357}
-
Manuel Rego Casasnovas authored
This patch adds percentage support to column-gap property. Most of the changes are related to the parsing logic, the column-gap property now accepts both length and percentages, on top of the "normal" initial value. A new utility class GapLength has been added, as it'll be useful to implement row-gap in the future. Apart from that the muticolumn layout code has been modified to resolve the percentage gaps (treating them as zero while computing preferred widths) and resolving them during layout. This doesn't follow the current text on the spec, but there is an ongoing discussion that might cause the text is changed: https://github.com/w3c/csswg-drafts/issues/509#issuecomment-355242101 We could update the implementation once we have a definitive answer from the CSS WG. Added a new WPT test to check the behavior under different sizing conditions. BUG=799413 TEST=external/wpt/css/css-multicol/multicol-gap-percentage-001.html Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Icccd046e913353b6f525481046a41ad125aea5ff Reviewed-on: https://chromium-review.googlesource.com/878199Reviewed-by:
meade_(do not use) <meade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#531356}
-
Joe Downing authored
This reverts commit dacf14c4. Reason for revert: Causing failure on Linux MSAN builder: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/7431 Original change's description: > Mac: teach GpuMemoryBufferVideoFramePool to handle XR30 > > This CL teaches GpuMemoryBufferVideoFramePool to handle XR30 > formats, when context capabilities' image_xr30 is enabled > and the incoming data is of 10 bit per component type. > > This CL also enables the necessary checks in the gles2 and > GpuMemoryBuffer support to recongnise this format in Mac only > (other platforms coming soon). > > Test with high bit depth videos e.g.: > 'http://crosvideo.appspot.com?codec=vp9.2&loop=true' > and media/test/data/... > - bear-320x180-hi10p-vp9.webm > - bear-320x180-hi10p.mp4 (this is an H.264 part 10, 10bpc) > - blackwhite_yuv420p_hi10p.mp4 > - bear-320x180-hi12p-vp9.webm > > Also covered in e.g. content_browsertests' > MediaColorTest.Yuv420pHighBitDepth > which would fail if the colors were inverted. > > Bug: 797347 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I8e73a7558d5506875d1547983d4e5e796a543aeb > Reviewed-on: https://chromium-review.googlesource.com/862326 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531293} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,rsesek@chromium.org,piman@chromium.org Change-Id: Ibc1979309377edc919206dbffd9f8a1258bf6acd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797347 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/881588Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#531355}
-
Ryan Sleevi authored
Ballot 193 / BR version 1.4.4 limits the lifetime of certificates to 825 days if issued on or after 2018-03-01. Update the lifetime enforcement in CertVerifyProc::HasTooLongValidity() to enforce this date range, in addition to the existing tests. Unlike the existing calculations, which are based on months, and thus inherently fuzzy as to what constitutes a month (see CA/B Forum archives), this is based on base::TimeDelta functions, which measures in microseconds and ignores leap seconds. BUG=799896 Change-Id: I260ac3b46cbcf066fea286231ed0c7045608879c Reviewed-on: https://chromium-review.googlesource.com/853893 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531354}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/6daa27815625..5864639a4650 $ git log 6daa27815..5864639a4 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I97444a824e109ab8cd04369a7594f9f04b0133f4 Reviewed-on: https://chromium-review.googlesource.com/881924 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531353}
-
Justin Novosad authored
When CanvasResource was refactored by this CL: https://chromium.googlesource.com/chromium/src/+/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6 We when from using SkImage to using StaticBitmapImage. For tracking texture resources. StaticBitmapImage benefits from a mailbox caching mechanism implemented in GraphicsContext3DUtils, so when the underlying GrTexture object is recycled, GraphicsContext3DUtils retrieves the old mailbox name from its cache. When CanvasResource was transition to use StaticBitmapImage we needed to stop disassociating mailbox names during tear down because it invalidate the mailboxes cached by GraphicsContext3DUtils. The test that verifies that mailbox names are not leaked was modified to expect mailbox disassociation to be triggered by GrTexture destruction rather than CanvasResource destruction. BUG=796838 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idff59a57a5acee08a7b7573e3b34593aa1938fa5 Reviewed-on: https://chromium-review.googlesource.com/881304Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#531352}
-
W. James MacLean authored
The CL updates RWHVG to use CursorManager when updating its cursor. Bug: 775488 Change-Id: I5534aa04c78d27db2d22ccc4134c66fa1f9ea4af Reviewed-on: https://chromium-review.googlesource.com/879322 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531351}
-
Bo Liu authored
Otherwise this crashes on some older version of android, it appears. Bug: 804297 Change-Id: I80bf10c1e3a6da36866658826b402e6b1cbf60ee Reviewed-on: https://chromium-review.googlesource.com/881839 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#531350}
-
Dmitry Gozman authored
Restoring InspectorSession may send protocol notifications synchronously, so we should setup all bindings beforehand. Bug: 804214 Change-Id: I68989990fe210a61251dc20047b891fa4155d596 Reviewed-on: https://chromium-review.googlesource.com/879137Reviewed-by:
-
dpapad authored
The element is no longer used and is deprecated in Polymer 2. Bug=802912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7e84de8cd64be8f838f8e2ae52d8dc4ccfd251c7 Reviewed-on: https://chromium-review.googlesource.com/877392Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531348}
-
Lei Zhang authored
Just need to rename a variabled named "interface" which is also used in Windows headers. Change-Id: Ibc1bebf11414130924d46053fc9017a9d62586f5 Reviewed-on: https://chromium-review.googlesource.com/880603Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#531347}
-
Jayson Adams authored
This cl replaces the bitmap-based tab progress spinner with the GPU- accelerated Material Design version. BUG=602558,542427 patch from issue 1997893002 at patchset 60001 (http://crrev.com/1997893002#ps60001) Change-Id: Id926579bffc0a7c11c35bea6452dd1b0662d6aa2 Reviewed-on: https://chromium-review.googlesource.com/580131Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/master@{#531346}
-
Ryan Sleevi authored
Use of the common name for matching the hostname is fundamentally insecure, as it allows for the bypass of security controls within certificates. Remove the remaining aspects of supporting logic that allow common name fallback, which were enabled by Enterprise Policy, now that the Enterprise Policy has been removed. BUG: 804349 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6e595f106b0d989935c9edc0d4c02e9a0f0f4584 Reviewed-on: https://chromium-review.googlesource.com/878901 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
-
Yixin Wang authored
Change-Id: I45fd9150165dd2c55b9e5c3cdb639853b7e84532 Reviewed-on: https://chromium-review.googlesource.com/879725Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#531344}
-
Joe Downing authored
This reverts commit a3cb5eee. Reason for revert: <INSERT REASONING HERE> Original change's description: > media: Simplify CdmService > > - Restrict CdmService to only host library CDM. Previously CdmService > is generic, but it's never used anywhere else, and that assumption > has caused some unnecessary code complexity. > - As such, also remove ENABLE_STANDALONE_CDM_SERVICE and replace it > with ENABLE_LIBRARY_CDMS where applicable. > - Remove the use of media::mojom::InterfaceFactory for the CdmService, > and replace it with a dedicated media::mojom::CdmFactory. > - Remove the use of MojoMediaClient in CdmService, and replace it with > CdmService::Client. > > BUG=771791 > > Change-Id: I49e0fc4958b18e1b619e20ab4772245b256ab454 > Reviewed-on: https://chromium-review.googlesource.com/852556 > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531329} TBR=nasko@chromium.org,xhwang@chromium.org,jrummell@chromium.org Change-Id: I330da3e6cd95e801d1def4abe4f9b8ec5c8fff1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771791 Reviewed-on: https://chromium-review.googlesource.com/881362Reviewed-by:
-
Alexey Kozyatinskiy authored
We should not check for resource tree model when inspecting Node.js target. R=dgozman@chromium.org Bug: chromium:787754 Change-Id: I04503a249acc05182524da40f83765e6ad7c37a5 Reviewed-on: https://chromium-review.googlesource.com/881468 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531342}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0ac874e7..260f54b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I28f653355b4f22cc2f3a636eb6c09a3edbbb79e8 Reviewed-on: https://chromium-review.googlesource.com/881422Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531341}
-
danakj authored
When glXGetSyncValuesOML is true, we expected this counter to be non-0 and added this error to find bugs, but it has become standard behaviour so this log is only generating noise. R=kbr@chromium.org Bug: 772844 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I38377c74d45197cf33b2caf3cf81239075f8cae8 Reviewed-on: https://chromium-review.googlesource.com/881285Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#531340}
-
Lei Zhang authored
Separate PDF plugin specific code from other PDF functions. Change-Id: If61f2316edc99b469ff1c7fb97d4a09fa98d8b5e Reviewed-on: https://chromium-review.googlesource.com/879731 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Ashley Enstad authored
Follow-up to chromium-review.googlesource.com/814595 target "peformance_test_suite" not found in //testing/buildbot/gn_isolate_map.pyl Bug: 757933 Change-Id: I070598678f586c703664619c5da917fe63747e50 Reviewed-on: https://chromium-review.googlesource.com/878724Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#531338}
-
Aaron Leventhal authored
Accessibility events can be difficult to debug when it is unclear what object the events occur on. This improves our event log format so that instead of just the role/name/value of events, we include something like <fieldset> or <div#foo> in the output, so that the tag and id are logged. This will help with debugging using both our event tests and with the ax_dump_event tool. Bug: None Change-Id: I79744395dd61f792358bc3ceb44ccadbedce7494 Reviewed-on: https://chromium-review.googlesource.com/876310Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#531337}
-
Jochen Eisinger authored
BUG=753691 R=ellyjones@chromium.org Change-Id: I474706ba795c9a1951a898b09a54161439372116 Reviewed-on: https://chromium-review.googlesource.com/881173Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531336}
-
Michael Thiessen authored
Daydream expects its icons to be in png format, and play store validation will fail if it doesn't find correctly formatted icons. This excludes '.dd.png' files from the automatic conversion to webp when building ChromeModern See b/72294258. TBR=dtrainor@chromium.org Bug: 802080 Change-Id: Icd55d5a08536697ec97c08701782c925165631c0 Reviewed-on: https://chromium-review.googlesource.com/881461Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Marcin Simonides authored
With this change "gn check" no longer assumes all #include paths are relative to the source root. Instead it searches for the includes by checking each of the directories listed in include_dirs for the target. A number of new issues have been discovered. The trivial ones have been fixed, the larger and more complex ones have been reported and the related parts of the project have been excluded from the default gn check run. BUG=794926 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I39c17a7ac47dc024dd374c8891ce4911809195cb Reviewed-on: https://chromium-review.googlesource.com/827014 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531334}
-
Maks Orlovich authored
This makes it easy to see that we don't delete things again once an entry is conceptially unlinked by a Doom. This also fixes the recent SimpleCacheQueuedOpenOnDoomedEntry testcase to behave more causally consistently. Also adds a testcase that covers new path --- but doesn't demonstrate any fix. Bug: Change-Id: I88d797eb23e0206ce3164bc1642ff464f6ba69e8 Reviewed-on: https://chromium-review.googlesource.com/862229Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#531333}
-
sczs authored
In some cases the UI changes related to Fullscreen being disabled need to animate. AnimatedScopedFullscreenDisabler works just like ScopedFullscreenDisabler but increments the disabled counter inside an animation block. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I79710443b8fa9d8137a03ce71035ccc9b077e1c6 Reviewed-on: https://chromium-review.googlesource.com/879568 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#531332}
-
Nate Chapin authored
This was regressed in https://chromium-review.googlesource.com/c/chromium/src/+/858257, which assumed that ImageResourceContents::Create() would never return nullptr. That would have been true if https://chromium-review.googlesource.com/c/chromium/src/+/860995 hadn't been reverted. Bug: 804829 Test: http/tests/navigation/image-css-load-in-subframe-unload-handler.html Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If53103d79907d5a01111aead2fdc93ce3491b3d7 Reviewed-on: https://chromium-review.googlesource.com/881642Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#531331}
-
Ryan Landay authored
When an IME tries to set a composition immediately after a non-editable element inside an editable region, it's possible for the selection base to get stuck inside the non-editable region, in which case the attempt to replace the selection fails. The fix is to pass the kCanSkipOverEditingBoundary flag when we call MostForwardCaretPosition() on the selection base so we can find the actual editable region. Bug: 790777,801441 Change-Id: I1014901742671f6fbb153c7117eaa1b271a265f7 Reviewed-on: https://chromium-review.googlesource.com/879839 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531330}
-
Xiaohan Wang authored
- Restrict CdmService to only host library CDM. Previously CdmService is generic, but it's never used anywhere else, and that assumption has caused some unnecessary code complexity. - As such, also remove ENABLE_STANDALONE_CDM_SERVICE and replace it with ENABLE_LIBRARY_CDMS where applicable. - Remove the use of media::mojom::InterfaceFactory for the CdmService, and replace it with a dedicated media::mojom::CdmFactory. - Remove the use of MojoMediaClient in CdmService, and replace it with CdmService::Client. BUG=771791 Change-Id: I49e0fc4958b18e1b619e20ab4772245b256ab454 Reviewed-on: https://chromium-review.googlesource.com/852556 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
Aga Wronska authored
Separate logic for creating users list (small and extra small display style) into ScrollableUsersListView. ScrollableUsersListView: * is initialized with appropriate params in LockContentsView * adjusts its insets according to device orientation * provides functionality to draw gradient at the top and bottom of the background Bug: 792742 Change-Id: I1d6087f7332261044a2d896b328570da124b9eb2 Reviewed-on: https://chromium-review.googlesource.com/875150Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#531328}
-
Erik Chen authored
Bug: Change-Id: I455c0d38cf11742d1651f5986dc9be148504b45b Reviewed-on: https://chromium-review.googlesource.com/879332Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#531327}
-
Tom Sepez authored
make browser_main_loop.cc line 266 and 666 match each other. Change-Id: Id2d7c21b0f58afbb585971057b77e0983b4c04ae Reviewed-on: https://chromium-review.googlesource.com/879565Reviewed-by:
-
Daniel Bratell authored
In jumbo builds multiple cc files are compiled in the same translation unit and then they will all share the anonymous namespace which can cause collisions if variables have the same name. That was the case for two kFilteredMessageClasses variables. This renames them to: kExtensionFilteredMessageClasses kRenderFilteredMessageClasses This is a followup to an equivalent change done in //content https://chromium-review.googlesource.com/721279 Bug: 746957 Change-Id: I959600adcc81dbd6e405c25aa0272acefc0387d9 Reviewed-on: https://chromium-review.googlesource.com/878362Reviewed-by:
-
Daniel Bratell authored
In jumbo build experiments, two kNotificationPrefix variables ended up in the same translation unit and clashed. This patch gives those two variables unique names. Bug: 746957 Change-Id: I200e9cb47129a1f20b8edec91ff0ff432a3c22d9 Reviewed-on: https://chromium-review.googlesource.com/874072 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531324}
-
