- 04 Dec, 2020 40 commits
-
-
David Black authored
Moving forward, when an add or removal of a holding space item occurs, the current container contents will animate out after which the container will be updated and its new contents animated in. This CL does not implement the animations but stubs in places for them. There should be no user visible change as a result of this CL. Note that this CL also attempts to simplify logic by removing all holding space item views when they are animated out and re-adding any views necessary before animating them in. This is slightly less performant but since the view count is small, the code is much simpler than would otherwise be if needing to diff the view state with the model state. Bug: 1154998 Change-Id: I822d1a6e4caadd1ddc6cc008429bfd1b28a0bb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572056Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#833629}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8ddf5ae4b8a5..0fdb2247e82e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8ccca4cdcedb36dcbb70e9f1cfa6ccc9a368c277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833628}
-
Josh Nohle authored
Previously, a user cancellation of an outgoing share from a Chromebook would have no effect if a connection with the receiving device was not already established. (The connection is established in roughly a 3-second window after the share target is selected.) So, an immediate cancellation previously had no effect, and the transfer proceeded. In this CL, we support cancellation before a connection is established. We also bring the Chrome OS cancellation method more in line with the GmsCore implementation. Notably, we report a cancellation before disconnecting to provide a more accurate transfer update status of "cancelled" instead of "failed". Manually verified cancellation in the following scenarios: * sending to and receiving from a phone; * cancelling on both the phone and Chromebook; * cancelling before a connection was established, after a connection was established, and during a payload transfer. One scenario--cancelling a Chromebook-to-phone share from the phone while the payload transfer was in progress--resulted in a failure notification on the Chromebook instead of a cancellation notification. This seems unrelated to this CL, and it is being tracked in crbug/1155412. Fixed: 1154926 Change-Id: I5ac141904af2fc614256b3c14e2ba3a99a984556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573884 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#833627}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c97e90b17a8..d472d834dbda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:912681 Tbr: ksakamoto@google.com Change-Id: Ic02fdc8c6bb1f7b3642d4ea4212f56366002cc7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572712Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833626}
-
Mitsuru Oshima authored
This class measures the throughput from the time first animation is started on a compositor, to the time last animation ended. This is useful to measure the total animation throughput during a transition that has many animations applied such as login, overview etc. Bug: 1150492 Test: covered by unittest Change-Id: Id0bfec6e57403b7f1ebe5a8068ae095b1412bc7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550366 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#833625}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8abf9fa0..04e154e4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3470281f8b39fe30d642479618cc2904d18b7e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573239Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833624}
-
Jeff Yoon authored
Adding PGO trybot GN arguments to mb_config.pyl Change-Id: I00cbb3c8165792858fc5f60f39723528ca71361f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552883Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@google.com> Cr-Commit-Position: refs/heads/master@{#833623}
-
Jérémie Boulic authored
This is a reland of 9d2bdda8 Original change's description: > [Files app] Generate modules for ui/file_manager/.../metadata_proxy.js > > Converted files: > - ui/file_manager/file_manager/background/js/metadata_proxy.js > - ui/file_manager/file_manager/background/js/metadata_proxy_unittest.js > > Bug: 1133186 > Change-Id: I81eb9d34fff12835ef5974acfee3817fec864340 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563105 > Commit-Queue: Jeremie Boulic <jboulic@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833130} Bug: 1133186 Change-Id: Idee34300befe5605219967ee7cea0ed803f4aeda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573699Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833622}
-
Kunihiko Sakamoto authored
This reverts commit 2a07cc57. Reason for revert: FileSystem/HoldingSpaceKeyedServiceBrowserTest.* are crashing on linux-chromeos-dbg bot: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21594 Original change's description: > Shutdown holding space delegates while device is suspended > > Some file systems are unmounted during device suspend (for example drive > FS), which was causing the holding space file system delegate's file > path removal detection to remove them from the holding space on device > suspend. To avoid this issue, holding space keyed service now observes > device suspend status and shuts down holding space delegates when the > device suspends. The delegates are re-initialized when suspend ends, > restoring the model from persistence again. > > BUG=1152924 > > Change-Id: Iffe4586bcb87f47d687ceeff0fc76e60a443c0d5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568355 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#833515} TBR=tbarzic@chromium.org,dmblack@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I4a55c3b18d48a701a09c6b205e69c27fc90abb16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1152924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573558Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833621}
-
Lei Shi authored
Refactored the underlying logic of STS. Previously, STS combines node enqueue, navigation control, and TTS playing in one function (i.e., startSpeechQueue_). I separate these functionalities by adding five navigation state variables. Then, enqueue nodes in startSpeechQueue_, play TTS via startCurrentNodeGroup_, and control navigation by manipulating the navigation state variables. With this CL, STS will enqueue content to TTS one nodeGroup at a time. Previously, STS enqueued all selected nodeGroups to TTS. To reflect this change, I modify the tests. More details notes: 1. Refactor function updateNodeHighlight_ as we don't need the opt_endIndex in this function. 2. Create function syncCurrentNodeWithCharIndex_, which reuses code logic from the previous function onTtsWordEvent_. 3. Split function startSpeechQueue_ into (1) startSpeechQueue_, (2) startCurrentNodeGroup_, and (3) startNodeGroupAfter_. Function startSpeechQueue_ adds new content to the speaking queue and starts TTS using startCurrentNodeGroup_, which starts reading the current NodeGroup based on the five navigation state variables. Function startNodeGroupAfter_ allows us the change the navigation state variables to the next NodeGroup. AX-Relnotes: N/A Bug: 1143817 Change-Id: I1aa719786108e0f98fda36ebade7536967cfd2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565698Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Lei Shi <leileilei@google.com> Cr-Commit-Position: refs/heads/master@{#833620}
-
Hiroki Nakagawa authored
This CL removes the following events relevant to <link rel=prerender>: - webkitprerenderstart - webkitprerenderstop - webkitprerenderload - webkitprerenderdomcontentloaded These were originally introduced for internal use and not upstreamed to any HTML specs. The following use counters make sure these are not used in the real world: - WebkitPrerenderStartEventFired - WebkitPrerenderStopEventFired - WebkitPrerenderLoadEventFired - WebkitPrerenderDOMContentLoadedEventFired Chrome Status Entry: https://www.chromestatus.com/feature/4925917174431744 Change-Id: Ia1f61e936d3126dbb367c99e80d88cdbe7313159 Bug: 839030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521474 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#833619}
-
John Chen authored
Disabling failing browse:chrome:omnibox:2019 story in three benchmarks on android-go-perf: * system_health.common_mobile/browse:chrome:omnibox:2019 * system_health.memory_mobile/browse:chrome:omnibox:2019 * v8.browsing_mobile/browse:chrome:omnibox:2019 Notry: true TBR: wenbinzhang@google.com Bug: 1154719 Change-Id: I51de128e2e1b940c0adf23b689ce87f0e3f52c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573888Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833618}
-
Andre Le authored
Add MultiDevice.SecureChannel.Nearby.SendMessageResult histogram. Bug: 1106937, 1150634 Change-Id: I23464231392275845e8e2c60c8edfbcd02d01ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566977Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#833617}
-
Yulun Wu authored
Screen recording can be found as an attachment in the bug. Bug: 1109293 Change-Id: Ief1092a0a1ee970900bc7b0baf24ab50667f8577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547393Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833616}
-
Nnamdi Theodore Johnson-Kanu authored
Screenshot: https://screenshot.googleplex.com/4KPcDWcvuJZUKvP.png Bug: 1093185 Change-Id: Ieea3e4b58a8da6f98e94af7d2dec2f2b53816b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569784 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#833615}
-
Kenichi Ishibashi authored
Bug: 1155428 Change-Id: Ib3ca5b1d0586c97160d1da9bdc562bfaf00af84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573836Reviewed-by:
-
Jasmine Chen authored
Use ObserverListThreadSafe for CameraActiveClientObserver instead of ObserverList. Also add a lock to guard the list. Bug: b/170075468 Test: simplechrome Change-Id: I976200eed4e24f036e96481a145250aa90fdc3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566329Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#833613}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/877fbcb69179..0fdb2247e82e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I65b60c4f918732f4ec8d8162aef5c5e0535190aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573777Reviewed-by:
-
Kunihiko Sakamoto authored
This reverts commit 2f0a1300. Reason for revert: VideoConferencingRoutineTest fails on MSan bot due to use-of-uninitialized-value: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21568 Original change's description: > network_diagnostics: Add VideoConferencing routine > > Tests for successful UDP and TCP connections to a STUN server and > whether several Google media hostnames are reachable. > > BUG=b/172994051 > TEST=unit_tests --gtest_filter=VideoConferencingRoutineTest.* > > Change-Id: I64d2784c3b3ae111c9e924b1296a5463dcb7cea2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535997 > Commit-Queue: Kartik Hegde <khegde@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Hugo Benichi <hugobenichi@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833465} TBR=stevenjb@chromium.org,dcheng@chromium.org,hugobenichi@google.com,khegde@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6d4f020371052227ab20ab45c3ffe85bb6f57310 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/172994051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573557Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/10f76ac226f2..31d3b217d3b5 2020-12-03 alessiob@webrtc.org RNN VAD: FC layer isolated into rnn_fc.h/.cc 2020-12-03 perkj@webrtc.org Revert "Add class InterArrivalDelta to goog_cc" 2020-12-03 alessiob@webrtc.org RNN VAD: FC and GRU layers implicit conversion to ArrayView 2020-12-03 grulja@gmail.com Improve screen sharing with PipeWire on Wayland 2020-12-03 sprang@webrtc.org Revert "Adds experimental libvpx VP9 speed settings." 2020-12-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20fa2e0b..8115efcf (833170:833270) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:682122 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib2d1958ca88b0b037f5cb62ef758b3bd020661d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573917Reviewed-by:
-
Rakina Zata Amni authored
Ensures we won't keep a connection too long when deferred for bfcache. The timeout is determined by the "max_time_to_live" param of kLoadingTasksUnfreezable, defaulting to 15 seconds. Bug: 1137682 Change-Id: I66cb229285f40ef12a69734975ac77c820a02082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569020 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I041e17bba9e870e3042c00ad3178265ae138e79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573627Reviewed-by:
-
Kyle Horimoto authored
Change-Id: I2b7df8f0f529a8d5a7108db90ab49330cc3ad469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573392 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#833607}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d919472c98c..63989d27ead7 2020-12-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If261af5e93b0a409239da0c8f41d07d8e63325b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572710Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0d2de6f05c54..1ad5791d97be 2020-12-04 ianelliott@google.com Revert "Vulkan: Use specialization constant for halfRenderAreaWidth" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: If342c179844716779ca0653308a65d9edadfe048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573635Reviewed-by:
-
Jérémie Boulic authored
When clicking the 'Delete' icon, a confirmation dialog is shown. Once closed, the dialog restores the focus to the previously active element. In the case of the 'Delete' button, it results in the tooltip showing again after a certain timeout. This change hides the 'Delete' button tooltip after the dialog is closed. The `hideTooltip` function is extended to cancel any potential timeout that has been initiated to show the tooltip. Bug: 1082019 test: browser_tests --gtest_filter=*filesTooltipHidesOnDeleteDialogClosed Change-Id: I4956174df6ad46c2a356cdb8b3985714ed3ff2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483732 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833604}
-
Esmael El-Moslimany authored
Bug: 1123905 Change-Id: Icd32d8adb20cb5e8ce16093b50c429ba25758ee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573338 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833603}
-
Clark DuVall authored
I forgot to add split_name to this generate_jni call. Bug: 1155277 Change-Id: I06d56ad42ffbc6afda34e64ee8f6037933f7b3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573160 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833602}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I606e12df9cf0082cc9dec33e8d26cd4423b2a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572731Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833601}
-
Luciano Pacheco authored
Bug: 1102263 Change-Id: I43c12160d9e70959e36a071dea95fe8c2f600ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571033 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833600}
-
Nicholas Hollingum authored
This item is shown for the borealis app icon and currently uses pluginvm's strings until borealis ones can be approved. Bug: b/172006764 Change-Id: I9036b1e555d8848d7082e753f3c6ce576f508f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570475Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#833599}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607007593-3407e023275e887982890e083190cec03a46fa25.profdata to chrome-win64-master-1607018334-2342e7b4fc523afed7119425e6663fe86ee0646f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I878f974c542c1a39b67acfbd8c23ba4d6c4f5661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572645Reviewed-by:
-
Lan Wei authored
Use testdriver Action API to simulate mouse and touch actions in pointerevents/pointerevent_fractional_coordinates.html. Bug: 1145677 Change-Id: I8ec66844c7662a88b9e7cb3d792778e9b6df6f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568605 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#833597}
-
David Reveman authored
This is causing more memory to be used in some cases because of this skia bug: https://bugs.chromium.org/p/skia/issues/detail?id=11038 48MB is enough to avoid that problem. Bug: 1155326 Change-Id: Ife884162d29ca4f1a46caaeb9aa0188c3fe44eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573156Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833596}
-
Amanda Deacon authored
Tests: unit tests Bug: 1098112 Change-Id: Ia17ebf3407b4f9429b6b2ab006210b38a0d7fab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570878Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Amanda Deacon <amandadeacon@chromium.org> Cr-Commit-Position: refs/heads/master@{#833595}
-
Hirokazu Honda authored
Existing hardware decoders support only YUV 4:2:0 videos. We currently rely the underlying libraries and drivers to deny non YUV 4:2:0 videos. We would rater confirm it in AcceleratedVideoDecoder. From this CL, AcceleratedVideoDecoder::Decode() returns kDecodeError if a video is not YUV 4:2:0. Bug: b:172223934 Test: media_unittests Change-Id: Ib0ddbe526a801476e382f0b7665a74573bd6a28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562618 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#833594}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b2c18f2f62b9..968b1fe7d7cb 2020-12-04 ehmaldonado@google.com [git-cl] Use owners client when processing --[tb]r-owners. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id5703ca04743442ec4e9d3eb444712499acddb6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573632Reviewed-by:
-
Sebastien Marchand authored
Bug: 1155316 Change-Id: I70e84f9445edae16c4fcab6d03b33a8f958ba842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572888Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#833592}
-
Clark DuVall authored
For now the chrome module's manifest is merged into the base manifest to match the expectations files we have. If the chrome module launches, we may want to have more checks on what gets put in the base manifest vs. the chrome manifest. Bug: 1151529 Change-Id: I786175aec33cf5f454a416d3f51e9dd069dbac82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572792Reviewed-by:
-
Mohsen Izadi authored
Mouse-dragged events are interesting for two reasons: - Some of mouse-dragged events are interesting themselves, for example when they are used to select text; - Some of mouse-dragged events end up generating other interesting events. For example, dragging a scrollbar thumb in a page generates mouse-dragged events that end up generating gesture-scroll-update events. For these cases, we need to create EventMetrics objects for the original mouse-dragged events in order to have accurate event timestamps for reporting generated events. Addition to UKM is approved in: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit?usp=sharing Bug: 1138918 Change-Id: Id4231d528fce64184273f6580a3895e1c1d96a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567631Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#833590}
-
