GitLab

The crash only happens on certain devices in certain countries.
The crash trace seems to indicate that the context could be null
in some cases.

Change-Id: I0ad8bdd4c79e66f7eebaf269154b9852e48e787f
Bug: 1019974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892062Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711414}

When the user closes a tab (or browser), we first determine whether we
can take a "fast shutdown" path and simply shut down the main frame
process.  That can be done if nothing in the current tab (or all tabs
if closing the browser) needs to run beforeunload/unload handlers.
Otherwise, we take the slow path, actually try to run those handlers
in all the frames, and wait for the results (including beforeunload
dialog dismissals) before proceeding with the close.

Historically, this was done by checking SuddenTerminationAllowed() on
the main frame's process, which would be set to true when *any* frame
in that process adds a beforeunload or unload handler.  When site
isolation shipped, we also added code to consult beforeunload handlers
in cross-site iframes (see issue https://crbug.com/853021) in M68.

But SuddenTerminationAllowed() is actually too coarse-grained for
this: it not only becomes false due to (before)unload handlers, but
other things as well (such as BlobBytesProvider).  So
https://chromium-review.googlesource.com/c/chromium/src/+/1504130
changed things to explicitly consult the main frame's
beforeunload/unload handler status, as tracked by
RFH::GetSuddenTerminationDisablerState(), instead of
SuddenTerminationAllowed().  Unfortunately, it seems that in that CL
we forgot about the process-wide nature of SuddenTerminationAllowed(),
specifically that it also covered handlers from any subframes in the
same process.  And/or, we missed that the call in
WebContentsImpl::NeedToFireBeforeUnload() to check subframes via
GetMainFrame()->ShouldDispatchBeforeUnload( true /*
check_subframes_only */); was in fact only checking cross-site
iframes, skipping not only the main frame but also its same-site
descendants.

That means we would incorrectly fast-close the tab (or browser) even
if a same-site iframe had a beforeunload handler.  This CL fixes this
by walking the full frame tree to check for these handlers and adds
two regression tests for the tab close and browser close cases.

Along the way, the CL also fixes a TODO to check not only beforeunload
but also unload handlers in subframes.  This is a bit more correct and
will also make it easier to fix issue 1014550, though note that
subframe unload handlers weren't broken before -- they actually still
ran due to the subframe unload process timeout that we still have in
RenderProcessHostImpl::DelayProcessShutdownForUnload().

Bug: 1010456, 1014550
Change-Id: I2b2c3e2ee546a766e5838e14f293266def4aeeed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881948
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711413}

- Removes restriction that live region changed events need to be fired from
nodes with the live region role, since we don't actually do this in UI code.
- Announces the node's name as the live region text, falling back to inner text
if name isn't set. Again, this tracks how we actually use the notifications.
- Debounces multiple notifications from the same node to one per 20ms

Bug: 1015002
Change-Id: Id564c85cd0ab0888877d4cf4b12fb872d1306284
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871830
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711412}

This is a simple change for animating the thumbstrip in/out. If this is
performant enough for now we might not have to interact with the
top-chrome slide controller.

Bug: chromium:992972
Change-Id: I2ed765cd61591c5941fcc851edb85b7e04089a8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894035
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711411}

This CL adds logic to HostCache to prioritize and deduplicate
addresses from address lists during merging. The merge step now
deduplicates addresses (across the two lists) and then performs
a stable sort by, first, whether addresses have associated ESNI keys
and, second, whether they are IPv6 or IPv4.

Changes by location:
- HostCache: new merging logic
- dns_util: new utility function to deduplicate an address list in a
stable manner (uses a flat_map for low overhead)
- HostResolverManager:
   1. deduplicate addresses when parsing A and AAAA responses
   2. modify logic around the AddressSorter::Sort callsite to account for
   the fact that the first address in a combined address list may not
   be IPv6

Test:
1. HostCache unittests to test merging
2. dns_util unittest to test the deduplication routine
3. HostResolverManager unittest to test that the addresses
HostResolverManager surfaces are sorted and deduplicated

R=ericorth

Bug: 1003494
Change-Id: I322d6342902c634f55d24a1a8074e52817e6e6a9
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887372
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711410}

Bug: 1014420
Change-Id: Idd2b5211db5a547e1364966f8c43efc5e0c7c0eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893518Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711409}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3bcc30e4..925e218b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I60b219e9f1aebac6d849f0dfcbebfe18fe423a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892993Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711408}

This CL introduces a new MediaWatchTimeChanged event and a
MediaHistoryContentsObserver to watch for the event and save
the playback information to the media history store.

Bug: 997813
Change-Id: I20061e1d614b703752fca9327d010689209c9575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881977
Commit-Queue: Evan Liu <evliu@google.com>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711407}

https://webrtc.googlesource.com/src.git/+log/8d65e9ab98d8..3ce44a354069

git log 8d65e9ab98d8..3ce44a354069 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 ivoc@webrtc.org Move NetEq headers to api/
2019-10-31 sprang@webrtc.org Refactors BitrateProber with unit types and absolute probe time.

Created with:
  gclient setdep -r src/third_party/webrtc@3ce44a354069

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: Id1b7561aee8dff62d9b4425bafab9f5e7ad95a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893327Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711406}

And fix a bug that we revealed when trying to add some new libs, where
deps of both buildCompile and compile were being marked as !isShipped.

Bug: 693079
Change-Id: I8ee83a5529a48aeb117efca8cf36f968c695f10c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893143Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711405}

TODO: crbug/1020231 add customized IIS site support in CEL

Bug: 1018819
Change-Id: I0502f5f7d686e77ae1779a94d8debd385efbd130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884990
Commit-Queue: Xiang Ji <jxiang@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711404}

This should have been addressed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1883621

Bug: 1018027
Change-Id: Idc6cea44ffcbd596be4d6cb0a3b861583f491e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893494Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711403}

https://quiche.googlesource.com/quiche.git/+log/cda1ce2eee02..f2c4e3ef544b

$ git log cda1ce2ee..f2c4e3ef5 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 fayang gfe-relnote: In QUIC, re-calculate pacing rate when cwnd gets bootstrapped. Protected by gfe2_reloadable_flag_quic_bbr_fix_pacing_rate.
2019-10-30 bnc Implement dynamic table, blocked streams, multiple streams, and multiple header blocks per stream in QpackDecoderFuzzer.
2019-10-30 bnc Implement gMock matchers to pretty print QuicErrorCode and QuicRstStreamErrorCode on failure.
2019-10-29 nharper Remove unused CreateSslCtx methods from TlsHandshaker classes
2019-10-29 renjietang gfe-relnote: various test code cleanup. Not protected.
2019-10-29 bnc Make HttpEncoder methods static.
2019-10-29 dschinazi Introduce QUIC_NO_EXPORT
2019-10-29 renjietang Remove duplicate call to send MAX_PUSH_ID frame.
2019-10-29 bnc Remove QuicMakeUnique, Http2MakeUnique, SpdyMakeUnique from platform/api/.

Created with:
  roll-dep src/net/third_party/quiche/src

R=rch@chromium.org

Change-Id: I0745d0e16ce77b00f0929773a098cb22ccf58ddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890965Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711402}

Bug: 985589
Change-Id: I0431adf4c4d26ab94dafd34f2a6bc6e372d8d2d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890817Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#711401}

crrev.com/c/1879506 crrev.com/c/1889949 fixed some flakiness issues.
Now the test should be stable on bots when running in parallel.

Bug: 958242
Change-Id: Ic76ab6547b29e59b66b0d8565e6a01935993df55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891736Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711400}

This is mechanical work before registering the app ids with the
updater lands. There is some common registration code that is
common on both install and update execution path. It is helpful
to have the update apps code in its own compilation unit, just as
install is.

R=waffles


Bug: 1020285
Change-Id: I06590cf1d73a5d22ae79d288de564c0040442678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893406Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711399}

This CL adds two metrics for display compositing.
GpuBlockedBetweenSwapsUs: Measures amount of time Gpu Main thread was
blocked during executing tasks for current frame.

SwapTimeUs: Measures time of glSwapBuffers call to evaluate if the
most blocking happens inside swap buffers or at different time

Change-Id: I089c5dbadabb53b128fcb043d9000521a873fefc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876911
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711398}

https://skia.googlesource.com/skia.git/+log/ac8a16ca5200..7823aeb8d6da

git log ac8a16ca5200..7823aeb8d6da --date=short --no-merges --format='%ad %ae %s'
2019-10-31 halcanary@google.com refactor/layering: SkMalloc.cpp
2019-10-31 mtklein@google.com only scale shader by paint alpha < 1
2019-10-31 mtklein@google.com fix uniform buffer size, scale by paint alpha

Created with:
  gclient setdep -r src/third_party/skia@7823aeb8d6da

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: I2115455eb31c8ada8191ee5e90c02c5cd5d32abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893817Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711397}

Next step for implementing usage of the
Windows.Devices.Geolocation WinRT API in Chromium to enable the
geolocation api to provide a more accurate geolocation position
if available, this CL:
  - Add implementation to location_provider_winrt which
  calls to the Windows.Device.Geolocation WinRT API and
  invokes callback with location retrieved.
  - Changes to location_arbitrator to explicitly make
  network location provider and system location provider
  mutually exclusive. If two providers are present there is no
  guarantee which provider provides the location when a call to
  getCurrentPosition is made.

Bug: 968883
Change-Id: Id44fcf13f739fb97e244a30c76396e4457e96839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865651
Commit-Queue: Peter Lavallee <pelavall@microsoft.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711396}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c5f821e4023..f9ac8f056b7f


Created with:
  gclient setdep -r src-internal@f9ac8f056b7f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:1018879,chromium:1019931,chromium:1014539,chromium:None
Change-Id: Iaa08d8a9608215adf650856e32ba475fac25f031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893325Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711395}

Currently, javascript is used to center the message-container.  This is
problematic because the content width is not always known when the JS
tries to center the message-container, leading to incorrect centering
when trying to center the div imperatively as info is missing.

This CL adds a min-width and max-width to the message-container so
centering can be achieved easily declaratively with other CSS rules
(left & transform).  In doing so, the message-container is now centered
correctly, but also has a min width and max width.

Bug: 937370
Change-Id: Ie73d8ef4a52d21685a51305e39351935ab9be6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891123Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711394}

Change-Id: I9afd7e710eb00cb9e21b39213a8b6606de46dcd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893398Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711393}

Measured Polymer 3 optimized UI to have similar performance to the
optimized Polymer 2 UI. The non-optimized version is ~25-30% faster
than the non-optimized Polymer 2 page.

Size:
Previous bundled page:
vulcanized.html: 194k
crisper.js: 234k
Total: 428k

Polymer 3 bundled page:
vulcanized.html: 2k
extensions.js: 406k
total: 408k (~20k smaller)

Note that the size of extensions.js is larger than necessary because
the Polymer license comments are included for every file, instead of
only once for each distinct license year, as was the case when these
comments were in HTML files processed by Polymer bundler, rather than
in JS files processed by uglify. So further improvements may be
possible in future.

Fixed: 1004967
Change-Id: I50dd4223142424e7f12da71dbf2fe7c82ebd19f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817293Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711392}

* Add a GN argument to whether show a launcher icon to open WebView
  developer UI main. This gn argument is off by default.
* The shown icon will be another icon in addition to any icons added by
  WebView providers.
* A launcher activity is defined as an activity-alias that links to
  developer UI main activity.
* The manifest file where this activity-alias is defined is merged into
  WebView manifest only if the flag is true.

Bug: 989831
Test: Manually inspect the new added launcher icon after installing system_webview_apk, monochrome_apk, trichrome with gn arg 'webview_devui_show_icon=true`
Change-Id: I9e5b808f5e1f9491d2ed813ccf342207a7642b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863929
Commit-Queue: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Auto-Submit: Hazem Ashmawy <hazems@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711391}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f7d8b0be4542..bf5ec7271d5c

git log f7d8b0be4542..bf5ec7271d5c --date=short --no-merges --format='%ad %ae %s'
2019-10-31 dburger@chromium.org Remove scheduling of master-chromium-pfq and children.

Created with:
  gclient setdep -r src/third_party/chromite@bf5ec7271d5c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I120d40beb261efebd4a46fa712c40f657d0f9f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893815Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711390}

Tbr: vasilii@chromium.org
Bug: 1020257
Change-Id: I1b4ce66b695cc0f5c1f2f62bbbe02be18f6bde6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894052Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711389}

We get rid of a helper function, replacing it with a function with the
same purpose provided by the Mojo bindings. Also add comments on the
purpose of the function and why it's using FusePipes.

Bug: 955171
Change-Id: I52aaa8a3b031fee0d39b11243d89627e5131f3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890036
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711388}

https://chromium.googlesource.com/angle/angle.git/+log/5e6be1d627e9..3ff097ff2055

git log 5e6be1d627e9..3ff097ff2055 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 jmadill@chromium.org Win: Add ANGLE_WAIT_FOR_DEBUGGER option.

Created with:
  gclient setdep -r src/third_party/angle@3ff097ff2055

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I5c733915d7c34ce68c5b7b17fe8c27563f2d20e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893321Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711387}

BUG=5027

Change-Id: Ia828554114412a760cc3d6e5c768ce8202ccfa5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885509
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711386}

This temporarily disables 4 network tool tests that will be
rebaselined and re-enabled after
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881592
has landed and DEPS has rolled

Bug: 963183
Change-Id: Ifb2607ffc690f7b8225bcb5635cecd28f112a58e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893515Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#711385}

Multiple scroll snap wpt tests use `scrollbar-width:none` css property
to hide scrollbars. This property is only supported in Gecko.

This CL adds the legacy webkit prefixed property [1] to enable the same
functionality. This addition allows 8 existing tests to pass in Chrome (and
potentially in Safari).

[1] ::-webkit-scrollar { display: none; }

Fixed: 10030555
Change-Id: Iefe5f5071d23cd40bab71a9d0e360b62e10e9c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884816
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711384}

And, while I'm here, also use ExtensionId where applicable.

Replacing enum with enum class not only makes scope of their options
narrower, but also allows allows more than one enum for histogram to
be declared at the same scope without conflicting symbols (otherwise
their technical field kMaxValue will cause the conflict).

Bug: 1015817
Change-Id: Ic2136bcbf2bd59657ad464019b3dad0a51786567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868880
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711383}

Nothing differentiates anymore between initial and subsequent
DNS config notifications from NetworkChangeNotifier, so merge them into
a single notification.


Fixed: 1001157
Change-Id: I1d67a7d7299d4a15307d2a68ca06d27caf3bef37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788241
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711382}

Bug: 1018266
Change-Id: I4f8c301428a1f2009571a691b871eb1d760f0eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888402
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711381}

https://dawn.googlesource.com/dawn.git/+log/9ec47a0bca27..cdc22769d474

git log 9ec47a0bca27..cdc22769d474 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 rharrison@chromium.org Rolling 4 dependencies

Created with:
  gclient setdep -r src/third_party/dawn@cdc22769d474

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: If5fd9767402da2b622f15a2d11efe6c0d9349723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893320Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711380}

Add Delegate classes to FakeCryptAuthFeatureStatusSetter and
FakeCryptAuthDeviceNotifier that are alerted when SetFeatureStatus() and
NotifyDevices(), respectively, are called. This is analogous to
the behavior of FakeSoftwareFeatureManager.

These delegates are used to make the DeviceSync service unit tests more
robust to asynchronous behavior.

Bug: 951969
Change-Id: Idcc1fe95a1b70fad0d99e67216bf40fd61af0ef8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893517
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711379}

This reverts commit 5e7f2837.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 711358 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVlN2YyODM3Mzg3YjZjY2YxNmMyM2UyYjQ4OTI4ZWRmMmZkYzg1NTMM

Sample Failed Build: https://ci.chromium.org/b/8898059709119128832

Sample Failed Step: content_browsertests

Original change's description:
> Fix UIA Fragment Root Navigation in Inspect
> 
> We discovered that the fragment root change that was recently submitted
> here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822
> regressed fragment root navigation in Inspect. This was not the case
> when Kevin had first submitted it. I traced it down to the changes that
> I made for Controller-For elements, so this change undoes those
> modifications.
> 
> In order to stabilize the content_browsertest that prompted the changes
> (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it
> was discovered that there were several issues in how we were
> handling date-time popups.
> 
> The first issue is that we were failing to return the proper parent
> window for the fragment root. In
> RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were
> returning nullptr as the parent of datetime popups, which was
> parenting the popup under the root desktop window in Inspect. This
> change now returns the host's window, which places the popup under
> the correct parent window in Inspect.
> 
> The second issue is that there was a cardinality problem with datetime
> popup windows. Since they share a BrowserAccessibilityManager with
> the main window (but are under a different fragment root),
> LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would
> always return the main window's root kRootWebArea instead of the
> popup window's kRootWebArea. So we'd have two different fragment roots
> that map to the same gfx::NativeViewAccessible. This would cause
> GetFragmentRootParentOf to return the incorrect parent most of the
> time. This change fixes that issue by adding an extra step for popup
> windows that traverses the root node and searches for the popup web
> root via OneShotAccessibilityTreeSearch.
> 
> Bug: 1019016
> Change-Id: I678425c8417334275727053243a39b1039e6f135
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102
> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711358}


Change-Id: I9099f1deb1a5a641ab08d4114d6d7d0121e47101
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894174
Cr-Commit-Position: refs/heads/master@{#711378}

The test was getting the page height before the top controls were fully
shown.

Bug: 1020065, 1019948
Change-Id: Ide28825e5c4896421dc17fcc84e4da6714f25364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893516Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711377}

ToTMac* were failing due to the deprecation of xcode build version
config in Chromium. Adding xcode build version to the failing bots
Xcode version 10b61 (Xcode 10.1 GM)
* ToTMac
* ToTMacCoverage
* ToTMac (dbg)
* ToTMacASan

Bug: 1019931,1014539
Change-Id: I71ae4b6a340a089ead3146bfb265af4d4cbe3066
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891795Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711376}

Chrome passed and firefox passed

Bug: 900581
Change-Id: I0b63e9908d36c380e0f328c66c20b6687a0504aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887232Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711375}