- 09 Oct, 2020 40 commits
-
-
Peter Kotwicz authored
This CL adds an exception for accent_font.xml. Internal webview contains accent_font.xml but not internal monochrome because accent_font.xml is a resource alias in internal monochrome. BUG=1115604 Change-Id: I9d6b96625baff4a9903b0e0e8e19c2c5c8f8cc89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462712Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#815617}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I7dea7045db9c4c3e25c0fbadc5f0ecd4f369c3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461123Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815616}
-
Robbie Gibson authored
The edit menu was being shown inside a DCHECK. (I.e DCHECK([self methodWithSideEffects]). This meant that it was stripped out in release builds, but not in debug, which is why this didn't reproduce locally. Bug: 1134647 Change-Id: Idbe1a48d0f9c82543cffcc3f79d05128e9589470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462266 Commit-Queue: Robbie Gibson <rkgibson@google.com> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815615}
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 955316 Change-Id: I44db3fb85a0c84d31f745aa238e4e290844ca8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463329Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815614}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2bf76269e147..c251d370b65e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I72daa0b68e2429acd90e3c80c524d02afddcfa38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461697Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815613}
-
Michael Ludwig authored
Bug: 1136863 Change-Id: I072c08012b90272de4ad4a5f66ceadabcb476e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462558 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#815612}
-
Alexander Dunaev authored
The DBus Menu supports rendering keyboard shortcuts for its items, for which the 'shortcut' property should be set for the menu item. The shortcut is built from the key code using platform-specific conversions. This CL adds a platform interface that allows the DBus menu to query the platform for the key sym string for the given key code, and enables the menu shortcuts for Ozone X11. Bug: 1121908 Change-Id: I42828f967cc2c0eec24d86ba0e0ad0528435bb1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450192 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#815611}
-
David Maunder authored
So it can be more easily depended on Bug: 1130769 Change-Id: I79785f1ab1ce4eb5e5773295e4723e8366153e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426296Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#815610}
-
Sorin Jianu authored
This tool is intended for developer use. It is not a production tool, although it may be extended at some point to offer the functionality of Omaha's ApplyTag.exe. The script is a wrapper for certificate_tag.exe. Since the tag format is not a simple concatenation of the magic string start and the tag, but it requires a big-endian value be inserted in between the strings, and certificate_tag.exe requires the tag be provided as a hex-encoded string, then some command wrapping is needed. For now, the tooling assumes the tag is ASCII-encoded, but UTF-8 support can be provided later on. To use the tool, invoke it like this: python3 chrome\updater\tools\tag.py --certificate_tag=out\Default\certificate_tag.exe --in_file=out\Default\UpdaterSetup.signed.exe --tag=appguid={8A69D345-D564-463c-AFF1-A69D9E530F96} Bug: 1128751 Change-Id: I2dab1dfd4e7fff34c9982868625b995cff122d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426765Reviewed-by:Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815609}
-
Renato Silva authored
Being the first screen in the OOBE flow, it remains important to have useful metrics about the state of this screen. Extend the metrics until M94, similar to the other metrics that already exist. Fixed: 1125676 Change-Id: I99525286ed51692687be4179554db950807a5de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461108Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#815608}
-
Xida Chen authored
TBR=eirage.chromium.org NOTRY=true Bug: 1136687 Change-Id: I6390de8529b22ac35a33ac1c9c2942d5214dcb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462386 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Bug: 1117478 Change-Id: I018277df50d1b786d5b72ab397e274d224ad4960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461115 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#815606}
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves //content/common/page_state.{cc, h, mojom}, /page_state_serialization.{cc,h} with relevant unit tests to blink. Bug: 1110246 Change-Id: Ifad68ae84931b45c48f0fa433c61d549737ec94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416208Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#815605}
-
Fredrik Söderqvist authored
We would previously produce the same angle for 180 -> 0 transitions as for 0 -> 180 (or similarly 90 -> -90 and -90 -> 90 respectively), which isn't correct. Tweak the condition in BisectingAngle() to adjust the in-angle when it is smaller than the out-angle to differentiate the two cases. Fixed: 1132525 Change-Id: I191e9e3d4889517f1188ec4a19e71beb8a966ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446729Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#815604}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/78768c9a86bf..58919b4db13b 2020-10-09 szuend@chromium.org [ts] Type-check network/RequestTimingView.js with TypeScript 2020-10-09 alexrudenko@chromium.org Enable TypeScript for AdvancedApp.js 2020-10-09 szuend@chromium.org [ts] Type-check network/HARWriter.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic5791f52a761feeba3a344ca345d8e0d52876c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463251Reviewed-by:
-
Mikel Astiz authored
This advanced API maps to the the equivalent TrustedVaultClient::AddTrustedRecoveryMethod() and allows the identity page (Gaia) to register a public key that is known to be trusted. Among other purposes, this is designed to allow the user to resolve degraded sync recoverability states from a web page. Bug: 1081650 Change-Id: Iadb57e71dd1c57925fadba456ff2efabac94863b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449329 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#815602}
-
Milica Selakovic authored
autofill_assistant::RunningManager This CL deprecates AutofillAssistant's state in PasswordManager. Now, ChromePasswordManager is autofill_assistant::RunningManager's observer. Bug: 1133783 Change-Id: I9149af34fa0a5da2833b37f4d19331d16817e58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440871Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#815601}
-
Sebastien Lalancette authored
This change was made based on a suggestion from isherman in: https://chromium-review.googlesource.com/c/chromium/src/+/2456288 Change-Id: Icf2f01b2bdf8cf933b7646659f9afc385787e531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461088Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
Bug: 1089619 Change-Id: I2ce420088488eeee1f093a146e80d01a6873f522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434597Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815599}
-
Andrew Shulaev authored
proto_library build rule for extension already has import_dirs pointing to //third_party/perfetto, which is needed for imports from track_event.proto to work. This makes it possible to use paths without third_party/perfetto, making verbatim copies of extension into Perfetto repository possible. Bug: 161696674 Change-Id: I6f77f1e8670599b48da464ddf57b71597941de36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462129 Commit-Queue: Andrew Shulaev <ddrone@google.com> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#815598}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602223197-364fdfa1722fdc996604dcc9a9de521cd4c0c0ad.profdata to chrome-linux-master-1602244639-8a31cdfac3c26c19c9de644309ff096c0a612320.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifc7041eca0c96b96f3a58ed85474c37964e6d3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462716Reviewed-by:
-
Yi Gu authored
There have been new flaky type reported on Mac recently and the test on Win seems to be normal: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=virtual%2Fthreaded%2Ffast%2Fscroll-snap%2Fsnaps-after-keyboard-scrolling.html Bug: 1056957 Change-Id: I2f6afefbee94ecae09ca09503df55afcc12d2c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463323Reviewed-by:
-
Philipp Hancke authored
webrtc-internals shows some of the the provisional stats which are not exposed to getStats. This is confusing when comparing the results, hence mark them and explain how they are marked. Drive-by: explain that [] are calculated. BUG=chromium:678292 Change-Id: Ide9d3b24fec6c8b57f2f982e42f93800c209f3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461339Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#815595}
-
Richard Knoll authored
This class will get more logic to show / hide notifications so extracting it into a separate file so we can test it easily. Also moves construction into the NotificationDisplayService so we can handle dependencies there. Bug: 1131375 Change-Id: I7693c18f4e2f8e677b9eb4c40079dfde802140f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452649Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#815594}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602223197-d9c33dbbd5ccae4e4a4bd70010f4c3ef94132fb3.profdata to chrome-mac-master-1602244639-6cd23926ee4e898bd11627c63cc4edf5ffd59847.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8e6670da96a83279fc57a5ccff10136434036d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463383Reviewed-by:
-
Richard Knoll authored
If a NotificationDelegate calls RemoveNotification in the Close handler we're trying to close it twice if the user clicks the "Close all" button in the message center. Instead remove the Notification from the list before calling Close so the next call exits early and is a noop as expected. This was fixed for RemoveNotification before in crrev.com/c/2330019 and this CL implements the same fix for RemoveAllNotifications. Bug: 1135709 Change-Id: I27e365957554c56a6cbea0200c408c6706189f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461119 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie97ce45f6b57218e5e7c61405348415385557282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462229Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#815591}
-
Robert Ma authored
This was likely missed in https://crrev.com/c/1769846. With this change, kill_tree now works on Windows and Linux in the same way. Change-Id: Ib5de5bff3ab934846e46ee0e9210d5be5f308dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462197Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#815590}
-
Aya ElAttar authored
No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: bsheedy@chromium.org Bug: 1136875 Change-Id: Icfc17da6cb3633697ef0c09f2e8a7a5b7e617edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461385Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#815589}
-
Fredrik Söderqvist authored
Implement ingenious idea for image document. Bug: 844743 Change-Id: I6fa9b373999a77e1a8eb8fd399b8f0e59834063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455448 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Richard Knoll authored
This test was flaky because the NotificationShownCallback is called before the new notification is added to the expected map. Changed it now to wait until that is the case and re-enabled the test. Bug: 1135576 Change-Id: I659c4acd4f6ae531748d4e428d7cb7e338bfd084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453250 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Updates a few chrome/ui classes for compatibility with ephemeral Guest profiles. Ephemeral guest profiles are not off-the-record and cannot open an Incognito window or have bookmarks, but they have history and Recent Tabs menu, and Clear Browsing Data option. Please see go/guest-on-disk for more context. Bug: 1125474 Change-Id: I8a1f6ceb03d4c72f310b225211728f8eaeb0d296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449250Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#815586}
-
Ryan Daum authored
* Registers and watch for text input focus events within webview content. * Defines a new gRPC payload for said events, and broadcasts them. Bug: internal b/161811385 Test: manually with wayland client tool Change-Id: Ie6d5167bc21f40d603e990b08a3e27b3802eeafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422501Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#815585}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 68a10bbc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I0b3cfcda931d91f8d8d963c3d7dbae28d1363dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460947Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815584}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c2d888fdffc..2bf76269e147 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib4bfdd4b8a29aa91096e423d033cc32859a2799d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462170Reviewed-by:
-
Rune Lillesveen authored
Both enabled on stable since M81. Bug: 925935, 939811 Change-Id: I558796309333c598169749e34b8f6a297837e4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461376Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#815582}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c2d888fdffc..2bf76269e147 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idc51544693482594bfcbbdcc48609a2718de4fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462169Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit eea6b735. Reason for revert: This new test is making any subsequent test fail, thus constantly failing the builder. Original change's description: > [iOS] Add New Window EG test. > > Original CL by marq: crrev/2424125 > > - Adds a cleanup step to EarlGreyTestCase that closes all but one window. > > - Adds test utilities for closing all (but one) windows, counting windows, > and waiting for a specific window count. > > - Adds a test utility to check for multiple window support. > > - Adds a simple test of the tools menu "New Window" item. > > - Updates & reenables the history and bookmarks EG tests to wait for a > window count (and to skip the tab-closing step, which wouldn't have > closed the window in any case). > > Bug: 1126893 > Change-Id: Id6b3ab02058e0db036045b0653a716fe19271b74 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450096 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Commit-Queue: Mark Cogan <marq@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815179} TBR=marq@chromium.org,stkhapugin@chromium.org Change-Id: I5d9d449a91c4032446cc61b0b27d521e6ae50103 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463322Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4fe27472..11158c21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibdda0cebc622b6426676d644842f103f5ee4007f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460948Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815579}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/56df381f7893..e611beb18340 2020-10-09 dberris@chromium.org auto-triage: Assign to sheriff for single-CL range 2020-10-09 dberris@chromium.org pinpoint: Always re-assign to culprit owners 2020-10-09 dberris@chromium.org chromeperf: Fix issue management If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1122554,chromium:1131908,chromium:1136443 Tbr: sadrul@google.com Change-Id: Ibc0e35f81fb15bb75ef910627798a5a8100ba46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462778Reviewed-by:
-
