GitLab

this is the biggest chunk I can pull out vaguely cleanly.  It does contain a
couple of fake calls to keep the compiler happy.
This CL also makes SetUpMetadata a member in order to ease testing in a later CL.

This depends on https://codereview.chromium.org/261843004/.

BUG=108012

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270016

Review URL: https://codereview.chromium.org/266333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273048 0039d316-1c4b-4281-b951-d872f2087c98

A workaround until ImageGrid switches to cc::NinePatchLayer.

BUG=376519

Review URL: https://codereview.chromium.org/302513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273046 0039d316-1c4b-4281-b951-d872f2087c98

This is a no-op since over a month ago:
https://codereview.chromium.org/206463009/

So it's probably safe to remove the Chromium code which plumbs
this preference around before Blink drops it on the floor.

After this lands, WebSettings::setFixedPositionCreatesStackingContext
can be removed entirely.

BUG=354688

Review URL: https://codereview.chromium.org/289973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273045 0039d316-1c4b-4281-b951-d872f2087c98

Change kEnableAudioTrackProcessing to a disable flag and remove finch code for AudioTrackProcessing.

The plan is to enable audio processing in getUserMedia as default for M37, and keep a kDisableAudioTrackProcessing flag to be able to fall back to the old path.

BUG=365672
TEST=bots

Review URL: https://codereview.chromium.org/293023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273044 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/293383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273042 0039d316-1c4b-4281-b951-d872f2087c98

This introduces a new mechanism for determining when
we're ready to activate the pending tree. The tile
priority is still used to determine when it's worth
waking up the compositor thread and evaluating if
we can activate. However, the actual check that
determines if we're ready to activate doesn't rely
on the state of scheduled raster tasks but is a
synchronous call on each layer.

The result is a pending tree activation mechanism that
is much easier to debug and validate for correctness,
while still providing the performance benefits of the
old mechanism by taking the "required to activate" field
of the tile priority into account when scheduling tasks.
 
BUG=375206
TEST=cc_unittests --gtest_filter=PictureLayerImplTest.AllTilesRequiredForActivationAreReadyToDraw

Review URL: https://codereview.chromium.org/287643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273040 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273039 0039d316-1c4b-4281-b951-d872f2087c98

control (whitespace change) is at https://codereview.chromium.org/300853004

NOTRY=True

Review URL: https://codereview.chromium.org/301723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377386
TEST=See bug, comment #2.

Review URL: https://codereview.chromium.org/300063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273037 0039d316-1c4b-4281-b951-d872f2087c98

if the target is not in english, adb_profiler_chrome can 
not know when the profiler is started and finished.
because adb_profiler_chrome uses only english regex for
parsing the logs. So this is a patch for showing the logs 
in english, however it still shows toasts by following 
the target's locale.

BUG=373505

Review URL: https://codereview.chromium.org/282813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273035 0039d316-1c4b-4281-b951-d872f2087c98

This method isn't necessary any longer. This is a small change to clean up more
of the OpenManifestEntry logic and move it out of the trusted plugin.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/296403010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273034 0039d316-1c4b-4281-b951-d872f2087c98

Major change:
- Make BrowserMediaPlayerManager (BMPM) a per RenderFrame object.
- Introduce MediaWebContentsObserver (MWCO) which managers all BMPMs.
- MWCO forwards all IPCs to BMPM.

Other changes necessary to switch from RenderView to RenderFrame:
- Use MediaWebContentsObserver to send PauseVideo message to render.
- Use render frame routing ID to set surface peer.

VIDEO_HOLE related changes:
- Add DidCommitCompositorFrame() to RenderFrameObserver.
- Add OnFrameInfoUpdated() to MediaWebContentsObserver.

BUG=338910
TEST=Tested with test pages and Youtube purchased movies.

Review URL: https://codereview.chromium.org/278353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273033 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377813

Review URL: https://codereview.chromium.org/284113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273032 0039d316-1c4b-4281-b951-d872f2087c98

desktop-chromium can trace memory status in about://tracing.
as same as desktop, this patch enables android to use 
disabled-by-default-memory option in adb_profile_chrome script.

BUG=None

Review URL: https://codereview.chromium.org/291723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273030 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174780:174877&mode=html
TBR=alph@chromium.org,esprehn@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/298063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273029 0039d316-1c4b-4281-b951-d872f2087c98

Add info for when sessionId is not provided in the restore function.

R=kalman@chromium.org
BUG=377607

Review URL: https://codereview.chromium.org/295423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273028 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
BUG=

Review URL: https://codereview.chromium.org/303663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273027 0039d316-1c4b-4281-b951-d872f2087c98

The android browser compositor removed support for sync readback.  Support for
async readback was added (https://codereview.chromium.org/281003002/).  This
patch adds a Java-side API through the existing ContentReadbackHandler.

android= https://chrome-internal-review.googlesource.com/#/c/164043/
BUG=252046

Review URL: https://codereview.chromium.org/297683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273026 0039d316-1c4b-4281-b951-d872f2087c98

This patch ensures that if a tile is initialized mid-iteration (as is
desirable in some unittests), then it will continue working as expected.

R=reveman

Review URL: https://codereview.chromium.org/295933008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273025 0039d316-1c4b-4281-b951-d872f2087c98

This cleans up some usage of TempFile and some logic inside PnaclCoordinator to
make it easier to follow. I made these changes while doing some other cleanup
for DescWrapper use in the trusted plugin.

BUG=333950
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/299143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273024 0039d316-1c4b-4281-b951-d872f2087c98

Introduce MaskedViewTargeter, a derived class of ViewTargeter.
Classes deriving from MaskedViewTargeter will be used to define a
custom-shaped hit test mask on a view to be considered in
event targeting.

BUG=375826
TEST=ViewTargeterTest.MaskedViewTargeter

Review URL: https://codereview.chromium.org/286933014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273023 0039d316-1c4b-4281-b951-d872f2087c98

Fix WeakPtrFactory member order in net/spdy/ & net/dns/

BUG=303818

Review URL: https://codereview.chromium.org/301573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273022 0039d316-1c4b-4281-b951-d872f2087c98

when determining if an extension is enabled before it's loaded or the
service is ready.

BUG=376963
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/292223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273021 0039d316-1c4b-4281-b951-d872f2087c98

If the user enters a chrome-extension:// url with an invalid extension
id, let's not crash. That's rude.

Instead, origin chip will display <id> as extension name, show a "page
not available" message.

BUG=375426

Review URL: https://codereview.chromium.org/291173008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273020 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273018 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have broken some ChromeOS bots with this error:
dump_syms: /var/tmp/portage/chromeos-base/google-breakpad-1303-r82/work/google-breakpad-1303/src/common/dwarf/dwarf2reader.cc:188: const char* dwarf2reader::CompilationUnit::SkipAttribute(const char*, dwarf2reader::DwarfForm): Assertion `header_.version == 2 || header_.version == 3' failed.

> NaCl: Update revision in DEPS, r13226 -> r13245
> 
> This pulls in the following Native Client changes:
> 
> r13227: (dyen) Standardized method to define extra substitution paths in toolchain_main.
> r13228: (dschuff) Do not build PNaCl host toolchain with build.sh
> r13229: (sbc) Add downloaded gn binaries to .gitignore
> r13230: (dschuff) Remove cloud-bucket flag from PNaCl package_version update script
> r13231: (bradnelson) Download spec2k to out instead of assuming it will be installed on the bots.
> r13232: (dschuff) Make build.sh use the repository directories from toolchain/build
> r13233: (jvoung) Download the spec harness on the rest of the spec bots.
> r13234: (sehr) Disable conflicting sysroot= in chromium arm build
> r13235: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13236: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13237: (dschuff) Update revision for PNaCl r13222->r13228
> r13238: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13239: (mcgrathr) toolchain_build: Update gcc revision (4.8.3 release)
> r13240: (mseaborn) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13241: (noelallen) Add OWNERS per-file *.gn for noeallen and bradnelson
> r13242: (noelallen) Untar raw toolchain and build cooked toolchain.
> r13243: (mcgrathr) Update nacl_arm_newlib toolchain
> r13244: (dyen) Toolchain build now displays solutions when an invalid repo is found.
> r13245: (mseaborn) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> 
> Review URL: https://codereview.chromium.org/300033004

TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/303703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273017 0039d316-1c4b-4281-b951-d872f2087c98

This adds ppapi-related targets except the tests to the GN build.

Did some minor tweaks to the .gypi ppapi lists. Some files were duplicated between the trusted and common lists which causes errors in GN (it doesn't uniquify the lists like GYP). Common is used in every place trusted is, so I just removed the duplicates from the trusted list.

Fixed some warnings in skia and tcmalloc. Added the ability to undefine NOMINMAX on Windows.

Fixed some src/ui Windows compilation issues.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/305513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273016 0039d316-1c4b-4281-b951-d872f2087c98

This brings in a version of naclports that doesn't contain
a conflicting definition of realpath(3).  Not sure how the
previous roll passed my local testing its r1290 that we
really need.

TBR=binji

Review URL: https://codereview.chromium.org/303663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273015 0039d316-1c4b-4281-b951-d872f2087c98

Make tooltips have their own toplevel window on Linux. This allows tooltips for bookmarks in a menu not to be clipped.

BUG=353533
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/290573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273014 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/293133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273013 0039d316-1c4b-4281-b951-d872f2087c98

Will fetch server thumbnails if they are available. Using the BitmapFetcher to obtain and decode images.

I've tested with a subsequent CL that modifies suggestions_source.cc.

Next CLs will implement local caching once the image is fetched.

BUG=None
TEST=ThumbnailManagerTest,ThumbnailManagerBrowserTest

Review URL: https://codereview.chromium.org/299713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273012 0039d316-1c4b-4281-b951-d872f2087c98

Lock Rotation when screen is manually rotated.
This re-lands: https://codereview.chromium.org/261163004
which was reverted by: https://codereview.chromium.org/271133002
64065053.

Additionally DisplayManager now accepts a source of display rotations. Those triggered by explicit user input (display settins, ctrl+shift+f3) will be stored as a part of display settings. Those triggered by rotation will not.

Upon exiting maximize mode the display will be returned to the last rotation explicitly set by a user.

TEST=MaximizeControllerModeTest
TEST=DisplayPreferencesTest
BUG=371426
BUG=369505

Review URL: https://codereview.chromium.org/289583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273011 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273010 0039d316-1c4b-4281-b951-d872f2087c98

This fixes traces failing to import on linux, as reported in https://code.google.com/p/trace-viewer/issues/detail?id=559

TBR=dsinclair
NOTRY=True

Review URL: https://codereview.chromium.org/302773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273009 0039d316-1c4b-4281-b951-d872f2087c98

The plan is to further split the file: functions.h (or something like
that) for common/basic functions, message_pipe.h, data_pipe.h, etc.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/307533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273008 0039d316-1c4b-4281-b951-d872f2087c98

This CL does the following:
* Moves chrome://network resources into their own directory
* Separates 'requestNetworkInfo' into two separate methods:
** NetworkUI.getNetworkLog
** networkConfig.getNetworks
* Moves networkConfig methods into their own module
** networkConfig emulates a subset of the chrome.networkingPrivate extension API
** This module will later also be used by the internet options JS code

BUG=366365
For c/b/browser_resources.grd:

R=armansito@chromium.org, pneubeck@chromium.org, xiyuan@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/260083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273007 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/292203010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273005 0039d316-1c4b-4281-b951-d872f2087c98

R=binji@chromium.org, binji
BUG=377084

Review URL: https://codereview.chromium.org/296413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273004 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Refactor and move ash independent nested accelerator code to ui/wm/core (https://codereview.chromium.org/298703007/)

Reason for revert:
caused test failures:
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19236

NestedAcceleratorTest.AcceleratorsHandled (run #1):
[ RUN      ] NestedAcceleratorTest.AcceleratorsHandled
Backtrace:
	ui::PlatformEventSource::OverrideDispatcher [0x0028B66D+253]
	wm::test::NestedAcceleratorTest_AcceleratorsHandled_Test::TestBody [0x00455D37+215]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x004D5829+329]
	testing::Test::Run [0x004EFF9E+174]
	testing::TestInfo::Run [0x004F023D+221]
	testing::TestCase::Run [0x004F00DF+239]
	testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x004D5D21+337]
	testing::UnitTest::Run [0x004F0393+211]
	RUN_ALL_TESTS [0x004A0EDF+15]
	base::TestSuite::Run [0x004A1129+233]
	base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>::Run [0x004150EB+27]
	base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo [0x00414FFA+26]
	base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int __cdecl(base::TestSuite *)>::Ru [0x0041506A+74]
	base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47]
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921]
	base::LaunchUnitTests [0x00498D15+37]
	main [0x0041681C+140]
	__tmainCRTStartup [0x00647D39+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
	mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
	BaseThreadInitThunk [0x76568624+14]
	RtlInitializeExceptionChain [0x773CAC69+133]
	RtlInitializeExceptionChain [0x773CAC3C+88]


NestedAcceleratorTest.AssociatedWindowAboveLockScreen (run #1):
[ RUN      ] NestedAcceleratorTest.AssociatedWindowAboveLockScreen
Backtrace:
	ui::PlatformEventSource::OverrideDispatcher [0x0286B66D+253]
	wm::test::NestedAcceleratorTest_AssociatedWindowAboveLockScreen_Test::TestBody [0x004563B5+517]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x004D5829+329]
	testing::Test::Run [0x004EFF9E+174]
	testing::TestInfo::Run [0x004F023D+221]
	testing::TestCase::Run [0x004F00DF+239]
	testing::internal::UnitTestImpl::RunAllTests [0x004F0696+726]
	testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x004D5D21+337]
	testing::UnitTest::Run [0x004F0393+211]
	RUN_ALL_TESTS [0x004A0EDF+15]
	base::TestSuite::Run [0x004A1129+233]
	base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>::Run [0x004150EB+27]
	base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,void __cdecl(WMTestSuite *)>::MakeItSo [0x00414FFA+26]
	base::internal::Invoker\u003C1,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall base::TestSuite::*)(void)>,int __cdecl(base::TestSuite *),void __cdecl(base::internal::UnretainedWrapper\u003CWMTestSuite>)>,int __cdecl(base::TestSuite *)>::Ru [0x0041506A+74]
	base::Callback\u003Cint __cdecl(void)>::Run [0x0049A03F+47]
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x004990C9+921]
	base::LaunchUnitTests [0x00498D15+37]
	main [0x0041681C+140]
	__tmainCRTStartup [0x00647D39+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
	mainCRTStartup [0x00647E7D+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
	BaseThreadInitThunk [0x76568624+14]
	RtlInitializeExceptionChain [0x773CAC69+133]
	RtlInitializeExceptionChain [0x773CAC3C+88]


Original issue's description:
> Refactor and move ash independent accelerator handling code in nested loop to ui/wm/core
> 
> I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them.
> 
> BUG=None
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272740
> 
> R=ben@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272995

TBR=ben@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/301743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273003 0039d316-1c4b-4281-b951-d872f2087c98