GitLab

BUG=672263

Review-Url: https://codereview.chromium.org/2781263004
Cr-Commit-Position: refs/heads/master@{#462745}

Revert of Media Remoting: End to end integration tests. (patchset #4 id:120001 of https://codereview.chromium.org/2692593002/ )

Reason for revert:

Findit identified CL at revision 462739 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYwZDRlMGE2M2ViM2YyYmUyNmFjYTEyODFiZTI5YzY0YjBmNWM2NzAM

Original issue's description:
> Media Remoting: End to end integration tests.
>
> Add end to end integration tests for Media Remoting. Refactors
> PipelineIntegrationTest to test both media and media remoting pipeline.
> Re-use current tests. No new tests are added in this CL.
>
> BUG=684065
>
> Review-Url: https://codereview.chromium.org/2692593002
> Cr-Commit-Position: refs/heads/master@{#462739}
> Committed: https://chromium.googlesource.com/chromium/src/+/60d4e0a63eb3f2be26aca1281be29c64b0f5c670

TBR=miu@chromium.org,sandersd@chromium.org,xjz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=684065

Review-Url: https://codereview.chromium.org/2804183002
Cr-Commit-Position: refs/heads/master@{#462744}

Cr-Commit-Position: refs/heads/master@{#462743}

This was assuming that YUV to RGB conversion had been done if the output
format was YUV, which is the opposite of what should be happening.

Make the CHECK for extra YUV to RGB conversion happen always, by adding
a "can ignore for testing" flag for the pixel tests that violate this
assumption.

BUG=709099
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2799603006
Cr-Commit-Position: refs/heads/master@{#462742}

The problem is that it was registering as a TabObserver but
not removing itself.  This moves the TabObserver logic into
NewTabPage, which does handle proper clean up.

BUG=708710

Review-Url: https://codereview.chromium.org/2803063003
Cr-Commit-Position: refs/heads/master@{#462741}

This is a continuation of other work to move CSS.*Value types to the nested
namespace blink::cssvalue to avoid name collisions. I will be moving over type
2 or 3 at a time per CL. In some cases we need to temporarily introduce using
statements while we're shuffling the classes around. These will be cleaned up
once all types have been moved to blink::cssvalue.

BUG=667961

Review-Url: https://codereview.chromium.org/2804673003
Cr-Commit-Position: refs/heads/master@{#462740}

Add end to end integration tests for Media Remoting. Refactors
PipelineIntegrationTest to test both media and media remoting pipeline.
Re-use current tests. No new tests are added in this CL.

BUG=684065

Review-Url: https://codereview.chromium.org/2692593002
Cr-Commit-Position: refs/heads/master@{#462739}

Ideally this should be YUY2, but we have a fallback to B8G8R8A8 and
should check that it's being used at most very rarely.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2799183002
Cr-Commit-Position: refs/heads/master@{#462738}

BUG=709208

Review-Url: https://codereview.chromium.org/2800013002
Cr-Commit-Position: refs/heads/master@{#462737}

https://pdfium.googlesource.com/pdfium.git/+log/c758d9dd3f94..8a24b25ee0b0

$ git log c758d9dd3..8a24b25ee --date=short --no-merges --format='%ad %ae %s'
2017-04-06 thestig Clean up CBC_QRCoderVersion and friends.

Created with:
  roll-dep src/third_party/pdfium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2807553002
Cr-Commit-Position: refs/heads/master@{#462736}

Subsequence display items cause complications for the SPv2 compositing algorithm
because they confuse the PaintChunker. Also, they are the last remaining
paired display item in SPv2 that blocks simplifying the display list format.

BUG=692614

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2793233002
Cr-Commit-Position: refs/heads/master@{#462735}

ValueStore::Status mirrors a leveldb "Status" object which contains an error/success code and a string message.

LevelDB is carefully written so that an "OK" status does not have a message associated with it. But then in the Chrome ValueStore code the string is unconditionally retrieved (LevelDB maps this to "OK") and then expensive search-and-replace operations are performed on it.

This changes the levelDB "Status" to avoid the status string on "OK". This no-string-on-OK state is already implied by the Status header.

Review-Url: https://codereview.chromium.org/2799543002
Cr-Commit-Position: refs/heads/master@{#462734}

Allow the embargo status of a permission to be cleared when the user changes the
setting for an embargoed permission to "Ask" or "Allow". However, the system
will still remember that the setting was previously embargoed, so if another
permission prompt is dismissed for that permission, it will be re-embargoed.
Permissions embargoed because they are blacklisted will be re-embargoed if they
are still on the blacklist during the next permission request.

BUG=704771
TEST=Run Chrome with the command line flag
--enable-features=BlockPromptsIfDismissedOften and navigate to
https://permission.site. Place the notification permission under embargo by
clicking the "Notifications" button three times until the permission prompt no
longer appears. In the page info bubble, the "Notifications" drop-down should
say "block". Choose "Allow" instead, which should update the bubble to allow
notifications and ask for the page to be reloaded. Then change the drop-down to
"Ask", which should also update the notifications permission back to "Ask".
Click the "Notifications" button on the page again and notice the permission
prompt to ask for notifications permission is shown again.

Review-Url: https://codereview.chromium.org/2790473004
Cr-Commit-Position: refs/heads/master@{#462733}

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2803543003
Cr-Commit-Position: refs/heads/master@{#462732}

This CL adds |supports_torch| to mojom.PhotoCapabilities, to differentiate
the capability from the actual value of |torch|, and wires it
for the Android implementations and for the LayoutTests.

Tested via unittests and manual test using
https://rawgit.com/Miguelao/demos/master/imagecapture.html

BUG=700607

Review-Url: https://codereview.chromium.org/2798263003
Cr-Commit-Position: refs/heads/master@{#462731}

This check was previously added for OriginTrialEnabled and SecureContext
(r461653). This applies the same check to FeaturePolicy which has the
same limitation (i.e., this *should* work but currently generates broken
code where FeaturePolicy is totally ignored, and therefore must be a
compile-time error for now.

BUG=695123

Review-Url: https://codereview.chromium.org/2802873003
Cr-Commit-Position: refs/heads/master@{#462730}

BUG=709148
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2803853002
Cr-Commit-Position: refs/heads/master@{#462729}

Since string is called string in Google3 but std::string in Chromium,
an alias is needed to make the two codebases identical.

Also ran git cl format.

This CL lands server change 151592591 by bnc.

BUG=488484

Review-Url: https://codereview.chromium.org/2801603003
Cr-Commit-Position: refs/heads/master@{#462728}

The issue is that the set of datatypes requested for configuration doesn't
match the set of update handlers registered with ModelTypeRegistry. This causes
segfault. The reason for it is that the types to configure are decided at the
time of configuration call in DataTypeManagerImpl on UI thread, while update
handlers are settled at the time of sync cycle execution (couple of posts on
sync thread later). Some update handlers can get unregistered by this time (the
bug has a description of scenario that can lead to this issue). This issue is
only applicable to configuration sync cycle since during normal sync cycle set
of datatypes is derived from ModelTypeRegistry.

The fix is to remove unregistered types from types to configure in
Syncer::ConfigureSyncShare.

BUG=703253
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2804743004
Cr-Commit-Position: refs/heads/master@{#462727}

These are getting thrown, but don't make any sense because we explicitly ask for
INTERNET permission.  Guessing rooted devices aren't playing nice with our
manifests.

BUG=708908

Review-Url: https://codereview.chromium.org/2805063002
Cr-Commit-Position: refs/heads/master@{#462726}

BUG=

Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801053002
Cr-Commit-Position: refs/heads/master@{#462725}

We are attempting to log metrics before native is initialized.

BUG=706400

Review-Url: https://codereview.chromium.org/2803943005
Cr-Commit-Position: refs/heads/master@{#462724}

This test just verifies that if a score is injected for a single URL then
that URL will appear in the site engagement WebUI, to protect against
changes which break some part of the pipeline from the scoring service
to the UI.

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2780873003
Cr-Commit-Position: refs/heads/master@{#462723}

BUG=707487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796343004
Cr-Commit-Position: refs/heads/master@{#462722}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ea02aa5af9f1..e650872309eb

$ git log ea02aa5af..e65087230 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 eakuefner [Catapult] Prune unused dependencies from third_party/polymer
2017-04-06 eakuefner [Catapult] Roll bower dependencies
2017-04-06 eakuefner [Catapult] Roll paper-styles only

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2798393004
Cr-Commit-Position: refs/heads/master@{#462721}

BUG=

Review-Url: https://codereview.chromium.org/2799983002
Cr-Commit-Position: refs/heads/master@{#462720}

https://skia.googlesource.com/skia.git/+log/9a121cc6ad74..7d3d87233190

$ git log 9a121cc6a..7d3d87233 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 mtklein jumper, gather_i8
2017-04-06 robertphillips Update stencil ops to have a parallel proxyID
2017-04-06 mtklein jumper, more gathers

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: Ib41d69656ee1ef494c8923f16c0580fb43e9ab26
Reviewed-on: https://chromium-review.googlesource.com/470746Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#462719}

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill,geofflang,piman

Review-Url: https://codereview.chromium.org/2802613006 .
Cr-Commit-Position: refs/heads/master@{#462718}

This makes the MainMenuItem accessible with a keyboard.

BUG=708902

Review-Url: https://codereview.chromium.org/2805763002
Cr-Commit-Position: refs/heads/master@{#462717}

Fix printer flaky bugs by adding another wait.
The bug is flaky because tests only wait for UI tasks to be completed,
but since PrintersManagerFactory uses
content::BrowserThread::GetBlockingPool() to schedule ModelTypeStore
initialization, and then reply result to UI thread, so we need to wait
on content::BrowserThread::GetBlockingPool() as well.

Remove unnecessary changes from
https://codereview.chromium.org/2758643002 since that did not really
fix this waiting issue.

BUG=689662, 701999

Review-Url: https://codereview.chromium.org/2799103002
Cr-Commit-Position: refs/heads/master@{#462716}

BUG=None
TEST=None

Change-Id: Id8697dae440df7f2d247dc06d69ba5c424ea50a6
Review-Url: https://codereview.chromium.org/2799943003
Cr-Commit-Position: refs/heads/master@{#462715}

This CL:
* Hides the subpage arrow when Bluetooth is disconnected.
* Fixes the dropdown text to 'Connect' for paired but disconnected

BUG=709079,705682
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2799163003
Cr-Commit-Position: refs/heads/master@{#462714}

These __gCrWeb APIs are only used in crw_context_menu_controller.mm.
They are moved to a new context-menu.js file:
- getElementFromPoint
- suppressNextClick
- getPageWidth

TEST=ran ios_web_unittests locally

BUG=614092

Review-Url: https://codereview.chromium.org/2800003002
Cr-Commit-Position: refs/heads/master@{#462713}

This class covers the entire connection process, from a UI callback (when the user clicks a tether network) to connecting to the associated device's Wi-Fi network.

BUG=672263

Review-Url: https://codereview.chromium.org/2792483002
Cr-Commit-Position: refs/heads/master@{#462712}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/126ec661..c5350347

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2807533002
Cr-Commit-Position: refs/heads/master@{#462711}

Copy some colors, actually simulate the toolbar.
Generally make things super fast.

R=esprehn@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2803653003
Cr-Commit-Position: refs/heads/master@{#462710}

Using wpt-import in Chromium 2ad62ba5.

Directory owners for changes in this CL:
dom-dev@chromium.org:
  external/wpt/dom
  external/wpt/html
  external/wpt/media
domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org:
  external/wpt/streams
dtapuska@chromium.org:
  external/wpt/uievents
foolip@chromium.org, maksim.sisov@intel.com:
  external/wpt/webvtt
hta@chromium.org:
  external/wpt/webrtc
jfernandez@igalia.com:
  external/wpt/css/css-align-3
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/storage
  external/wpt/IndexedDB
  external/wpt/FileAPI
kojii@chromium.org:
  external/wpt/css/css-rhythm-1
  external/wpt/css/css-writing-modes-3
mcasas@chromium.org:
  external/wpt/mediacapture-record
mek@chromium.org:
  external/wpt/webmessaging
michaeln@chromium.org, jsbell@chromium.org:
  external/wpt/webstorage
nhiroki@chromium.org:
  external/wpt/workers
ortuno@chromium.org, scheib@chromium.org:
  external/wpt/bluetooth
rego@igalia.com:
  external/wpt/css/css-ui-3
  external/wpt/css/selectors4
shimazu@chromium.org:
  external/wpt/service-workers
style-dev@chromium.org:
  external/wpt/css/cssom-view-1
  external/wpt/css/cssom-1
suzyh@chromium.org:
  external/wpt/web-animations

TBR=qyearsley@chromium.org
NOEXPORT=true

Change-Id: I82e0d83896434defda8a6a864d07dbbfcfa78d96
Reviewed-on: https://chromium-review.googlesource.com/470328Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#462709}

Make |using_ssl_| a const. This makes the code slightly easier to read.

BUG=475060

Review-Url: https://codereview.chromium.org/2803023004
Cr-Commit-Position: refs/heads/master@{#462708}

Currently, extensions which are disabled in incognito mode are also loaded in an
incognito renderer. This is redundant and can cause non-required bindings to be
generated in the renderer. Also, it has potential security implications.

Prevent this by only loading incognito-enabled extensions in an incognito
renderer. However extensions which can't be enabled in the incognito mode (e.g.
platform apps etc.) still need to be loaded in incognito renderers, so that
incognito tabs can connect with them (issue 305394).

Also, add tests for the same.

BUG=527548

Review-Url: https://codereview.chromium.org/2766263003
Cr-Commit-Position: refs/heads/master@{#462707}

Also, re-enables switching from sw to accelerated canvas.

BUG=704571

Review-Url: https://codereview.chromium.org/2799033002
Cr-Commit-Position: refs/heads/master@{#462706}