GitLab

Landing http://codereview.chromium.org/334026.

BUG=20825,23780,24200
TEST=none
Review URL: http://codereview.chromium.org/338039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30174 0039d316-1c4b-4281-b951-d872f2087c98

Times New Roman of Windows XP doens't have a glyph for U+1E3F though
Windows Vista has.  It makes different results for U+1E3F rendering.

BUG=25617
TEST=none
Review URL: http://codereview.chromium.org/333025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24472

Review URL: http://codereview.chromium.org/337035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30172 0039d316-1c4b-4281-b951-d872f2087c98

>	chrome.dll!`anonymous namespace'::OnNoMemory()  Line 126	C++
	chrome.dll!_invalid_parameter_noinfo()  Line 99 + 0xc bytes	C++
	chrome.dll!RefCountedBytes::front()  Line 67 + 0x1b bytes	C++
	chrome.dll!BookmarkModel::OnFavIconDataAvailable(int handle=8, bool know_favicon=true, scoped_refptr<RefCountedBytes> data={...}, bool expired=true, GURL icon_url={...})  Line 652 + 0x2b bytes	C++

It seems RefCountedBytes data has no data. If data size is 0, accessing front
of data would cause crash.
By checking its size, fixes this crash.

BUG=25803
TEST=no crash on startup

Review URL: http://codereview.chromium.org/328037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30171 0039d316-1c4b-4281-b951-d872f2087c98

(see discussion and history there)

BUG=10876
TEST=FilePathTest.MatchesExtension.CompareIgnoreCase


TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/337042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30170 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/333042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30169 0039d316-1c4b-4281-b951-d872f2087c98

(see discussion and history there)

BUG=10876
TEST=FilePathTest.MatchesExtension.CompareIgnoreCase


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30168 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=25354
Review URL: http://codereview.chromium.org/329035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/334033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25873
TEST=unittest


Review URL: http://codereview.chromium.org/330026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30165 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=25354
Review URL: http://codereview.chromium.org/329033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30164 0039d316-1c4b-4281-b951-d872f2087c98

Simplify threading in browser thread by making only ChromeThread deal with different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread.  If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching.  With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354
Review URL: http://codereview.chromium.org/306032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98

Revert (4 of 4) 30153 - Introduce browser_sync::ExtensionsActivityMonitor to collect extensions API usage
for correlation to sync commit requests.  Add ChromiumExtensionsActivity to sync.proto
to allow passing this data to sync servers.

BUG=25323
TEST=Added ExtensionsActivityMonitorTest. +Performing mutations on the bookmarks model via an extension should result in
ChromiumExtensionsActivity for each such extension showing up in CommitMessages.

Review URL: http://codereview.chromium.org/325001

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/333040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30162 0039d316-1c4b-4281-b951-d872f2087c98

Revert (3 of 4) 30154 - Fix build bustage by adding dependency back on sync_proto from sync_unit_tests.

TBR=nick

Review URL: http://codereview.chromium.org/334038

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/333039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30161 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333037

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/337039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30160 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333038

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/328036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30159 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30157 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30156 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/334038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30154 0039d316-1c4b-4281-b951-d872f2087c98

for correlation to sync commit requests.  Add ChromiumExtensionsActivity to sync.proto
to allow passing this data to sync servers.

BUG=25323
TEST=Added ExtensionsActivityMonitorTest. +Performing mutations on the bookmarks model via an extension should result in
ChromiumExtensionsActivity for each such extension showing up in CommitMessages.

Review URL: http://codereview.chromium.org/325001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30153 0039d316-1c4b-4281-b951-d872f2087c98

Revert 30149 - The existing file_util::AbsolutePath() function was already doing what we needed to do in the ExtensionResource class.

BUG= http://crbug.com/25681 & http://crbug.com/25131

Review URL: http://codereview.chromium.org/334028

TBR=mad@chromium.org
Review URL: http://codereview.chromium.org/335042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25200
TEST=perf bots stay green

Review URL: http://codereview.chromium.org/334034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30151 0039d316-1c4b-4281-b951-d872f2087c98

The existing file_util::AbsolutePath() function was already doing what we needed to do in the ExtensionResource class.

BUG= http://crbug.com/25681 & http://crbug.com/25131

Review URL: http://codereview.chromium.org/334028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30149 0039d316-1c4b-4281-b951-d872f2087c98

Make the memory resource functions return bools so that we know when the information is not available. Refactor TaskManager slightly.

BUG=23366
TEST=See "N/A" for memory usage in Linux task manager

Review URL: http://codereview.chromium.org/339012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30148 0039d316-1c4b-4281-b951-d872f2087c98

Patch authored by Thiago Farina (thiago.farina@gmail.com)

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/328025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30147 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30146 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ojan

Review URL: http://codereview.chromium.org/334037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30144 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25200
TEST=buildbot tests work

Review URL: http://codereview.chromium.org/335039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30143 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/338032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30140 0039d316-1c4b-4281-b951-d872f2087c98

It would work with:
   dump_cache.exe foo bar baz
But it would fail with:
   dump_cache foo bar baz

The latter caused an odd crash which was all too difficult to
find!

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/330024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30139 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/328027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30138 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21908

TEST=Control-click on the bookmark bar, either on an existing folder
or on the blank area and choose "Add Folder..." from the contextual
menu. A sheet will drop down from the bookmark bar asking for the name
of the folder to add. The edit field will be populated with the
proposed name 'New folder'. ('New folder' will be appropriately
localized.)


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30136 0039d316-1c4b-4281-b951-d872f2087c98

libdbus-glib uses the glib main loop internally.  We were making calls on a background thread that wound up telling libdbus-glib to get a connection to the system bus on said background thread.  This led to a background thread trying to use the same glib main loop as Chrome's UI thread, and concurrency issues led to crashing.  Sadly, there can be only one main loop per process, as I understand it.

This code takes away the attempts to use the background thread.  As our interaction with dbus is semantically asynchronous, this seems ok to me. 
Review URL: http://codereview.chromium.org/339013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30135 0039d316-1c4b-4281-b951-d872f2087c98

extension_action.*.

Final bit of refactor will be to rename ExtensionAction2 to
ExtensionAction will be the next CL.

BUG=24472,25844

Review URL: http://codereview.chromium.org/332021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30133 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=builds ok
Review URL: http://codereview.chromium.org/295049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30132 0039d316-1c4b-4281-b951-d872f2087c98

on Mac and Linux as it does on Windows.

BUG=25869
TEST=about:terms should work.  In a branded build, terms should show up.
     In an unbranded build, the about:terms page is supposed to be blank,
     but there should be some skeletal HTML visible in "View Source".
Review URL: http://codereview.chromium.org/338028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30130 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30129 0039d316-1c4b-4281-b951-d872f2087c98

The following descriptions were taken from <http://blogs.msdn.com/wndp/articles/IPV6_PAC_Extensions_v0_9.aspx> 

---------------------------- 
* myIpAddressEx(): 
Returns a semi-colon delimited string containing all IP addresses for localhost (IPv6 and/or IPv4), or an empty string if unable to resolve localhost to an IP address. 

* dnsResolveEx(host): 
Returns semi-colon delimited string containing IPv6 and IPv4 addresses or an empty string if host is not resolvable. 

* isResolvableEx(): 
Returns TRUE if the host is resolvable to a IPv4 or IPv6 address, FALSE otherwise. 
---------------------------- 

These differ from the vanilla PAC functions in the following ways: 

* myIpAddressEx() returns all the addrsses for localhost (including IPv6 ones), whereas myIpAddress() only returns the first IPv4 one. 
* On failure, myIpAddress() returns "127.0.0.1" whereas on failure myIpAddressEx() returns empty string. 
* dnsResolveEx() returns a list of addresses (including IPV6 ones), whereas dnsResolve() only returns the first IPv4 address. 
* On failure, dnsResolve() returns |null|, whereas on failure dnsResolveEx() returns empty string. 

BUG=25407
TEST=ProxyResolverV8Test.DNSResolutionFailure, ProxyResolverJSBindingsTest.RestrictAddressFamily, ProxyResolverJSBindingsTest.ExFunctionsReturnList
Review URL: http://codereview.chromium.org/333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30127 0039d316-1c4b-4281-b951-d872f2087c98

TEST=run the unittests and watch them pass.
BUG=none

Review URL: http://codereview.chromium.org/334016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30126 0039d316-1c4b-4281-b951-d872f2087c98