- 04 Nov, 2019 40 commits
-
-
Christopher Cameron authored
Implement ScrollbarThemeMac::PaintScrollCorner. This function needs to know properties of its vertical scrollbar (is it on left or right, is it in dark mode, etc), to be correctly implemented. Plumb these arguments through. Pass by pointer for fear that they not always exist. Determine the CocoaScrollbarPainter::Params from the Cocoa ScrollbarAnimator and ScrollbarPainter classes. Leave all of the code to update those classes in place, as an incantation (attempts to change it cause bizarre bugs -- it needs to be removed in one go). Update layout tests. Bug: 961835 Change-Id: I883c5614ebfaaab3c0cf32117d210392ffec030a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889296 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712346}
-
Shimi Zhang authored
Event listeners for the injected JS object are different from evaluateJavascript() in a way that evaluateJavascript() will execute the JavaScript immediately when it reaches to the renderer, however JJI's event listener posted to the event loop asynchronously. So we can't expect that a listener is executed before evaluateJavascript(). This CL changed the validation to relying on the async call of the listeners instead of using evaluateJavascript(). Bug: 1015023 Test: Run both tests locally 1000 times, didn't see any failure. Change-Id: I1434b43f5dbc7f2700580c9c053453f5d20398c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894248 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712345}
-
Sean Kau authored
Inserting External Data Handlers into the vector of handlers should use push_back rather than emplace_back since we're calling std::make_unique instead of invoking the constructors directly. Bug: chromium:1020443 Change-Id: I54b8f7394dfc571d49b486f4a39d7b506653488f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893687Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#712344}
-
Mike Wittman authored
Propagates the optional metadata key values to the metrics upload proto. Bug: 976864 Change-Id: I1d3f4323dfa2a6643b599a0afeb25162b58b83c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895969 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712343}
-
Daniel Hosseinian authored
Printer types that can be blacklisted include privet, PDF, local, extension, and cloud printers. If a certain printer type is on the blacklist, calls of 'getPrinters' for that type would immediately resolve without dispatching any Web UI events. Calls of 'getPrinterCapabilities' for a blacklisted printer type would be rejected. Because cloud printers are fetched separately, if cloud printers are on the blacklist, the pref will have the same effect as setting the "CloudPrintSubmitEnabled" policy to false. This is the first CL to implement a policy disabling certain printer types. A future CL will add the policy configurations. Bug: 487875 Change-Id: I3bd4e1d3d3ecae3c2a6c379f3b3ae009b2c4921c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881844 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#712342}
-
Nigel Tao authored
Change-Id: I5991ee3d95674e95045a3a230a0f97adc1c1347b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898153Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#712341}
-
Sam Fortiner authored
Modifying unit tests to validate that the layers are positioned properly via the transform property tree or offset from transform node instead of via checking GraphicsLayer's position. This is in preparation for removing GraphicsLayer's GetPosition entirely. Bug: 999336 Change-Id: Ib591083846f411fe7bd9e3ad7180b16ed2f2573d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897131 Commit-Queue: Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712340}
-
Caleb Raitto authored
Bug: 953995 Change-Id: I6e137d81a43a67ca001ec67c77330656664de561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894024Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#712339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d85686f7c379..cc836871cb18 git log d85686f7c379..cc836871cb18 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 michaelludwig@google.com Make SkBlendMode_AsCoeff() public 2019-11-04 bsalomon@google.com Some improvements to backend texture creation. 2019-11-04 jvanverth@google.com Fix memory leak in iOS viewer. 2019-11-04 robertphillips@google.com Use QuadHelper and PatternHelper in more places 2019-11-04 herb@google.com Fix fuzz bug in isValid for SkDescriptor 2019-11-04 fmalita@chromium.org [skottie] Add support for gradient opacity stops 2019-11-04 michaelludwig@google.com Return coverage from inset() call instead of using a separate function. 2019-11-04 mtklein@google.com updateUniforms() just once 2019-11-04 fmalita@chromium.org [skottie] Add a couple more 3D tests Created with: gclient setdep -r src/third_party/skia@cc836871cb18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I5c3ff7568a4b653a085aa499a1f03ae42d0e2bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712338}
-
Nic Champagne Williamson authored
This change sets the COLOR_LOCATION_BAR_BORDER to the kWindowText color in Windows high contrast mode. Bug: 1021215 Change-Id: I8e97787f7c53bf572d77c943da6c55d3bfeea326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898131Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#712337}
-
Manu Cornet authored
This should fix the linked bug. Bug: 1018362 Change-Id: I8ca7543b7a2eb382d091c4cb78c0cce0cbf0b806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883654 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#712336}
-
Nate Fischer authored
This restructures the production logic so we can test if the app package name is logged appropriately in UMA metrics. This tests that, when we believe the app package name should not be logged, it is indeed empty. Bug: 969803 Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* Change-Id: I6b20d2c153a30a6742dafcd013ebbba9ef3e5f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895923 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Joshua Pawlicki authored
TBR=hcarmona@chromium.org Bug: 1010381 Change-Id: Ide847931c8774bbe7cc11d3ceaade1eec9d242bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898295Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712334}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 80-3940.0-1572255699-benchmark-80.0.3954.0-r1 to 80-3943.1-1572866479-benchmark-80.0.3954.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I4894e1d432e02665320b08a5e48818c83506bb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898687Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ee0968eaa398..f16e793858c4 git log ee0968eaa398..f16e793858c4 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 rharrison@google.com Rolling 5 dependencies (#862) 2019-11-04 9856269+sarahM0@users.noreply.github.com Add --emit-line-drective option (#861) Created with: gclient setdep -r src/third_party/shaderc/src@f16e793858c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ibfe2bd41baf979c14bf6fe9f78ee08eae5979e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898129Reviewed-by:
-
Nick Burris authored
This patch adds tests for the specified security restrictions for scroll to text: https://wicg.github.io/ScrollToTextFragment/#should-allow-text-fragment - Test for navigation without a user activation. - Test for window.open() navigation without 'noopener' option. - Test for navigation within an iframe - Test for same document navigations. Tested updated WPT locally with run_web_tests.py --additional-driver-flag= '--enable-blink-features=TextFragmentIdentifiers' Change-Id: Ia70e32a42d629fe6f9ec28b89c3167a1c1efbd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894302Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#712331}
-
rbpotter authored
Port the patch for iron-iconset-svg to the v3 version, since the added createIcon() function is still needed for Print Preview. Bug: 1012574 Change-Id: I6cc6d73e6088c4f9e01fe439ac43c183ed12fe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898405 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#712330}
-
Frank Tang authored
Bug: chromium:1020034 Change-Id: I01ba52316734556787f0aa0d76d5225040924056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894668Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#712329}
-
Changwan Ryu authored
Clarify that this is allowed. Bug: 918065 Change-Id: Ibb593015218dbb391d2165bc724191a4654ac33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898476Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712328}
-
Jinsuk Kim authored
This CL collapses the preview tab, upon a click event on its header, down to peek state. Bug: 1019294 Change-Id: I6a9c7198b19efef61b311f6c3ba0bb4cbc7a356d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888854 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712327}
-
Jiewei Qian authored
AppId is required at AppBrowserController constructor, to allow calculation of constant attributes. - Improves performance by eliminating redundant string comparisons in HasTabStrip method - Be explicit about HasTabStrip conditions, fixes a bug where tab strip shows up for ManifestWebAppBrowserController - Clarify the intention of checking AppId existance is to determine whether a browser shows an installed App. Fixes: 1013008 Change-Id: If275701e2c0068368635c86f8f1c6bcbfd266718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886138Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#712326}
-
Jan Wilken Dörrie authored
This change unifies the various base::make_span(container) utility functions and simply perfectly forwards the argument to the span constructor. Two overloads remain, one that deduces the span's extent automatically and one that let's the caller specify the extent. In order to do so this change introduces an internal::Extent struct, which is inspired by std::extent to deduce the right extent from the passed in argument. This helper is also used to simplify the internal EnableIfSpanCompatibleArray helper. Lastly it adds more tests to make sure make_span deduces the right type and extent. Bug: 828324 Change-Id: Ib55fc25ab2ad4227daf05d427e0aadf77c671817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878367 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#712325}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79d9e4b8508d..94d6f48ba1b7 git log 79d9e4b8508d..94d6f48ba1b7 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 ehmaldonado@google.com gsutil: Decode output from subprocess. Created with: gclient setdep -r src/third_party/depot_tools@94d6f48ba1b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1007872,chromium:1009819 Change-Id: I8f68653864c496fed49f09f374bb37ca5193e755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898294Reviewed-by:
-
Peter Kasting authored
The old code assumes children might need layout even when not invalid. This was originally added to fix http://crbug.com/8511 . This seems like a bogus fix; if the metrics of something in the nonclient area change in such a way that we actually notice and make it to NonClientView::Layout(), we should have had an opportunity to invalid child layouts as needed. I suspect this doesn't actually happen anymore (some of the rest of that bugfix is already gone), but if it does we should fix in a different way. This also reorders definitions to match declaration order, removes a bunch of section-break comments that are atypical style nowadays, and adds some TODOs for further refactoring. Bug: none Change-Id: Ib386921c85c43ee05473acf1ac1b660a68d28809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823642 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Otherwise signing in could make the user experience worse, if there aren't enough remote suggestions, e.g., a user with local history but a fresh Google account or server's failure to return remote suggestions. Bug: 996516,1021244 Change-Id: I9cbfebadc5a7e7e1d6e204890d668cc8b9f59984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898299Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#712322}
-
Bettina authored
Remove the sparkles in the password check icon and added padding. Light: https://screenshot.googleplex.com/TsGx2ZL9jKd Dark: https://screenshot.googleplex.com/2Y9uM7muff3 Bug: 1017297 Change-Id: I4bafef0a1db1e25d338a3749309a96eeb08e8782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894311Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#712321}
-
Rakesh Soma authored
Bug: 1020797 Change-Id: Ic396db0a772629cca5913db06383f5160ec264bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878043 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#712320}
-
nancy authored
kAppServiceAsh is the flag to integrate AppService in UI app_list. Since it has been enabled for a few months for M78, M79 release, it should not be disabled, so the flag kAppServiceAsh can be removed. BUG=1016159 Change-Id: Ib8bebd845e0dcd1a60f8cd3623d975cfcd40ca0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892979Reviewed-by:
-
Sam Goto authored
This CL refactors our existing code base to enable a **desktop** instance to request an SMS from a **mobile** instance via the chrome SharingService. We introduce a level of indirection, called SmsFetcher, which orchestrates between the local provisioning of SMSes (via the existing SmsProvider interface) and the remote provisioning of SMSes (via a newly introduced API FetchRemoteSMS exposed on ContentBrowserClient). chrome/ implements FetchRemoteSMS via SmsRemoteFetcher, which integrates with the chrome-specific go/unido infrastructure to fetch SMSes from remote devices. The SmsService uses the SmsFetcher (which fetches both local and remote SMSes) as opposed to the SmsProvider (which only fetches local SMSes). From an ownership perspective, the SmsFetcher is owned by the BrowserContext via the SupportsUserData infrastructure. The desktop UI and the go/unido integration is left deliberately unimplemented to keep this CL self-contained. Architectural diagrams, alternatives explored and further considerations are expanded in the design doc attached. Design-Doc: https://docs.google.com/document/d/1da8CjO71DlFbBzDcSosFRXTvDsKII_XMCohpZLQ_QbM/edit# Bug: 1015645 Change-Id: I2f563d27ed1c29d2de8a6bd2eef10865ec41e57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868049 Commit-Queue: Sam Goto <goto@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#712318}
-
Ankit Kumar 🌪️ authored
Annotation bounds sent from the plugin are relative to user screen coordinates. Currently, the bounds are added with page_bounds which is incorrect. This CL fixes the same. The addition of page_bounds are only required if the bounds are relative to the origin of the page. Bug: 981448 Change-Id: I02e23aaf6c706248fa12a562b112633297421d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894665Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#712317} -
Daniel Cheng authored
For some reason, outputting to stdout is quite slow on Mac. This likely warrants a separate followup, but reducing the size of stdout to be more information-dense seems generally valuable as well. stdout goes from ~21MB to ~430KB, which saves ~7 minutes in on the Mac bots, and ~1 minute on the Windows bots. The output that's lost is generally of low value. One big loss is that stdout from invocations of content_shell are no longer included in the stdout of run_web_tests.py. This means that it's harder to get debug info from LOG(ERROR) for passing tests... hopefully this isn't a common use case. Bug: 1014845 Change-Id: Ib7129ac9207c1641c1264a92b2e93a1be5c9b025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894105Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#712316}
-
Sorin Jianu authored
Send both the updater and Chrome app ids in the "update apps" use case. With this change, --install and --ua commands work as expected, meaning the app ids and the versions are sent during update checks. There is a edge case, not handled currently, where the app id for the updater is not available until the first update check has happened. This is going to be resolved in a future CL which lands as part of fixing this CR bug. R=waffles Bug: 1020285 Change-Id: I2856a795ed61f590f85d792e4d5e1493bd23b84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894833Reviewed-by:
-
Aaron Leventhal authored
Bug: 1017535 Change-Id: I398c6870ac0f82452baee8aed9d0f273f1e7af1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894292 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#712314}
-
Hazem Ashmawy authored
Add menu option in WebView shell browser to launch developer UI from the current WebView package. Add intent-filter to WebView developer UI MainActivity with a new action "com.android.webview.SHOW_DEV_UI". Fixed: 1014827 Test: Manually inspect and launch dev ui from shell browser menu Test: Build and install SystemWebView and Monochrome switch providers and verify the right UI is launched Test: Build and install tip-of-the-tree SystemWebView and verify that a failure toast is shown Change-Id: Ia00ae05118e2974ac1e6ddd3b95c70717da862a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893864 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#712313}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2b9317ad76b3..ca585bb45729 git log 2b9317ad76b3..ca585bb45729 --date=short --no-merges --format='%ad %ae %s' 2019-11-04 ivoc@webrtc.org Make some DecisionLogic functions virtual. 2019-11-04 mbonadei@webrtc.org Use template instantiation declaration/definition for RTCStatsMember<T>. 2019-11-04 sprang@webrtc.org Revert "Refactors BitrateProber with unit types and absolute probe time." 2019-11-04 henrika@webrtc.org Adds WebRTC-Audio-AgcMinMicLevelExperiment to AGC1 Created with: gclient setdep -r src/third_party/webrtc@ca585bb45729 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1018579 Change-Id: Iefde8162a32001cc3e68182af4e30fff0039ffc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898127Reviewed-by:
-
Dzmitry Neviadomski authored
Android system tries to scan test data for media files. These files may appear in file pickers and Image Gallery apps. R=jbudorick@chromium.org Bug: 796640 Change-Id: I1f84f724d33e168f27794cbcf2546afb4fd8e61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897658 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712311}
-
Peter Kasting authored
This also does some other misc. cleanup. Bug: none Change-Id: Id7ca9b8618da7ca66b6448b77554a24300a339b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894458 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99086cbb..1776a0ea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If40afb56035307cd162ed4886301567945f029e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898170Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712309}
-
Avery Musbach authored
There is a part of OverviewItem::OnWindowDestroying that looks exactly like UnpauseOcclusionTracker from the anonymous namespace in overview_window_drag_controller.cc. It comes right after calling OverviewWindowDragController::ResetGesture, which calls UnpauseOcclusionTracker anyway. Bug: None Change-Id: If8070af54b97faf1cb710e7dd06f2395528e13ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898200 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712308}
-
Thomas Guilbert authored
Clusterfuzz has highlighted an issue which can cause us to return a negative number of frames written, when we underflow. This CL fix the underflow issue by not fulfilling requests if we don't have enough data in |audio_buffer_|, regardless of the amount of data in |resampler_->BufferedFrames()|. This results in some small amount of data being lost. When we reach the end of stream, we play out all remaining data, along with enough silence to fulfill the request. Bug: 1019766 Change-Id: I728caa4afe45fac3f0944ef50bec5c00f9344d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895899 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712307}
-
