- 11 Jan, 2019 40 commits
-
-
Jun Mukai authored
The non-client area in ProxyWindow is set through "DraggableRegions", and this section is used for draggability of the window (see https://cs.chromium.org/chromium/src/apps/ui/views/app_window_frame_view.cc?sq=package:chromium&g=0&l=196). The same logic should be introduced on Mash, otherwise frameless app window can't be dragged. Bug: 920469 Test: ash_unittests Change-Id: If249d58dbf0a84aa3b333799f44f122dca04c4e6 Reviewed-on: https://chromium-review.googlesource.com/c/1405458Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#622061}
-
Chris Harrelson authored
setting needs overflow recalc to PaintLayer. Bug: 918597, 918598 Change-Id: I7736dc073deabdcf773d29574f6448c08cb699b1 Reviewed-on: https://chromium-review.googlesource.com/c/1405452 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#622060}
-
Ovidio Henriquez authored
This change adds the chooser-exception-list Polymer element to site settings. This element will fetch the chooser exceptions from the C++ site and process them for display. The element uses a chooser-exception-list-entry to render each chooser exception in the list. This change also adds to ability for the paper-tooltip to have its target set manually. This allows the target to be set on the common paper-tooltip element used in chooser-exception-list and site-list without having to access its private `_target` property. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: I3f127d2cf655b2d75157d7174a9bd5e434b583a8 Reviewed-on: https://chromium-review.googlesource.com/c/1357556 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#622059}
-
Daniel Bratell authored
R=mmenke@chromium.org Change-Id: I34db82f8d15864eab67c6cd7dd6490ebac31ec02 Reviewed-on: https://chromium-review.googlesource.com/c/1407004Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#622058}
-
Denis Kuznetsov authored
Bug: 916991 Change-Id: If13af642d61dc00b406e09ccdde7555829f9f1bf Reviewed-on: https://chromium-review.googlesource.com/c/1406975 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#622057}
-
Michael van Ouwerkerk authored
In the UMA dashboard we can use this to slice metrics like PrivateMemoryFootprint. Bug: 882370 Change-Id: I70f07590db3ad183325ed2e4e03fbe680413c937 Reviewed-on: https://chromium-review.googlesource.com/c/1405189Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#622056}
-
Dan Harrington authored
Bug: 908523 Change-Id: I014e6f5213096d7dd3f6f88454ac338eb4c9ed3c Reviewed-on: https://chromium-review.googlesource.com/c/1407113Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#622055}
-
Liquan(Max) Gu authored
In order to make FCP++ deal with both text and image, we combine Largest Image Paint and Largest Text Paint into Largest Content Paint. The largest content paint is the paint time of either the largest text paint or the largest image paint, depending on whether the largest text or the largest image is larger. We take whichever larger to be the largest content and use its paint time as Largest Content Paint. Bug: 919619 Change-Id: I623e0682b43b2a98ec681b3988159780ac0f7adb Reviewed-on: https://chromium-review.googlesource.com/c/1399282 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#622054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9af71a58413e..e58cda9a3da9 Created with: gclient setdep -r src-internal@e58cda9a3da9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I31082c1e4fef7224c52e508a44321c6238fe0fa6 Reviewed-on: https://chromium-review.googlesource.com/c/1407116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622053}
-
Steven Bennetts authored
This includes some deps cleanup of //chromeos. For explicit DEPS extraction: TBR=sky@chromium.org Bug: 918682 Change-Id: I551c9a78284e86aef229f7c12e9b8611d4514c07 Reviewed-on: https://chromium-review.googlesource.com/c/1405968 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622052}
-
Yuly Novikov authored
conformance2/textures/image_bitmap_from_image_data/ tex-2d-rgb9_e5-rgb-float.html deqp/functional/gles3/framebufferblit/depth_stencil.html TBR=kbr@chromium.org Bug: 921052, 921055 Change-Id: If6e3a998f7de646c20fd22396e0faa8b081a4a2b Reviewed-on: https://chromium-review.googlesource.com/c/1407111Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#622051}
-
Ayu Ishii authored
Bug: 916176 Change-Id: Ic2ff27655cec1a3ec4991a468710449b62457d80 Reviewed-on: https://chromium-review.googlesource.com/c/1392272Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#622050}
-
Ben Kelly authored
This is a reland of cc10cead The previous patch failed to build after the ResourceFetcher constructor arguments changed. This reland includes a mechanical fix to use the new constructor form. Original change's description: > Support IsolatedCodeCache for service worker pass-through responses. > > Previously code caching of scripts served from service workers was only > supported if the Response was produced from cache_storage. If the > service worker implemented a pass-through handler like: > > evt.respondWith(fetch(evt.request)) > > Then the v8 compiler could not store or load code cache for the script. > > With IsolatedCodeCache shipping it becomes much simpler to now > support this feature. This CL enables support by: > > 1) Fetching the code cache for service worker controlled scripts. > 2) Allowing the code cache to be used for pass-through responses. > 3) Storing any code cache produced for pass-through responses. > > We still explicitly disable code cache for service worker handlers that > produce either: > > a) Synthetic `new Response()` objects. > b) Response objects produced by `fetch()` to a URL different from the > original request URL. > > Bug: 917414 > Change-Id: I4efdc852a27069d2937056af0133a986e745b2be > Reviewed-on: https://chromium-review.googlesource.com/c/1394740 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621993} TBR=kinuko@chromium.org Bug: 917414 Change-Id: I547f0b410c59a14a1f9fff8f328b008ee7b1bb79 Reviewed-on: https://chromium-review.googlesource.com/c/1407029Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#622049}
-
Oksana Zhuravlova authored
This change moves the remaining output FrameHostMsg_CreateChildFrame parameters into the FrameHostMsg_CreateChildFrame_Params_Reply struct. Bug: 718652 Change-Id: I50678321dc49e2c449452292decf71dae8b90db3 Reviewed-on: https://chromium-review.googlesource.com/c/1405878Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#622048}
-
Dan Harrington authored
Watch for navigations and request coordinator changes to determine when the in-progress notification should be shown. A follow-up CL will introduce an instrumentation test to supplement the unit tests here. Bug: 883486 RELAND: This is a reland for https://chromium-review.googlesource.com/c/1381233 Changes to OfflinePageBridge were removed. TBR=petewil@chromium.org This is the same patch, but without the base CL. The base CL was unintentially submitted previously. Change-Id: I8e6988edcc0e8ca810f99c1961c9cdb9f730ba40 Reviewed-on: https://chromium-review.googlesource.com/c/1406939 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#622047}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/36248fcd635b..31a486419e27 git log 36248fcd635b..31a486419e27 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 digit@google.com Improve no-long-lines check for Python files. Created with: gclient setdep -r src/third_party/depot_tools@31a486419e27 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:890734 TBR=agable@chromium.org Change-Id: I9ab884eab3eec557371b5b10321f893ea09161fd Reviewed-on: https://chromium-review.googlesource.com/c/1406956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622046}
-
Dmitry Gozman authored
- Trigger static locals on main frame. We used to do that as a part of loading main resource, but now we don't. - Allow null Resource in DispatchDidReceiveResponse, it's not actually needed and will be missing for main resources. Bug: 855189 Change-Id: I51d2a433501bfdff4dba677d61210b62bec58802 Reviewed-on: https://chromium-review.googlesource.com/c/1401674Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622045}
-
Becca Hughes authored
At the moment on Android we trigger the kPlay or kPause actions if they are registered. This moves that logic a layer down to C++ so it will work for keyboard controls too. BUG=894255 Change-Id: I0eae3ac51b7d772643ab2a56091e3f0ddb6b2325 Reviewed-on: https://chromium-review.googlesource.com/c/1404178Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#622044}
-
Abhijeet Kandalkar authored
This CL fixes kiosk_browsertest away from talking to IdentityManagerFactory in favor of talking to IdentityManagerFactory. Bug: 920204 Change-Id: I584638eb5e31e39954658793dc25da80db993588 Reviewed-on: https://chromium-review.googlesource.com/c/1406729Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#622043}
-
Rune Lillesveen authored
Fixes crash when trying to set selectorText of detached @page rules. We only match local name part of the tag, so there should be no behavioral change here. Bug: 920303 Change-Id: I4b09b4e108506fd21d87844dec32209f5984de49 Reviewed-on: https://chromium-review.googlesource.com/c/1406716 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#622042}
-
Alex Newcomer authored
The shelf bg used to shift opacity as the launcher animation began, instead it should wait until the launcher is at shelf height. This changes two things: - Notify observers of target visibility changing when the animation begins. - Notify observers of actual visibility changing when the animation ends. Change-Id: I6e020406bb6fc0daf3430cec38c0abb6fb230a97 Reviewed-on: https://chromium-review.googlesource.com/c/1370368Reviewed-by:
-
Eric Lawrence authored
Show rendered output for URL containing spaces. Recompress example images. Change-Id: I6b35a5589e5b83377399c8ef1cd333322fb5eb47 Reviewed-on: https://chromium-review.googlesource.com/c/1406932Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#622040}
-
Ethan Nicholas authored
Change-Id: I94fbe4917ea5b5d4ce442a69219551a77313836d Reviewed-on: https://chromium-review.googlesource.com/c/1407036Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622039}
-
Martin Robinson authored
Previously a null was returned when querying the parent accessible of a document on AuraLinux. This change implements sets this accessible as a property on the view that contains the WebContents, allowing native accessibility APIs to traverse all the way up the accessibility tree by querying this value. Bug: 905013 Change-Id: I960becdcbc99a035aae00ff9f550206b042b5af3 Reviewed-on: https://chromium-review.googlesource.com/c/1356596 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#622038}
-
Navid Zolghadr authored
Bug: 612456 Change-Id: Idefb93e48c6d99ea3927702d17280a2c82850fdb Reviewed-on: https://chromium-review.googlesource.com/c/1405435Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622037}
-
Dave Tapuska authored
This is a reland of b7181485 Original change's description: > Enable 64 bit truncation warnings in blink > > BUG=879657 > > Change-Id: I80f12446a4a7507436fa85db4b454705b841a91b > Reviewed-on: https://chromium-review.googlesource.com/c/1362207 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621694} Bug: 879657 Change-Id: I2635dc3f93f93dbe05f059a91740d0d4305e39ae Reviewed-on: https://chromium-review.googlesource.com/c/1406130 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#622036}
-
Dave Tapuska authored
IntersectionObserver is using kInternalIntersectionObserver which is a pausable task queue. BUG=907125 Change-Id: I63fd26c407f32e64996f8e8a9af4ee860fc4daf6 Reviewed-on: https://chromium-review.googlesource.com/c/1388297 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a663e359..2bc360ca Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If5d1b71cd1f541b5fa80dff7b496f4ab21e99e47 Reviewed-on: https://chromium-review.googlesource.com/c/1406935Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622034}
-
Adithya Srinivasan authored
Tbr: sebsg@chromium.org No-Try: true Bug: 921062 Change-Id: Ic9699d7c3a2350e4969730288ae1ffae47917f4b Reviewed-on: https://chromium-review.googlesource.com/c/1407091Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#622033}
-
Robert Ma authored
This flaky test is seen to have three different failure modes on Android. This CL unblocks the wpt-importer. TBR=foolip No-Try: True Change-Id: Id2ae37beb200e05baff59c276a4735ceda616c49 Reviewed-on: https://chromium-review.googlesource.com/c/1407092Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#622032}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d0af9555211..9af71a58413e Created with: gclient setdep -r src-internal@9af71a58413e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3462073d32926f0bb55fd5a1b3999bd7251441a6 Reviewed-on: https://chromium-review.googlesource.com/c/1406954Reviewed-by:
-
Tibor Goldschwendt authored
Bug: 908819 Change-Id: I23a9f9f3f7439e6d34223321e93da2dee5bb6cbf Reviewed-on: https://chromium-review.googlesource.com/c/1406938 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#622030}
-
Roman Sorokin authored
Disabled on Mac due to flakiness TBR=aaronhk@chromium.org Bug: 920907 Change-Id: Ib3b4df696dbb7b7a1a2a4f214b2c9bd67d12d5b0 Reviewed-on: https://chromium-review.googlesource.com/c/1407070Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#622029}
-
Roman Sorokin authored
Due to flakiness (see bug) It runs on mac only TBR=rsesek@chromium.org Bug: 920582 Change-Id: I5006cdb12017f7bfb4455f2bbfaaa738f6ffab12 Reviewed-on: https://chromium-review.googlesource.com/c/1407006Reviewed-by:
-
Fredrik Söderquist authored
Remove the (unneeded) includes of console_message.h from core/dom/document.h and core/execution_context/security_context.h. This should for instance avoids indirectly including dom_node_ids.h more than needed. This will hopefully improve compilation speed a little bit, for some people. Bug: 242216 Change-Id: I775478624933833981c0f9ccd28e82e1bf815e00 Reviewed-on: https://chromium-review.googlesource.com/c/1406974 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#622027}
-
Daniel Bratell authored
R=thakis@chromium.org Change-Id: I60faf240e3335bba2a4258c1677b07fb892e9b69 Reviewed-on: https://chromium-review.googlesource.com/c/1407075Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/2cf86e5ab6dc..68752454406a $ git log 2cf86e5ab..687524544 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 junyer Avoid null PODArray<> issues in SparseSet and SparseArray<>. 2019-01-11 junyer Use PODArray<> in SparseArray<>. 2019-01-10 junyer Simplify SparseArray<> significantly. 2019-01-10 junyer Ensure we succeed at constructing new sparse and dense arrays. 2019-01-09 ckennelly Ensure we succeed at constructing new sparse and dense arrays. 2019-01-09 ckennelly Use PODArray<> in SparseSet. 2019-01-08 stevenperron Make Frame use an index, not an iterator. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 0 Change-Id: I83055ef76fff8b493e2b75a877c8baf145f0bfea Reviewed-on: https://chromium-review.googlesource.com/c/1406572Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#622025}
-
Etienne Bergeron authored
This CL is fixing the cause of the flakiness of this unittest: BackgroundTracingManagerBrowserTest.NoWhitelistedArgsStripped We believe the flakiness was caused by the possibility of start/stop tracing twice. We added a dump of stackframe when the tracing observer call |OnTraceLogEnabled| and we realized that on linux it's called twice. The stackframes are below. Calling sites are: 1) content::BackgroundTracingManagerImpl::SetActiveScenario() 2) content::BackgroundTracingManagerImpl::OnFinalizeComplete() The call 1) is the expected one in the unittest since it's the one starting tracing. The call 2) is caused by the config not being correctly disable with the call to |DisableScenarioWhenIdle|. BackgroundTracingManager::GetInstance()->WhenIdle( base::Bind(&DisableScenarioWhenIdle)); A snippet of code can be found below that shows why |config_| needs to be resetted to avoid multiple start/stop tracing. #2 0x561c34813aee content::(anonymous namespace)::TestTracingHelper::OnTraceLogEnabled() #3 0x7f9254ddff30 base::trace_event::TraceLog::SetEnabled() #4 0x7f925057686c content::BackgroundTracingManagerImpl::StartTracing() #5 0x7f9250574b1e content::BackgroundTracingManagerImpl::StartTracingIfConfigNeedsIt() #6 0x7f9250574752 content::BackgroundTracingManagerImpl::SetActiveScenario() #7 0x561c347f221a content::BackgroundTracingManagerBrowserTest_NoWhitelistedArgsStripped_Test::RunTestOnMainThread() #8 0x561c35d391dd content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #9 0x561c33f88f0d _ZN4base8internal13FunctorTraitsIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #10 0x561c33f88e84 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJPS5_EEEvOT_DpOT0_ #11 0x561c33f88e35 _ZN4base8internal7InvokerINS0_9BindStateIMN7content41GenerateMHTMLAndExitRendererMessageFilterEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #12 0x561c34164f9c _ZN4base8internal7InvokerINS0_9BindStateIMNS_12MockCallbackINS_17RepeatingCallbackIFvvEEEEEFvvEJNS0_17UnretainedWrapperIS7_EEEEES5_E3RunEPNS0_13BindStateBaseE #13 0x561c33e2827d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #14 0x561c35fb418d content::ShellBrowserMainParts::PreMainMessageLoopRun() #15 0x7f924f65fb32 content::BrowserMainLoop::PreMainMessageLoopRun() #2 0x561c34813aee content::(anonymous namespace)::TestTracingHelper::OnTraceLogEnabled() #3 0x7f9254ddff30 base::trace_event::TraceLog::SetEnabled() #4 0x7f925057686c content::BackgroundTracingManagerImpl::StartTracing() #5 0x7f9250574b1e content::BackgroundTracingManagerImpl::StartTracingIfConfigNeedsIt() #6 0x7f9250579062 content::BackgroundTracingManagerImpl::OnFinalizeComplete() #7 0x7f924f17f715 _ZN4base8internal13FunctorTraitsIMN4mojo8internal24CallbackWithDeleteHelperIFvbEEEFvbEvE6InvokeIS8_PS6_JbEEEvT_OT0_DpOT1_ #8 0x7f924f17f66f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN4mojo8internal24CallbackWithDeleteHelperIFvbEEEFvbEJPS8_bEEEvOT_DpOT0_ void BackgroundTracingManagerImpl::OnFinalizeComplete(bool success) { [...] if (!idle_callback_.is_null()) idle_callback_.Run(); bool is_allowed_begin = !delegate_ || (config_ && delegate_->IsAllowedToBeginBackgroundScenario( *config_.get(), requires_anonymized_data_)) [...] // NOTE: config_ must be empty to avoid starting tracing if (is_allowed_begin) { StartTracingIfConfigNeedsIt(); } else { AbortScenario(); } B=639706,795803 R=oysteine@chromium.org Change-Id: I5495b542615633c62a3451a75a668866b18592b0 Reviewed-on: https://chromium-review.googlesource.com/c/1341134 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#622024}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/87da937789ae..b8b3c9918f14 git log 87da937789ae..b8b3c9918f14 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 terelius@webrtc.org Clean up visibility and dependencies of RTC event log build targets. 2019-01-11 titovartem@webrtc.org Introduce stats calculator. 2019-01-11 nisse@webrtc.org Reland "Refactor and remove media_optimization::MediaOptimization." 2019-01-11 nisse@webrtc.org Delete VCMEncodedFrame methods Buffer and MutableBuffer Created with: gclient setdep -r src/third_party/webrtc@b8b3c9918f14 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If89d496accc140f066266748261d8b0f99e45eb8 Reviewed-on: https://chromium-review.googlesource.com/c/1406948Reviewed-by:
-
Emily Stark authored
TBR=meacer@chromium.org Change-Id: I3dd17ffa9f60e4efc07bee69d92ef7f5783097e7 Reviewed-on: https://chromium-review.googlesource.com/c/1407109 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
-
