GitLab

BUG=418651

Committed: https://crrev.com/057f7a69dd40c93550b375b4287dba70d719316a
Cr-Commit-Position: refs/heads/master@{#302303}

Review URL: https://codereview.chromium.org/692683003

Cr-Commit-Position: refs/heads/master@{#303658}

This decreases compile time, so we don't need to build certain libraries with -O0 anymore (and we can't because PBQP doesn't support -O0)

BUG=426271
TBR=inferno@chromium.org

Review URL: https://codereview.chromium.org/715633004

Cr-Commit-Position: refs/heads/master@{#303657}

SigninScreenHandler determines whether the account picker or the GAIA
sign-in screen should be shown. However, the GAIA sign-in screen shows
asynchronously, which causes a race condition. The GAIA sign-in screen
may finish showing after the SigninScreenHandler has decided to switch
to the account picker instead.

This race is causing two DeviceLocalAccountTest.* tests to flake on the
Chrome OS ASan/LSan bots.

BUG=432119
TEST=DeviceLocalAccountTest.* no longer flakes

Review URL: https://codereview.chromium.org/718623003

Cr-Commit-Position: refs/heads/master@{#303656}

Revert "Revert of Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (patchset #1 id:1 of https://codereview.chromium.org/658903004/)"

This re-applies https://codereview.chromium.org/620563002 again.

Note to tree sheriffs: this CL might trigger ChromeOS telemetry tests failing with error messages like "Cannot set property 'disabled' of null".

BUG=419030
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/686863002

Cr-Commit-Position: refs/heads/master@{#303655}

HISTOGRAM_ENUMERATION -> LOCAL_HISTOGRAM_ENUMERATION

BUG=

Review URL: https://codereview.chromium.org/711773005

Cr-Commit-Position: refs/heads/master@{#303654}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5584785..1d74323

TBR=yhirano@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/714903002

Cr-Commit-Position: refs/heads/master@{#303653}

BUG=410400
TEST=fixing broken browser tests
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/711403002

Cr-Commit-Position: refs/heads/master@{#303652}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bffcb52..c536942

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jcgregorio@google.com

Review URL: https://codereview.chromium.org/715723003

Cr-Commit-Position: refs/heads/master@{#303651}

BUG=415213

TEST=Please see the bug crbug.com/415213 for steps to reproduce.

Somehow sum of width of the words is greater by one pixel than width of the concatenation of these words in this particular case ("The administrator for this account has disallowed multiple sign-in." message and Link board). When we try to get preferred size we break the message into two lines and get maximum width of these two strings. We get the width which is smaller by one pixel. And then during rendering again we try to break the message into two lines by adding new words one by one and it does not fit in this width. So it does not fit into the preferred size and lose the last word.

Review URL: https://codereview.chromium.org/614103007

Cr-Commit-Position: refs/heads/master@{#303650}

Currently, we'll crash when this method is called if a site sets
`NoReferrerWhenDowngrade`. That seems like something worth fixing. :)

-----------------------------------------------------------------------
Reland of https://crrev.com/3b0e841aa8b7d5ca5999f4340b8fa6f73305d3d2,
which was reverted due to compliation errors on the main waterfall.
-----------------------------------------------------------------------

BUG=431711
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/716813002

Cr-Commit-Position: refs/heads/master@{#303649}

Reland of: https://codereview.chromium.org/701403002/
Reverted here: https://codereview.chromium.org/709003003/

InitDone() made an illegal state transition from BACKEND_CLOSED to BACKEND_OPEN.  I removed that transition, which means that pending operations will exit early instead of complete, so I updated the test expectations.

I also added some new testing framework to be able to delay not only cache backend creation but backend functions themselves, so far only OpenEntry.  This is used to recreate the dcheck crash discovered by the layout tests in https://crbug.com/431163

I don't intend to commit until after branch cut as this CL is mostly code cleanup and new tests.

BUG=430884

Review URL: https://codereview.chromium.org/692993005

Cr-Commit-Position: refs/heads/master@{#303648}

BUG=431752

Review URL: https://codereview.chromium.org/715433005

Cr-Commit-Position: refs/heads/master@{#303647}

Explicitly list the packages for which we need to install build dependencies.
The grep-based approach no longer works since we now have packages which are
specific to a certain Ubuntu release.

BUG=414189
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/711283003

Cr-Commit-Position: refs/heads/master@{#303646}

Script just dumps the categories as received from trace buffer.
It includes group of categories clubbed. A minor cleanup to present
each individual category actually present in the code and list them
as seen by the user when trace RecordDialog is created in the UI.

BUG=None

R=nduca,dsinclair

Review URL: https://codereview.chromium.org/690103005

Cr-Commit-Position: refs/heads/master@{#303645}

This reverts commit ddff4327.

Speculative revert to see if it fixes Debug layout test failures:
inspector/console/console-format.html
http/tests/appcache/fallback.html
e.g., http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/23616

TBR=rmcilroy
BUG=391005

Review URL: https://codereview.chromium.org/711393002

Cr-Commit-Position: refs/heads/master@{#303644}

This makes layout tests similar to the real embedder.

BUG=none

Review URL: https://codereview.chromium.org/712003004

Cr-Commit-Position: refs/heads/master@{#303643}

This patch adds code for recording the interesting parts of the
TaskQueueManager, RendererSchedulerImpl and RenderSchedulerSelector
classes into a trace. The main bits of state that are captured:

 - All tasks in the incoming and work queues.
 - Number of tasks in the work queue as a time series.
 - The work queue which was selected for execution.
 - Scheduler priority both as a time series and snapshots.
 - Selector priorities as snapshots.

Sample trace:
https://drive.google.com/file/d/0ByyxMXB38gLDUTFpRzhldmI2Q2c/view?usp=sharing

BUG=391005

Review URL: https://codereview.chromium.org/681793003

Cr-Commit-Position: refs/heads/master@{#303642}

Depends on https://codereview.chromium.org/707243003

BUG=401438,407997

Review URL: https://codereview.chromium.org/706253003

Cr-Commit-Position: refs/heads/master@{#303641}

Cr-Commit-Position: refs/heads/master@{#303640}

BUG=379943
TBR=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/710313002

Cr-Commit-Position: refs/heads/master@{#303639}

This patch adds a watchlist for scheduling related code reviews.

BUG=432040

Review URL: https://codereview.chromium.org/711373002

Cr-Commit-Position: refs/heads/master@{#303638}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ab33cd3..5584785

TBR=yhirano@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/710303002

Cr-Commit-Position: refs/heads/master@{#303637}

Trying again.

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/705573007

Cr-Commit-Position: refs/heads/master@{#303636}

[Password Manager] Correct the documentation within PasswordFormFillData struct for form origin and action.

It's a follow-up CL to: https://codereview.chromium.org/614023002/

BUG=417295

Review URL: https://codereview.chromium.org/711333002

Cr-Commit-Position: refs/heads/master@{#303635}

(patchset #3 id:40001 of https://codereview.chromium.org/677073002/)

This reverts commit 62bb47df.

It was originally reverted because it broke one layout test in blink.
The problem with the layout test was in blink itself and fixed in
https://codereview.chromium.org/709733003/ so I am now relading this.

BUG=401424
TBR=tkent

Review URL: https://codereview.chromium.org/716763002

Cr-Commit-Position: refs/heads/master@{#303634}

Revert of Adding media/base/android to webrtc_media watchlist (patchset #2 id:20001 of https://codereview.chromium.org/704253002/)

Reason for revert:
Missed a | and now we get all kinds of notifications :)

Original issue's description:
> Adding media/base/android to webrtc_media watchlist
>
> Idea being to include VideoCapture and MediaCodec and
> native-side related stuff.
>
> TBR=posciak@chromium.org
> BUG=
>
> Committed: https://crrev.com/1f9711b56c572d44ad9dae0ab0484e07fbb3b43c
> Cr-Commit-Position: refs/heads/master@{#303618}

TBR=posciak@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/708223004

Cr-Commit-Position: refs/heads/master@{#303633}

BUG=405566

Review URL: https://codereview.chromium.org/658163003

Cr-Commit-Position: refs/heads/master@{#303632}

Revert of Referrer Policy: Update SanitizeForRequest with new default behavior. (patchset #2 id:20001 of https://codereview.chromium.org/689363003/)

Reason for revert:
Doesn't compile on the debug bot. ?!

Original issue's description:
> Referrer Policy: Update SanitizeForRequest with new default behavior.
>
> Currently, we'll crash when this method is called if a site sets
> `NoReferrerWhenDowngrade`. That seems like something worth fixing. :)
>
> BUG=431711
>
> Committed: https://crrev.com/3b0e841aa8b7d5ca5999f4340b8fa6f73305d3d2
> Cr-Commit-Position: refs/heads/master@{#303629}

TBR=jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=431711

Review URL: https://codereview.chromium.org/683233003

Cr-Commit-Position: refs/heads/master@{#303631}

BUG=431739
TBR=battre@chromium.org

Review URL: https://codereview.chromium.org/711043002

Cr-Commit-Position: refs/heads/master@{#303630}

Currently, we'll crash when this method is called if a site sets
`NoReferrerWhenDowngrade`. That seems like something worth fixing. :)

BUG=431711

Review URL: https://codereview.chromium.org/689363003

Cr-Commit-Position: refs/heads/master@{#303629}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/088bcb0..ab33cd3

TBR=yhirano@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/715433003

Cr-Commit-Position: refs/heads/master@{#303628}

Some related cleanup:
- History UI: Properly distinguish profile->IsSupervised vs. prefs::kAllowDeletingBrowserHistory vs groupByDomain
- "New incognito window" in hotdog menu: Honor IncognitoModePrefs

BUG=232316

Review URL: https://codereview.chromium.org/697693004

Cr-Commit-Position: refs/heads/master@{#303627}

 * ProgressCenterPanel
 * DirectoryTree
 * GearButton
 * TaskItems (ComboButton)

BUG=267281
TEST=None

Review URL: https://codereview.chromium.org/708383003

Cr-Commit-Position: refs/heads/master@{#303626}

BUG=391005

Review URL: https://codereview.chromium.org/704933002

Cr-Commit-Position: refs/heads/master@{#303625}

BUG=432067,432070,432071
TBR=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/718653002

Cr-Commit-Position: refs/heads/master@{#303624}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1104b83..088bcb0

TBR=yhirano@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/712333002

Cr-Commit-Position: refs/heads/master@{#303623}

BUG=432044
TEST=manually

Review URL: https://codereview.chromium.org/694813005

Cr-Commit-Position: refs/heads/master@{#303622}

flings did not send DidReceiveInputEvent.  In addition we also pass the input
event type through because we want to ignore keyboard and mouse events.

BUG=391005,426375,429814

Review URL: https://codereview.chromium.org/692483002

Cr-Commit-Position: refs/heads/master@{#303621}

We want the overlay cast icon to be visible on all backgrounds, so its
background has to be at least semi-opaque. The non-overlay cast icon,
however, should have the same background as the media controls, which
is easiest to achive by making its background transparent. As such we
need different icons for the two cases.

This CL simply provides the new icons. The corresponding Blink CL, which
uses them, is https://codereview.chromium.org/716613002.

BUG=426373

Review URL: https://codereview.chromium.org/711083002

Cr-Commit-Position: refs/heads/master@{#303620}

BUG=375230

Review URL: https://codereview.chromium.org/680943002

Cr-Commit-Position: refs/heads/master@{#303619}