- 18 Apr, 2018 40 commits
-
-
Kai Ninomiya authored
https://chromium-review.googlesource.com/c/chromium/src/+/1014352 TBR=kbr@chromium.org Bug: 833463 Change-Id: I1780be2e8bcf3b32600d8a96594fef67c2c579f3 Reviewed-on: https://chromium-review.googlesource.com/1013153Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#551819}
-
Evan Stade authored
Bug: 678687 Change-Id: If1bc9f87184627130879775865b5e8696faf82c2 Reviewed-on: https://chromium-review.googlesource.com/1008278Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#551818}
-
Lukasz Anforowicz authored
This CL just moves some Cross-Origin Read-Blocking (CORB) code into //service/network. No intended behavior change. Bug: 792546 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8d6ccc6a2bd6c673edf6b127868b2d0868bed4c4 Reviewed-on: https://chromium-review.googlesource.com/1012746Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#551817}
-
Tyler Breisacher authored
BUG=760416 Change-Id: Id94e43e1540f78de7f57b126a242c5197dbfc8a2 Reviewed-on: https://chromium-review.googlesource.com/650535Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Tyler Breisacher <tbreisacher@chromium.org> Cr-Commit-Position: refs/heads/master@{#551816}
-
Eli Ribble authored
These functions makes it possible for other code to iterate over all of the features known to the system. CQ code will ensure that chromecast code calls chromecast::IsFeatureEnabled rather than base::FeatureList::IsEnabled which will enforce that new Features are properly registered Minor header fixes included for free. Bug: 73173111 Test: None Change-Id: Ic2dd2aa789a88fea62f724b683ce1e7c81fa3035 Reviewed-on: https://chromium-review.googlesource.com/1014523 Commit-Queue: Eli Ribble <eliribble@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551815}
-
bsheedy authored
Upgrades the VrCore and Daydream Home APKs used for testing. The keyboard APK upgrade will come at a later time to help differentiate any perf regressions caused by the upgrade. Change-Id: I349beff4b5e97ea3edd1bdd3ef1fe5be3821d388 Reviewed-on: https://chromium-review.googlesource.com/1014505Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551814}
-
Devlin Cronin authored
Update ExtensionWebstorePrivateApiTest to manifest v2 and remove the allowance for manifest v1 extensions. Repackage two crx's used in the webstorePrivate API tests to be updated to manifest v2. Bug: 816679 Change-Id: I8ba99179c99b62c6ef49cf3aa8e7afab7dfacdf5 Reviewed-on: https://chromium-review.googlesource.com/1015081Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551813}
-
Ian Clelland authored
Bug: 761009 Change-Id: I07844c77a73b0be1605b9970af1249ea7f189fe3 Reviewed-on: https://chromium-review.googlesource.com/949050Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#551812}
-
Jan Wilken Doerrie authored
This change implements Windows::Foundation::IAsyncOperation. It provides a simple interface and allows clients to specify desired results via a callback. This is mostly useful for tests, when custom fake implementations of UWP interfaces are required. Some of these implementations must provide Async methods, that return an instantiation of IAsyncOperation. Bug: 821766 Change-Id: I728c0bb5311898fac4ee5f5e54d8a64b2aa61d94 Reviewed-on: https://chromium-review.googlesource.com/984194Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#551811}
-
https://pdfium.googlesource.com/pdfium.git/+log/51a41ea222ee..7439517516a0 $ git log 51a41ea22..743951751 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 tsepez Add AsRawSpan() to ByteString. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I89cfce7acf9bd124f51c05e7816133bf8541ecfe Reviewed-on: https://chromium-review.googlesource.com/1017585 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551810}
-
Yuke Liao authored
Link to coverage.py to code_coverage.md Bug: 833912 Change-Id: I089bbef64424004f543823d663dad00b3a275fbe Reviewed-on: https://chromium-review.googlesource.com/1017239Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#551809}
-
Erik Chen authored
The test is flaky, likely due to recent refactors to the heap profiling code to support Android Webview. I'm disabling it temporarily while I investigate. Bug: 833590 Change-Id: Idd7dd982d9e5586f76f991455d1ae717323c519d TBR: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1017598Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551808}
-
Mihai Sardarescu authored
When Desktop Identity Consistency is enabled, this CL records the user actions Signin_SigninNewAccount_From*, Signin_SigninWithDefault_From* and Signin_SigninNotDefault_From* for the following access points: * bookmark bubble * extension installed bubble * user menu (a.k.a. avatar bubble) * password saved bubble * settings Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I09656690891ce66def3cf30faa3fa99b612cc266 Reviewed-on: https://chromium-review.googlesource.com/1013919Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#551807}
-
chrome://gpuMohsen Izadi authored
When GPU access is blocked (i.e., hardware acceleration and SwiftShader are both disabled), chrome://gpu reports incorrect values for Surface Synchronization and Viz Service Display Compositor features. BUG=829426 TEST=manual Change-Id: I977a3902d71d53d77be2473ecd4b755b895f6a79 Reviewed-on: https://chromium-review.googlesource.com/1017227Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551806}
-
W. James MacLean authored
At present, the code in RenderWidgetHostViewAndroid will send events to the InputEventRouter even if using_browser_compositor_ is false. This CL fixes that. Change-Id: I1ff9a1e70b9fc2ef44a357b520df269ce29e69af Reviewed-on: https://chromium-review.googlesource.com/1017228 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#551805}
-
Devlin Cronin authored
Update IdentityTestWithSignin to manifest v2 and remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I0312986394cf10c58f31884284f7830df947feea Reviewed-on: https://chromium-review.googlesource.com/1014600Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551804}
-
Yuwei Huang authored
Currently we create FullscreenControlHost when the view hierarchy is changed, which adds ~27ms to the app startup time. This CL delays the creation of FullscreenControlHost until the browser enters fullscreen. Bug: 833594 Change-Id: I291aa8e84eb154bbda52434d17e430d54c0507c6 Reviewed-on: https://chromium-review.googlesource.com/1014658Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#551803}
-
Moe Ahmadi authored
When a permanent auth error state is triggered, re-masks all the server cards. Don't suggest server cards while in a permanent auth error state. Bug: 825319 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I99906a59922845a099431ebbed06eac5adf0b5f1 Reviewed-on: https://chromium-review.googlesource.com/979137 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551802}
-
kylechar authored
Remove #ifdef USE_X11 && !USE_GLIB check. That would have been for the X11 CrOS build which no longer exists. Bug: none Change-Id: Iccea3d36ef92ed1dde44773ce4a74184a7a2c37b Reviewed-on: https://chromium-review.googlesource.com/1014281Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#551801}
-
Réda Housni Alaoui authored
GetPhotoState was disabled on Windows because of issue 722038. The issue only impacts the Video Capture DirectShow implementation. This prevents video stream from being stopped when InitializeVideoAndCameraControls fails on DirectShow and let GetPhotoState calls reach the MediaFoundation implementation. Bug: 833449, 722038 Change-Id: Ifad3fa1ee86938ee62a306bbf5900bf645a5eb9f Reviewed-on: https://chromium-review.googlesource.com/1013697 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551800}
-
Thomas Guilbert authored
The FlingingRenderer adapts from the media::Renderer interface to the MediaController interface. It is used in the context of RemotePlayback, and is created from an already existing presentation ID Bug: 790766 Change-Id: I2284468f3342ad4123e5318c3f2c930a171fea06 Reviewed-on: https://chromium-review.googlesource.com/1003229Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#551799}
-
Kyle Horimoto authored
This CL modifies CryptAuthEnrollerImpl and CryptAuthDeviceManagerImpl to take a CryptAuthClientFactory* instead of a std::unique_ptr<CryptAuthClientFactory> in their constructors. It was unnecessary to have each class own its own instance of the factory, and this refactor will help as I add an instance of the factory to the DeviceSync service. Bug: 824568, 752273 Change-Id: Ie3818cb7d81439689e4edb60f6c024f0e5069435 Reviewed-on: https://chromium-review.googlesource.com/1017307 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551798}
-
Jonathan Backer authored
This CL makes --enable-oop-rasterization --enable-raster-decoder work on desktop linux builds of chromium. Changes: - Update raster_cmd_buffer_functions.txt with changes in gles2_cmd_buffer_functions.txt and regenerate autogen files. - Copy code from RasterImplementationGLES into RasterImplementation. - Copy code from GLES2DecoderImpl into RasterDecoderImpl Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia7b50acc843ecd641a8a74927d94303138849e86 Reviewed-on: https://chromium-review.googlesource.com/1011203Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#551797}
-
btolsch authored
Using only AF_INET to probe a Wifi interface that IPv6-only will fail, even though the interface is functional. This change adds an AF_INET6 check if AF_INET fails. Bug: None Change-Id: I81f9c2a2a51041597ee384804018b4de7dccc88d Reviewed-on: https://chromium-review.googlesource.com/1017344 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#551796}
-
Paul Miller authored
Context.getDir() creates Chrome's data directory, app_chrome/, with rwxrwx--x. ChromeMainDelegateAndroid::RunProcess() then limits this to rwx------. RunProcess() goes out of its way to avoid granting any user permissions that weren't already present, but this seems like a mistake; it shouldn't be possible for app_chrome/ to have fewer permissions than rwx------. So RunProcess is simplified to set the permissions to exactly rwx------. Also don't print data_path in the error message because if PathService::Get() failed, data_path is empty. Also restrict WebView's directory, app_webview/, using Os.chown(). Doing this in PathUtils covers both Chrome and WebView. However, Os.chown() requires API >= 21, which is the case for WebView but not Chrome, so Chrome's RunProcess() code must stay for now. Rehabilitate //chrome/test:chrome_app_unittests to run on Android (crbug 609855 says it was broken but it seems to work now) and add a unit test for the simplified native code. BUG=832388,609855 internal bug b/19993402 Change-Id: I1bcfe72940ddc1fb23f2b0bef50775853843ea76 Reviewed-on: https://chromium-review.googlesource.com/984773 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#551795}
-
Sigurdur Asgeirsson authored
This avoids creating a new entry in the map for each process on each cycle on Windows, which was happening as of my last change. Add a state variable to keep track of when a measurement cycle is underway in preparation for allowing measurement requests at arbitrary times. Replace the delegate class with a simple virtual function, and use protected access control in combination with a Testing* subclass to expose class' internal state for testing. This allows removing all test-specific code from the class declaration. Bug: 755840 Change-Id: I7658a355525fffe92327bb85151ba124cc81d371 Reviewed-on: https://chromium-review.googlesource.com/1015299 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#551794}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/85c75025906a..9ccad5689c09 $ git log 85c750259..9ccad5689 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 jbudorick bot_update: Ensure create_manifest ignores repos with explicit None urls. Created with: roll-dep src/third_party/depot_tools BUG=chromium:830306 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2c6e4e6659349d3360e31b8cbf94cb5fd940bca5 Reviewed-on: https://chromium-review.googlesource.com/1017381 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551793}
-
https://chromium.googlesource.com/angle/angle.git/+log/eb79e337c9f7..427064d2ac0b $ git log eb79e337c..427064d2a --date=short --no-merges --format='%ad %ae %s' 2018-04-13 jmadill Fix perf regression with checkStatus. 2018-04-10 courtneygo Vulkan: Add build toggle for validation layers. 2018-04-17 jmadill Optimize ValidateDrawAttribs: Part 2. 2018-04-16 lucferron Vulkan: Use SH_INITIALIZE_UNINITIALIZED_LOCALS in ShaderVk 2018-04-16 lucferron Vulkan: Implement depth_range dirty bit and enable tests 2018-04-16 lucferron Vulkan: Fix the issue with unused attributes / varyings 2018-04-18 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation (2nd try) 2018-04-13 oetuaho Refactor GL tests to use a shader library Created with: roll-dep src/third_party/angle BUG=chromium:822235 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I99521579232a65d62698e7c4f73aa0b697f219fc Reviewed-on: https://chromium-review.googlesource.com/1017318 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551792}
-
crystallambert@chromium.org authored
There is currently false information on Options Version 2 doc related to deprecation of options manifest registration. This update removes this language. Bug: none Change-Id: I5c8864a18dcc8dd6c01b1bd7932bfa69e6030656 Reviewed-on: https://chromium-review.googlesource.com/990934Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#551791}
-
bsheedy authored
Forces the VR bisect script to use a detached head state when determining initial values. This prevents us from accidentally dirtying the current branch if --apply-stash-before-sync is used, while also fixing an issue with --apply-stash-before-sync if both the good and bad values need to be determined where the stash application from the good run would still be around during the bad run. Change-Id: I039959a3bdd3d9fff56a32e19097b03c946c5838 Reviewed-on: https://chromium-review.googlesource.com/1017313 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551790}
-
Jun Choi authored
CTAP HID transport protocol uses 4 byte channel ID to check that the message sent by the authenticator is only received and processed by the correct client process. On the other hand, CTAP BLE transport protocol defines no such mechanism to differentiate incoming BLE fragments. This, under some circumstances, enables relying parties to receive response from authenticators that was intended for different site. In order to prevent malicious RP from receiving authenticator response intended for different site, check relying party ID hash returned from the authenticator in response to MakeCredential and GetAssertion response. Bug: 828507 Change-Id: I3b743fc9b9f79284ab4b979d17c75ccc9e5a889c Reviewed-on: https://chromium-review.googlesource.com/1004118 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551789}
-
Wez authored
We work-around shared global state in component builds of the Cronet native library by avoiding creating the AtExitManager in those builds. The condition for that is fixed here, from being based on Debug build to depending directly on whether this is a component build. The tests are also enabled on Fuchsia/Debug, where they now pass. Bug: 833401, 816705 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1401c0dcaa8e893c6cd4bcbf75f8d4d30ccd0116 Reviewed-on: https://chromium-review.googlesource.com/1014642 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#551788}
-
Doug Arnett authored
Bug: 834338 Change-Id: Id209b84b7546d9cb0c374f9779bebf6f7d20a9c5 Reviewed-on: https://chromium-review.googlesource.com/1017306Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#551787}
-
Matthew Jones authored
This change adds a TabModelSelectorObserver for the bottom sheet to observe tab model changed. If the tab model changes, the sheet is hidden. The sheet also no longer tries to peek when loading a URL since 'peek' is no longer the minimum state. This patch also includes a change to the open/close events which are now driven off of the sheet's height rather than its state. This prevents a crash where a URL is loaded and the sheet closes and immediately tries to re-peek. Bug: 832814 Change-Id: I41c88599b55a2b763dbaa94adca2117594b88f2a Reviewed-on: https://chromium-review.googlesource.com/1014712 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#551786}
-
Florin Malita authored
SK_SUPPORT_LEGACY_A8_MASKBLITTER, for https://skia-review.googlesource.com/c/skia/+/121642 Change-Id: Id47e95cb764c526864f3af8350a546254ee1c54d Reviewed-on: https://chromium-review.googlesource.com/1016670Reviewed-by:
Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#551785}
-
Ahmed Fakhry authored
This CL adds ability to set CRTC color matrix to the DisplayColorManager and combine it with whatever calibration matrix available for the respective display. This CL also optimizes DrmDevice::SetColorCorrection() and improves it for the use cases when it is only desired to set the color transform matrix without gamma/degamma. BUG=749250 TEST=ash_unittests --gtest_filter=DisplayColorManagerTest.SetDisplayColorMatrix* Change-Id: I748da11b06a8100d7fa1de8d18f00a95602d3057 Reviewed-on: https://chromium-review.googlesource.com/1013302Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551784}
-
wutao authored
This cl adds the framework to search Settings shortcuts in launcher. Changes: 1. Add feature flag to enable Settings shortcut search in launcher. 2. New class SettingsShortProvider. 3. New class SettingsShortResult. 4. New struct SettingsShortcutMetadata. Bug: 834049 Test: SettingsShortcutProviderTest.Basic and SettingsShortcutResultTest.Basic Change-Id: Ib25f2d18487b77c138b7d550ad06b6f2ac73f6c2 Reviewed-on: https://chromium-review.googlesource.com/1016128Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551783}
-
Mikel Astiz authored
A common interface (AbstractSessionsSyncManager) is introduce with two implementations of session sync: 1. SessionsSyncManager (Directory-based, legacy). 2. SessionSyncBridge (USS-based, new). A feature toggle controls which of the two is used by the browser (no behavioral change by default). Bug: 681921 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8ccf7747b785134a23814a63f0e9d8ac9a47facf Reviewed-on: https://chromium-review.googlesource.com/1013522 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#551782}
-
Danyao Wang authored
Fixed broken unit test reported in crbug.com/834307 This is a reland of f1291fb3 Original change's description: > [Nav Experiment] Propagate virtual URL in ReloadWithUserAgentType. > > This hides the internal URL used by WKBasedNavigationManager to force > create an entry in WKBackForwardList when reloading with a different > user agent type (see crrev.com/c/919175). > > Also fixed a bug in NavigationManagerTest which wasn't testing the > redirect case when GetParam() == TEST_WK_BASED_NAVIGATION_MANAGER. > > Bug: 833958 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I095178302bfc4d209c2d058aab736777cc8b2de4 > Reviewed-on: https://chromium-review.googlesource.com/1016002 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551548} Bug: 833958,834307 Change-Id: I9856f340e408d92fbce934f8ae2bbddb119b066d Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1017005Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551781}
-
rbpotter authored
Add a HeaderFooter test to verify that the header footer option appears and disappears correctly for different margin and paper size settings. Migrated from tests in print_preview_tests.js. Bug: 814860 Change-Id: I18012eb26ccd261b94a88f70ef24746e872910ba Reviewed-on: https://chromium-review.googlesource.com/1013301 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551780}
-