GitLab

We can avoid draining the full marking worklist again by visiting them
before initially draining the worklist. This also preserves the
invariant the the epilogue should not find any new objects.

Bug: chromium:843903
Change-Id: I178d7b564ad9aaf5a086183dad83adfcb5c7d5a1
Reviewed-on: https://chromium-review.googlesource.com/1158412Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579786}

Preparation for hooking up @font-face { src: local() } matching in
Blink. For now adding an implementation that extracts full font name and
postscript name from fonts given a set of directories to scan.

Includes unit tests for basic functionality, compatibility with TrueType
collections and for resilience against corrupted font files.

For the general design see https://crbug.com/828317.

Bug: 867877
Change-Id: I5f557d99a5be49671bd9aa13c1712b6f8a2aa96b
Reviewed-on: https://chromium-review.googlesource.com/1151348Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579785}

I introduced some test expectations in https://crrev.com/c/1145129 which
I believe might be unnecessarily strict.  In particular,
Net.ConnectionInfo.MainFrame and Net.ConnectionInfo.SubResource might be
recorded in OnReceivedResponse() for favicon but RecordLoadHistograms()
not called yet by the time test execution arrives to the expectations.
This CL relaxes some expectations to prevent these tests from becoming
flaky.

Bug: 859546
Change-Id: Idbacc7d024176406c5eb1a4be6d190e168a7d432
Reviewed-on: https://chromium-review.googlesource.com/1156848Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579784}

Without this change, there is a race condition where it's possible that
an auth token gets requested from the native side (via
OAuth2TokenServiceDelegateAndroid) for an account that was actually
already removed, which causes an exception in
FakeAccountManagerDelegate.getAccountHolder.

https://crrev.com/c/1148392 uncovered this, but I believe the race
condition is there independent of that CL (it's just much less likely
to get triggered).

Bug: 856179
Change-Id: I23bdf54aba90b1bbfd64f45963ea32d08b63c852
Reviewed-on: https://chromium-review.googlesource.com/1156688
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579783}

Ensure that a native widget gets a destroying call to ensure a right
destruction order and SiteProcessCountTracker can eventually
decrement process count.

Otherwise, a DCHECK in dtor of SiteProcessCountTracker is called.

TEST: ./out/OzoneLinux/views_unittests --ozone-platform=wayland
--gtest_filter=DesktopWindowTreeHostPlatformTest.CallOnNativeWidgetDestroying

Change-Id: I82f39a8e9673b9737215cf85e7810dbb0af78ceb
Reviewed-on: https://chromium-review.googlesource.com/1154530
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579782}

It is flaky

Bug: 869829
No-try: True
No-presubmit: True
Change-Id: I9f49e4c6c7d3457e967e964ee1f8e5e36402a258
Reviewed-on: https://chromium-review.googlesource.com/1158624Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579781}

Change-Id: I81a0ce6ebb664ec993028f561729051884924a26
Reviewed-on: https://chromium-review.googlesource.com/1152948
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579780}

Creates a new payments_section.html/js (credit cards for now).

With Autofill Home disabled, will add a new row in the Advanced Passwords and Forms
section to go to the credit cards section. There used to be one general Autofill
row that had both addresses and credit cards.

With Autofill Home enabled, the "Payments" row on the People page will now lead
to a payments-only section, and the "Addresses" row will lead to its own section
as well.

This is one change of several that will also clean up the settings toggle to
hopefully have a clearer story.

Screenshots of the change: https://goo.gl/iZWkCE (internal)

Bug: 860526
Test: browser_tests
Change-Id: I7572ccc71633ee806b4a5db522a64e2b4f79d5dc
Reviewed-on: https://chromium-review.googlesource.com/1152475
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579779}

When buidling using jumbo, files gets merged and functions
with the same name may end up in the same namespace and
conflict. This happens for the function IsCreditCardExporationType
in:
components/autofill/core/browser/form_structure.cc
components/autofill/core/browser/autofill_manager.cc

Since the functions are identical they are moved to a shared
util file. Since the function needs
components/autofill/core/browser/field_types.h it cannot be
moved to components/autofill/core/common.

Bug: 869381
Change-Id: I69492fbc8af0ed9289504cb6aba3e745acb17b24
Reviewed-on: https://chromium-review.googlesource.com/1158364
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579778}

PasswordFormManager fills multiple times on different events from the
Renderer. That's not optimal from performance point of view, but it adds
robustness. This CL implements the same behaviour in
NewPasswordFormManager as in PasswordFormManager: to fill till 5 times.

This is quick fix, that will be merged in M-69. The better more
robust filling is more complicated and will be implemented later.

Bug: 868948, 831123
Change-Id: I44c93c5358b0e6707c545001f5f1a1fb7b60eec3
Reviewed-on: https://chromium-review.googlesource.com/1155116
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579777}

Setting the prefs has no immediate effect - they're only read during
sync startup (and after that, there are many situations where the values
are overwritten).

https://crrev.com/c/1148392 exposed this as an actual problem; before
that, things just happened to work out.

Bug: 856179
Change-Id: I24a3c8a22c87a128238efb5d0b9dd2ef8a022c71
Reviewed-on: https://chromium-review.googlesource.com/1156600Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579776}

https://pdfium.googlesource.com/pdfium.git/+log/d4906e83d313..3a40bed9d6e5


git log d4906e83d313..3a40bed9d6e5 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 thestig@chromium.org Add a ScopedLocale for use within CXFA_LocaleValue.
2018-08-01 thestig@chromium.org Mark CFGAS_FormatString methods as const.


Created with:
  gclient setdep -r src/third_party/pdfium@3a40bed9d6e5

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I407416ac3ea95b7e5e50d8cc7038d6f740c3e347
Reviewed-on: https://chromium-review.googlesource.com/1158345Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579775}

Layout tree rebuild and re-attachment now only matches selectors for
::first-letter. It's not worth populating the Bloom filter with
ancestor attributes just for optimizing ::first-letter matching.

Bug: 843520, 836126
Change-Id: I22c3a4d6518314ded66ef9b214db53c3ff16aac2
Reviewed-on: https://chromium-review.googlesource.com/1158230Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579774}

Every test in the set is flaking.

TBR=rouslan@chromium.org

Bug: 869790
Change-Id: I0a1e5d1a9fa52188386a441d65748547ef9ee890
Reviewed-on: https://chromium-review.googlesource.com/1158367Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579773}

R=schenney@chromium.org

Bug: 464103
Change-Id: Ic8ee3dca6d8fc9b333c7c17d2878786ff87342f7
Reviewed-on: https://chromium-review.googlesource.com/1155642Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579772}

Disable virtual/outofblink-cors/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html on mac rel

The test is flaking on the trybots with timeout

Bug: 869800
No-presubmit: True
No-try: True
Change-Id: I3e4c3c500f2d965dc443d0cf01e7e278cb41b992
Reviewed-on: https://chromium-review.googlesource.com/1158524Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579771}

https://webrtc.googlesource.com/src.git/+log/da3dbe83a352..6e250820b17e


git log da3dbe83a352..6e250820b17e --date=short --no-merges --format='%ad %ae %s'
2018-08-01 mbonadei@webrtc.org Removing rtc_base:base build target.


Created with:
  gclient setdep -r src/third_party/webrtc@6e250820b17e

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I78eefce1da61b25e7ce6662bbce75a761602b4b7
Reviewed-on: https://chromium-review.googlesource.com/1158324Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579770}

Added the 'AllowOnlyPolicyNetworksToConnectIfAvailable' policy to ONC.
If a managed network is available in the lsit of visible networks, all
unmanaged networks are considered as prohibited. However, we don't
remove network configurations for unmanaged networks because we might
want to re-connect with them, once we lose availability of the managed
network.
If this policy is enabled, we are currently connected to an unmanaged
network and a managed network is available, we automatically connect
to the available managed network when the network scan finishes.

Bug: 848719
Change-Id: I6da37d1b9d7813ff7bdfd52ab0e28081f9e48631
Reviewed-on: https://chromium-review.googlesource.com/1122979
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579769}

When building using jumbo, files get merged and variables
and functions with the same name may end up in the same
namespace/scope and conflict.

This commit solves the issues in components/autofill
by renaming the conflicting functions and variables to
something more file specific.

Bug: 869381
Change-Id: Ifccae861ca7379346fb0939113ac227b770f9640
Reviewed-on: https://chromium-review.googlesource.com/1158235Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#579768}

Fades the leading icon and the clear button to avoid overlapping with
the toolbar elements.

Bug: 867406
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib60719fe1adee84032bbd59588609fd63cfa06ed
Reviewed-on: https://chromium-review.googlesource.com/1152919
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579767}

- No longer necessary now that we compile against O and use a new
enough version of the support library that can handle channels.

Change-Id: I454d8cbc63744a277e05423998594e44cb4d7768
Reviewed-on: https://chromium-review.googlesource.com/1156550
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579766}

When building using jumbo, files get merged. This
results in a conflict with the namespace i18n.
This commit solves the issue bu specifying that the
global namespace should be used, by addind the
"::" prefix.

Bug: 869381
Change-Id: I3432251c5f91fbb1f35df6ef5a9c70337df5e21f
Reviewed-on: https://chromium-review.googlesource.com/1156601Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#579765}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6c5ad298..c1e3354d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I675155b3ede96bce34f1562f9e6cbe014454df4e
Reviewed-on: https://chromium-review.googlesource.com/1158386Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579764}

- iOS 12 returns nil for system cookie with null creation time.

Bug: 865803, 688540
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I612b4ab55aedb0a2c0d9b2a7cb24418c5a0a6c19
Reviewed-on: https://chromium-review.googlesource.com/1157229Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579763}

I confirmed this can be built with is_chrome_branded=true and is_official_build=true.

Bug: 868248
Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
Change-Id: I6bfbd22c89dd4d3d655fce0db10448afb6cb2103
Reviewed-on: https://chromium-review.googlesource.com/1157946
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579762}

TRACE_EVENT is currently used but TRACE_EVENT_WITH_FLOW makes it easier to
track the flow of fetch events.

Bug: 860394
Change-Id: I7aa669ee3769763c31f6b8621bbb1bb466c17ae0
Reviewed-on: https://chromium-review.googlesource.com/1156334Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Momoko Hattori <momohatt@google.com>
Cr-Commit-Position: refs/heads/master@{#579761}

These tests have been observed to repeatedly crash on
WebKit Linux Trusty MSAN

Bug: 869818
No-try: True
No-presubmit: True
Change-Id: Ieb9d7a9ce970960051ab480001a61f6db9bb8bf5
Reviewed-on: https://chromium-review.googlesource.com/1158464Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579760}

A metric is added to count the number of times Flash permissions are
set for a website. The counter is separated based on whether this is the
first granting of permission or the next times.

Bug: 865933
Change-Id: If33aaf4915109f6e7ed49dc1e7142c64b6981fac
Reviewed-on: https://chromium-review.googlesource.com/1145197Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579759}

This CL tries to fix the test failure introduced by testVarationArgsCompatibi-
lityMode. We replaced the hardcoded number with a reliable check of the exact
arguments added. This CL mimcs the change in CL:1151447.

Bug: 869602
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I79579ae403066a410b477920a7fd1e29777aaf8a
Reviewed-on: https://chromium-review.googlesource.com/1158229Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Leonard Ge <wangge@google.com>
Cr-Commit-Position: refs/heads/master@{#579758}

Preferences related to ChromeOS Proximity Auth are removed from the
persistent storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Id9247d7ba200705786327aeab7f251a77de0435f
Reviewed-on: https://chromium-review.googlesource.com/1158067
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579757}

The task type was introduced at https://chromium-review.googlesource.com/c/chromium/src/+/1088534
but kInternalMedia was not appropriate since BroardcastChannel has
nothing to do with media. Use kPostedMessage instead.

Bug: 846618
Change-Id: Icdb72bd88aa4de9b6a7d415dde41268a5d7ca4bc
Reviewed-on: https://chromium-review.googlesource.com/1158314Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579756}

When WritableUnalignedMapping takes a handle, it *does* own it (the temporary
shared memory region created in the constructor consumes the handle).

Bug: 849207
Change-Id: Icabca455727ad275d9c5a55065c5baf18f44e08c
Reviewed-on: https://chromium-review.googlesource.com/1152913Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579755}

An upcoming change to base::Bind rejects binding ref counted objects
when their ref count is zero, as that pattern of usage is error prone.
This CL updates that pattern in //content.

For DOMStorageContextWrapper, the instance and a MemoryPressureListener
used to own each other implicitly. And, after this CL,
DOMStorageContextWrapper owns MemoryPressureListener.

For PlatformNotificationContextImpl, its Initialize() makes a reference
to the instance, and drops it soon. So, without keeping a reference
in caller, Initialize() may destroy the instance.

For WebContentsImpl::RequestAXTreeSnapshot, this should also keep a
reference to the instance, as AXTreeSnapshotCombiner::AddFrame called
by RecursiveRequestAXTreeSnapshotOnFrame makes a reference to
AXTreeSnapshotCombiner, and releases the reference after the method
call. So, that destroys AXTreeSnapshotCombiner instance implicitly.

SW's StoppedObserever and TestFileErrorInjector is the false positive
cases of the check.

Bug: 866456
Change-Id: Ie99c996fdcf2413b170de2a246d63c34433a24ac
Reviewed-on: https://chromium-review.googlesource.com/1156200Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579754}

https://android.googlesource.com/platform/external/perfetto.git/+log/a52306a4a7f2..313502391288


git log a52306a4a7f2..313502391288 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 hjd@google.com Merge "perfetto-ui: Upgrade typescript to 3.0.1"
2018-07-31 hjd@google.com perfetto-ui: Upgrade typescript to 3.0.1


Created with:
  gclient setdep -r src/third_party/perfetto@313502391288

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I680f641ad4b91ae30e73de6bc413033ddd6f81e3
Reviewed-on: https://chromium-review.googlesource.com/1158344
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579753}

These are loaded through WorkerShadowPage, and this CL to add a code to check
the preferences and add the header in there.

Bug: 853085
Change-Id: I080e3fa4cb175763b17dca127907750c51eef966
Reviewed-on: https://chromium-review.googlesource.com/1154782Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579752}

In addition to existing limit of 200 messages in a single task also
limit it to 10 milliseconds to avoid starvation.

This logic will be removed when message-per-task mojo dispatching
will be implemented.

BUG=867133
R=mek@chromium.org

Change-Id: I397d60d06e62507e8a322ee9e68be36093fefa57
Reviewed-on: https://chromium-review.googlesource.com/1152815Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579751}

This change now logs the rest of the notification UKM fields that were
previously not logged. How they are logged is unchanged.

Bug: 842622
Change-Id: Id4deab3a09dc6ff19ecdde076460b3927358b622
Reviewed-on: https://chromium-review.googlesource.com/1151116
Commit-Queue: Sharon Yang <yangsharon@google.com>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579750}

NextEventId(), which is used in ServiceWorkerTimeoutTimer is not thread-safe.
I fixed this problem by using AtomicSequenceNumber.
This ensures event ids dispatched to service workers in a process are unique in the process.

Bug: 869706
Change-Id: Ia19aa180007479387463d3d0725dae052da17632
Reviewed-on: https://chromium-review.googlesource.com/1158092
Commit-Queue: Momoko Hattori <momohatt@google.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579749}

FileChooser: Move pending file chooser queue from content::RenderFrameImpl to blink::ChromeClientImpl

* Motivation

This is a preparation to switch FileChooser from legacy IPC to
Mojo. Blink and Pepper want to communicate with the browser process
directly, and the logic in RenderFrameImpl should be moved.

* Implementation

Pepper: The pending queue has never been used. PepperFileChooserHost
blocks file chooser requests while a file chooser is already shown. So
we can just bypass the pending queue.

Blink: Implement the pending queue in blink::ChromeClientImpl.
- Add ChromeClientImpl data member to WebFileChooserCompletionImpl to
 call it back.
- Add FrameOrNull() to WebFileChooserCompletionImpl, FileChooser, and
  FileChooserClient in order to obtain WebLocalFrameClient from
  WebFileChooserCompletionImpl.

Bug: 869257
Change-Id: Ib00d949b4f638c2a660119a86c9115a03f300920
Reviewed-on: https://chromium-review.googlesource.com/1157742Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579748}

"IsSyncDisabled" described neither what the method was trying to do, nor
what it actually did. This CL flips it to "IsSyncEnabledByUser" (yay
less negation), and also fixes its implementation to actually check
that.

This was exposed as an actual problem by https://crrev.com/c/1148392.

Bug: 856179
Change-Id: I4219b5fa8d596edc80ed649983bc59198051c521
Reviewed-on: https://chromium-review.googlesource.com/1156599
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579747}