GitLab

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a680c23e7859..beec66070ea7

git log a680c23e7859..beec66070ea7 --date=short --first-parent --format='%ad %ae %s'
2020-03-31 ehmaldonado@google.com git-cl: Execute clang-format-diff.py using vpython.

Created with:
  gclient setdep -r src/third_party/depot_tools@beec66070ea7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1066187
Tbr: agable@chromium.org
Change-Id: Icc8d272dcf2913e7ba8c4f82fb6025bd7668b676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131148Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755174}

https://quiche.googlesource.com/quiche.git/+log/0abcd8febd32..5a39301cb829

$ git log 0abcd8feb..5a39301cb --date=short --no-merges --format='%ad %ae %s'
2020-03-31 quiche-dev Update QboneStream to have a configurable TTL.
2020-03-31 fayang Add a QuicCoalescedPacket::ToString which will be used for net-log in chrome.
2020-03-31 bnc gfe-relnote: verify gfe2_reloadable_flag_quic_create_incoming_stream_bug.

Created with:
  roll-dep src/net/third_party/quiche/src

R=dschinazi@chromium.org

Change-Id: I68e8b14a4a306343abdd5ec01a4f8494b8f90720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130640Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755173}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af705142bcc4..18db0d80f61d


Created with:
  gclient setdep -r src-internal@18db0d80f61d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: If8c8dd91c3d8d767f1a657948f3a2bff7740761e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130837Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755172}

Bug: 1044139
Change-Id: I477580eeaad92239b624fbe78dc3c8d8fc005d4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130870Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755171}

Add tests around the display of preferences managed by policy
(administrator) and custodians (parent(s)).

Bug: 1044401
Change-Id: I6176b9c89ab218a50f06fa611507e057377d5cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130676Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755170}

This CL adds FromProgrammaticContentScript_PermissionToAllUrls_FileUrls
testcase to the CorbAndCorsExtensionBrowserTest suite.

Bug: 1051594
Change-Id: I219474f8c8b9335f474735d4c1b753df2004c68d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124543
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755169}

This CL:
- Removes WebApkActivity usage in tests in preparation for
deleting WebApkActivity
- Removes references to WebApkActivity in tests

BUG=1059580

Change-Id: I6c4788938854fccdfc12477bd2bd6e2bb5ec6c88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126471
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755168}

https://dawn.googlesource.com/dawn.git/+log/7982cc052763..3da19b843ffd

git log 7982cc052763..3da19b843ffd --date=short --first-parent --format='%ad %ae %s'
2020-03-31 cwallez@chromium.org Use the default values for Dispatch in examples and tests
2020-03-31 cwallez@chromium.org Add the defaults for Draw and DrawIndexed

Created with:
  gclient setdep -r src/third_party/dawn@3da19b843ffd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ia299e1a151a2b992dfbd66747669f457ec35974c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130844Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755167}

This reverts commit 721f0aa1.

Reason for revert:
suspect this is breaking compilation on ios-simulator

Original change's description:
> [ios] Remove dead code in first_run_util
> 
> Removed dead codepaths and marked unused histograms obsolete.
> 
> Change-Id: Ie4f5485ebd9c915dcb36c8ac7d14d2d688b200e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129507
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Commit-Queue: edchin <edchin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755163}

TBR=isherman@chromium.org,kkhorimoto@chromium.org,mrefaat@chromium.org,edchin@chromium.org

Change-Id: I1d3d94ce35b28df80626a1838b3c110957b8757d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131354Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755166}

Per spec, a rejected animation ready or finished promise should be
marked as handled. A small change was added to script promise property
to support marking the promise as handled.

Bug: 1066458
Change-Id: I22f1adaaf35a05d0730f72c892d67b6a3bf15e8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129774Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755165}

This change uses set_ink_drop* method to set the opacity and it also
adds a new color ID to be used as the ink drop color.

For now the color ID has the same value used for GetDarkSchemeColor
and GetDefaultColor.

Bug: 1056950
Change-Id: I18ca7482fe4bb718600d9839a46a22159a7f3269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116948Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Maria Villarreal <mavill@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#755164}

Removed dead codepaths and marked unused histograms obsolete.

Change-Id: Ie4f5485ebd9c915dcb36c8ac7d14d2d688b200e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129507Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755163}

The test has timed out 3 times in a row on the MSAN bot. Updating the
test expectations.

TBR=leese@chromium.org

Bug: 1066647
Change-Id: I58df9c2b5f5f8edd3bf92d75099e449ec917c449
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131037Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755162}

'presentationTimestamp' is being renamed to 'mediaTime', which
differentiates it from 'presentationTime'

'expectedPresentationTime' is renamed to 'expectedDisplayTime' to make
the expected usage of the field more intuitive for web developers.

'elapsedProcessingTime' is renamed to 'processingDuration', since it is
a time delta, and not a timestamp.

'presentedFrames' and 'mediaTime' are also marked as required.

Bug: 1012063
Change-Id: Iaee640e9a41eb94155096ac49057cc5e14476ef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099240
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755161}

Fixed: 1063153
Change-Id: Ia9060c5d7fd0ae0ec10a9014cbf9bc1cbf0df1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122246
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755160}

This also seems like a good metric to have, only recorded when
prefetching attempts have been made.

Bug: 1023485
Change-Id: I34c647d20c165386221c117e18f8212882fc9db2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129891Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755159}

../../chromecast/media/cma/backend/volume_control.cc:50:17: error:
unused variable 'kMinDbFS' [-Werror,-Wunused-const-variable]
constexpr float kMinDbFS = -120.0f;
                ^
		1 error generated.

Change-Id: I787673a625feb4d23c304404f5b62e8f663b2d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131247Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755158}

Change-Id: Ibf3e6936d438cd18868235e9fb783a3b9b78b6ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128377
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755157}

Per go/chrome-tos-ia and crbug.com/1065912, the FRE Privacy Notice is
removed.

This CL also removes all the obsolete code that supported showing a
privacy link in FRE. Much of this code was introduced in this
original CL: crrev.com/c/860220.

Bug: 1065912
Change-Id: I047e19d76cd9ada687650dbf326dd84374514a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127727
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755156}

ToolbarButtonIPHController is build with a particular ChromeActivity
and the objects associated with it. Therefore it doesn't need to
use TabImpl.getActivity() to get the current activity dynamically.
This CL removes replaces the use of API with the controller's
|mActivity|.

Bug: 952703
Change-Id: Ie3e601250192832f4fb2706e44e673c374a0129a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129374Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755155}

Prior to 1b6beceb we would stop
deferring logs before any threads had been started. The new
mechanism defers quite a bit longer and as such may encounter
thread safety issues.

The fix is to add a lock when we're deferring logs and move the
take over process into a helper class so we can ensure continuity
pre and post take over.

The fix only uses the lock when we're in deferred mode, after the
takeover we no longer need it.

R=danakj

Fixed: 1066469
Change-Id: Ie272d6581329c51bb624b08750ad7ccf60e3e17c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130628
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755154}

Add a flag for checking content against
safe search.

BUG=1066643

Change-Id: I039c0fbb4b97c92fade0dfd5718e50f03a7e7398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130775Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755153}

Change-Id: Idb7edeeb717e11779501e58865ef716295cab04a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131208
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755152}

This CL fixes the routing for the OS settings pages pluginVm/details
and pluginVm/sharedPaths, which the File Manager relies on.

Bug: b:152708714
Change-Id: Id5bb0272c70dbf4097bbb675d897dd22af830e10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129453Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755151}

DeviceCommandRunRoutineJobTest's new RunJob
function combines the job initialization and
running. It reduces the amount of code necessary
to write a new unit test by hiding the details of
the initialization from the unit test.

Bug: chromium:1066251
Change-Id: I4ab334689d66a7bd09b3ff55fd27ef54d90567e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130678Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755150}

Bug: 1065897
Change-Id: Ie021c84c3474a3b35550618691f6f9082a09c25d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130970Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#755149}

Bug: 1062074
Change-Id: I82b8b2f01fbb319e8a7008c13b0b932ebc214564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128375
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755148}

This change launches the WebOTP API to Android stable.

Bug: 670299
Change-Id: I5cd923ac9ce71ea8902a823bd7a8f8395b92f7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067810Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Alex Russell <slightlyoff@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755147}

BUG=1066013

Change-Id: I8ac8816fb4eda6913d60d548811bab14f45e2f9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129857
Auto-Submit: Theresa  <twellington@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755146}

Bug: 1055228
Change-Id: Icac03f005a378c5b2f15b56641f3c754817fdb47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123313
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755145}

Add entry to about flags

BUG=1024351

Change-Id: Ie3abeda1761692abbc2ca23ccfa6e1cb323e7420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130184Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755144}

This CL removes the
WebappDataStorage#updateTimeOfLastCheckForUpdatedWebManifest() call in
WebappDataStorageTest to make the test more representative of prod after
https://chromium-review.googlesource.com/c/chromium/src/+/936602/

BUG=None

Change-Id: I369aa2aede781915c669f8faf1ec31536a5e13b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126468
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755143}

The includes need to be in the same order in ResourceId.template and
resource_mapper.cc. https://crrev.com/c/2091496 added page info icons,
but the includes were swapped in ResourceId.template.

Bug: 1066410
Change-Id: Idb465a017891cf5610191ebe8d304b2c580e5f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130808Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755142}

https://skia.googlesource.com/skia.git/+log/8b99b9e1d11c..8a78e9cdc30e

git log 8b99b9e1d11c..8a78e9cdc30e --date=short --first-parent --format='%ad %ae %s'
2020-03-31 bsalomon@google.com Don't require color type to wrap a texture/RT.
2020-03-31 brianosman@google.com Move SkDraw to use SkVerticesPriv, remove redundant private API
2020-03-31 jvanverth@google.com Allow GrD3DTextureResourceInfo to include declared D3D12 types.
2020-03-31 mtklein@google.com small int->Val hunt

Created with:
  gclient setdep -r src/third_party/skia@8a78e9cdc30e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I325b6fe6f10dd5eedc55a4a39bd2ea4a7f17f392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130831Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755141}

Bug: 1066182
Change-Id: Ie3f85da9c31840f54a8538640dfaf2cc42fa3ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131014
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755140}

This CL removes direct dependencies on HelpAndFeedback from the Site
Settings UI, which is in the process of being componentized so it can be
reused by WebLayer. The existing help logic is moved to
ChromeSiteSettingsClient, since it contains Chrome-specific URLs and
logic.

Bug: 1058597
Change-Id: Id676437e447377e19f062ee5d1524bd2de0511d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128369Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755139}

Change-Id: I8883e99c1a412b4489781c1b556895af07260c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128833
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755138}

Previous versions of Chrome (M48 and earlier) looked for policy data
under the "ChromePolicy" key, but current MDM vendors do not support
placing policy data in a child dictionary.  This CL updates
PolicyLoaderIOS to read policy data from the top-level dictionary.  In
order to prevent existing configurations from taking effect as we enable
policy support, this CL also adds the requirement that an
"EnableTrustedTesterSupport" key be present and set to true, or else
PolicyLoaderIOS will not load any policy data, even if data is present
in the configuration dictionary.

This CL adds EG tests to verify that policy data is ignored when
the required key is not set.  It also splits the existing tests into
two files and simplifies how policy data is passed on the command line.

BUG=1065261

Change-Id: I4434b863dc9c52e3312c91365487a1fb05dc028e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123408
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Guillaume Jenkins <gujen@google.com>
Cr-Commit-Position: refs/heads/master@{#755137}

This is a follow up to crrev.com/c/2079303.

The PZPS header information is expected in the following format in the
Chrome suggest response. Every suggestion that must appear under a header
has a suggestion group id in its respective "google:suggestdetail" dict
which maps to a header text inside "google:headertexts>a".

...
"google:headertexts":{
  "a":{
    "40009":"Recommended for you"
  }
},
"google:suggestdetail":[
  ...
  {
    "zl":40009
  },
  {
    "zl":40009
  }
],
...

This CL improves on its predecessor by storing the header mapping
information in the ACResult and the suggestion group id in the ACMatch.
This allows hiding/showing matches that belong to a certain group id
(possibly using prefs) regardless of the internationalized header value.

Also as opposed to the previous CL that discarded the headers if they were
deemed incorrect, this CL assumes the server provided suggestion group ids
are correct and instead demotes the grouped suggestions to the bottom of
the list of suggestions do that the backfilled local suggestions would not
appear under server provided headers.

Bug: 1065152,1052519
Change-Id: I2c4e6a8a76606047e9350715fff0316190d24bdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128843
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755136}

Change-Id: Ib7bf8c6c399953527fe8e988322502197f596a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130767Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755135}