GitLab

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/34cccdc65d79..4b97a1108114

git log 34cccdc65d79..4b97a1108114 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 johnkslang@users.noreply.github.com Merge pull request #1919 from dj2/install_spirv
2019-10-03 johnkslang@users.noreply.github.com Merge pull request #1918 from KhronosGroup/format-attributes
2019-09-25 johnkslang@users.noreply.github.com Merge pull request #1906 from ShchchowAMD/master
2019-09-20 johnkslang@users.noreply.github.com Merge pull request #1910 from KhronosGroup/fix-1900-const-nonuniform
2019-09-19 johnkslang@users.noreply.github.com Merge pull request #1907 from kainino0x/separate-web-and-emscripten
2019-09-19 johnkslang@users.noreply.github.com Merge pull request #1905 from KhronosGroup/GL_EXT_buffer_reference_uvec2
2019-09-18 johnkslang@users.noreply.github.com Merge pull request #1908 from digit-google/fuchsia-fixes
2019-09-18 cepheus@frii.com README: Fix WASM typos.
2019-09-18 cepheus@frii.com HLSL: Fix #1903 Catch 0-argument case to constructors.
2019-09-18 johnkslang@users.noreply.github.com Merge pull request #1902 from jeffbolznv/extended_types
2019-09-16 johnkslang@users.noreply.github.com Merge pull request #1899 from KhronosGroup/SPIR-V_1.5
2019-09-16 johnkslang@users.noreply.github.com Merge pull request #1894 from ShchchowAMD/master
2019-09-12 johnkslang@users.noreply.github.com Merge pull request #1897 from dj2/unused
2019-09-11 johnkslang@users.noreply.github.com Merge pull request #1895 from amdrexu/bugfix
2019-09-05 cepheus@frii.com Fix #1879: Check for valid variable before checking for unsized arrays.
2019-09-05 johnkslang@users.noreply.github.com Merge pull request #1892 from greg-lunarg/kg106
2019-09-03 johnkslang@users.noreply.github.com Merge pull request #1889 from Roy-AMD/code-refine
2019-08-30 cepheus@frii.com Placeholder fix for part of #1870.
2019-08-30 cepheus@frii.com Non-functional: Make whitespace/braces consistent for a recent commit.
2019-08-29 johnkslang@users.noreply.github.com Merge pull request #1885 from zoddicus/fixUnInitializedVariableWarnings
2019-08-28 johnkslang@users.noreply.github.com Merge pull request #1876 from jeffbolznv/imma
2019-08-28 cepheus@frii.com ESSL/SPV: Fix #1856: Allow ESSL shaders to compile to OpenGL SPIR-V.
2019-08-28 cepheus@frii.com Documentation: Provide more detail in setting up the environment.
2019-08-27 johnkslang@users.noreply.github.com Merge pull request #1883 from Kangz/fix_gn
2019-08-27 johnkslang@users.noreply.github.com Merge pull request #1881 from baldurk/buffer-array-bind-reflection-fix
2019-08-26 johnkslang@users.noreply.github.com Merge pull request #1882 from Kangz/fix-chrome
2019-08-26 johnkslang@users.noreply.github.com Merge pull request #1878 from dneto0/chrome-fix
2019-08-22 cepheus@frii.com Bump revision.
2019-08-22 johnkslang@users.noreply.github.com Merge pull request #1874 from KhronosGroup/inherit-memory-qualifiers
2019-08-22 johnkslang@users.noreply.github.com Merge pull request #1875 from jonahryandavis/extra-tokens
2019-08-21 cepheus@frii.com Bump version.
2019-08-21 johnkslang@users.noreply.github.com Merge pull request #1855 from KhronosGroup/web

Created with:
  gclient setdep -r src/third_party/glslang/src@4b97a1108114

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com,geofflang@google.com

Bug: None
Change-Id: Ia35e07d16f2adfc46bce3b5a581fb4bade2f8315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844121Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703380}

The present CL refactors overview in preparation for the idea that each
root window will have its own SplitViewController with its own
observers. Each OverviewGrid shall observe the corresponding
SplitViewController. OverviewSession shall observe the
SplitViewController for the primary root window, for the sole purpose of
updating the bounds of the no windows widget.

Test: ash_unittests OverviewSessionTest.* OverviewGridTest.*
Bug: 970013
Change-Id: Iae96ff34eb7e6c3f0fb48eb38d563e3366f72861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841776
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703379}

When calling CreateLowBoxToken, the kernel API will throw an error if
there is a mismatch between the saved_handles_count and the
saved_handles array. If the count is 0, the pointer must be null.

This change passes in nullptr to CreateLowBoxToken for saved_handles if
saved_handles_count is 0.

Bug: 1000447
Change-Id: I2e5706944e5348ae1833eb28562945b7874f6a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845831Reviewed-by: James Forshaw <forshaw@chromium.org>
Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703378}

Instead of MRUCache which uses a sorted map under the hood. Use two
std:arrays, one to store all the keys (very cache friendly when scanning
them). And then immediately jump to the value in the other array.

This leads to a ~9% speed up (5 to 13% at the 95% confidence). See the
"two_arrays tracing/tipOfTreeTracing" sheet in
https://docs.google.com/spreadsheets/d/1HIiyUQa7d8eLfMBBBm_7V60kqNABYoFbHpKdpwnYu78/

Total tracing overhead is ~59.8% (52% to 67% at the 95% confidence). See the
"two_arrays tracing/tipOfTreeNotTracing" sheet in the doc above.

Bug: 1007611
Change-Id: Ie2584e0e3a13e34097021fd128387cfa4fabaeed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844822
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703377}

These changes simplify migrating to starlark by removing spurious diffs
from the semantic diff.

The name in the hand-written project.cfg doesn't appear to actually be
used. In lucicfg, the parameter that populates the name field in the
generated project.cfg is used for creating the fully-qualified names of
the form <project>/<bucket>/<builder> where the actual value is only
<builder> or <bucket>/<builder>.

The repo field in the gitiles field of the trigger field doesn't require
the .git suffix and the normalized value when computing the semantic
diff omits it. In lucicfg, the parameter that populates the field
disallows the .git suffix.

Change-Id: Id26647e72cbdb2c7f913ab608273ccc032e14d55
Bug: 1011908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836002
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703376}

Bug: 1008838
Change-Id: Id8ca2de0720fe6a7254291b18d5969c6174780da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842551Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703375}

Our initial remediation instructions for https://crbug.com/1007358,
https://web.archive.org/web/20190925230123/https://support.google.com/chrome/thread/15235262,
instructed users to remove system Keystone while preserving system
tickets. Following these instructions, user Keystone would be installed
when Chrome was launched, and a user ticket would have been registered.
Chrome's own install script would then find a system ticket and remove
the user ticket and cancel the user-driven update.

By only respecting a system Keystone ticket when system Keystone
actually appears to be installed, based on the presence of
GoogleSoftwareUpdate.bundle in the system (root /Library) location, the
immediate user ticket removal can be avoided, and the update attempt
will not be abandoned.

Because a system ticket is present, it's likely that the user will still
not have appropriate permission to update the Chrome installation. But
in this case, at least the error message will be more accurate. This fix
is necessary for users to successfully recover by installing a new copy
of Chrome as a user.

The "set up automatic updates for all users" button can be used to
reinstall system Keystone and get Chrome correctly back on a system
ticket.

Bug: 1007358
Change-Id: I8a9218cb959e359d6f6033de1d638b99344d8374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834944Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703374}

So that cookies get looked up in 1st party, not 3rd party, context.
This should keep the tests:

IsolatedAppTest.CookieIsolation
IsolatedAppTest.SubresourceCookieIsolation
PlatformAppBrowserTest.Isolation
WebViewTest.CookieIsolation

working with upcoming cookie behavior changes.

Bug: 1006816
Change-Id: I3d366dcb484efa61045d6d339bb1e7d3c5062a08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844712Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703373}

https://webrtc.googlesource.com/src.git/+log/b441acf65652..99a209624835

git log b441acf65652..99a209624835 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 ivoc@webrtc.org Added support for skipping get_audio events, adding dummy packets and setting a field trial string.
2019-10-07 srte@webrtc.org Replaces static modifier functions in AudioSendStream.
2019-10-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 35431c51..10156469 (703133:703248)

Created with:
  gclient setdep -r src/third_party/webrtc@99a209624835

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Ie137c73dcf0b6edf50122787675503be5e7b08f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845090Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703372}

This CL implements Don't Show Again for the notification UI on iOS
client. MDCAlertController doesn't work well if it has too many buttons,
(and there is no checkbox UI in iOS either), so I introduced a custom
dialog view controller instead that stacks the message and buttons
vertically.

Screenshots:
https://screenshot.googleplex.com/eJk0NEnXGBk
https://screenshot.googleplex.com/vQY6nQwB2MN

Bug: 1001291
Change-Id: I2a6e94ba5a9162d6144c3a5acb0c0040259d5ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836974Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703371}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I58eb2f1f250a09221c7a2d3162cd7398e4666e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845572Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703370}

Bug: 866336
Change-Id: I4e59974ee8f11cd789720b587d2954d7e3086168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1309654
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703369}

This CL adds a few integration tests. They stop at the bridge since the
execution of native code slows the tests down, introduces flakiness and
most-likely doesn't work on Kitkat.

Bug: 957532
Change-Id: I291c50ef7b8772198c89109bbe3acd885a43d054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845372
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703368}

This adds policy definitions for two policies that allow reverting to
"legacy" SameSite cookie behavior, either by default or for a specific
list of domains. As the policy implementation is not yet complete, these
are tagged with 'future': True for now.

Bug: 978172
Change-Id: Ieb95eec87b08b0c44a535ad8b1c7c90431d6a039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837234
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703367}

This CL modifies the JPEGImageDecoder to detect the YUV subsampling
format correctly when not all the components are in the first scan.
Prior to this change, the subsampling calculation was based on the
information in the first scan. However, for some JPEGs
(non-interleaved), this would produce YUV_UNKNOWN. This change makes the
computation based on the information in the SOF which is global for the
image and includes the information of all the scans.

Bug: 900446
Test: Add a test to cover the non-interleaved case.
Change-Id: If1d810f0d921cba3603cf82ac9fba19da02e8982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844094Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703366}

Ensure that newly created sessions get the current XRVisibilityState,
even if they were created after that visibility state may have changed.

Bug: 1011566
Change-Id: I5eac2aac73f74a7e4b4426be3b5e6603097db39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841246Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703365}

Change-Id: Ie638c6f3d05c548056a8f78a83ac7f243bff0472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841751
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703364}

This is to match the spec change[1].

[1] https://github.com/gpuweb/gpuweb/pull/423/files#diff-599c3a4f36042dec5cdc606f3c30dc38R913

Bug: 877147
Change-Id: I3fcf6505fd69caa6b3932145f937bc1b523b9244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844526Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#703363}

This is to match the WebGPU's WebIDL[1].

[1] https://github.com/gpuweb/gpuweb/pull/359

Bug: 877147
Change-Id: Ia5fedae01348411f5e1c59faebe5c13a3dd85f91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843791Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#703362}

Bug: 840435
Change-Id: I08726654201e5db65e79f86f52b19a18094c8146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842412Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703361}

A delay of 3 seconds may not be long enough to act before restore finishes.
Also, remove WKWebView cache to prevent any fast pageloads.

Bug: 1011336
Change-Id: I69b2f0a3ab0b2e1c1a5c7d7a08dd71def48c90ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842035
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703360}

Setting the label only needs to be done when either the width of the
SelectedKeywordView changes or when the keyword changes. Layout does not
need to play a part of this.

BUG=1005568
TEST=interactive_ui_tests SelectedKeywordViewTest*

Change-Id: I8e77635f23d05b17bda41c3286147fa612e45de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838255Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703359}

ios-simulator-noncq will be used to stage tests that are EG2 but
not yet ready to promote to CQ, and to help load balance the CQ
bot full-configs.

Bug: 1011526,1009566
Change-Id: I93af918ed7763b02c42b0b8595b857b88dd686bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841949Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703358}

Use RenderProcessHostObserver and RenderProcessHostCreationObserver
APIs, to replace the usage of NotificationService. More details in
the bug.

Bug: 357627
Change-Id: I57d75492ac13b7da014833c24be52f8c37fe531b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842611Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703357}

Android versions before M require a permission to read the call state
which we use to get metrics for Click to Call. As we do not want to add
permissions to the manifest, we won't try to log this metric on pre M
devices.

Bug: 1011767
Change-Id: I244295f57443c0831c488695b7ed2ea537e7c77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845007Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703356}

Implementation of proposed behavior #1:
- When 2+ tabs are dragged, they immediately lose their original grouped
status.
- The grouped status of the dragged tabs updates together, based on the
mouse position (i.e. treat the multiple dragged tabs like one giant tab,
as far as grouped status is concerned).
- If drag is canceled, all tabs go back to where they were taken from
(existing behavior).

Bug: 978609
Change-Id: Iab5ef1e66c50880d0fea433f712fcb10a825a769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833300
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703355}

Change the caption string field from "Enable power peak shift"
to "Enable peak shift power management".

Bug=b:141540468

Change-Id: I06795634e89a74b0c20bdc1d1d915c572cf80c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845005Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#703354}

This CL makes the outline of highlighted ToolbarButton thicker and thus
more visible if the highlight has no text. Highlight with no text is
at the moment only used by the AvatarToolbarButton in state
kHighlightAnimation. Without this change, that animation felt too
subtle.

Bug: 1008340
Change-Id: I64b4c3464957c34fc362fc350fb47595fa24285c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831801
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703353}

When BrowserRootView is being destroyed, we shouldn't call callbacks from
DropTarget. It might be already destroyed.

Bug: 1001942
Change-Id: Iddecc9334d814f9154d44ff32473c5fa167b3b23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844001
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703352}

This reverts commit 7172c7f2.

Reason for revert: Re-enabling to catch flaky run loop tasks with
additional run loop debug information. New run loop timeout information
added as part of crbug/1010061.

Original change's description:
> Disable SubresourceFilterSafeBrowsingActivationThrottleTest.NoConfigs
>
> TBR=hbos@chromium.org
> NOTRY=true
>
> Bug: 1010020
> Change-Id: Ia15694adcd86238dd59b7775d9d6a25ee3d2cfcf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833118
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#701548}

TBR=hbos@chromium.org,xidachen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1010020
Change-Id: I09daf7f0ae76bacf6826334f250b10a2d1a4c3ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843913Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#703351}

This reverts commit b473f1d8.

Reason for revert: Re-enabling tests to catch flaky run loop tasks
with additional run loop debug information. New run loop timeout information
added as part of crbug/1010061.

Original change's description:
> Disable SubframeNavigationFilteringThrottleTest.FilterOnRedirect
>
> TBR=hbos@chromium.org
> NOTRY=true
>
> Bug: 1010020
> Change-Id: I6f78af68ae006d29e991b180adadc347170224a0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833116
> Reviewed-by: Xida Chen <xidachen@chromium.org>
> Commit-Queue: Xida Chen <xidachen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#701544}

TBR=hbos@chromium.org,xidachen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1010020
Change-Id: Ifeef268d208a2ff12bfd6c5dc5f8e95afa6bbf73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845153Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Justin Miron <justinmiron@google.com>
Cr-Commit-Position: refs/heads/master@{#703350}

Makes 'NAVIGATE' be the '0', or potentially default, value.

Bug: internal b/141853741
Test: none
Change-Id: I6d5025e32396be7fe61035046c2b237f1645c504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844077Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703349}

In addition to better readablility this replaces use of
base::RunLoop().RunUntilIdle() with EvalJs's ability to wait for a
Promise to resolve. This should hopefully de-flake the device add and
remove tests.

Bug: 999472, 999502
Change-Id: I766d28e8fcde19e84346b46cc6dafedd4c921a77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842616Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703348}

Issue: Idle thread creation is not disallowed while JoinForTesting().
Fix: prevent thread creation in EnsureEnoughWorkersLockRequired with join_for_testing_started_.

Bug: 1009536
Change-Id: I3f6f18efa5e950c69fef1f7d4458d703ca1d6056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834201
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703347}

This CL moves processing of FrameHostMsg_DownloadUrl and
FrameHostMsg_SaveImageFromDataURL from
RenderFrameMessageFilter::OnMessageReceived (which runs on the IO
thread) to RenderFrameHostImpl::OnMessageReceived (which runs on the UI
thread).

As part of the refactoring, the CL also removed no-longer-necessary
|render_view_id| and |render_frame_id| fields from the IPC payloads.
These fields are implied, when sending the IPC messages directly to
a RenderFrameHostImpl.

The CL had to modify some tests to account for the changes:

- Apparently there was no coverage of RenderFrameHostImpl::SaveImageAt.
  The CL adds coverage in the form of DownloadContentTest.SaveImageAt.

- The RenderViewHostTest.SaveImageFromDataURL unit test was very closely
  tied to a specific implementation and was basically verifying that
  RenderFrameMessageFilter::OnMessageReceived forwards the IPC to
  RenderFrameMessageFilter::OnDownloadUrl and then to
  the (test version of) RenderFrameMessageFilter::DownloadUrl.
  The CL removed the test - the end-to-end test coverage offered by the
  new DownloadContentTest.SaveImageAt should be more valuable.

- The CL only needed to slightly tweak
  RenderFrameImplTest.SaveImageFromDataURL test to account for modified
  payload of the FrameHostMsg_SaveImageFromDataURL IPC.

The CL also opportunistically fixed some |git cl lint| issues (IWYU,
marking some constructors as explicit, whitespace formatting).

Change-Id: I3cd6d9545b16ed8d5ebe51c05dd588fffc1ed17b
Bug: 1008917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827949Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703346}

We are going to remove RevocableInterfacePtr and so change to use the
mojo::Remote directly.

BUG=978694

Change-Id: I08745b87773b4dc534a1e32652d4faf156259d00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842298Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703345}

The pathvisited UMA was recording every typo as a different page, we only want to record valid pages, so now we check if it a valid settings page before recording.

Bug: 869847
Change-Id: I53a7834f9d8544d9bc6bbdb3e2cca9887b2fb49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819311Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703344}

When running CopyStackContentsAndRewritePointers on ARM64, we need to
include the stack pointer itself in the list of registers to update so
that they point to the new copy of the stack data. Together with
https://crrev.com/c/v8/v8/+/1845189 , this allows the unit test
V8UnwinderTest.UnwindThroughV8Frames to pass on Windows ARM64.

Change-Id: Ie08cb8d942d7ee29ee69aea3cc2d58407529027e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844276Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#703343}

This CL makes the needed paint / compositing changes to make the DOM overlay
element appear transparent.

Split out from https://crrev.com/c/1741008

Bug: 991747
Change-Id: I6461c095becb5b2712942521b33338bdaf5ccfff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802674
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703342}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5750cdd8..62fdbf47

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9a840d00be16a4d6ee4a369c6c48ebea84c5df56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844397Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#703341}