GitLab

In this CL:
 - Move tokenize_line class method to TestExpectationLine, as suggested by FIXME.
 - Make tokenize_line non-protected, since it's used in another class, and
   would be useful in other modules, e.g. update_w3c_test_expectations.
 - Move class attributes that tokenize_line depends on.
 - Other changes suggested by linter (e.g. shorten long variable name).

This is a preliminary refactoring CL which is intended to make it easier to re-use tokenize_line in update_w3c_test_expectations.py, in order to make it easier to fix http://crbug.com/647395.

BUG=647395

Review-Url: https://codereview.chromium.org/2341173002
Cr-Commit-Position: refs/heads/master@{#419013}

Review-Url: https://codereview.chromium.org/2344813004
Cr-Commit-Position: refs/heads/master@{#419012}

Revert of Adding target to build SwiftShader (patchset #4 id:60001 of https://codereview.chromium.org/2330173002/ )

Reason for revert:
This seems to not build in our sysroot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/5244/steps/compile/logs/stdio

Original issue's description:
> Adding target to build SwiftShader
>
> Added the swiftshader target to BUILD.gn's deps in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium.
>
> BUG=630728
>
> Committed: https://crrev.com/72ce608cb69854a0029f019e67ddf1509c274f0a
> Cr-Commit-Position: refs/heads/master@{#418934}

TBR=sugoi@google.com,sugoi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630728

Review-Url: https://codereview.chromium.org/2349473003
Cr-Commit-Position: refs/heads/master@{#419011}

As part of this I realized SetLockedToRoot and
SetDescendantsStayInSameRootWindow meant the same thing, so I nuked
the later.

In order to test this I need multiple display support, which isn't
quite working yet (in particular shutdown is currently
problematic).

BUG=615552
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2344783002
Cr-Commit-Position: refs/heads/master@{#419010}

TBR=bruening@chromium.org
BUG=647420

Review-Url: https://codereview.chromium.org/2348453003
Cr-Commit-Position: refs/heads/master@{#419009}

BUG=509735

Review-Url: https://codereview.chromium.org/2310683003
Cr-Commit-Position: refs/heads/master@{#419008}

These new tests measure performance of dispatching incoming messages on the same
thread.

Currently on Linux:
RouterDispatchCost  3.93483e+06 times/second
MultiplexRouterDispatchCost 3.39754e+06 times/second

BUG=594244

Review-Url: https://codereview.chromium.org/2340363002
Cr-Commit-Position: refs/heads/master@{#419007}

Some functions (the ones that do I/O) use this crazy three-level error
system (rv, SSL_get_error, and the error queue). Others are more
straightforward and simply use the error queue.

Using SSL_get_error here could result in state from other operations
getting in the way of things.

Since these don't actually do I/O and really can only fail on internal
error, just map to ERR_FAILED rather than try to have so many
MapOpenSSLError variants.

Also treat SSL_export_key_material's return value as a boolean. In
BoringSSL, the calling convention is simpler and documented as such.

BUG=none

Review-Url: https://codereview.chromium.org/2342123002
Cr-Commit-Position: refs/heads/master@{#419006}

This implements a new mus IPC protocol to allow inter-process drag and
drop in mus. It handles the entire lifecycle of a drag between two mus
Windows, possibly in different processes. This patch does not implement
changing the mouse cursor or showing a drag representation, which is
queued work.

This patch is mus side only; it does not implement the views sided of
this protocol, which is next. (With it, you can drag text from the
chrome omnibox to the quick launcher and vice versa. You can drag text
from the quick launcher to the content area. Etc.)

BUG=614037

Review-Url: https://codereview.chromium.org/2266603002
Cr-Commit-Position: refs/heads/master@{#419005}

Add logic to open options pages that open in tabs (embedded options
pages still to come). Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2329443004
Cr-Commit-Position: refs/heads/master@{#419004}

https://pdfium.googlesource.com/pdfium.git/+log/8f53f54a9cca..0a17fafd723e

$ git log 8f53f54a9..0a17fafd7 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 tonikitoo Use either /RECT or /QuadPoints for annotation coordinates, depending on /AP
2016-09-15 npm Use ToUnicode mapping even when unicode is 0.
2016-09-15 npm Deleted unused defintions and methods from PWL_FontMap
2016-09-15 dsinclair Cleanup CFX_SystemHandler.
2016-09-15 dsinclair Use safe math when rendering line segments in AGG.
2016-09-15 dsinclair Replace FX_UINT with unsigned int

BUG=647026

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2342113002
Cr-Commit-Position: refs/heads/master@{#419003}

https://chromium.googlesource.com/skia.git/+log/615af784ab6e..7bffcd267301

$ git log 615af784a..7bffcd267 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 bsalomon Fix key computation for GrPaths
2016-09-15 mtklein GN: port Valgrind bots.
2016-09-15 bsalomon Add GrContextOptions flag to disable distance field path renderer.
2016-09-15 robertphillips Fix color bug in SkRRectsGaussianEdgeShader

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2348623002
Cr-Commit-Position: refs/heads/master@{#419002}

Previously it was possible for GVD to be processing a Flush() but not
have no outstanding bitstream buffers in the VDA when it received a
NotifyError(). For example, when decoding single frame videos. In that
case it went into the error state but never propagated the error. Now,
if an error is received while in the flushing state, the error is
propagated by calling the decode cb corresponding to the EOS buffer.

BUG=647081
TEST=manually verified that AVDA decode errors now propagate to WMPI

Review-Url: https://codereview.chromium.org/2344703003
Cr-Commit-Position: refs/heads/master@{#419001}

Fixing the flaky unittest by correcting the wrong measurement units.
This CL also enables the test for mac bots.

BUG=645538, 646758

Review-Url: https://codereview.chromium.org/2344673002
Cr-Commit-Position: refs/heads/master@{#419000}

BUG=571155

Review-Url: https://codereview.chromium.org/2340423002
Cr-Commit-Position: refs/heads/master@{#418999}

The lack of gpu context recovery was causing some layout tests
to be flaky. After running the test
virtual/gpu/fast/canvas/canvas-lost-gpu-context.html all subsequent
gpu tests run in the same instance of content_shell would fail.

BUG=646973

Review-Url: https://codereview.chromium.org/2335223004
Cr-Commit-Position: refs/heads/master@{#418998}

The behavior of MediaStreamAudioTrack::Configure() has changed:

Configure() used to be able to complete before any audio sample
is received because the AudioParameter can be obtained from a
WebRtcLocalAudioTrack according to
https://codereview.chromium.org/857093002

After the media stream refactoring http://crbug.com/577874
Configure() remains pending until the first audio frame is
received. For always-on hotword detection with a DSP audio
source, no audio sample is sent until the DSP detects a
potential hotword trigger.

This patch removes MS_CONFIGURED timeout so that the plugin
can keep waiting for a hotword instead of reporting a timeout
error.

BUG=616203
TEST=Verified always-on hotwording on Samus and Chell
Signed-off-by: Ben Zhang <benzh@chromium.org>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2306803003
Cr-Commit-Position: refs/heads/master@{#418997}

This test doesn't run fast enough to always finish within the hard-coded 45 second time limit.

R=kbr@chromium.org
TBR=piman@chromium.org

BUG=646442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2346883002
Cr-Commit-Position: refs/heads/master@{#418996}

https://chromium.googlesource.com/angle/angle.git/+log/09cfac6..415f29e

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2347683002
Cr-Commit-Position: refs/heads/master@{#418995}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/194bd0247efb60371dbcae87731f13dce4fa7934 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/adcd4b78d5f35da535ccf82a221afb9fa389f631 presubmit_support: Remove a noisy logging.debug() (thakis@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=none

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2346883004
Cr-Commit-Position: refs/heads/master@{#418994}

BUG=571155

Review-Url: https://codereview.chromium.org/2348603002
Cr-Commit-Position: refs/heads/master@{#418993}

Revert of Enable whitelisting for targets other than libchrome. (patchset #8 id:40002 of https://codereview.chromium.org/2336033002/ )

Reason for revert:
Broke ninja on Linux x64:

ninja: Entering directory `out/Release'
[1/1] Regenerating ninja files
FAILED: build.ninja
/mnt/ssd/miu/chromium/src/buildtools/linux64/gn --root=/mnt/ssd/miu/chromium/src -q gen //out/Release/
ERROR at //chrome/BUILD.gn:1358:5: Undefined identifier.
    public_deps += [ ":default_apps" ]
    ^----------
See //BUILD.gn:211:7: which caused the file to be included.
      "//chrome",
      ^---------
ninja: error: rebuilding 'build.ninja': subcommand failed

Original issue's description:
> Refactor chrome resource targets into chrome_paks.gni
>
> This will allow monochrome to easily define its own set of the same
> targets with a different resource whitelist
>
> BUG=641032
>
> Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e
> Cr-Commit-Position: refs/heads/master@{#418966}

TBR=brettw@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641032

Review-Url: https://codereview.chromium.org/2348643002
Cr-Commit-Position: refs/heads/master@{#418992}

BUG=646037

Review-Url: https://codereview.chromium.org/2343973002
Cr-Commit-Position: refs/heads/master@{#418991}

Opening a link in a new tab/window was broken with PlzNavigate.

This CL solves the majority of broken tests. There is still 3
browser_tests that doesn't work properly yet, but it seems to me this
is unrelated to click modifiers (ctrl/shift/meta+click).

Timeout:
    ReferrerPolicyTest.HttpLeftClickRedirectToHTTPOriginWhenCrossOrigin

Flaky fail:
    ClickModifierTest.WindowOpenControlShiftClickTest
    ClickModifierTest.WindowOpenBasicClickTest

BUG=644116

R=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2323153003
Cr-Commit-Position: refs/heads/master@{#418990}

We need to configure code to use built-in data from system library,
not a separate file shipped with Chrome.

BUG=551343
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/2339173005 .

Cr-Commit-Position: refs/heads/master@{#418989}

This implements:

- allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Review-Url: https://codereview.chromium.org/2259903002
Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}

BUG=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/2343883002 .

Cr-Commit-Position: refs/heads/master@{#418987}

chrome.exe appears to have grown by 150% when skia rolled in r411308.
chrome.exe shouldn't need skia or gfx, so let's try not depending on
them!

BUG=647223
R=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2345503006
Cr-Commit-Position: refs/heads/master@{#418986}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8091fad9d075ecec116e1740360ff955a7654c4a Remove use_isolate from Marshmallow 64 bit Tester (bpastene@chromium.org)
  https://crrev.com/2f0a7c064259dc0e0bf375c2d1771544f5647a1c Changed sequence of package_build step to be before package_build_for_bisect (miimnk@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=645662

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2342153002
Cr-Commit-Position: refs/heads/master@{#418985}

This method is not used outside of SequencedWorkerPool itself. Making it private
will prevent external users from using it directly, which will help the deprecation
of SequencedWorkerPool.

SequencedWorkerPool::IsRunningSequenceOnCurrentThread() is still used
by the RunsTasksOnCurrentThread() method of SequencedTaskRunners
returned by a SequencedWokrerPool.

BUG=622400

Review-Url: https://codereview.chromium.org/2341063002
Cr-Commit-Position: refs/heads/master@{#418984}

BUG=384330

Review-Url: https://codereview.chromium.org/2343923002
Cr-Commit-Position: refs/heads/master@{#418983}

Bring the code to C++11 standard and streamline the execution path inside the function.

BUG=646904

Review-Url: https://codereview.chromium.org/2340003002
Cr-Commit-Position: refs/heads/master@{#418982}

It merely needs a TaskRunner to PostTask() to.

This allows the unittest to merely use a base::Thread and alleviates
issue 646443.

Also did some modern style cleanup:
 - ThreadChecker => SequenceChecker (no state is thread-affine)
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (avoids a refcount bump when handing off ownership:
    https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/discussion)

BUG=646443
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2335193007
Cr-Commit-Position: refs/heads/master@{#418981}

BUG=620813

Review-Url: https://codereview.chromium.org/2339873003
Cr-Commit-Position: refs/heads/master@{#418980}

It seems that feature-related singleton classes can be potentially
accessed during shutdown, which will crash. Make these classes
leaky, which is now the preference anyway.

BUG=646275

Review-Url: https://codereview.chromium.org/2338273005
Cr-Commit-Position: refs/heads/master@{#418979}

https://chromium.googlesource.com/chromium/src/+/7c023bffa

BUG=641261
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/2342143002 .

Cr-Commit-Position: refs/heads/master@{#418978}

This change populates the feedback dialog with some initial info, including profile email and current URL, by adding a new WebUI Message Handler for C++ <-> JS messaging. The handler will be build out to support more messaging in the future, e.g. system info, screenshots, and feedback submission.

BUG=632112

Review-Url: https://codereview.chromium.org/2190653003
Cr-Commit-Position: refs/heads/master@{#418977}

This simplifies the code a little bit + avoids consuming memory for what
is ultimately an unused value.

BUG=647392
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2329523003
Cr-Commit-Position: refs/heads/master@{#418976}

https://chromium.googlesource.com/webm/libvpx.git/+log/e66cd132f09e..4282d29355df

$ git log e66cd132f..4282d2935 --date=short --no-merges --format='%ad %ae %s'
2016-09-13 johannkoenig vp8 decoder: cast decoding_thread_count to int
2016-09-13 johannkoenig vp9 frame parallel test: Initialize cfg to 0
2016-09-13 johannkoenig vp9cx_set_ref.c: remove unused 'cfg' parameter
2016-09-13 johannkoenig webmenc: remove unused 'fps' parameter
2016-09-09 jzern cosmetics,vp8: join some lines, fix table format
2016-09-09 marpan vp8: Set the skin model to mode 1.
2016-09-06 glider vp8: Remove TSAN warning around end of encode.
2016-09-07 jzern vpx_mem.c: remove unnecessary inline
2016-09-07 slavarnway vpx_dsp: added vpx_highbd_idct32x32_1_add_sse2()
2016-09-03 sarahparker Fix missing write to opsnr in internal stats
2016-09-01 jzern invalid_file_test: quiet -Wunused-const-variable warnings
2016-09-01 jzern vp8_cx_iface: quiet -Wshorten-64-to-32 warning
2016-09-01 jzern get_cpu_count: quiet -Wshorten-64-to-32 warnings
2016-09-01 paulwilkins Casts to remove some warnings.
2016-08-31 johannkoenig Enable -Wundef by default
2016-08-31 johannkoenig Define VP8_TEMPORAL_ALT_REF to !CONFIG_REALTIME_ONLY
2016-08-26 johannkoenig Remove CONFIG_DEBUG guards from assert()
2016-08-26 johannkoenig Remove unused function vpx_de_mblock
2016-08-26 johannkoenig Fix -Wundef warning for OUTPUT_FPF
2016-08-26 johannkoenig Fix -Wundef warning for __SANITIZE_ADDRESS__
(...)

R=johannkoenig@google.com

Review-Url: https://codereview.chromium.org/2346903003
Cr-Commit-Position: refs/heads/master@{#418975}

BUG=None

Review-Url: https://codereview.chromium.org/2233963002
Cr-Commit-Position: refs/heads/master@{#418974}