GitLab

This will also be enabled on Aura when Aura and Android touch selection flows
finally unified. I also plan to have at least one more experimental strategy
implmenented.

Prerequisite CL: https://codereview.chromium.org/988023005/

BUG=451255

Review URL: https://codereview.chromium.org/1096773002

Cr-Commit-Position: refs/heads/master@{#326896}

refresh token.

This change is necessary because, if the host daemon attempts to
retrieve an email address for an auth code from GCD, the request
fails, causing the host daemon to report failure and not return a
refresh token.

BUG=471928

Review URL: https://codereview.chromium.org/1076093003

Cr-Commit-Position: refs/heads/master@{#326895}

The parent_offset currently stored at each transform tree node sometimes
depends on the transform between some other node (which happens to
correspond to node's owning layer's parent's transform node) and the node's
parent. When this transform changes and the transform tree isn't rebuilt,
the parent_offset becomes stale. This CL replaces parent_offset with
source_offset, which is the portion of parent_offset that doesn't depend on
a transform between tree nodes, and adds a source_node_id to each node
so that the transform between nodes (when needed) can be recomputed
when the transform tree is updated.

BUG=480589

Review URL: https://codereview.chromium.org/1106013002

Cr-Commit-Position: refs/heads/master@{#326894}

Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #4 id:80001 of https://codereview.chromium.org/1092153005/)

The last version was broken for x86_64 DEBUG build.
On x86_64, it is necessary to set sa_restorer appropriately,
if not specified. What we need in the function is just invoking
the rt_sigreturn system call. However, it is special system call
which touches user land stack, so that a function prologue will
break the program.
In RELEASE build, that prologue is gone (including syscall() invocation)
by optimization. However, in DEBUG build, there is the prologue.
Unfortunately, all CQ and trybot do not run DEBUG tests so that it
was not catched.

Also, it turned out that MSAN does not work with direct sigaction syscall, unfortunately. (In more precise, it does not work if we *mix* direct sigaction syscall and sigaction() in libc).

This version fixes them.

TEST=Ran sandbox_linux_tests with DEBUG build locally. Ran msan tests, too. Ran trybots including 64 debug bot and msan ones.
BUG=358465
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm,linux_chromium_trusty_dbg,linux_chromium_dbg_ng,linux_chromium_msan_rel_ng

Review URL: https://codereview.chromium.org/1099263003

Cr-Commit-Position: refs/heads/master@{#326893}

If the underlying call to 'gn gen' (or gyp_chromium) failed,
mb was swallowing the error.

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1078913003

Cr-Commit-Position: refs/heads/master@{#326892}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9d9725c..d96fd0c

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1102833005

Cr-Commit-Position: refs/heads/master@{#326891}

This cherry-picks two mojo changes past e7270700, namely:

mojo.gni fix: https://chromium.googlesource.com/external/mojo/+/c88997f930c71b7e6748948263c4c01d7e10bc75
generated C++ interface definition fix: https://chromium.googlesource.com/external/mojo/+/6f41dc4d98fc17a447cd48837cc8ff7edf8df465

Finally this CL also adds a default TaskTracker to the
chromium mojo environment.

BUG=
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1101303002

Cr-Commit-Position: refs/heads/master@{#326890}

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1101323003

Cr-Commit-Position: refs/heads/master@{#326889}

The out-of-bounds access leads to a test failure under DrMemory.

BUG=480650
TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/1109533003

Cr-Commit-Position: refs/heads/master@{#326888}

BUG=none
TEST=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1107613003

Cr-Commit-Position: refs/heads/master@{#326887}

SslHmacChannelAuthenticator passes in a null one which crashes but the
IsAllowedBadCert check, as well as inconsistent ability to use X509Certificate
in the sandbox masks the issue most of the time.

This also fixes FakeStreamSocket to propogate disconnects to the peer, which is
needed to add a test for this case. (If SSLClientSocket doesn't like a
certificate, it just ceremoniously disconnects the connection right after the
handshake.) This test crashed before this CL outside the sandbox. (Inside the
sandbox, it's possible that it worked on some platforms due to the sandbox
breaking net::X509Certificate. I didn't do a survey.)

BUG=none

Review URL: https://codereview.chromium.org/1080593003

Cr-Commit-Position: refs/heads/master@{#326886}

Time and date appear as a series of spin buttons with their help attributes containing their label text. Include $help in the default output rule.
Add a condition to substitute a proper role message string for role textField.

TEST=OutputE2ETest.*

Review URL: https://codereview.chromium.org/1106583003

Cr-Commit-Position: refs/heads/master@{#326885}

This makes the SingleThreadProxy match the behaviour of ThreadProxy and
ensures that when the embedder is doing Layout() if it changes things
that would cause a commit, those things will already happen in the
upcoming commit so it does not schedule a second commit afterward.

R=enne,vmpstr
BUG=466426

Review URL: https://codereview.chromium.org/1061993009

Cr-Commit-Position: refs/heads/master@{#326884}

BUG=461052

Review URL: https://codereview.chromium.org/1108683002

Cr-Commit-Position: refs/heads/master@{#326883}

This should fix the following error on an ASan Linux builder:

../../dbus/values_util_unittest.cc:360:15: error: use of undeclared identifier 'sqrt'
    keys[i] = sqrt(values[i]);
              ^

BUG=none
R=thakis@chromium.org
TBR=satorux

Review URL: https://codereview.chromium.org/1083323005

Cr-Commit-Position: refs/heads/master@{#326882}

CBR is required for cyclic refresh.

BUG=134202

Review URL: https://codereview.chromium.org/1079593004

Cr-Commit-Position: refs/heads/master@{#326881}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1091093006

Cr-Commit-Position: refs/heads/master@{#326880}

TCPListenSocket will be removed, use TCPServerSocket instead.

BUG=472766

Review URL: https://codereview.chromium.org/1053343002

Cr-Commit-Position: refs/heads/master@{#326879}

Revert of Encrypt certificate reports before uploading to HTTP URLs (patchset #20 id:400001 of https://codereview.chromium.org/1083493003/)

Reason for revert:
This CL broke the Win8 GN bot:

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6514

Original issue's description:
> Encrypt certificate reports before uploading to HTTP URLs
>
> This CL introduces a new protobuf to store encrypted
> CertLoggerRequests. Serialized certificate reports are encrypted with an
> AES-CTR-128-HMAC-SHA256 AEAD (from BoringSSL, thus encrypted reports are
> only supported on BoringSSL platforms) before being uploaded to HTTP
> endpoints. |CertificateErrorReporter::IsHttpUploadUrlSupported| allows
> users of the class to set an HTTP URL if supported.
>
> BUG=461590
>
> Committed: https://crrev.com/0a3351c2a7c81284f82e6531380a21d079f55056
> Cr-Commit-Position: refs/heads/master@{#326876}

TBR=agl@chromium.org,felt@chromium.org,mattm@chromium.org,estark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=461590

Review URL: https://codereview.chromium.org/1073913004

Cr-Commit-Position: refs/heads/master@{#326878}

screen rotations on inactive displays.

TEST=ScreenOrientationControllerTest, RotateInactiveDisplay

BUG=479503

Review URL: https://codereview.chromium.org/1108473002

Cr-Commit-Position: refs/heads/master@{#326877}

This CL introduces a new protobuf to store encrypted
CertLoggerRequests. Serialized certificate reports are encrypted with an
AES-CTR-128-HMAC-SHA256 AEAD (from BoringSSL, thus encrypted reports are
only supported on BoringSSL platforms) before being uploaded to HTTP
endpoints. |CertificateErrorReporter::IsHttpUploadUrlSupported| allows
users of the class to set an HTTP URL if supported.

BUG=461590

Review URL: https://codereview.chromium.org/1083493003

Cr-Commit-Position: refs/heads/master@{#326876}

This just happened to work before due to prior includes.

BUG=472862

Review URL: https://codereview.chromium.org/1054963009

Cr-Commit-Position: refs/heads/master@{#326875}

Review URL: https://codereview.chromium.org/1052993012

Cr-Commit-Position: refs/heads/master@{#326874}

It's being moved to a different repo, see https://codereview.chromium.org/1100783002

BUG=433338

Review URL: https://codereview.chromium.org/1105963002

Cr-Commit-Position: refs/heads/master@{#326873}

Interestingly, it is very similar to
https://codereview.chromium.org/277943002 !

BUG=440843, 362521

Review URL: https://codereview.chromium.org/1093223006

Cr-Commit-Position: refs/heads/master@{#326872}

Haven't been able to repro this locally, but it's apparently possible for a
calculation to return a negative value for an animation duration, resulting in
a crash.

BUG=481031

Review URL: https://codereview.chromium.org/1108653002

Cr-Commit-Position: refs/heads/master@{#326871}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1100223002

Cr-Commit-Position: refs/heads/master@{#326870}

for all alert dialogs.

BUG=463576

Review URL: https://codereview.chromium.org/1096263005

Cr-Commit-Position: refs/heads/master@{#326869}

This fixes a test failure on clang bots.

BUG=480546
R=anthonyvd@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1108643002

Cr-Commit-Position: refs/heads/master@{#326868}

These browser tests should end the need for constant manual testing.
These have been a long time coming.

BUG=475688

Review URL: https://codereview.chromium.org/1088763002

Cr-Commit-Position: refs/heads/master@{#326867}

It should fix the following error:
FAILED: cd ../../gpu; python ../tools/isolate_driver.py check --isolated
"../out/Release/gpu_unittests.isolated" --isolate
"gpu_unittests.isolate" --path-variable DEPTH .. --path-variable
PRODUCT_DIR "../out/Release " --extra-variable
"version_full=44.0.2383.0" --config-variable
"CONFIGURATION_NAME=Release" --config-variable "OS=linux"
--config-variable "asan=0" --config-variable "branding=Chromium"
--config-variable "chromeos=0" --config-variable
"component=static_library" --config-variable "disable_nacl=0"
--config-variable "enable_pepper_cdms=1" --config-variable
"enable_plugins=1" --config-variable "fastbuild=1" --config-variable
"icu_use_data_file_flag=1" --config-variable
"internal_gles2_conform_tests=0" --config-variable
"libpeer_target_type=static_library" --config-variable "lsan=0"
--config-variable "msan=0" --config-variable "target_arch=x64"
--config-variable "tsan=0" --config-variable "use_custom_libcxx=0"
--config-variable "use_instrumented_libraries=0" --config-variable
"use_prebuilt_instrumented_libraries=0" --config-variable
"use_openssl=0" --config-variable "use_ozone=0" --config-variable
"use_x11=1" --config-variable "v8_use_external_startup_data=1"
Failed to find an input file: Input file
/b/build/slave/linux_clobber/build/src/out/Release/xdisplaycheck doesn't
exist

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/19419/steps/compile%20%28with%20patch%29/logs/stdio

BUG=481110
TEST=trybots
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/1095203007

Cr-Commit-Position: refs/heads/master@{#326866}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/aa31ee7..9d9725c

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/1060583010

Cr-Commit-Position: refs/heads/master@{#326865}

See https://docs.google.com/document/d/1AZmbifXOirRdIcAkhgXT_u1wam5FRxy-Wt7I-kv3CCg/edit?usp=sharing for details.

BUG=479306

Review URL: https://codereview.chromium.org/1099313003

Cr-Commit-Position: refs/heads/master@{#326864}

Review URL: https://codereview.chromium.org/1099713005

Cr-Commit-Position: refs/heads/master@{#326863}

The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override.

This patch was manually generated using a regex and a text editor.

BUG=417463

Review URL: https://codereview.chromium.org/1102573006

Cr-Commit-Position: refs/heads/master@{#326862}

Adds a gyp and gn build target: base_junit_tests
Adds test suite: base_junit_tests

Depends on https://codereview.chromium.org/1048153002/
BUG=448030,472152

Review URL: https://codereview.chromium.org/1051343002

Cr-Commit-Position: refs/heads/master@{#326861}

Review URL: https://codereview.chromium.org/1100803004

Cr-Commit-Position: refs/heads/master@{#326860}

To fix PresentationServiceImplTest.DefaultSessionStartReset timeout
in  Android Tests (dbg).

TEST=git cl try + linux_android_dbg_ng
----

Added DefaultSessionStartContext for coordinating sending default
session back to PresentationDispatcher.

When ListenForDefaultSessionStart is called, DefaultSessionStartContext
will be installed on PresentationServiceImpl. When both the default
session and PresentationDispatcher's callback are available, the
callback will be invoked with the session.

On Reset(), if a callback is available, it will be invoked with null.
Changed PresentationDispatcher to not update Blink in that case.

Also, PSImpl now keeps track of the corresponding RFH's ID instead of
RFH* since most of the time we only need to use the ID.

Changed PresentationServiceDelegate's Add/RemoveObserver interface,
since the PresentationServiceDelegate need to be able to correlate
an Observer with a RFH. (at most 1 per RFH, as it stands today).

Added OnDefaultPresentationStarted to
PresentationServiceDelegate::Observer interface and implemented it
in PresentationServiceImpl.

Added tests in PresentationServiceImpl.

BUG=459001

Review URL: https://codereview.chromium.org/1055053004

Cr-Commit-Position: refs/heads/master@{#326859}

WebRTC 9068:9084
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/51fb6e4..324d972

Libjingle 9069:9081
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/c37efc9..d8bca77

TBR=
BUG=

Review URL: https://codereview.chromium.org/1051353006

Cr-Commit-Position: refs/heads/master@{#326858}

BUG=478428
TEST=Hover mouse over Back and Close buttons in new GAIA login (for Add person,
Create new account, etc).  Cursor should change to pointer hand.

Review URL: https://codereview.chromium.org/1097053008

Cr-Commit-Position: refs/heads/master@{#326857}