- 29 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/12c9d4ac61f2..4e39779a5662 2020-07-28 amaiorano@google.com Add CMake script to setup and build ANGLE 2020-07-28 amaiorano@google.com Add ANGLE as submodule If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id9dfd94a53362ef99a22d3f3dab756055e697eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792535}
-
Brian Sheedy authored
Disables the Telemetry minidump symbolization tests on Mac, as they are currently failing on some 10.15.5 machines due to Xcode not being set up properly for Telemetry tests, and newly reinstalled machines do not have a system-wide installation anymore. TBR=johnchen@chromium.org Bug: 1110441 Change-Id: I2e9f3d33a1086db24c07f167f5ab376a2a564146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324606Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792534}
-
Yuchen Liu authored
Add "app", "multizone", which are needed when talking to chromecast service. Bug: internal b/161738703 Test: Run cast_shell without crash Change-Id: I47082f4b48ed167d29db1c8ce5f63027fd8eeea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324761Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792533}
-
Sebastien Marchand authored
This memory pressure handler has been observed to be quite slow some times, this will let us diagnose how much of a problem this is in practice. Bug: 1109982 Change-Id: Id967ec8a79abd25c2a294002f852583bc49714ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320411 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792532}
-
Will Harris authored
This avoids the delay load helper being run inside the closure callback which can cause CFG violations. BUG=1110484 Change-Id: Iff7fd304f99662b0204ac4d2e1b1fc4b896cc990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324570 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#792531}
-
Kenichi Ishibashi authored
This CL: * Pack extension in PRE_EventsAfterRestart to prevent reloading an extension quickly, similar to crrev.com/c/2318508 * Disable TabsQuery* and TabsOnUpdated* tests as these become flaky when mojofied service worker storage is used These are preparations for using mojo version of service worker storage's GetNewRegistrationId(). Bug: 1091141 Change-Id: I1239627087ec321af794a75788d43270f7c31fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321988Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792530}
-
James Cook authored
The Chrome OS default for "On Startup" is "Continue where I left off". Use the same default for Lacros. In theory we would get this for free when Lacros starts using the OS_CHROMEOS macro. However, I think the macro conversion process is going to start with a bulk conversion of UI-layer Chrome OS code to IS_ASH, so I suspect we'll need the IS_LACROS check anyway. Bug: 1109050 Test: with a new profile, "Continue where I left off" is the default Change-Id: I5015ea9bfcaaa4108a147c0cb3c0347fe0acdabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316804Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#792529}
-
Rakina Zata Amni authored
This reverts commit f672068e. Reason for revert: Caused failing test https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/40039 Original change's description: > [LiteVideo] Rework UKM to record on DidFinish and WCO destruction. > > This change resolves the UKM recording and ties it just to the > mainframe decision and result. It also flushes when the web contents > observer destructs. A future change will update the event on > rebuffers and consider more events for subframes. > > Bug: 1109068 > Change-Id: Iacd04920811d96c4eedd3290309a8bad93777b58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321520 > Auto-Submit: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: rajendrant <rajendrant@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792513} TBR=tbansal@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org Change-Id: Ic8ccef2431cb402a285edd00b29cf78d44b03ab9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1109068, 1110739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325295Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#792528}
-
Nicholas Verne authored
Hide the illustration when there's a progress bar. This is to stop the visual noise when the illustration moves downwards. Bug: 1103505 Change-Id: I9d144abe21207ff3ab0fec0f7258d15eea317db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321887 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#792527}
-
Sara Kato authored
Test: AccessibilityNodeInfoDataWrapperTest, AXTreeSourceArcTest passes Bug: b/162279773 Change-Id: Ib89e771a0da05ec5ee629b13a810e423ef052a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322287Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#792526}
-
Hirokazu Honda authored
media/gpu/video_decode_accelerator_tests: Use a parser to check if a bitstream has a stream configuration EncodedDataHelper::HasConfigInfo() checks if a vp8 and vp9 stream has a stream configuration by checking the first bit of the stream. This is correct for vp8, but wrong for vp9. Thus it always returns true in vp9 stream. This bug is not critical because video_decode_accelerator_tests checks if there is a stream configuration, but doesn't check the count. This CL fixes the bug by using parsers for vp8 and vp9 both as well as for h264. Bug: None Test: video_decode_accelerator_tests on atlas Change-Id: Id1b784e087a102ece40b704d876f0796c0edbc53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319519 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#792525}
-
Joe DeBlasio authored
This CL makes a tiny tweak to safety tips to ensure that the reputation callback aborts on error pages, even when reputation is checked on visibility change. It also fixes a race condition in the tests that somehow hadn't made the existing tests flaky, but came up in the new test. Fixed: 1019228 Change-Id: Ic31c66cf2db6db2ca59c12a0a33f7173fded438a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324866 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#792524}
-
David Black authored
Bug: 1109819, 1109820, 1109842, 1109843, 1109844 Bug: 1109845, 1109846, 1109847, 1109848, 1109849 Bug: 1109850 Change-Id: Ie117ac625c9e8573145823f30d39337bef568dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320988Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
This reverts commit e22976af. Reason for revert: Causes test failure at https://ci.chromium.org/p/chromium/builders/ci/linux-blink-cors-rel/7409 Original change's description: > [Nearby] Add NearbyShareSettings mojo for use in settings and webui > > |NearbyShareSettings| provides a strongly typed wrapper over the raw > user prefs and allows clients to observe individual changes. This class > also implements a mojo interface to allow multiple WebUIs to access > settings (OSSettingsUI, NearbyShareDialog, and eventually SettingsUI). > > This CL achieves sharing of mojos and the components that depend on them > outside of chrome://resources by having the shared resources hosted in > chrome://nearby and re-registering them in chrome://os-settings. This > gets around having to include explicit references to the mojo generated > resources in //content which required a DEPS exception that was not > acceptable to //content/OWNERS. > > Many other options were considered to solve this shared resource > problem. Please see the dicussion thread for more context: > http://g/chrome-webui/Q8WGiGO7h-E > > Change-Id: I831044176ed71b15fb7df0be8f1c393e574254f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317166 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Josh Nohle <nohle@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792503} TBR=sky@chromium.org,khorimoto@chromium.org,nohle@chromium.org,knollr@chromium.org,ajgo@chromium.org,vecore@google.com Change-Id: I6168c5dbc8419370bac8c87fb7caa43068ad90c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325433Reviewed-by:
-
David Roger authored
This CL: - plumbs the account info from C++ to javascript - updates the javascript to show the avatar and name - implements the WebUI handler and listen to account changes Screenshot: https://drive.google.com/file/d/1um4ddQvSLoDidpdOWKjk5gHDmfWG5vSy/view?usp=sharing Screenshot in dark mode: https://drive.google.com/file/d/1GstEo8oYBI7wLuTdxprIwJGlH4yiYWyR/view?usp=sharing (Note that the account name does not have enough contrast, this will be fixed later) Bug: 1076880 Change-Id: I81f2b90723fafa25b33b4e326e6b2a17fc28dbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315136 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#792521}
-
Dale Curtis authored
Per discussion when we tried to enable these for VAAPI: https://chromium-review.googlesource.com/c/chromium/src/+/2303676 Many of these workarounds are specific to early VP9 decoder hardware, not VP8. Since we are enabling VP8 decode now, we should be precise about what needs to be disabled. R=tmathmeyer, zmo Bug: 1066176, 654111, 616318, 1062849 Test: None. Change-Id: I7615a279e451cb7acef62c74cb0fc2e21ba898d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325091 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#792520}
-
Eugene But authored
Logs are 100% true. Replaced metric with call to check, so next time if this crash we know that ChromeBrowserProvider is not a culprit. Bug: 1097827 Change-Id: Ib0107fe9a8495c71843cb9d8055a19c0b341e598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320808Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#792519}
-
Travis Skare authored
Bug: 1109649 Change-Id: I319cebee36eee81087bf8b19f2f04bc0bac8190a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321766 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#792518}
-
Jing Wang authored
The cases are given by laurentt@ in https://docs.google.com/spreadsheets/d/1zcRwSCQUbiA4Czp9JBY_QpFl-f1Mtulm9hL6GOY-c7Q/edit#gid=1364923800 No longer emit kPersonalNumber metrics, merged it into kPersonalPhoneNumber metrics. Refactor ProposeAssistiveAction a bit by using early return. Randomly add some new cases in tests. Bug: 1109073 Change-Id: I6ed3de18eafcf9fae30eade609187ff6c47faa31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318491 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#792517}
-
Rachel Carpenter authored
We just wanted to experiment with a group of users in M85, all new users from M86 onwards should get the default behaviour. We do still want the users that are already part of an experiment group to continue to see the changed behaviour for a couple of milestones to check longer term usage. Will clean up/remove the trial after that. Bug: b/161170571,b/158540665 Change-Id: I85ea81c42b7b9d7439c6128a1e4f5830546d88d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324090 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#792516}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I4592e1b2a5bf1ebb69a176049a7cfd1126138c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325239Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792515}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I6d51dab7e6c30fbc1a9fca20255ad3b1d92b89d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324896Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#792514}
-
Michael Crouse authored
This change resolves the UKM recording and ties it just to the mainframe decision and result. It also flushes when the web contents observer destructs. A future change will update the event on rebuffers and consider more events for subframes. Bug: 1109068 Change-Id: Iacd04920811d96c4eedd3290309a8bad93777b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321520 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#792513}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I07d2b87c0e6449ae11cc32a71159639cac6c22c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324991 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#792512}
-
Yoshifumi Inoue authored
This patch changes "tools/win/DebugVisualizers/webkit.natvis" to handle new |StringImpl| implementation[1]. I confirmed this change for both 8-Bit string and 16-Bit string, e.g. 8-Bit for |Element::tag_name| via (AtomicString), 16-Bit |NGInlineNodeData::text_content_|. Note: We use type cast operator to read |std::atomic_uint32_t|, because DebugVisualizers can't read value from struct field for it. [1] http://crrev.com/c/2301589 Make StringImpl flags atomic and threadsafe Bug: 1083392 Change-Id: I559ff4619695c1a4b1f5d330c36df2e85149c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309528 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792511}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: Id45c7f9695045347d9675656c83f0aadeb4013a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324177Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792510}
-
Rakina Zata Amni authored
This reverts commit e1e445e8. Reason for revert: Possibly causing compile failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/50257 Original change's description: > Split MainPageBehavior between browser and OS settings. > > This is a prerequisite to implement lazy loading for Polymer 3. > > Bug: 1045266 > Change-Id: I92c428cd2c18d6f4096ee5fbdd26ae77efb831ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321954 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Jon Mann <jonmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792491} TBR=khorimoto@chromium.org,dpapad@chromium.org,jonmann@chromium.org Change-Id: I0416e8fcda1d9c03eaccc1dfad3082c88568928b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045266, 1110567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325470Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/32344f5f..3daffb45 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b3df57be73532422e0c03c6dca4af7fa8f614ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324821Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792508}
-
Jason Lin authored
login_screen_extension_ui::WebDialogView::ShouldShowCloseButton() calls WebDialogDelegate::CanCloseDialog(), which is being removed in cl 2278793. This CL removes the ShouldShowCloseButton() override and makes necessary changes to the login_screen_extension_ui::DialogDelegate so that the default ShouldShowCloseButton() will work as expected. Bug: 970196 Change-Id: I6cfeb25f3fb264cbe325d83acaafe9a69e7e366d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319491Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#792507}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595959156-afb0fd7058e155b7eeff3c31fa05c2b8de5863d0.profdata to chrome-mac-master-1595979134-9957467c65788ac9845fa5dfc5d2872d1247a426.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8bbdcf03435e31c29ae5b0c225751b6cbc470202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325199Reviewed-by:
-
Melissa Zhang authored
Bug: 1097623 Change-Id: I2fa34006e75971dfabfa23f77c45dc07f86454ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315730Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Adenilson Cavalcanti authored
This will fix the build for gcc@aarch64, enabling building V8 with gcc for aarch64. Bug: 1066302 Change-Id: I4818d6384553a877f6c1c240b7f0c66c8db69b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315440Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#792504}
-
James Vecore authored
|NearbyShareSettings| provides a strongly typed wrapper over the raw user prefs and allows clients to observe individual changes. This class also implements a mojo interface to allow multiple WebUIs to access settings (OSSettingsUI, NearbyShareDialog, and eventually SettingsUI). This CL achieves sharing of mojos and the components that depend on them outside of chrome://resources by having the shared resources hosted in chrome://nearby and re-registering them in chrome://os-settings. This gets around having to include explicit references to the mojo generated resources in //content which required a DEPS exception that was not acceptable to //content/OWNERS. Many other options were considered to solve this shared resource problem. Please see the dicussion thread for more context: http://g/chrome-webui/Q8WGiGO7h-E Change-Id: I831044176ed71b15fb7df0be8f1c393e574254f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317166 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#792503}
-
Darwin Huang authored
Explain that chromeos_is_browser_only is set on ChromeOS when using Wayland. Change-Id: I7649ef51b8c7759f4dfed0021bf32bcc2c8f6886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324663Reviewed-by:
-
Nicholas Verne authored
Bug: 1103505 Change-Id: I162fa82ecd13a43117ce6be1e098591bb3518674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320710 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
-
Hesen Zhang authored
- TileService not support incognito profile. Bug: 1110285 Change-Id: Ief1c8025b74ec5df94c5e811d213a6679fd6069c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324938Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792500}
-
Jongmok Kim authored
Bug: 1100034 Change-Id: Id91fef164ce560cdecc777c35c100dd42d16685a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322288Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jongmok Kim <jongmok.kim@navercorp.com> Cr-Commit-Position: refs/heads/master@{#792499}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/engagement. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=calamity@chromium.org Bug: 1106699 Change-Id: Ia256324372fffe91b7dd7bda603faea66fbbb666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316361 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#792498}
-
Harkiran Bolaria authored
Bug: 1110344 Change-Id: I93448f79508b3de35b1067ea3a6080b42ed0a860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316886Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Cr-Commit-Position: refs/heads/master@{#792497}
-
Omid Tourzan authored
Testing Speedometer formula and internals and new behaviors in progress panel. The setUpPage method of files_xf_elements_unittest.js changed to setUp as it is not called per test case and causes conflict between tests. Bug: 953308 Change-Id: I24c88e63cdcec99f73a5233e18d2d91dbac8d2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317128 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792496}
-
