- 22 Dec, 2018 2 commits
-
-
Sunny Sachanandani authored
Clear the DWM frame area on WM_ERASEBKGND so that Chrome's client area blends with DWM frame for app windows. Refactor the code to update and clear DWM frame and move it to hwnd message handler so that browser and app windows can share the same code. This mimics existing logic for updating the DWM frame and adds the clear DWM frame behavior to app windows, but one notable change is that it will clear on every WM_ERASEBKGND message, and not just the first one. This shouldn't have a performance impact and seems more correct anyway. Bug: 904322 Change-Id: I70c3ae97a94114dd63110736a35cef4dd887b1aa Reviewed-on: https://chromium-review.googlesource.com/c/1382928Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#618684}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f396a42a943f..442e7b273107 git log f396a42a943f..442e7b273107 --date=short --no-merges --format='%ad %ae %s' 2018-12-21 crouleau@chromium.org [Telemetry] Remove deprecated --output-file flag. Created with: gclient setdep -r src/third_party/catapult@442e7b273107 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:894254 TBR=sullivan@chromium.org Change-Id: I27b5960a43bdee3247ed1379c14629d20b6064c7 Reviewed-on: https://chromium-review.googlesource.com/c/1388996Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618683}
-
- 21 Dec, 2018 38 commits
-
-
Christopher Cameron authored
NativeWidgetMac::CloseNow expects that the callbacks for window closure will happen before the function exits. For out-of-process windows, this will not be the case (and the callbacks will never be made because the host interface will have been destroyed). In out-of-process mode, add explicit calls to these callbacks. This matches the behavior BridgedNativeWidgetHostImpl's OnBridgeFactoryHostDestroying (which has the same problem where the window destroy callbacks won't come in). Bug: 915572 Change-Id: Ie65dfef1a7e483364ee95df2e52083c777523a61 Reviewed-on: https://chromium-review.googlesource.com/c/1388722 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#618682}
-
Aran Gilman authored
AccessibilityTableColumnHidden should fail when hiding the column causes incorrect behavior, not when unrelated changes to attribute computation change the value of row index. However, no other tests caught the discrepancy between set and computed aria attributes, so a new test for that is also added. Bug: 904896 Change-Id: I6af6fa8260c4eeea477f19ffe9dfd8ce621052f9 Reviewed-on: https://chromium-review.googlesource.com/c/1376739 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618681}
-
Aaron Leventhal authored
Bug: 896359 Change-Id: Idf548dee9fe65183a9093132560741dee9ae4029 Reviewed-on: https://chromium-review.googlesource.com/c/1388552 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#618680}
-
Kristi Park authored
Missed this during the initial deprecation. last_forced_time is now unused. Bug: 893362 Change-Id: I907befacea250a0bb8e971c78dab0124e5a39c1a Reviewed-on: https://chromium-review.googlesource.com/c/1388816 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#618679}
-
Devlin Cronin authored
Update the Site Access section to meet the new mocks. Instead of a drop down, include a radio button group to support selection of site access options. Incorporate the list of allowed sites, if the "specific sites" option is selected, into the radio group item. This is a purely aesthetic change and has no functional difference. Test changes are only to update identifiers. Screenshots: https://imgur.com/a/SgAhyJu Bug: 914523 Change-Id: Ib9521f1a4196c8030babb9041560c573e146b39b Reviewed-on: https://chromium-review.googlesource.com/c/1385483 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#618678}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/91085072faa1..d375f1c8d19f git log 91085072faa1..d375f1c8d19f --date=short --no-merges --format='%ad %ae %s' 2018-12-21 nisse@webrtc.org Refactor NetEqTestFactory to not use "external" decoders 2018-12-21 ilnik@webrtc.org Add ability to paste VideoFrameBuffer into the middle of I010Buffer and I420Buffer 2018-12-21 srte@webrtc.org Adds new timer based rate controller trial to GoogCC 2018-12-21 oprypin@webrtc.org mb: Turn LUCI desktop perf bots into builder + tester pairs 2018-12-21 nisse@webrtc.org Delete test VideoSendStreamTest.CapturesTextureAndVideoFrames. Created with: gclient setdep -r src/third_party/webrtc@d375f1c8d19f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:908001,chromium:362437 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I748339500a5e02e483107c37ca78e0591bc9b922 Reviewed-on: https://chromium-review.googlesource.com/c/1388624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618677}
-
Dmitry Gozman authored
There will be no request once we stop using WebURLLoader for navigations. This patch exposes some bits of WebURLRequest instead of request itself. TBR=vakh@chromium.org Bug: 855189 Change-Id: I909fa33480392610d7205cc345f26ff9aa2091d6 Reviewed-on: https://chromium-review.googlesource.com/c/1385146 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#618676}
-
Ken Rockot authored
Right now the two Service Manager embedders -- Content and iOS -- are both using catalog::ManifestProvider to support dynamic lookup of service manifests when needed. This is kind of pointless since all manifests are already known at initialization time. Furthermore, it relies on using JSON/base::Value manifests, which are going away. This CL changes both embedders to initialize the Service Manager with a populated list of Manifest objects instead. In order to arrange this, both ContentBrowserClient and iOS's WebClient API are updated to return service manifest overlays as Manifest objects. Parsing of the original base::Value manifest objects is pushed into a new Manifest::FromValueDeprecated static helper which will be phased out as these manifests are migrated to native code definitions. Finally, Manifest itself had to be updated to use std::string everywhere it was using const char*, because we can't realistically use C-style strings if we're going to construct Manifest objects over unowned dynamic string data. We can probably revert back to const char* when we remove FromValueDeprecated. TBR=sky@chromium.org Bug: 895616 Change-Id: I6c9e8eebdcc3e51dbfef2b52dacffbded76afe47 Reviewed-on: https://chromium-review.googlesource.com/c/1383530 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#618675}
-
manuk authored
Bug: 891303 Change-Id: I2e9dd3d635a2d5776fc5d1bca045b9b2fee539b3 Reviewed-on: https://chromium-review.googlesource.com/c/1382899Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#618674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b69b658db67..896defe03d0b Created with: gclient setdep -r src-internal@896defe03d0b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I374521d097876f793b495278804c0edef812d1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1388998Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618673}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ae3945f4d219..eb3f4742a6bd git log ae3945f4d219..eb3f4742a6bd --date=short --no-merges --format='%ad %ae %s' 2018-12-21 tsepez@chromium.org Update README.md about public APIs. Created with: gclient setdep -r src/third_party/pdfium@eb3f4742a6bd The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3a182593d4317d2f4be06105d9879ff65d775ab5 Reviewed-on: https://chromium-review.googlesource.com/c/1388999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618672}
-
Lei Zhang authored
BUG=916697 Change-Id: I3aeed8353b490ebcb77f16ab4d87e370fb5f0109 Reviewed-on: https://chromium-review.googlesource.com/c/1388391Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#618671}
-
Jonathan Backer authored
It doesn't seem to work for the root sk_surface_ with SkDDL. Plus, we might skip an unnecessary copy. Specifically, when we do a makeImageSnapshot, we are probably doing a GPU --> GPU memory copy. This is followed by a GPU --> CPU memory copy to turn the SkImage into a SkBitmap. With the new code, Skia may optimize to a single GPU --> CPU memory copy. Bug: 911643 Change-Id: Ia456a9bba1a59f7f37134a8642a76064a54bf75f Reviewed-on: https://chromium-review.googlesource.com/c/1387024Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#618670}
-
Devlin Cronin authored
Remove a lingering linked_ptr usage. Bug: 556939 Change-Id: I45840cfce318214aa4598dd5124c5cf134794d29 Reviewed-on: https://chromium-review.googlesource.com/c/1388927Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618669}
-
Caleb Rouleau authored
It has been failing for several days. To reenable, just re-add the lines I removed to perf_data_generator.py and then rerun tools/perf/generate_perf_data TBR=jbudorick@chromium.org Bug: 916824, 915429 Change-Id: I46bb0cd44b1ebf68ccbd6eae79a718c4cf49ee73 Reviewed-on: https://chromium-review.googlesource.com/c/1387832Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#618668}
-
Meilin Wang authored
Bug: b/120549692 Test: run autotest in chromeos chroot Change-Id: I68111f28c73536226ad601ae63bba3459d0eb902 Reviewed-on: https://chromium-review.googlesource.com/c/1383040 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#618667}
-
danakj authored
One struct holds things that will stay in the eventual WebViewImpl, and the other holds things that will move to WebWidgetImpl once they are split. This will allow us to DCHECK that you're not inside a WebWidget API call when you access ViewData, or vice versa. And it makes users clear within the WebViewImpl class which one they are acting on, as we make a decision where each variable belongs. It also allows us to do that incrementally. R=dcheng@chromium.org Change-Id: I255cf0de838928e3f88c805563017702067e0d48 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1388920Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#618666}
-
Devlin Cronin authored
Remove linked_ptr usage from extensions event-related code, including event_router.* and lazy_event_dispatcher.*. Most of these were easy changes, where the object didn't actually have to be linked. One exception is in the lazy event dispatching. Previously, we would store the linked_ptr in a callback while waiting for the extension background page to start up. Now, we instead have to create a copy of the event. This is slightly less efficient, since it is an additional copy (potentially even an additional copy per browser context per extension), but realistically, this won't happen frequently (because the background context would be around for at least 5 seconds after any event). Bug: 913604 Change-Id: I9cb534f69f1839a7fbfe640490317221c5448884 Reviewed-on: https://chromium-review.googlesource.com/c/1370721 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#618665}
-
Peter Collingbourne authored
- Don't try to copy binaries for all the architectures every time, just copy the ones for the arch that we're currently dealing with. - Build just the binaries that we want. Change-Id: I0cfacb8436209d928e77aed239ad422f29e4c716 Reviewed-on: https://chromium-review.googlesource.com/c/1377210Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#618664}
-
Tommy C. Li authored
Doing this work for a couple reasons: - Unit tests are less flaky and faster. - These can be written as unit tests without losing any testing power. - Query in Omnibox may need to update the clipboard behavior soon, this is kind of adjacent work. Bug: 874592, 751031 Change-Id: Ibf5273f22578be713ab3c48539ab5311e5c7a7cc Reviewed-on: https://chromium-review.googlesource.com/c/1377174 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#618663}
-
Miguel Casas authored
ToT memory-infra dump shows the Textures allocated for GPU video decoding, but it has no idea of the Renderer client on behalf of whom the GPU-side allocation has happened, see e.g. [1]. This CL adds GpuVideoDecoder::OnMemoryDump(), with the appropriate OwnershipEdge, so that: - The textures from the GPU process are reported with |effective_size| 0 and a renderer owner, e.g. [2]. - The Renderer has a new gpu sub-category |video_decoding| with the textures reporting both |size| and |effective_size|, and to which those in the GPU process can refer to, e.g. [3]. There's a bunch of changes to GpuVideoAcceleratorFactories{Impl} to be able to access the gpu::ContextSupport (intermediate types are not available to media/filters); also media/filters can't depend on ui/gl, so this CL adds a trivial trace_util.{cc,h} to media/video, respecting the hierarchies. [1] https://i.imgur.com/3tJThzL.png (https://imgur.com/a/7Y01lQ9) [2] https://i.imgur.com/KqJ8jQf.jpg (https://imgur.com/a/jrXGM49) [3] https://i.imgur.com/f0u5xeR.png (https://imgur.com/a/zrlSVke) Bug: 916807 Change-Id: Iffbb3cf8911ff6009a7f4989409e1bb6a95cf719 Reviewed-on: https://chromium-review.googlesource.com/c/1385546 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#618662}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ied126756ba70f82e15df348f23ec50dd6f5ac41a Reviewed-on: https://chromium-review.googlesource.com/c/1388958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618661}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bdc2ab93563f..167f1270a9ee git log bdc2ab93563f..167f1270a9ee --date=short --no-merges --format='%ad %ae %s' 2018-12-21 dj2@everburning.com Output disassembly line number for binary parse errors. (#2195) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@167f1270a9ee The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I45e206601f99fd7dbb108ba33561f14d22575110 Reviewed-on: https://chromium-review.googlesource.com/c/1388997Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618660}
-
Vlad Tsyrklevich authored
My current experiment indicates this is the best default parameter to use in terms of performance versus crashes. Bug: 896019 Change-Id: I59028eba3bc994970d49b031e547a078f9702ba0 Reviewed-on: https://chromium-review.googlesource.com/c/1389020Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#618659}
-
Karan Bhatia authored
r616847 introduced the ability for the "content_security_policy" manifest key to be used as a dictionary. While the CL restricted the "content_security_policy.extension_pages" key to the trunk channel, it didn't restrict the usage of "content_security_policy" manifest key as a dictionary on non-trunk channels. Fix this. BUG=914224 Change-Id: Ida60cbfadf7001b4253c65967b0d106ec5bb098b Reviewed-on: https://chromium-review.googlesource.com/c/1388171 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#618658}
-
David Bertoni authored
We use std::pair as both a key and a value in some maps. Using LazyContextId makes the code more readable and a bit more efficient in some places. Bug: 915814 Change-Id: I9026bff13d74e093b6d703b7d4d95d07fe33e3c6 Reviewed-on: https://chromium-review.googlesource.com/c/1384751 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#618657}
-
Sidney San Martín authored
The window server enforces rounded corners on a window when its content view has a layer. BridgedNativeWidgetImpl::CreateContentView() replaces a window's content view, so it needs to make sure that the new content view has a layer. BrowserFrameMac::InitNativeWidget() already did this for browser windows, but moving it covers more cases, like app shims. Bug: 917001 Change-Id: Iab5b459ba6950ee00327c3938ab897ee0a48bb0d Reviewed-on: https://chromium-review.googlesource.com/c/1388807Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#618656}
-
Xiaocheng Hu authored
The layout test asserts mapping between logical and visual caret positions, which is changed by the bidi caret affinity flag. This patch adds new behavior under the flag to make the test pass there. Bug: 917165 Change-Id: I0494f08b7af5ddce7eeff0aff43348d84efa1931 Reviewed-on: https://chromium-review.googlesource.com/c/1388815 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#618655}
-
Kurt Horimoto authored
BVC previously used self.visible, which is set in |-viewWillAppear:|, as a trigger to start broadcasting its UI state. However, cancelled UIViewController transitions can sometimes result in |-viewWillAppear:| being called without its accompanying |-viewDidAppear:| and |-viewWillDisappear:| selectors. As a result, BVC continued to broadcast its UI even if its views were removed from the hierarchy and deallocated, thus resulting in the crash from crbug.com/915123. This CL updates BVC.broadcasting to be gated on BVC.viewVisible, which is instead set in |-viewDidAppear:| after a successful presentation. In addition to mitigating the crash, this also is an improvement semantically, as BVC should not be broadcasting its state until it is fully presented. If objects care about BVC's UI during a transition, it should be using the transition coordinator. Currently, the BVC's broadcasted values are only used by FullscreenController, and no scrolling is occurring in between |-viewWillAppear:| and |-viewDidAppear:|, meaning that this CL has no functional change. Bug: 915123, 916581 Change-Id: Ifc0245e6e93f823c733be41ea471954912e7b577 Reviewed-on: https://chromium-review.googlesource.com/c/1388713Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#618654}
-
danakj authored
SetBackgroundOpaque() is a concept that applies only to WebViews, not to WebWidgets. It is set by ChromeOS UI pieces, which each have their own WebView/Page. It is also set by webview tag, which has its own WebView contained inside another outer one. So we move the SetBackgroundOpaque() methods and IPCs from RenderWidget to RenderView. In the renderer, the WebWidget::BackgroundColor() is not used except internally, so remove it from the WebWidget API. The WebFrameWidgetImpl is only used for child frames, and during Initialize(), it will set its background color to be overridden to transparent, preventing any future colors to matter, unless the override was cleared. But since clearing overrides only happens by IPC to the main frame widget (now to the RenderView) that clearing can't happen. So remove all background color code from WebFrameWidgetImpl, and just set the compositor's background color to transparent during startup. Android WebView and ChromeCast code was also setting the base background color via the WebFrameWidget, but both are in code that corresponds to a view, not a widget, so pass the value to WebViewImpl directly instead by adding SetBaseBackgroundColor to the WebView API. Then we remove all background color APIs from WebFrameWidget as well. R=ajwong@chromium.org, avi@chromium.org, dcheng@chromium.org TBR=dcheng Change-Id: I3d83064d13836f286f8ebc89118b990bbdbb80d3 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1382861 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#618653}
-
Michael Ludwig authored
Bug: 915735 Change-Id: I2637ff932cbe090e41cf71d4ad0b02eff141f2b2 Reviewed-on: https://chromium-review.googlesource.com/c/1388547Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#618652}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/02cb969e13c7..f4dd96c6b81b git log 02cb969e13c7..f4dd96c6b81b --date=short --no-merges --format='%ad %ae %s' 2018-12-21 reed@google.com Reland "Revert "serialize fonts instead of paints"" 2018-12-21 ethannicholas@google.com fixed SPIR-V global initializer ordering 2018-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 92b16ea26290..d50521fd068e (1 commits) 2018-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bb0a7f09a91e..809d01138e0a (1 commits) 2018-12-21 halcanary@google.com SkPDF: unify SkPDFOffsetMap and SkPDFObjectSerializer 2018-12-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e0b5a4b0416b..bb0a7f09a91e (2 commits) 2018-12-21 caryclark@skia.org fix pathops bug 8380 2018-12-21 reed@google.com Revert "share constructors/enum in both variants of SkReadBuffer" 2018-12-21 michaelludwig@google.com Implement per-edge aa as extra vertices instead of interpolated edge distances 2018-12-21 herb@google.com Move from a generalized appendGlyph to two specialized methods. 2018-12-21 reed@google.com use font for measuring/paths 2018-12-21 reed@google.com share constructors/enum in both variants of SkReadBuffer 2018-12-21 reed@google.com Revert "Revert "serialize fonts instead of paints"" 2018-12-21 reed@google.com Revert "serialize fonts instead of paints" 2018-12-21 bsalomon@google.com Move GrResourceKey.h to include/private. 2018-12-21 robertphillips@google.com Short term fix for SkClipStack unique key issue 2018-12-21 reed@google.com serialize fonts instead of paints 2018-12-21 halcanary@google.com SkPDF: debugging flag SK_PDF_BASE85_BINARY applies to JPEG Created with: gclient setdep -r src/third_party/skia@f4dd96c6b81b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:914833,chromium:b/120946388 TBR=halcanary@chromium.org Change-Id: Ide4efdfb6f874d1794316745926fc26559852da6 Reviewed-on: https://chromium-review.googlesource.com/c/1388995Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618651}
-
Lei Zhang authored
BUG=882085 Change-Id: I07243c03a28a45f3d368269668b54eadc0b50e98 Reviewed-on: https://chromium-review.googlesource.com/c/1362223Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#618650}
-
Piotr Bialecki authored
Now that we can use ARCore SDK 1.5, we can start using 3D version of hit test and remove previously used one. Since we no longer use ArFrame_hitTest, it is getting removed from arcore_shim.cc. Bug: 835948, 854823 Change-Id: Ibf8e953135b04925dbebd384e16f8f08ad52a869 Reviewed-on: https://chromium-review.googlesource.com/c/1357723Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#618649}
-
Krishna Govind authored
TBR=abdulsyed@chromium.org Change-Id: Ic98ef04581797a2cac82487adb5e0af9f547b4f2 Reviewed-on: https://chromium-review.googlesource.com/c/1388748Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#618648}
-
Dave Tapuska authored
Use size_t for hash value which matches the function definition requirement and the type. BUG=879657 Change-Id: I486cfd3adde1880c03b1657d9cb803c5d50f16f4 Reviewed-on: https://chromium-review.googlesource.com/c/1387827Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#618647}
-
Evan Stade authored
- Allow testing DesktopNativeWidgetAura on Chrome OS by doing necessary Mus setup. - To accommodate Chrome OS, tests must specify that they will be testing desktop widgets before SetUp (for tests that inherit from ViewsTestBase). On Chrome OS, these are the tests that provide Mus coverage. - Command line flags are ignored, so views_unittests will perform the same tests with and without --enable-features=SingleProcessMash - Enable some test suites on Chrome OS, such as desktop_native_widget_aura_unittest.cc, and some individual tests. Bug: 911784 Change-Id: Ic3acd21770f07fb8298a172dc556b3fa036d6791 Reviewed-on: https://chromium-review.googlesource.com/c/1378666 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#618646}
-
Pavel Feldman authored
Bug: 917477 Change-Id: Ibf881ccc9577a6aa380c07b613042395567fb39d Reviewed-on: https://chromium-review.googlesource.com/c/1388751Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#618645}
-