- 30 Sep, 2020 40 commits
-
-
Asanka Herath authored
Callsites should only use FromTypeAndToken. Bug: 973801 Change-Id: Ide955dd19de105310ba699c2e5246454f6e1abaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432201 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#812251}
-
Evan Stade authored
This is necessary for Chrome because a normal profile and an incognito profile use the same MediaRouter. That object should be notified when the incognito profile shuts down. This is not necessary for WebLayer because OTR contexts have their own MediaRouter (the OTR context is not linked to a normal/base context). Bug: 1057100 Change-Id: I9c4426a4219bd971c6690b4d2712e5d39ec3f91e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438946Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#812250}
-
Dan Harrington authored
And restructure feed code so that we can use it. This flag pulls Feed v1 out of the build. It's a bit different that enable_feed_v2. enable_feed_v2 retains most of the v2 code in chromium -- only the internal code is actually removed when enable_feed_v2 is off. If both flags are ON (the default), we use the InterestFeedV2 feature to select which version to use. To facilitate this, only feed_feature_list.cc and FeedFeatures.java should inspect the state of this feature directly. If both build flags are OFF, we use the V2 UI classes as essentially a pass-through to a recycler view, but will not request any Feed content. The compile flag enable_feed_in_chrome was removed. Other changes: * I've moved some files around to make it more clear what code is for v1 only. * I've added FeedV1 and FeedV2 java classes to wrap access to version specific things, so that FeedV1 can be removed using the compile flag. Bug: 1129187 Change-Id: I19b1b8deeafae51b00e6b2c23373da787dc7c93d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417533 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#812249}
-
Mike Wittman authored
Fourth in a series factoring the ThreadProfiler platform specific configuration state from the code that takes action on the state. Defines a GetChildProcessEnableFraction function that returns how frequently the profiler should be enabled within a given process. The end goal is to reduce the configuration complexity, to support enabling per-thread on Android. Bug: 1129939 Change-Id: I936c671cd30f1750cf87d6ec8ce9aee45c051be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424672 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#812248}
-
Haiyang Pan authored
As discussed in crbug.com/1133002#c6, remove this to make room for content_browsertests Bug: 1133002 Change-Id: Ib6598f2b2b8681378e13a196f66d064f6ff24983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441108Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#812247}
-
Mustaq Ahmed authored
Change-Id: I8a928600f226b452abd8c0747f6baf123ed10a5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437742 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812246}
-
Matthias Körber authored
This CL gives heuristically detected street name and house number field precedence over server predictions. Change-Id: Icadcb5854e15127830d9b9b114d9986943517dfa Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440521Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#812245}
-
Jazz Xu authored
This CL modify the media tray such that the bubble won't close when user unpins media tray from shelf. Bug: 1133488 Change-Id: I4ea32592c15b49312c8ab6a14e734069b39c9f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439011Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812244}
-
chinsenj authored
As an ongoing effort to make the window cycle list (alt-tab) more interactive, this CL makes it so the following interactions cycle the window cycle list: - Two and three finger horizontal trackpad scroll. - Mouse wheel scroll. Test: Manual + added tests. Bug: 1067327 Change-Id: Ibec4a34ee6e2eca77589d2598ad44fb84a2bea62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426477 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#812243}
-
Daniel Hosseinian authored
When PDF contents are rotated, rotate the canvases holding the thumbnail images using CSS. Resize the divs holding the canvaves so that the layouts of the thumbnails are updated. Bug: 652400 Change-Id: Ib17fbba2905ac71a38d310ea1dd419933d7785eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438476 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812242}
-
Angus L. M. McLean IV authored
When no windows are shown, and a user presses tab, focus the launcher/Home button on the display which has the mouse. This was based on @newcomer's original CL, https://crrev.com/c/2128227. The comments there as well as in the bug have been handled here. Bug: 1060337 Change-Id: I801b8ecc4e7fefb697cf2ace56736f6e85b3cd43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412518 Commit-Queue: Angus McLean <angusmclean@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812241}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a87c5076a876..aac5728a8260 2020-09-30 robertphillips@google.com Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache (take 2) 2020-09-30 johnstiles@google.com Add ProgramWriter, a non-const version of ProgramVisitor. 2020-09-30 johnstiles@google.com Add unit test for inlining trivial arguments. 2020-09-30 ethannicholas@google.com moved SkSL Extension data into IRNode 2020-09-30 csmartdalton@google.com Don't cast emscripten pointers when assembling WebGL interface 2020-09-30 johnstiles@google.com Update nanobench SkSL tests. 2020-09-30 ethannicholas@google.com Revert "Revert "moved SkSL ExpressionStatement's data into IRNode"" 2020-09-30 bsalomon@google.com Add sample count field to GrD3DTextureResourceInfo. 2020-09-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ec42b1438fd2 to fa082bb58ba7 (11 revisions) 2020-09-30 johnstiles@google.com Avoid creating temporary variables for nested trivial cases. 2020-09-30 johnstiles@google.com Revert "moved SkSL ExpressionStatement's data into IRNode" 2020-09-30 brianosman@google.com Revert "Make GrRRectBlurEffect use the thread-safe uniquely-keyed view cache" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408,chromium:1133459 Tbr: brianosman@google.com Test: Test: Test: CQ Change-Id: Ibfa175c50422039e16124cea3b99c0b2db410f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440987Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812240}
-
Jun Mukai authored
This seems to be used in tablet mode. Extending 1 year more. Also added owners. Bug: 1125830, 1072660, 1072659, 1088587 Test: none Change-Id: I91bb14e92d8372d228a29d629941eb896c8c6b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438495Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#812239}
-
Daniel Hosseinian authored
In preparation for rotating the thumbnails in response to PDF content rotations, propagate the number of clockwise rotations to the thumbnails. A future change will implement the rotations. Bug: 652400 Change-Id: I89933d30edb102a31ae5381677aaf9f8874dadea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437487 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
dpapad authored
Fixed: 1130478 Change-Id: I755023dbe5fc9c96b2e9c693a3b233b47551a9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439646 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#812237}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/59d478038b9b..e816b5197f5e 2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I7693a90103689bcdc241a96f7b180529ce73e4e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440471Reviewed-by:
-
Darren Shen authored
Whenever the VK visibility / bounds changes, it notifies listeners such as the WorkspaceLayoutManager. For historical reasons, we always notify the first time, even if there was actually no change. For example, the VK starts off with empty "displaced" bounds. If the VK is opened, the "displaced" bounds can still be empty (as expected). However, we still notify listeners that the bounds have "changed" to empty, even though it was already empty. This can be misleading. It makes more sense to only notify when there is actually a change in the bounds value. In fact, [1] relies on this behaviour. Whenever it receives a zero bounds, it assumes that the VK went from shown -> hidden. The assumption only holds if we always send real bounds changes. [1] https://source.chromium.org/chromium/chromium/src/+/master:ash/wm/workspace/workspace_layout_manager.cc;l=249;drc=e3687581e4b1a85562130e9cc1a8765fc5b9022e Bug: 1030481 Change-Id: I0cdd91e2b334caefd3f10b818d3d4b6b77a2ee93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434410Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#812235}
-
Milica Selakovic authored
AutofillAssistantRuntimeObserver AutofillAssistantRuntimeManager will keep the state if Autobot UI is shown and accordingly notify about change subscribed observers. AutofillAssistantRuntimeManager can be queried about visibility of Autobot's UI. Bug: 1133783 Change-Id: I044855c20dae6b4c4fec5a9f6624afee3af48442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424186 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812234}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/def823dfb288..11b196b0c0c6 2020-09-30 vsavu@google.com Add comment to indicate the LTS branch 2020-09-30 saklein@chromium.org portage_util: CPV Cleanup 2020-09-29 saklein@chromium.org api/tutorials: Add validation tutorial. 2020-09-29 saklein@chromium.org Build API: Add hello world tutorial. 2020-09-29 navil@google.com chromeos_config: Add public full builder for eve. 2020-09-29 tomhughes@chromium.org chromite: make zork sign accessory_rwsig for fingerprint firmware 2020-09-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-09-28 vyshu@google.com payload_generator: add default target version 2020-09-28 ahassani@chromium.org paygen: Add signature sizes when inserting signatures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I03ba9de694d8b46501dd6d8c7d62a9792e6ff7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440468Reviewed-by:
-
Raymond Toy authored
Previously, we explicitly cleared the destination node in BaseAudioContext::Clear(), called from BaseAudioContext::Uninitialize(). But the destination node is a Member variable of BaseAudioContext, and Oilpan can handle clearing this when the context goes away. In the bug, what was happening that the destination node was cleared, but we were constructing the ScriptProcessorNode which needed information from the destination to compute the appropriate buffer size. By not clearing the destination, we can compute the size. The destination node gets cleared when the context is collected. Bug: 1132642 Change-Id: I7715bbce7a84f758c7c886a9635c277311622550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439436Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812232}
-
Daniel Hosseinian authored
If the sidenav icons are shown, add some padding to the right of the thumbnails. Before and after photos: https://imgur.com/a/a6T0DD2 Bug: 652400 Change-Id: I15039ab0b672a3e6fac370f10278c1a45f890553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434094 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Avery Musbach authored
BEFORE: Touch exploration causes the mouse cursor to appear even if there are no pointing devices whatsoever. AFTER: Touch exploration has no effect on cursor visibility. Bug: b/167952435 Test: manual Change-Id: I0ff8d0ddf59272183bed65655f10be5aeb57210b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436627Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#812230}
-
Luke Zielinski authored
This avoids path errors on windows. Tested locally on a Windows checkout to confirm the tests pass. Bug: 11334758 Change-Id: I28ffbebcb06984cd2a5aee252a52947d7c848a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439013Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812229}
-
Josiah K authored
Parent Tracking Bug: 1131153 Fixed: 1129711 AX-Relnotes: Add accessibilityPrivate method to update magnifier viewport and focus following highlight Change-Id: Id5fa2c05e39f763b7a599e3445f40945a71f5e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417457Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#812228}
-
Tibor Goldschwendt authored
Screenshot: https://screenshot.googleplex.com/7pbxJMPP2QgAgkM Fixed: 1130862 Change-Id: Ied56500f9384fc9bedc15eef4cb8ffcde4830b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437473 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#812227}
-
Felipe Andrade authored
Extend the expiration date of AuthPolicy and Kerberos histograms. Also, synchronizing the milestone of expiry, to make maintenance of these histograms easier. Justification for AuthPolicy: the feature doesn't send enough data to DM Server to provide data about it's usage. Justification for Kerberos: the feature is still under trusted testers. Bug: 1130634, 1130631, 1127945, 1104946, 1104923 Change-Id: I1179f1ea2deea5681cf5c8c09a8380b57a8e28f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435308Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#812226}
-
Xianzhu Wang authored
Verified that the crash reports have the same crash address as what I reproduced locally by manually passing a null frame to ScrollingCoordinator. Haven't reproduced with a test case. Not sure why the MainFrame() is null. Bug: 1131411 Change-Id: I736850cdbf8fbcb8760bdbe377316bee930fb3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439537Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812225}
-
Stepan Khapugin authored
Fixes some scene-specific API usage on iOS 13 that's not gated with multiwindow checks. Bug: 1133356 Change-Id: I6ead2767526b111d3ad292ac638509428ff3f88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437399 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#812224}
-
Alex Turner authored
The FontMatchingMetrics class records UKMs about the font matching on the web. This will be used for the identifiability study to understand the privacy leak that font matching can cause. Currently, these metrics are only recorded for matching in the CssFontSelector (i.e. occurring on documents). This cl allows construction of a FontMatchingMetrics object on WorkerGlobalScopes and adds reporting from the OffscreenFontSelector. This ensures that the font matching occurring on workers is recorded, so that any resulting privacy leak can be studied. Bug: 1131928, 1025945 Change-Id: Ic8794813453d8a715071cfa71f1c4fed7444f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197604Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#812223}
-
Keren Zhu authored
Bug: none Change-Id: I90367acee185648eac442ea7b317672c464d3b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437693 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812222}
-
Daniel Hosseinian authored
Add a thicker highlight around the thumbnail when it corresponds to the active PDF page. Draw an even thicker highlight around the thumbnail when it corresponds to the active PDF page and it is focused. Also, do not draw focus outline on thumbnails that are clicked. Bug: 652400 Change-Id: I30a790ad400a705d766099fb322b297913f48f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434734 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#812221}
-
Austin Sullivan authored
Variable in assertion should be |length_result|, not |result| Change-Id: I5c5060bb787aa7cc33a739bc856dec41c78bf790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438487Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: enne <enne@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#812220}
-
Eric Roman authored
The goal of this histogram isn't to measure which version the server is expecting, but rather to upper bound how many differences (success OR failure) there _could_ be if we changed to a locale-insensitive uppercasing approach. Bug: 1051924 Change-Id: I8ed7471a6270b95e3cd1a4d8c808d23339321a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438258Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#812219}
-
Xida Chen authored
TBR=jianli@chromium.org NOTRY=true Bug: 1124981 Change-Id: I4d0bc93d601f69aeb0af506f67f86e274ba5734a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441277Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#812218}
-
Stephen Martinis authored
This reverts commit 04baf73b. Reason for revert: outage is over Original change's description: > Disable clang tidy and metrics analyzer in tricium > > These machines are using the main linux pool, which is overloaded. > See bug for more details. > > No-Presubmit: true > Bug: 1133410 > Change-Id: I4b29e1d343c1dcbf46d185251db931199f06b322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438852 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811805} TBR=qyearsley@chromium.org,tandrii@google.com,estaab@chromium.org,martiniss@chromium.org Change-Id: Ifed16288732733512d31f09d33d577aa4899ba41 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441119Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812217}
-
Stephen Martinis authored
This reverts commit 7d7eb2cd. Reason for revert: outage is over Original change's description: > Disable CQ experiments > > We're having issues with high pending times on the linux CQ pool. > Disabling this for now, since experiments are optional and are > currently using up capacity. > > No-Presubmit: true > Bug: 1133410 > Change-Id: I4d34c8a7403249601dfbbdba450b46b97d3ef869 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438672 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Auto-Submit: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811773} TBR=estaab@chromium.org,martiniss@chromium.org,gbeaty@chromium.org Change-Id: Iba64cf556a302342d58dc207072ef8f05b868096 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441020Reviewed-by:
-
Jan Wilken Dörrie authored
This change fixes key press event handlers by checking a weak ptr before invoking them. Bug: 1133671, 1133688 Change-Id: Id7708653c127a49343edf57de2a6fa4522ca088d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440620Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#812215}
-
Lei Zhang authored
Bug: 1048812 Change-Id: I7ddf909e0c5179f758230b9bd93734e015a6c45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436273Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
This toggle will suppress all signin promos when toggled off. If the user tries to toggle it off when signed-in, it will show the signout dialogue and start the signout flow. The toggle sets Signin.Allowed pref to false in order to suppress the promos and prevents the user from signing in. Bug: 1097718 Change-Id: I31fcd199c2ad74ee36079bb63ad506673b2dfd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437379 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812213}
-
Daniel Hosseinian authored
Make thumbnails opaque in their default states. Remove opacity on the thumbnail of the active page. Decrease opacity when hovering over thumbnails of inactive pages. Increase opacity against a white background when hovering over thumbnails of active pages. Bug: 652400 Change-Id: I58c39dfdba8bd606ce202c69c6e11e2e21beac82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434886 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
