- 23 Aug, 2017 40 commits
-
-
David Bokan authored
This is a speculative patch to check if we're reentering PerformScrollAnchoringAdjustments. Bug: 745686 Change-Id: Ie01827b4fa30f55e221a906e7fbae73245ecaa83 Reviewed-on: https://chromium-review.googlesource.com/627632Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#496558}
-
Matt Menke authored
This class provided a bogus IOThread for unit testing. Of the 3 tests and one test fixture that were instantiating a TestingIOThreadState, only one test was actually using it. That one test was just testing that it was creating a particular object, not that the object was correctly hooked up, so doesn't seem worth keeping. The main motivation of getting rid of this class, beyond it's limited utility, is to make migration to the network service, which will involve replacing the IOThread class, simpler. Bug: 755309 Change-Id: I5e8bae00e17d2da70e4951a530c0b1546bca9218 Reviewed-on: https://chromium-review.googlesource.com/619178Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#496557}
-
Theresa Wellington authored
BUG=757841 Change-Id: I84590b7f5b49a7fb363b39a8580ec5285b5db75f Reviewed-on: https://chromium-review.googlesource.com/626756 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#496556}
-
Klemen Kozjek authored
This CL adds notification messages for renaming process for events: PENDING, SUCCESS, and FAILURE. In addition to notification this CL also adds strings required by notifications. As a result, when renaming is invoked you ought to see notification that reports the current status of renaming. BUG=274041 TEST=browser_tests FileManagerJsTest.DeviceHandler* Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I000bdb58ca93c7f61c8bdf111397d495fc89316e Reviewed-on: https://chromium-review.googlesource.com/615105 Commit-Queue: Klemen Kozjek <klemenko@google.com> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#496555}
-
David Tseng authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib130dbf92ed60c750e454abb32bf7dcb5c898c92 Reviewed-on: https://chromium-review.googlesource.com/619619Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#496554}
-
Justin Carlson authored
Bug: 758048 Change-Id: Ib6ca673fc324f1b6a0eace572c106fcb9f5f762d Reviewed-on: https://chromium-review.googlesource.com/627524Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#496553}
-
Scott Haseley authored
This CL adds tab switch load time metrics to TabManagerStatsCollector during session restore and background tab opening. Since it is possible to have background tab loading or session restore occurring simultaneously in multiple windows, the implementation tracks all new foreground tabs as they are switched to, and records metrics when receiving the done loading signal from the TabManager for tracked tabs. The new metrics are TabManager.Experimental.BackgroundTabOpening.TabSwitchLoadTime and TabManager.Experimental.SessionRestore.TabSwitchLoadTime. This CL also adds the TabManager.BackgroundTabOpening.SwitchToTab metric, which is the background tab opening version of TabManager.SessionRestore.SwitchToTab. Bug: 755363 Change-Id: Ie43b48e325b14a93c806b12f3a483415ccff8cef Reviewed-on: https://chromium-review.googlesource.com/614723 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
lpy <lpy@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#496552}
-
Kyle Horimoto authored
If Celluar is available on the device (i.e., the device has its own LTE connection), this CL leaves things as they are. If Cellular is not available on the device, (1) If Mobile data is disabled via toggle, display "Mobile data is turned off." (2) If Mobile data is disabled due to Bluetooth being off, display "Enabling mobile data will enable Bluetooth." (3) If Mobile data is enabled but no host devices have been scanned, display "No mobile devices found." Note: This CL also fixes an issue when Wi-Fi is disabled. The string "Wi-Fi is turned off" is supposed to be displayed when Wi-Fi is off but there are no nearby networks. However, there was a bug which prevented this string from being displayed if there was another network (i.e., Ethernet/Tether/Cellular) was available. Bug: 754465, 672263 Change-Id: I947f36974c6407ebe69b6483679f042a9315141d Reviewed-on: https://chromium-review.googlesource.com/627256 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#496551}
-
Tatsuhisa Yamaguchi authored
This will also allow to finish renaming when tapping outside the input text box. Bug: 755774,756839 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d05724e85c9615b284dc7e799cb2dfb7f18f190 Reviewed-on: https://chromium-review.googlesource.com/622332 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: 723882 Change-Id: I47cbb2d5fefeed201117d0f8ccc1d85f67de43da Reviewed-on: https://chromium-review.googlesource.com/615881 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Gregory Chatzinoff authored
TBR=mahmadi Bug: 758038 Change-Id: I5db7b82f8b9117d8731c62c4910619121caa9593 Reviewed-on: https://chromium-review.googlesource.com/627046Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#496548}
-
Anantanarayanan Iyengar authored
The main changes are as below: 1. The AppCacheUpdateJobTest class now maintains a pointer to the URLLoaderFactoryGetter class. This instance is instantiated for the duration of the test. 2. The mock factory is registered as a test factory on the URLLoaderFactoryGetter via the SetNetworkFactoryForTesting() method. 3. Added a function GetResponseForURL() to the test class RetryRequestTestJob. This mimics the logic in the RetryFactory function and is invoked by the mock URLLoaderFactory. 4. Added a function ValidateExtraHeaders() to the test class HttpHeadersRequestTestJob. This checks the cache modified headers. It is invoked by the factory function and by the mock URLLoaderFactory. BUG=715632 TBR=jam Change-Id: I6fbb6a3b582c5971cf8a0c2e6bc9acf7670a696c Reviewed-on: https://chromium-review.googlesource.com/616256 Commit-Queue: Ananta Iyengar <ananta@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#496547}
-
Qiang Xu authored
Bug: 757473 Test: tested with fullscreen app list flag and background blur flag Change-Id: I1c5fbe9d69dc48b58b8f8181853de51ae22af9e9 Reviewed-on: https://chromium-review.googlesource.com/627696Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#496546}
-
Steven Bennetts authored
Bug: 728353 Change-Id: Ia96acca50581b7d3e8e30b01d445c8c4031cb4f1 Reviewed-on: https://chromium-review.googlesource.com/622069 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496545}
-
Alexei Filippov authored
BUG=751892 Change-Id: I9c7c2a6ff37b553b7d4634016a08ef600864ff67 Reviewed-on: https://chromium-review.googlesource.com/626722Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#496544}
-
Koji Ishii authored
The old code laid out upright glyph bounds horizontally and unite, then assumed it's logical. This was mitigated because the word cache segments every East Asian upright character as a word, and they're mostly square. In LayoutNG, this issue is more severe. The fix is to compute run bounds in physical because HarfBuzz lays out in physical. Then convert to logical before uniting to ShapeResult. To do this, this patch introduced a distinction between "flow" and "typographic mode". See comments in SimpleFontData::IsHorizontalMode(). Also fixed letter-spacing to increase widths in vertical flow, since bounds are logical. Nontes on test results rebaselines: - paint/invalidation/japanese-rl-selection-{clear,repaint}.html These tests invalidated overly excessive regions before the fix. These were fixed on Win/Mac. Linux improved a lot too, but "clear" is still excessive by half a line to the left, and "repaint" is slightly smaller on the left. Manual sanity tests indicated no obvious regressions. - svg/* SVG computes glyph bounds of each character and use it for layout. Since errors of one character in old code were not huge, only by vertical origin offsets, slight changes are seen but both before and after the fix look reasonable to me. BUG=636993 Change-Id: I55371f23b419195b3d3550af54f425b0b422f1a1 Reviewed-on: https://chromium-review.googlesource.com/577492 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#496543}
-
Pedro Amaral authored
First a little background on context menu events. A context menu event is actually a mouse event with the contextmenu type. This means that the context menu event comes with a location. This location is then used to know if the triggered menu had selected text. This is done in ContextMenuClient::ShowContextMenu() by checking if the HitTestResult landed inside of a selection. If it did then WebContextMenuData.selected_text is set to the selected text. This causes a problem for non-located menus (menus triggered by EventHandler::ShowNonLocatedContextMenu(), some examples are keyboard, contextual search tap, or touch handle triggered menus). Non-located menus set their location to the bottom left corner of the first selection rect. This causes an issue when there are multiple lines of text and we only select the first one. When the context menu is fired it's location is between the first and second lines of text. If the css style line-height is small enough (say 0.7 em like in the added test) the hit test will hit the second (unselected) line of text and we will incorrectly think that the event did not hit a selection. This caused the linked bug where the floating popup menu was not shown. This CL fixes this problem by having the non-located menu trigger on the midpoint of the left edge of the first selection rect instead of on the bottom left corner. Bug: 729969 Change-Id: Iec640fd57dc949f0f9657c2c473f716e6d70799e Reviewed-on: https://chromium-review.googlesource.com/611483Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#496542}
-
David Bokan authored
The new WPRGO files have been uploaded to cloud storage. This CL commits the new sha1 hashes and updated json for the page set. The digg.com story failed the conversion and has been disabled in this CL for all benchmarks from which its used. See bug 756119 for details. Bug: 756119, 730036 Change-Id: I28f87a4c5855b1b4af3de233e016d74b0a112fd9 Reviewed-on: https://chromium-review.googlesource.com/621948 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#496541}
-
Prashant Malani authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/5484a0346e1e..d3b70a23a22a $ git log 5484a0346..d3b70a23a --date=short --no-merges --format='%ad %ae %s' 2017-08-21 pmalani Add D-bus service constants for midis. Created with: roll-dep src/third_party/cros_system_api Bug: chromium:701005 Change-Id: I0e42178b006a3235ad6b69769783da1e8084677c Reviewed-on: https://chromium-review.googlesource.com/627085Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Prashant Malani <pmalani@google.com> Cr-Commit-Position: refs/heads/master@{#496540}
-
Marti Wong authored
This CL adds some new "TranslateCompactUI" experiments to the fieldtrial for testing different values of auto-never theshold in the compact UI on Android. Bug: 720184 Change-Id: I3360d5724b212ca7aba62b484803e402d54da260 Reviewed-on: https://chromium-review.googlesource.com/623016 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Alexei Svitkine (very slow) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#496539}
-
Weidong Guo authored
Reason for crash: DesktopNativeWidgetAura::InitNativeWidget binds current widget with the root window's kDesktopNativeWidgetAuraKey for desktop build. But the DCHECK in DesktopScreenPositionClient::SetBounds() expects current widget's root window's kDesktopNativeWidgetAuraKey is not set or is not set to the current widget. Changes: Set bounds widget's native view in parent window's coordinates instead of screen coordinates to avoid calling Window::SetBoundsInScreen() which triggers DesktopScreenPositionClient::SetBounds(). BUG=757573 Change-Id: Id627572256fd315ae4609d347a7999cecb2ee0f1 Reviewed-on: https://chromium-review.googlesource.com/627385 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Sebastien SG authored
Now that the Win7 bug is fixed upstream, Chromium can link to the most recent version of libaddressinput. Bug: 752122 Change-Id: I58be37ba5b1aeb0fca6d9c9a7e0cfc622c37a7f8 Reviewed-on: https://chromium-review.googlesource.com/627102 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#496537}
-
Xiaohui Chen authored
BUG=b/38124462 TEST=build and flash locally, see keyboard shortcut toggles Change-Id: Iad6c244d38d9c8140a233d28bf20065bbdda36a1 Reviewed-on: https://chromium-review.googlesource.com/624901 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Pedro Amaral authored
Adding several metrics to measure how useful flipping touch handles would be in avoiding clipping. This will be especially useful in deciding whether or not we can move WebView to use composited handles instead of popup handles. BUG: 757985 Change-Id: I4115b25de5320a2b1c4987fd7290b8390b3b0bef Reviewed-on: https://chromium-review.googlesource.com/621872 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#496535}
-
Alice Boxhall authored
Bug: 514674 Change-Id: If1d1cb8bcbf4fa1048a1a9a5d24eafee405d92ef Reviewed-on: https://chromium-review.googlesource.com/622112Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#496534}
-
Justin Carlson authored
Implementing this also obsoleted the updated time mechanism for tracking whether or not our configuration is up-to-date in CUPS. This involved a lot of fixups to remove the last_updated field from the Printer object. Bug: 757595, Change-Id: I7c75f9ce6a3d16e8bba2a9e6cf0c2e7cf7a09358 Reviewed-on: https://chromium-review.googlesource.com/627342Reviewed-by:
-
Erik Luo authored
Enables the use of 'url:foo.js' style queries in the console filter bar, once exclusive to Network panel's filter. Also brings over the ability to make negative queries: -foo foo -/bar*/ Screenshot: http://imgur.com/a/RAPUP Bug: 685283 Change-Id: Ib79f68649df92714740aea1f1c36eeb1331f19cc Reviewed-on: https://chromium-review.googlesource.com/625236Reviewed-by:
-
John Abd-El-Malek authored
BUG=729848 TBR=yzshen@chromium.org Change-Id: I23d6f6313309668abe5ea510a1b4055dabf519c4 Reviewed-on: https://chromium-review.googlesource.com/627383 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#496531}
-
Matt Giuca authored
This large comment is from 2014 and is a bit confusing, as it goes to great length to justify behaviour that is mandated by the spec. The new version references the spec, makes the examples clearer, and links to a bug for ongoing work. Bug: 351639 Change-Id: Idc726476470c730fbccf983b78be15932f7dcd27 Reviewed-on: https://chromium-review.googlesource.com/625555Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#496530}
-
Reilly Grant authored
This change adds a connection error handler to the URLLoaderClient pipe bound to the ThrottlingURLLoader. If this pipe unexpectedly closes before the OnComplete message is received then the request is cancelled with net::ERR_FAILED. This mirrors the behavior of ResourceDispatcher when the ResourceHostMsg_SyncLoad IPC fails without returning an error code. This condition happens when a request is cancelled by the browser process and the SyncResourceHandler or MojoAsyncResourceHandler is unexpectedly destroyed. Until PlzNavigate ships this failure can only be signaled for sync requests as navigation loads expect to be able to be cancelled without signaling any failure. Bug: 756751 Change-Id: I0ac8498ad38f27b50b64e1a13e6af2c6883b2f35 Reviewed-on: https://chromium-review.googlesource.com/621949Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#496529}
-
Tien-Ren Chen authored
There is little advantage from this extra layer of indirection. Just remove it to make GraphicsLayer implements WebContentLayerClient directly. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I36e33a475942f6902b77dd4a92bf31579f227879 Reviewed-on: https://chromium-review.googlesource.com/616204 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#496528}
-
Alex Newcomer authored
On close the launcher should animate to the shelf height and the contents of the launcher should shift their opacity to 0. In side shelf mode the launcher has a different animation, the whole app list shifts in opacity to 0 with no movement. Bug: 754072 Change-Id: I245b4fa8b5dd26644d87b5f5717df73fc7dc3742 Reviewed-on: https://chromium-review.googlesource.com/619596Reviewed-by:
-
Han Leon authored
This CL changes device::SerialConnection to hold a base::WeakPtrFactory member rather than inherit base::SupportsWeakPtr<> to avoid the subtle use-after-destroy issue: 1. SerialConnection dtor starts, destroyes its' device::mojom::SerialIoHandlerPtr |io_handler_| member. 2. The SerialIoHandlerPtr dtor triggers some one callback XXX wrapped by ScopedCallbackRunner to run. 3. The callback XXX was actually bound with a weak ptr of SerialConnection, at this time point the parent class SupportsWeakPtr's dtor has not been triggered yet so that the weak ptr is still in a valid state, although we are already inside the execution context of SerialConnection dtor. A base::WeakPtrFactory member at the end of member list will be destroyed immediatelly once entering SerialConnection dtor, thus in the above step 3 the bound weak ptr should be identified as invalid so that callback XXX won't be called at all. This is the expected behavior. BUG=757756 Change-Id: Ib73ac55dcfba250c4f8b96fb9e3d3e85490ea9a0 Reviewed-on: https://chromium-review.googlesource.com/626197Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#496526}
-
Piotr Swigon authored
Because it's less LOC and now with JUnit4 we can. Change-Id: Ia7408e85ee8dc73e1f24cea65690103bf015fb7a Reviewed-on: https://chromium-review.googlesource.com/624830Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#496525}
-
Scott Violet authored
. the cursor position needs to take into account the ui_scale. Aura expects this behavior, so that without it we end up with a mismatch in Env::last_mouse_location() where it can jump around. . WindowEventDispatcher may end up converting the coordinates of LocatedEvents. This is only applicable to local coordinates, not the root coordinates. BUG=726865 TEST=covered by tests Change-Id: I4750b974508b16a04c528ff02ac96d348ec0929a Reviewed-on: https://chromium-review.googlesource.com/627656Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#496524}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/267641a90cb1..a184ac7e0cdb $ git log 267641a90..a184ac7e0 --date=short --no-merges --format='%ad %ae %s' 2017-08-22 bsalomon Revert "Revert "Revert "Add GrTextureOp and use to implement SkGpuDevice::drawImage[Rect]() when possible""" 2017-08-22 herb Fix poor handling of nullptr for new blur code 2017-08-22 enne Don't validate() in ~SkPathRef 2017-08-22 brianosman Add GrPrepareCallback, always run at the start of flush 2017-08-22 scroggo Make haveDecodedRow return void Created with: roll-dep src/third_party/skia BUG=749147 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I3c535e2c947d75d30affe0569f30097dfdb9f035 Reviewed-on: https://chromium-review.googlesource.com/627634Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#496523}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/ed2f2769bf11..32489a0eb4b5 $ git log ed2f2769b..32489a0eb --date=short --no-merges --format='%ad %ae %s' 2017-08-22 rharrison Bypass asserts in string [] operator for empty strings 2017-08-22 janeliulwq Corrected the error setting after calling FPDF_LoadDocument() Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I1dd44e605cf060ac80ae82beb6b5819971583ff0 Reviewed-on: https://chromium-review.googlesource.com/627620 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#496522}
-
Karan Bhatia authored
Currently when an enabled extension is blocked by ManagementPolicy::UserMayLoad, it is unloaded without its preferences being removed. Also, ExtensionPrefs shows the state of such extensions as enabled. This can lead to bugs where unloaded policy blacklisted extensions can have side-effects. Also, ManagementPolicy::UserMayLoad is not checked while enabling a disabled extension. This can cause blacklisted extensions to become enabled. This CL brings the following changes: - A new disabled reason DISABLE_BLOCKED_BY_POLICY is introduced. - When an enabled extension fails ManagementPolicy::UserMayLoad, it is disabled with DISABLE_BLOCKED_BY_POLICY. - Hence extensions which fail UserMayLoad checks are now visible to the user on chrome://extensions page, instead of silently remaining installed. - They are re-enabled automatically when they satisfy the policy. - ManagementPolicy::MustRemainDisabled also checks ManagementPolicy::UserMayLoad now. This leads to cleaner code at call sites and helps avoid inconsistent checking of the management policy. - Some cases in which disabled policy blacklisted extensions could be re-enabled are fixed. BUG=709264, 754448, 461747 TEST=Install EvilProxy (https://chrome.google.com/webstore/detail/evilproxy/jndopnbadbiahpmbnfadmmadjhpjbmon). Ensure navigating to tools.google.com causes a 404. Add the extension to policy blacklist. Ensure navigating to tools.google.com works fine. Restart browser. Ensure navigating to tools.google.com works fine. TEST=Install EvilProxy. Ensure navigating to tools.google.com causes a 404. Close browser. Add the extension to policy blacklist. Start browser. Ensure navigating to tools.google.com works fine. TEST=Install EvilProxy. Add the extension to policy blacklist. Close browser. Remove extension from policy blacklist. Start browser. Ensure navigating to tools.google.com causes a 404. TEST=Install EvilProxy. Add the extension to policy blacklist. Ensure navigating to tools.google.com works fine. Remove extension from policy blacklist. Ensure navigating to tools.google.com causes a 404. TEST=Install EvilProxy. Disable the extension from chrome://extensions page. Add it to policy blacklist. Ensure it can't be enabled from chrome://extensions. Change-Id: Ia25d7a2a49bd1c006a435c26397c834ffa5ae632 Reviewed-on: https://chromium-review.googlesource.com/611662 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496521}
-
Mark Pilgrim authored
Make AppCacheStorageImpl::ScheduleSimpleTask take a OnceClosure Bug: 714018 Change-Id: I919bde1c5cc4117f4978aec9ed22f8a07d137218 Reviewed-on: https://chromium-review.googlesource.com/627198 Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> Reviewed-by:
-
Robert Hogan authored
The testcase no longer fails due to unrelated changes, so this is a preventive measure - it was an oversight not to add it when landing the original CL. Bug: 756410 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3f653b17bc3e02b382171f4e2f20701cff30e6e4 Reviewed-on: https://chromium-review.googlesource.com/624165 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Cr-Commit-Position: refs/heads/master@{#496519}
-
