GitLab

These metrics have been useful from time-to-time over the years to
answer questions about how users zoom; most recently in the last 2
weeks.

Bug: 975221
Change-Id: If9e251c0e4396b5914e2e9a3d322f1fc6cfe0476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678380Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Auto-Submit: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681309}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/424fc331f3be..9a69857888af


Created with:
  gclient setdep -r src-internal@9a69857888af

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I7d18872ae2b2f88f4c9c5e1c3b8d45c97029ecbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720989Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681308}

Bug: 986380
Change-Id: Ib4ed402900f28036d94bb36d8660f895f44fcc6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715666Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681307}

This change adds UMA tracking for SMSReceiver API to give us data on friction
and performance of UI decisions made for this feature. Because there was some
disagreement between adding the user interaction after a successful call, this
will give us a better idea of what kind of impact the UI has or doesn't have.
Specifically it will track the following.

1. Duration between the time a SMS is successfully received and when the user
   selects Continue.

2. Duration between the time a SMS is successfully received and when the user
   selects Cancel.

More details on metrics and its motivation here in the API Design Doc [1].

[1] https://docs.google.com/document/d/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0/edit#heading=h.bbporvvwzoo7


Bug: 976332
Change-Id: Id689c9937c17a9dc930cce89ba0965e8f20a96d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716961Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681306}

Sometimes the doodle height on the NTP is changing. If this is occurring
while the omnibox is focused, the stored offset of the collection view
is too big and upon unfocusing the omnibox the NTP is too much scrolled.

Bug: 986763
Change-Id: Ia2c641f547f6bb8780143f4edf5a94f09b9bc5bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720814
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681305}

Two WPT autorolls and no joy on their expectations. Mark these tests a
Pass Failure on all bots to green the chromium tree webkit tests.

No-try: true
No-presubmit: true
Bug: 987915
Change-Id: If7c28237cdd7a10d48d058da864279332308edeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720840Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681304}

Current, we assume that |ShouldWalkCheck| wouldn't change during the
lifetime of |ScopedPaintTimingDetectorBlockPaintHook|. It turns out
that it can, for unknown reason. A temporary fix is to redo
|ShouldWalkCheck| at the close of the scoped hook.

Bug: 983860

Change-Id: I524a1a6281107ac87fc5a517009cd93be7426574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719448Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681303}

* Ensures omnibox popup shortcuts egtests compat with EG2
* Adds a new EG2 target and adds shortcuts tests to ios_chrome_eg2tests
* Cleans up shortcut egtest deps

Bug: 866147
Change-Id: I3c004889b230e7590a62d5f4ab062cb6103456f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698420
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681302}

We see autofill tests take between 30 and 30000 milliseconds and
that is probably disk I/O. Switching to a memory database makes
the tests much faster, though it's unclear what the cause of the
30 second tests is.

Change-Id: Ie4a7d331f6b2dead3649e406a039ea68ce188990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718325Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#681301}

Snapshots are normally captures in MainController's
|-prepareTabSwitcher|.  When links are opened via the context menu in
a different ApplicationMode, it is opened without entering the tab
switcher and the snapshot for the previous WebState might be stale.

Bug: 978400
Change-Id: Ifaf1b5dec80e2a139cdbe3a0f34ae51f3fae54c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716039
Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681300}

On Android, input events are delivered asynchronously. Because of that,
onClick listeners may be invoked after the fragment has been removed or
Chrome has been backgrounded. When Chrome is backgrounded, any fragment
transactions will fail to avoid state loss. This CL adds checks to bail
out early from click listeners if the parent fragment isn't resumed or
the state has already been saved. Also, calls to commit and dismiss are
replaced with commitAllowingStateLoss and dismissAllowingStateLoss.

Bug: 987884
Change-Id: I96494eaf0370934f2c502cfd5e768c6e8ec30c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718951
Commit-Queue: Theresa <twellington@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681299}

permission_types.h should own the helper method used for generating a
vector of all PermissionTypes. This is done dynamically to reduce
the burden of updating this list. It is stored in a static container
so that it can be lazily generated as needed. Additionally, use of
dynamic memory guarantees uncomplicated destruction while static
storage does not consider this a "leak".

Bug: 986605
Change-Id: I7bcaafe9cf94d31a3ae796c97f754da643e3c572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716946Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681298}

This CL creates a new virtual suite that runs web tests with the audio
service running on a sandboxed utility process.
It also adds expectations for audio-related tests already in expectations
files.

Bug: 976696
Change-Id: Ia25ff740fb4735db0d3ae4ea9d08787e6818da5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715811
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681297}

Early conversion to double resulted in DocumentTimeline returning a
different value than the requestAnimationFrame timestamp. By preserving
the full precision time delta we can use the exact same conversion as
the requestAnimationFrame timestamp.

Bug: 986974
Change-Id: I508330a168bf6523b1ec3912efb24159b876f6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719853
Commit-Queue: Robert Flack <flackr@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681296}

This reverts commit 69b9b238.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1719859 depends on this cl.

Original change's description:
> Implement GetCurrentFramebufferDamage().
> 
> GLOutputSurfaceBufferQueue::GetCurrentFramebufferDamage() didn't get
> implemented in https://crrev.com/c/1685909. This caused some interesting
> graphics glitches with OOP-D enabled.
> 
> Bug: none
> Change-Id: Idb0d8e43c36e5f925f4c475a2010660b10c48f97
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702147
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#677458}

TBR=dcastagna@chromium.org,kylechar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: none
Change-Id: I56334ee6d3d261dfd5b84d8fa5b8e337770b3792
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720909Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681295}

In this CL I've conditionally disabled new DCHECKs added
in crrev.com/c/1593403. Although the outline updates
should be safe, we should still fix this properly
and enable these DCHECKS universally.

Bug: 987836
Change-Id: I04d4e79652c2556ca058cb959b859c03a9415d10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719772Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681294}

Fixing a variable typo and adding
SigninPromoViewMediatorTest::AddDefaultIdentity().
Related to: crrev.com/c/1718370

Change-Id: I4532e824b5ab540a7d42eaaaeb271e52e16200cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717303
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681293}

On iOS 13, fallback colors aren't used anymore.
Changes iOS 12 selected text color to the new one.

Bug: 987174
Change-Id: Iab24298207babfdd306516a23dd9c51b8fc9c46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719354
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681292}

This CL triggers the unmasking dialog when a user in the Manual
Fallback dialog selects a masked server card, and uses the results to
populate the field in the form.

Change-Id: I350cde87eb412ab709c4eca589e62ed3429ef920
Bug: 969194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686674
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#681291}

Build with GCC and libstdc++ is failing in files using tab_sharing_ui.h
as it has a ScopedObserver of a TabStripModel without including it
in advance.

Bug: 819294
Change-Id: I4b12073484f65ad2bb873119daa748245296d282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713526Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#681290}

MDC font was defaulting to system font of size 14, this is kept the
same. But for some reason the font they returned couldn't be recreated
with a semibold trait. So it was switched to a normal system font of
the same size.

Fix a bug when a tab was instantiated without being selected. This
was caused by creating the views after they were being styled.

An early return to the |selected| setter was added to simplify that
method.

Bug: 987169, 976817
Change-Id: I10c97a5a8a6f155f0aac21a7f2bf5ab16ded56a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718949
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681289}

Allowing testers to setup responses with a byte array body
instead of a String body is important because it reflects
the true range of values that can be returned in the body of
a response.

Bug: 669707
Change-Id: I96f385bde0aa592caf60eee763bd26d0ccd2eba4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715173
Commit-Queue: Benjamin Kirchman <kirchman@google.com>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681288}

... from modules/mediastream/video_track_adapter_settings.h

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ifd92202da1df04bbd49ceec13865e7c38f546c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715884
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681287}

https://android.googlesource.com/platform/external/perfetto.git/+log/b3891c1e6e90..d7e4835d4345


git log b3891c1e6e90..d7e4835d4345 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 treehugger-gerrit@google.com Merge "traced_probes: ftrace page header parsing: turn "overwrite_count" into a bool that it effectively is"


Created with:
  gclient setdep -r src/third_party/perfetto@d7e4835d4345

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I4112e8fa24296d8d993eccdce24d80382917abc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720731Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681286}

Replaces the "$1" in the About page EOL string with the device type.

Bug: 987877
Change-Id: I79be75919f623961abb5e3f8aeab114b9c8afecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719932
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681285}

Neither wallpaper nor account image can be changed in guest mode,
so hide the entire "Personalization" section.

However, ensure the "Appearance" section is still visible in browser
settings, since font size can still be changed.

Screenshots:
- OS settings - http://screen/U7f46skHwXw
- Browser settings - http://screen/kAEEMMpYML7

Bug: 972152
Change-Id: I95196b506a155d98fb8315ab302e9dc5f847e1a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719468Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681284}

Change GN output directory to start with out/, since the other way is
not recommended, leading to confused presubmit in some cases.

Bug: None
Change-Id: I645d9e2bd8f41dc2836492f6d1d58a8aaeab7e4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718969Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Auto-Submit: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681283}

Also clean up some of the platform conditions.

Bug: 987970
Change-Id: Ie15353400163599dc97bc15c2658650c8d1c0ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720636
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681282}

This CL adds 'EffectiveAppearance' field, which
stores a value same as 'Appearance' at this moment, and makes
'Appearance()' and 'HasAppearance()' private.

'EffectiveAppearance' is set in LayoutTheme::AdjustStyle().
Rendering code in Blink should refer to 'EffectiveAppearance'
instead of 'Appearance'.

This CL also reduces the size of the Appearance field from
6 bits to 5 bits. crrev.com/641985 reduced the number of
ControlPart items from 42 to 25.

The plan is that 'Appearance' field stores computed-value of
-webkit-appearance, and 'EffectiveAppearance' will store
used-value.

This CL has no behavior changes.

Bug: 965432, 981720
Change-Id: Ifee508c1c8d9fd7f721f0fcc1c4c5c0a52d244c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687573Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681281}

The following methods had no callers and are beng removed
by this CL:

- GetConstraintMinAsDouble()
- GetConstraintMaxAsDouble()
- GetConstraintValueAsString()

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I010896801978cce6b03dd6020ef9556708124d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715408
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681280}

Implements a pref that represents the onboarding experience state.
It is updated every time a new PasswordStore instance is built.
The number of saved credentials is used as a condition for showing the onboarding,
as well as the current state itself.

Bug: 983445
Change-Id: I5ddf0869843bc71f84db4cb04c3b95fcd530bb65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708074
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681279}

https://webrtc.googlesource.com/src.git/+log/d7ab56d4c20c..378cae2543f5


git log d7ab56d4c20c..378cae2543f5 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b6340b51..94041439 (681123:681228)


Created with:
  gclient setdep -r src/third_party/webrtc@378cae2543f5

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Id38822f1945937705d2b887e6ea435be2a87665d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720729Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681278}

I'm working on a more reliable method to upload files for another project,
and was looking into using that in the DownloadFeedbackService as well.
I expect these metrics to be important if that pans out, so extend the
lifetime of these metrics by a little bit.

Bug: 969929
Change-Id: I1d26b502ad76cf4aa753344a19b0bd2e96c83a6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719653
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681277}

This method (from media_stream_constraints_util.cc|h) is used only
within media_stream_constraints_util_audio.cc.
This CL moves it to the anonymous namespace in this file.

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Idde550276ce75c12e8e2ddc203b1d889ae1588b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715665
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681276}

The class has not references left in content/, and can move
moved out of the Blink exposed API as long as forward refenrences
are used in processed_local_audio_source.h.

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I6d9d9370aa8c0ea3aa6b23923919896de12d9d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715664
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681275}

This is a follow up of [1].

[1] https://crrev.com/c/1710237

BUG=704136,923394
R=guidou@chromium.org

Change-Id: I34829b50b263f47cd8d4b6fc9b41df60b57ede0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715164
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681274}

This removes the global defines

    FULL_SAFE_BROWSING
    SAFE_BROWSING_CSD
    SAFE_BROWSING_DB_LOCAL
    SAFE_BROWSING_DB_REMOTE

and moves them to the buildflag system instead. They live in the
new (generated) buildflag header components/safe_browsing/buildflags.h
which is generated by //components/safe_browsing:buildflags.

No behavior change.

Bug: 961767
Change-Id: Ifdc78c21ef4c2e2ab8fc9f48461734a559794333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719289Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681273}

This CL makes sure that the Kerberos system daemon is not started
unnecessarily if there are no Kerberos accounts.

BUG=chromium:963824
TEST=Log into Chromebook with enabled KerberosEnabled policy, but no
     existing accounts (neither through KerberosAccounts policy nor
     added manually). Open ssh console (e.g. CTRL + ALT + -->), verify
     that 'ps -A | grep kerberos' does not show a Kerberos process.

Change-Id: I6b8b4cfd1f50a6b9abc97b8b72fa322fdb83cfc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720770Reviewed-by: A Olsen <olsen@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681272}

This CL is large because it moves various files in
content/renderer/media/{stream,webrtc} to blink.
These files are being moved in one step here because it'd not
be easy to do it incrementally, as of other prior steps.

The following files got moved:

  - content/renderer/media/stream/audio_service_audio_processor_proxy.h
  - content/renderer/media/stream/media_stream_audio_processor.h =>
    third_party/blink/public/platform/modules/mediastream/

  - content/renderer/media/stream/media_stream_constraints_util_audio.h
  - content/renderer/media/stream/processed_local_audio_source.h =>
    third_party/blink/public/web/modules/mediastream/

  - content/renderer/media/webrtc_audio_device_impl.h
  - content/renderer/media/webrtc_audio_device_not_impl.h =>
    third_party/blink/public/web/modules/webrtc/

  - content/renderer/media/stream/media_stream_constraints_util_audio.cc
  - content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
  - content/renderer/media/stream/processed_local_audio_source.cc =>
    third_party/blink/renderer/modules/mediastream/

  - content/renderer/media/webrtc_audio_device_impl.cc
  - content/renderer/media/webrtc_audio_device_not_impl.cc =>
    third_party/blink/renderer/modules/webrtc/

  - content/renderer/media/stream/aec_dump_agent_impl.cc
  - content/renderer/media/stream/aec_dump_agent_impl.h =>
    third_party/blink/renderer/platform/mediastream/

  - content/renderer/media/stream/audio_service_audio_processor_proxy.cc
  - content/renderer/media/stream/media_stream_audio_processor.cc =>
    third_party/blink/renderer/platform/exported/mediastream/

Remarks:

1) Most of the changes in this CL are straightforward, eg namespace or path inclusion
  adaptation, add/replacing "bridge" blink::Platform methods, etc. However, one change
  might deserve some reasoning.

  aec_dump_agent_impl.cc|h: The class AecDumpAgentImpl inherits from mojom::AecDumpAgent.
  However, in order to do this, we would need to include aec_dump.mojom.h, which is not
  allowed for Blink API headers - instead aec_dump.mojom-shared.h is enforced.

  To avoid including aec_dump.mojom.h from a (temporary) blink API headers, the CL factors
  out the "Delegate" inner class out of AecDumpAgentImpl into its own header, and make it
  part of the blink API (aec_dump_agent_impl_delegate.h).
  aec_dump_agent_impl.cc|h got moved to blink/renderer/platform, and include
  aec_dump.mojom-blink.h without problems.

2) The following tests got blink::TestingPlatform derived classes
  added locally, in order to implement the needed factories:

  - content/renderer/media/webrtc/rtc_peer_connection_handler_unittest.cc
  - content/renderer/media/stream/processed_local_audio_source_unittest.cc
  - third_party/blink/renderer/modules/mediastrea/media_stream_constraints_util_audio_test.cc

  By the time the first two files above get moved to Blink, the files should
  share the same derived blink::TestingPlatform implementation, factored out into a helper.
  TODO added.

3) Data types and APIs that are not allowed in Blink, eg base::Bind{Once,Repeating}.
  std::vector and std::string were forcibly allowed at this stage, and will be remove
  in a follow up.
  TODO added.

4) Most of the APIs added as public blink APIs here will eventually get moved again to
  blink/renderer/platform or blink/renderer/modules. It is just a matter of its existing
  clients in //content get Onion souped.
  TODOs added.

BUG=704136

Change-Id: I7799c94a441c49ade6f19518879b1ee0e5d37882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710237
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681271}

Using wpt-import in Chromium 8d139660.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
f050694a "Restrict Shape Detection API to Secure Contexts"
14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-writing-modes

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id455468aad80c389018c4d62aa90aff902db6723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719113Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681270}