- 24 Aug, 2018 40 commits
-
-
David Benjamin authored
This is leftover from https://codereview.chromium.org/2715513004. This will remove HttpAuthController's vtable and hopefully decrease code size. Change-Id: I61dbc388f006234a64cb0a87d6475c12ba6b724e Reviewed-on: https://chromium-review.googlesource.com/1187731Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#585879}
-
Xiaohan Wang authored
- Add TriStateSiteSettingsPreference, a Preference that has three RadioButtonWithDescription, corresponding to Allowed, Ask and Blocked state respectively to be used for site settings. - The title of the 3 radio buttons are fixed: "Allowed", "Ask first", and "Blocked". - The descriptions of the 3 radio buttons are declared in ContentSettingsResources. - SingleCategoryPreferences is updated to support both the toggle and a new tri-state setting, only one of which will be shown. When the tri-state setting is shown: * Hide the read_write_toggle. * Initialize the TriStateSiteSettingsPreference * Listen to setting change in the TriStateSiteSettingsPreference - Update PrefServiceBridge to be able get/set the ContentSetting, instead of getting/setting a boolean. Screenshots of the new UI at https://photos.app.goo.gl/rgkh53VNkesAGXKa7 TBR=raymes@chromium.org Bug: 854737 Test: Manually tested. Change-Id: I1a19474960bec9b5677ec1dc8408ec487248787b Reviewed-on: https://chromium-review.googlesource.com/1179461 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#585878}
-
Evan Stade authored
The wrong version of this DCHECK slipped by in b2270914 Bug: 640365 Change-Id: I9e1922c537851be269f483e98878bb2d200e9260 Reviewed-on: https://chromium-review.googlesource.com/1187712Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#585877}
-
Eliot Courtney authored
free resize it. Bug: b/113151342 Test: unit test + opened a PIP window in tablet mode and was able to Change-Id: Ic72478a35c5726e7ffa2e89fd61243b87f4bf4d7 Reviewed-on: https://chromium-review.googlesource.com/1188404Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#585876}
-
Jacob Dufault authored
Bug: 877047 Change-Id: If77842d8f90cfc0a09420c82745d82a1b0a2030d Reviewed-on: https://chromium-review.googlesource.com/1187407Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#585875}
-
Jonathan Metzman authored
Allow fuzzers to opt out of using AFL's forkserver. Also opt v8 fuzzers out of using it. v8 fuzzers start threads when LLVMFuzzerInitialize is called. This breaks AFL's forkserver because one cannot fork after a thread has started. This is a speculative fix for crbug.com/875199 Bug: 797798, 875199, 796680 Change-Id: I12e8408afaba9c9ca435d031e4263fcc2f80c67f Reviewed-on: https://chromium-review.googlesource.com/1187835Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585874}
-
Eliot Courtney authored
overview. It was visible but not included in the overview. Bug: b/112668590 Test: Added unittests + put a window into PIP mode then started the Change-Id: I245c6a9eb05fb08fca68619b35261967d1becea2 Reviewed-on: https://chromium-review.googlesource.com/1177207Reviewed-by:
-
Dominik Röttsches authored
HarfBuzzShaper asks FontFallbackIterator whether a full hint list will be required. A full hint list is only required when determining which parts of a segmented font need to be downloaded. A segmented font face is a face that is composed out of multiple @font-face rules with different unicode-range: descriptors. The fallback characters need to be compared against the unicode-range: values. In other cases, only the first character that has a definite script is useful for fallback. A segmented font is a set of @font-face declarations with the same family name, but different unicode-range: descriptors. The order of performing font fallback with segmented fonts in the stack looks as follows: * We're going through the font stack font family by font family. * When selecting one family, we have to check whether it is a segmented font or not. * If it is segmented, we go sequentially through the different @font-face declarations, with differing unicode-range descriptors in reverse order of declaration. * Once we have determined that there is nothing more to shape with this segmented font family, we continue to the next family. The important situation regarding hint chars is as follows, in an example: 1) The first character of the remaining text to be shaped does not need the first segment of a @font-face, but only uses the second. 2) The second character needs the first segment of the @font-face, but since we go through them in order, we are not going to go back and find it anymore and will shape this character with the wrong font. If, at step 1 hint chars are collected, all @font-face's from a segmented font are selected, as all characters are compared against all unicode-ranges. fast/css/font-face-unicode-range.html was transformed into a inspector-protocol/layout style test and one case was added to check that the above mechanism works after falling back from a primary font. Bug: 848295 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I38ddc196c02d92bb4608928772edee07203f98e7 Reviewed-on: https://chromium-review.googlesource.com/1172662 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#585872}
-
David Bokan authored
These tests: virtual/threaded/fast/events/pinch/pinch-zoom-into-center.html virtual/threaded/fast/events/pinch/pinch-zoom-pan-position-fixed.html pinch-zoom-pan-within-zoomed-viewport.html were breaking because Mac doesn't support touch events and the pinch was being done using touch. I've changed to use a touchpad source as this doesn't affect the meaning of the tests as well as some minor cleanups. While here, I also rewrote a number of tests to use gesture-util.js and the async/await style which is more readable and easier to produce non-flaky tests. TBR=nasko@chromium.org Bug: 854199,873435,877494,877361 Change-Id: I19f6e199fea694013d3dceaeb32c881059301f1d Reviewed-on: https://chromium-review.googlesource.com/1185238 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585871}
-
Tanja Gornak authored
Having the deprecated version of the InvalidationServiceProviderFactory will allow to migrate every sub-project which depends on invalidations individually. Follow-up CL introduces new factory, which internally will create the invalidation service based on FCM: https://chromium-review.googlesource.com/c/chromium/src/+/1185093 Bug: 801985 TBR=skuhne@chromium.org, emaxx@chromium.org, fukino@chromium.org, msarda@chromium.org, xiyuan@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I84c64366017de58bdfe060e59b8d54e8d2153a8d Reviewed-on: https://chromium-review.googlesource.com/1185014 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#585870}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/195b9510dbe5..8dabf7bda37f git log 195b9510dbe5..8dabf7bda37f --date=short --no-merges --format='%ad %ae %s' 2018-08-24 bmgordon@chromium.org lib/constants: Change ndk_translation ACLs Created with: gclient setdep -r src/third_party/chromite@8dabf7bda37f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I69ef6979718ca0c1209cff3623af4755d5a34d3c Reviewed-on: https://chromium-review.googlesource.com/1188503Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585869}
-
Lei Zhang authored
Instead of taking the dimensions as two separate parameters. Change-Id: I6a92aa4c21d932f131c0aae39860edfd9b642c2b Reviewed-on: https://chromium-review.googlesource.com/1185371Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585868}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/60e5b43e85ec..1118cfdbdcc2 git log 60e5b43e85ec..1118cfdbdcc2 --date=short --no-merges --format='%ad %ae %s' 2018-08-24 kjlubick@google.com Update Pixel 2 XL to Android P Created with: gclient setdep -r src/third_party/skia@1118cfdbdcc2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Icc1bb43d82953e117b475b84c3db830e61a01fd1 Reviewed-on: https://chromium-review.googlesource.com/1188504Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585867}
-
Donn Denman authored
Extends the CS component to have an API for preferences, with a call for the Unified Consent use-case. Extends Contextual Search to record the previous user setting, and use it for throttling of server requests when needed. Details in https://go/cs-unity-throttle. The initial integration with Unified Consent calling this API is in a separate CL. Also provides some minor cleanup by adding definitions for the TTS enabled and disabled setting strings. BUG=825428 Change-Id: I187e903a30cfb671aeeaba00ce6fb578219c17a2 Reviewed-on: https://chromium-review.googlesource.com/1157869 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Ben Kelly authored
The spec requires rejecting cache.addAll() with an InvalidStateError. This CL improves the exception message by describing which requests were found to be duplicates. If duplicate rejection is turned off via the feature flag then the list of duplicates will be reported to the web console. Bug: 720919 Change-Id: I7a9faaa45f8ce2a8b2b3b4006e0ae1d2b7ae8754 Reviewed-on: https://chromium-review.googlesource.com/1174659 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585865}
-
Nicolas Pena authored
This CL adds static strings for the various PerformanceEntry types by using the the make_names template. This removes the need for thread-safe copies. Bug: 852050 Change-Id: Ie37d3022c25bb354d335edebbc08e78de0ccbd7a Reviewed-on: https://chromium-review.googlesource.com/1187377Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#585864}
-
Roger Tawa authored
Bug: None Change-Id: I9370b99599f128d7379761c77ba9195be59baf71 Reviewed-on: https://chromium-review.googlesource.com/1187270 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585863}
-
Christian Fremerey authored
Bug: None Change-Id: I8e5bdafc86e9bf45e6e9fb43fb2c0b4d11abbc09 Reviewed-on: https://chromium-review.googlesource.com/1187724Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#585862}
-
Mugdha Lakhani authored
Now that we're passing BackgroundFetchRegistration with all BackgroundFetch Events, the unit tests can be simplified. Bug: 876691, 869918 Change-Id: I5137981b32666901cdc6f953b744372695b11d72 Reviewed-on: https://chromium-review.googlesource.com/1186722 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#585861}
-
Dave Tapuska authored
Make sure the type on the interface matches the IDL type. All were unsigned long in the case which maps to uint32_t. BUG=596846 Change-Id: Iecec0190018d18735d7ffe0c0521af8c7f5514f8 Reviewed-on: https://chromium-review.googlesource.com/1188606Reviewed-by:
-
yiyix authored
|registered_frame_sink_ids_to_is_connected_| and |frame_sink_elements_| saves the same information about the FrameSinkId, that is if a FrameSinkId is register and/or created. This cl removes the variable |registered_frame_sink_ids_to_is_connected_|. Bug:816802 Change-Id: Iad9c9e9819ffd44ca8aff7c7b82ad0b5852d6e8d Reviewed-on: https://chromium-review.googlesource.com/1186195Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#585859}
-
Aga Wronska authored
Information about specific demo mode configuration (online, offline) is needed to customize demo experince. This change is a followup to initial demo mode detection: https://chromium.googlesource.com/chromium/src/+/ff7f92d7c843630dcdde104421929bdecf34f637 * Consolidate DemoSession::EnrollmentType and DemoSetupController::EnrollmentType into DemoSession::DemoModeConfig to avoid confusion between the two. * Remove EnrollmentConfig::Mode member from DemoSetupController as it is redundant to demo mode configuration. * Store demo mode configuration as a preference in the local state. * Add new device mode policy:DEVICE_MODE_DEMO to represent demo devices. New mode should be passed by DMServer during online demo setup as well as used during offline setup. The ability to manually enroll device into demo domain is preserved for now. Demo mode will be recognized if either device mode is set to demo or device domain matches demo domain. Manually do offline demo setup. Manually do online demo setup with local copy of DMServer that serves new device mode. Bug: 855669 Test: Run demo mode unit and browser tests. Change-Id: I5ce9eb2c96f0ddc7a50e7ec1665e52bb9d203704 Reviewed-on: https://chromium-review.googlesource.com/1173253Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#585858}
-
Chris Lu authored
[ios] Set ClearBrowsingDataTableViewController and its NavigationController to nil immediately after completing dismiss When a URL is opened, CBD dismisses itself. Then History checks with the CBD coordinator to make sure that CBD is dismissed (nav controller is nil) before dismissing itself. Since we don't set the navController to nil before calling the completion block in dismissClearBrowsingDataWithCompletion:, the CBD coordinator thinks that it still exists so it attempts `[self dismissClearBrowsingDataWithCompletion:completionHandler];`, which then doesn't execute the completion block since there was nothing to dismiss. Video: https://drive.google.com/open?id=1A7-W5LXhjzvh4DcUQguQEv0qWC88Ncp1 Bug: 877243 Change-Id: Id2f67c934e0ef2033abc28f97bb9bf211dbb5ddb Reviewed-on: https://chromium-review.googlesource.com/1187631Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#585857}
-
Kevin McNee authored
This is a reland of be51aadb Original change's description: > Consistent touchpad pinch behaviour for app windows and webviews > > Currently, app windows (possibly containing webviews): > 1) suppress all pinch events which also suppresses the > synthetic wheel event, but not touchscreen touch events, and > 2) allow "smart zoom" on Mac which can change the page scale even > though other means of changing the page scale are suppressed. > > As a result of (1), if we have, say, google maps in a webview, a > user can pinch zoom with a touchscreen, but not with a touchpad. > > We now suppress gesture events to app windows based on whether they > cause a scale change. So now touchscreen and touchpad pinching are > consistent since the page has access to the events so that it may > implement custom pinch zoom behaviour, but unhandled events still > do not result in a scale change for the app window. Also, smart > zoom is suppressed to be consistent with other touchpad pinching. > > Bug: 725970, 874132 > Change-Id: I03dd2048002d69dc7c8a822fc727140c67d64706 > Reviewed-on: https://chromium-review.googlesource.com/1174933 > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585489} Bug: 725970, 874132 Change-Id: I23420821c1166f7b641faf672798ddac0e928ad9 Reviewed-on: https://chromium-review.googlesource.com/1187345Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#585856}
-
Hugo Holgersson authored
"... the default action MUST be to shift the document focus". https://www.w3.org/TR/uievents/#event-type-keydown As focus movement happens during keydown, once we got the succeeding keyup-event, it's safe to assert activeElement. Why not do the asserts at 'focusin' instead? After 'keyup', we're safe to send another trigger-key. (Most spatnav tests verify several focus movements). Bug: 803086 Change-Id: I6927d61a9d323f5bd3fe8a6022aef2f6eca50521 Reviewed-on: https://chromium-review.googlesource.com/1188476Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#585855}
-
Tatiana Buldina authored
Updated several error codes returned by ChromeDriver, for compliance to W3C standard. Bug: chromedriver:2552 Change-Id: Ie05b784beee8f6e9a79e4c0356e9d3c2dbce3874 Reviewed-on: https://chromium-review.googlesource.com/1187193 Commit-Queue: Tatiana Buldina <buldina@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585854}
-
Guido Urdaneta authored
This makes these utilities easier to use from other projects, which we plan to do in the upcoming Hardware Platform Extension API (see crbug.com/854636). This CL also refactors the function to get the computer manufacturer and model so that they are available as separate strings, and adds a number of style/lint fixes. Bug: 874408 Change-Id: I408151cc478ccf37a0515d17d1381115b12d9122 Reviewed-on: https://chromium-review.googlesource.com/1175781Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
This moves the |base_value_updated_| flag from the "primitive type" version of SVGAnimatedProperty to SVGAnimatedPropertyBase, and sets it in BaseValueChanged. The flag is cleared in SynchronizeAttribute. This allows some code to be simplified. It also avoids synchronizations triggered by just having created the tear-off object like in the bug. Bug: 873470 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59f30dd69286dc0799a583eb6a52c41022b0af91 Reviewed-on: https://chromium-review.googlesource.com/1188305 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585852}
-
Balazs Engedy authored
Bug: 847985 Change-Id: I2ae8ec26a2c01e2ffd1b1527cad0387c1e90f389 Reviewed-on: https://chromium-review.googlesource.com/1187104 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585851}
-
David Quiroz Marin authored
The current implementation of font.Width has a problem with RTL text with spaces. Additionally, this fix allows to update canvas textMetrics actualBoundingBox which should return the minimum bounding box that covers all strokes/ink. Bug:277215 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If8815d640836d334381072b385d7fa8474a6ec45 Reviewed-on: https://chromium-review.googlesource.com/1179244Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: David Quiroz Marin <davidqu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585850}
-
Majid Valipour authored
EffectProxy.localTime should accept undefined as its local time and treat that as meaning that the keyframe effect is not in effect. Note: This is a partial fix. We still need to make sure that any applied effect is cleared once localTime is set to undefined. This patch only ensures that when the initial value is not set, or set to undefined the keyframe effect is not applied. Test: virtual/threaded/fast/animationworklet/worklet-animation-local-time-undefined.html Bug: 870711 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2fdc716c331eb11a9b3eed524ac703f50a222a49 Reviewed-on: https://chromium-review.googlesource.com/1181935Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585849}
-
Lei Zhang authored
There are a couple places that starts with UTF8 data and converts them to UTF16 before passing them to base::Value. base::Value turns around and converts it back to UTF8. Fix some nits along the way. Change-Id: I10ad741de22aecc04b37fa633ab0033a26acc688 Reviewed-on: https://chromium-review.googlesource.com/1188033Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585848}
-
Mugdha Lakhani authored
This removes BackgroundFetchSettledFetches from blink, idl files, and the WPT tests. In a follow up CL I'll remove it from all the event dispatcher code on the browser side. This fix also makes cache_query_params optional in MatchRequests() in mojo. This is required because otherwise the mojo bindings logic crashes the renderer when we try to pass in a nullptr for cache_query_params from blink. Bug: 869918, 863016 Change-Id: Ifa933451f98f82902d8455ba5401c629c8c24811 Reviewed-on: https://chromium-review.googlesource.com/1186735 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585847}
-
Thomas Tangl authored
The eligibility for showing the consent bump is checked on every startup during the creation of the UnifiedConsentService. Two metrics for the consent bump suppress reason are added: - User turned off a sync data type - User turned off a on-by-default privacy setting Bug: 872435 Change-Id: I6187e88bebce1516aec72fd369281c34b89039be Reviewed-on: https://chromium-review.googlesource.com/1188478 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585846}
-
John Budorick authored
TBR=tapted@chromium.org Bug: 877129 Change-Id: I86a6136f304f5dde483c9b778ed1a8d058090294 Reviewed-on: https://chromium-review.googlesource.com/1187828Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#585845}
-
Nico Weber authored
The arm NEON comment was about FELightingNEON.cpp which was removed in https://codereview.chromium.org/14262015 , with the other neon code then being garbage-collected later in https://codereview.chromium.org/313303003 The file also contains a few source_sets with only header files. Since header filesa aren't compiled by themselves, that doesn't make much sense, so remove all these targets that didn't also contain cc files. Bug: 381082 Change-Id: I13a4a9ded44fa46a119574a03fe18a7f12b54cec Reviewed-on: https://chromium-review.googlesource.com/1187503Reviewed-by:
Stephen White <senorblanco@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#585844}
-
John Budorick authored
Bug: 876539 Change-Id: Ib28bf55e7213789186b8180904f7317cb5c0d8ce Reviewed-on: https://chromium-review.googlesource.com/1186542 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#585843}
-
Fredrik Söderquist authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I989622cb82e8135d387f5807723eaf0704e2bbb3 Reviewed-on: https://chromium-review.googlesource.com/1188306Reviewed-by:
-
Lei Zhang authored
Instead of creating spans from ReadOnlySharedMemoryMappings manually. Change-Id: I00a1d10eafc58e3eb8e8b6ddb31c27fdcec05643 Reviewed-on: https://chromium-review.googlesource.com/1187742Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585841}
-
Sigurdur Asgeirsson authored
Bug: 874968 Change-Id: I32c3ab375b033f64436f47cc1fa2186a5b63178a Reviewed-on: https://chromium-review.googlesource.com/1187181 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#585840}
-
