- 26 Sep, 2018 40 commits
-
-
Xiaoqian Dai authored
I accidentally delete one line code that should not be deleted. Bring it back. Bug: 887042 Change-Id: I9a6c4131eb2003888e0edd987ae7362ad847c568 Reviewed-on: https://chromium-review.googlesource.com/1247182Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594508}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74419b36e4b2..a42c3f899d04 git log 74419b36e4b2..a42c3f899d04 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dgarrett@google.com chromeos_config: Schedule with hours not days. Created with: gclient setdep -r src/third_party/chromite@a42c3f899d04 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idf4c8ede4be0606a35a611a0106c6188de2a21bc Reviewed-on: https://chromium-review.googlesource.com/1247082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594507}
-
Nico Weber authored
Bug: 101600 Change-Id: Ia497c75176cb9d01c40e371f5f8e58ba3f3713a8 Reviewed-on: https://chromium-review.googlesource.com/1246602 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594506}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2012676a..c6ab99ab Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6145b640628583d6106d5bce7925a00bf5bceaf0 Reviewed-on: https://chromium-review.googlesource.com/1246952Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594505}
-
Wenzhao Zang authored
This CL is more lightweight solution compared with the previous attempts: https://crrev.com/c/1229695 (An overkill. "no wallpaper" is not a valid UI state we'll support.) https://crrev.com/c/1187547 (A risky change. Large number of tests failed.) https://crrev.com/c/1173433 (Doesn't quite handle the "no wallpaper" case.) Bug: 874015 Change-Id: I7656856d1b631b7f6d2555f932116ea08e7d23ec Reviewed-on: https://chromium-review.googlesource.com/1237149Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594504}
-
Adithya Srinivasan authored
This reverts commit 2eeb21dd. Reason for revert: This CL is causing crashes in canary (https://crbug.com/889422) Original change's description: > [FileSystem] Remove WebFileSystem > > - Adds blink.mojom.FileSystemManager to the frame and worker > registries, allowing it to be accessed directly from > ExecutionContext::GetInterfaceProvider()->GetInterface() > - Changes ownership of blink::FileSystemDispatcher: now owned by > ExecutionContext > - Omits render_frame_id_ from ChooseEntry > - Removes WebFileSystem and content::FileSystemDispatcher > > Bug: 787281, 873661 > Change-Id: Ie41d48c5a206b5d1f387fcee3bd47bc30a708f0f > Reviewed-on: https://chromium-review.googlesource.com/1217506 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593983} TBR=kinuko@chromium.org,mek@chromium.org,pwnall@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 787281, 873661 Change-Id: Iacfc3c08d838f2258fd35603270d41beab086623 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/1246863 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#594503}
-
Suman Nelson Kancherla authored
Tested by checking the default value of "WebXR orientation sensor device" before and after the change, and it switched from disbaled to enabled, as expected. Bug: 695937 Change-Id: Ib5c3e9aee51d855740db1d6cbb9267068b411d19 Reviewed-on: https://chromium-review.googlesource.com/1244878Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#594502}
-
Thomas Tangl authored
The following changes have been made: - Add toggle in the privacy settings to allow Chrome sign-in on next startup - Add preference that propagates the toggle value on next startup - Add snackbar to relaunch Chrome - Disable Dice when sign-in is disallowed - Remove the line "Sign into Chrome is disabled by the administrator of this device" - Record a metric Signin.SigninAllowed on every startup Screenshots: https://drive.google.com/drive/folders/154_2BSPzfM8SQbiiJ8ARyUP7iNmhf8rJ?usp=sharing Bug: 888776 Change-Id: Iaa724f630d578cd4ef4449b7d658e766d7fdbdd5 Reviewed-on: https://chromium-review.googlesource.com/1245794 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594501}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5767fc042834..7a3197bae3ca git log 5767fc042834..7a3197bae3ca --date=short --no-merges --format='%ad %ae %s' 2018-09-26 robertphillips@google.com Revert "Fix bug in GM's DDL drawing mode" 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a602f9064b3e..af8b73c9e632 (3 commits) Created with: gclient setdep -r src/third_party/skia@7a3197bae3ca The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Ie45457ced6f754f2ec97b38432aa11e169bd570c Reviewed-on: https://chromium-review.googlesource.com/1246986Reviewed-by:
-
Ryan Cui authored
Tests were blacklisted because of flakiness due to crbug.com/884589. Now that it's fixed, renable these tests. Bug: 884589 Change-Id: Idc1b073c7a50636778231177488112f778d649b5 Reviewed-on: https://chromium-review.googlesource.com/1246954Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#594499}
-
Xianzhu Wang authored
In order to handle paint offset translation. Bug: 889463 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee36b15e2b823057af66298d2d13727cce12da06 Reviewed-on: https://chromium-review.googlesource.com/1246957Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594498}
-
Pavel Feldman authored
Revert "Reland "DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter."" This reverts commit fad0ee09. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter." > > This is a reland of 3321d814 > > Original change's description: > > DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter. > > > > Change-Id: Ic22c1bf38aaf8e5d3e7caabf3c686c8c45b985b0 > > Reviewed-on: https://chromium-review.googlesource.com/1244460 > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#594161} > > Change-Id: I8a33e70976a2e52b7f69c5b2d0fa4e5af3594c6a > Reviewed-on: https://chromium-review.googlesource.com/1246901 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594477} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org Change-Id: I64854d5d9f698e559619aec46b1f8de9fd56fd99 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1246597Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594497}
-
Mohamed Amir Yosef authored
When migrating bookmarks sync to USS architecture, it assumes that the bookmark model is creating only once. ManagedBookmarkServiceTest.EmptyManagedNode is creating the model twice which doesn't match the expecations of the new architecture. This CL refactor the test to make sure the bookmark model is created only once. In fact, the new scenario being tested resembles reality a lot closer, since keyed services are never destroyed during the lifetime of a profile. Bug: 516866 Change-Id: I4a966270cc6bfcbdb7e1c87a096fea6a81e4b1b4 Reviewed-on: https://chromium-review.googlesource.com/1243075Reviewed-by:
-
Matt Reynolds authored
Vendor and product IDs are 16-bit values used to identify USB and Bluetooth devices. Depending on the platform, they may be reported as integers or strings. This CL modifies all places in Gamepad where device IDs are stored as strings or signed integers to instead store them in a minimum-width integer unsigned type (uint16_t). Similarly, HID usage pages and usage numbers are defined to be 16-bit values. The constants holding these values are changed to uint16_t. In a future CL, Gamepad device ID and HID constants will be pulled out of the platform-specific data fetcher implementations and placed in a common header. BUG=786250 Change-Id: I30a0841db91008802331939a86a7b6c3c5f58586 Reviewed-on: https://chromium-review.googlesource.com/1102099 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#594495}
-
Liquan(Max) Gu authored
According to the spec (https://html.spec.whatwg.org/multipage/browsing-the-web.html#read-media), "Then, the user agent must act as if it had stopped parsing", so we mark DOM-interactive to Media Document when finishes parsing. Bug: 845385 Change-Id: I825409e9cf4c8d11f1f9233844492cc3a0bebe9a Reviewed-on: https://chromium-review.googlesource.com/1239516Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594494}
-
Manas Verma authored
Before, the promo title would be different depending on whether or not the user is signed in — "...sign in and turn on sync." vs "...turn on sync." Now with the new DICe UI, promo titles will not include "sign in and ". So regardless of whether the user is signed-in, the promo title will now be "To use your cards on all devices, turn on sync." Bug: 872825 Change-Id: I5de9061ac8ad5771f803ba4f66969338746256a1 Reviewed-on: https://chromium-review.googlesource.com/1246363Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#594493}
-
Khushal authored
This trace event was removed in [1] but is needed by telemetry scripts to measure the decode time for images in perf tests. NOTE TO PERF SHERRIFS A regression in blink_perf.image_decoder benchmark is expected from this change since it restores this benchmark. R=chrishtr@chromium.org Bug: 881192 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I100082d30f2ebed4c8d7efa91a22c4670d4c2492 Reviewed-on: https://chromium-review.googlesource.com/1246272Reviewed-by:
-
Paul Miller authored
This reverts commit ef70c85e. Reason for revert: WebView now supports permanent-consistency. BUG=866722 Original change's description: > WebView: Ignore permanent-consistency experiments > > Android WebView currently treats permanent-consistency experiments > (which are intended to retain their group assignments across runs) as > session-consistency (which are intended to be randomly assigned on each > run). It's safer to not apply permanent-consistency experiments to > WebView at all, to avoid mistakes. > > BUG=866722 > > Change-Id: I9d501437718d934c2a59b95335c787302ce758e7 > Reviewed-on: https://chromium-review.googlesource.com/1148991 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Paul Miller <paulmiller@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578070} TBR=changwan@chromium.org,holte@chromium.org,paulmiller@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866722 Change-Id: Ifd00450fbba1afc1db619109cf918ef75cbcf84f Reviewed-on: https://chromium-review.googlesource.com/1237244Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594491}
-
Sarah Hu authored
use password/PIN to unlock. Bug: 879297 Change-Id: Ia4518584977f24af1b7f7f2a849d1dc598e5fc95 Reviewed-on: https://chromium-review.googlesource.com/1211804Reviewed-by:
-
Clark DuVall authored
This is a speculative fix for http://crbug.com/884638. What I believe is happening is the RenderFrame is being destroyed while the WeakWrapperSharedURLLoaderFactory is still alive, and a request attempts to use it. This seems to be happening the most when the AdDelayThrottle is enabled and is delaying ads requests, which may explain why the request is finishing after the RenderFrame is destroyed. Bug: 884638 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I66960e5c5150345e7fd59f5ab5795414ec482a71 Reviewed-on: https://chromium-review.googlesource.com/1241955Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Kevin Bailey authored
This CL describes an experiment to see if a dark blue keyword mode button will make it more visible and attention-getting. Bug: 883901 Change-Id: Ibef0b56b1a36f6debae0a446123632e173448c48 Reviewed-on: https://chromium-review.googlesource.com/1234035 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#594488}
-
James Cook authored
This makes it easier to find and consistent with ChromeShellDelegate. Also cleanup unnecessary includes in ChromeShellDelegate. I'm doing this because I may need to add a method to the delegate. Bug: none Test: existing browser_tests, manually test magnifier Change-Id: Icf0fdda4f6bea0f9fc3c281902e87fc036764950 Reviewed-on: https://chromium-review.googlesource.com/1246661Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#594487}
-
Scott Chen authored
This is to prepare for a following CL to move all the components/nux/ backend code to chrome/browser/ui/webui/welcome/. The decision to move components/nux/ to chrome/browser/ui/webui/welcome/ is based on the fact that nux is only ever going to be used in webui and exclusively within the welcome flow. Bug: 874122 Change-Id: I873047c06dc76f14c4d9affb5c3829dc0f4b5e18 Reviewed-on: https://chromium-review.googlesource.com/1229333 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594486}
-
Mathieu Perreault authored
Will only log the validity of PaymentsCustomerData's billing customer id during the full card request. This is the only moment we can be sure that the user has an account. Bug: 884689 Change-Id: I74699f14827e2954ac03480f17ac7f51b391ae73 Reviewed-on: https://chromium-review.googlesource.com/1246289 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
Justin DeWitt authored
When testing end-to-end, found some problems with the Fetcher: * POST is not accepted by the server, converted to GET (using query params) * URL was not set in the request * URL utils had a bug causing "/v1/" to be missing from the path. Bug: 867488 Change-Id: Ie60010bc45ac67923d211bce2a84248186f2dbc0 Reviewed-on: https://chromium-review.googlesource.com/1247021Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594484}
-
Alexei Filippov authored
No changes to the class except renaming from HeapTrackingOverviewGrid BUG=889545 Change-Id: I6ffd4d40e7ca9d34e37794ebcc1a631ad3b40ff9 Reviewed-on: https://chromium-review.googlesource.com/1246362 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594483}
-
danakj authored
This bool is always true, and is not used. No need to send it. Also removes the dead needs_repainting_on_restore_ from the RenderWidgetHostImpl. R=ajwong@chromium.org, dcheng@chromium.org, piman@chromium.org Bug: 419087 Change-Id: I673e5de215a9118b061478260d0dc012ae078d37 Reviewed-on: https://chromium-review.googlesource.com/1246942Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#594482}
-
Joanmarie Diggs authored
Preferring the title attribute over "submit" means that end users will potentially get a more precise name for the widget. In addition, because both Gecko and WebKit prefer the title attribute, making this change will increase interoperability. Lastly, the HTML-AAM does state user agents can use the title attribute; using "submit" is presented as an option. Note that a bug has been filed against the HTML-AAM because such options seem to decrease rather than increase the likelihood of interoperability. Bug: 889562 Change-Id: I73b4f6ed79488d7e2eb41e9ae80aabafe8590a88 Reviewed-on: https://chromium-review.googlesource.com/1246724 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594481}
-
Sarah Hu authored
Bug: 888704 Change-Id: I3d6ccd1d4d4d19377db2d0698ac403ff79cd40e6 Reviewed-on: https://chromium-review.googlesource.com/1244124 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
-
Kevin Marshall authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org TBR=sergeyu@chromium.org TBR=mmenke@chromium.org Change-Id: I470f7f3a9b10ed9c31b40b02e1f5a01a36ff25f4 Reviewed-on: https://chromium-review.googlesource.com/1246955 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594479}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c6bd073ee01..5767fc042834 git log 6c6bd073ee01..5767fc042834 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 96a1ceb171cf..3d27f2e721ed (1 commits) 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 82ea7fbce65f..0eb21d4ecadd (1 commits) 2018-09-26 mtklein@google.com refactor downsamplebitmap GM Created with: gclient setdep -r src/third_party/skia@5767fc042834 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I8193bbb55af0b0c38bcb8501b413a950b2110246 Reviewed-on: https://chromium-review.googlesource.com/1246835Reviewed-by:
-
Pavel Feldman authored
This is a reland of 3321d814 Original change's description: > DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter. > > Change-Id: Ic22c1bf38aaf8e5d3e7caabf3c686c8c45b985b0 > Reviewed-on: https://chromium-review.googlesource.com/1244460 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594161} Change-Id: I8a33e70976a2e52b7f69c5b2d0fa4e5af3594c6a Reviewed-on: https://chromium-review.googlesource.com/1246901Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594477}
-
chrome://discardsSigurdur Asgeirsson authored
Bug: 874968 Change-Id: I289e12b23e3bac144615ca5cfbe861e22404170a Reviewed-on: https://chromium-review.googlesource.com/1244497Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594476}
-
Chris Palmer authored
Bug: 888926 Change-Id: Iab0d82d272e2f24a5e91180d64bc8e2aa8a8238d Reviewed-on: https://chromium-review.googlesource.com/1246827Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#594475}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74114507769e..74419b36e4b2 git log 74114507769e..74419b36e4b2 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dgarrett@chromium.org chromeos_config: Mark eve/nocturne as important again. 2018-09-26 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-26 dgarrett@google.com chromeos_config: Mark initial firmwarebranch builds active. 2018-09-26 dgarrett@google.com chromeos_config: Create firmwarebranch builders. Created with: gclient setdep -r src/third_party/chromite@74419b36e4b2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3d93c09b8e19bb4abecc0e7f350b6c8fb57209a6 Reviewed-on: https://chromium-review.googlesource.com/1246237Reviewed-by:
-
Sergey Ulanov authored
GN now supports string_replace(), which allows to remove namespace_path TBR=dcheng@chromium.org (trivial change in //base) Change-Id: Iac8a71b6962cf48bc7a79e2f7fc62a88969f80a1 Reviewed-on: https://chromium-review.googlesource.com/1246834 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Weidong Guo authored
Bug: 884889 Change-Id: If9c93d44de4693ded68e09947d8bee1fff00c471 Reviewed-on: https://chromium-review.googlesource.com/1246151 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594472}
-
Shakti Sahu authored
This CL connects offline item with the download shelf. Some of the OfflineItemModel methods are still not implemented. Bug: 881499 Change-Id: I2f0cd71815a08bcddfca753378543749389d78db Reviewed-on: https://chromium-review.googlesource.com/1239875 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594471}
-
Kevin Marshall authored
This CL adds cookie support to the browser, so that the content layer can set and query cookies. * TestLauncher modified to give isolated /data directories to child processes. * Browsertests added to test cookie support in incognito/in-memory and persisted cases. Bug: 858853 Change-Id: Ia22e27778323e5b08fd872a2b29b4c7d879f80a0 Reviewed-on: https://chromium-review.googlesource.com/1168479Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#594470}
-
Jeffrey Kardatzke authored
Recently we updated all timeouts in cicerone to be longer because we were running into too many failures relating to timeouts and we should be much more lenient with that for now. We also avoid using the D-Bus default timeout now as well in here so the values are well known. BUG=chromium:849438 TEST=Builds Change-Id: I6fef4a25c1056d91fc4059146fa2a67094ad9a5d Reviewed-on: https://chromium-review.googlesource.com/1246784Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#594469}
-
