GitLab

Appcache::OnCorruptionDetected handling. The general idea is to delete everything and start over (reinitialize) if we notice corruption on disk. The is some pre-existing code to perform the reinitialization function, but that was only used in a more narrow case where the disk cache could not have been open. With the changes in this CL, reinitialization can be triggered pretty much at any time.
 
* The AppCacheDatabase classes uses an SQLConnecton ErrorHandler to detect catastrophic errors (corruption).

* The AppCacheStorageImpl's DatabaseTask class checks for having seen corruption during a task and initiates a heavy handed operation to delete everything and start over.

* The AppCacheStorageImpl::InitTask also checks for the presence of a stale/undeletable DiskCache when there is no SQL database. If found, that also triggers reinitialization.

* The AppCacheService class does exponential backoff to avoid thrashing the disk on repeated reinit attempts.

* The AppCacheDiskCache class's Disable() method has been modified such that all file handles get released.

TBR=jam
BUG=318544

Review URL: https://codereview.chromium.org/137493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247967 0039d316-1c4b-4281-b951-d872f2087c98

The command buffer uses ui/gfx/ types and ui/gl/ bindings, but those are
separate components from ui/ui.gyp:ui. libui.dll pulls in a bunch of dependencies
(like net/) that the command buffer doesn't need.

R=piman

Review URL: https://codereview.chromium.org/137203006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247966 0039d316-1c4b-4281-b951-d872f2087c98

We're using fontconfig in font_render_params_linux.cc without declaring a
depedency. This fixes the "Ozone ECS Linux" build.

TEST=build ui_unittests with "embedded==1 component=shared_library"
TBR=asvitkine@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/133973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247965 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247962 0039d316-1c4b-4281-b951-d872f2087c98

This broke check_licenses:

'third_party/trace-viewer/third_party/tvcm/tvcm/test_runner.py' has non-whitelisted license 'UNKNOWN'

> Roll trace-viewer DEPS 1091:1112.
> 
> R=dsinclair@chromium.org
> BUG=280375
> 
> Review URL: https://codereview.chromium.org/132333020

TBR=avallee@chromium.org

Review URL: https://codereview.chromium.org/135403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247961 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247960 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 1c8c27c1.
Broke 10 autofill tests in interactive_ui_tests on linux debug.

TBR=dgalzkov@chromium.org

Review URL: https://codereview.chromium.org/147113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247959 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247957 0039d316-1c4b-4281-b951-d872f2087c98

R=dsinclair@chromium.org
BUG=280375

Review URL: https://codereview.chromium.org/132333020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326651

Review URL: https://codereview.chromium.org/150203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247955 0039d316-1c4b-4281-b951-d872f2087c98

Right now the default mode is to make requests against the server unless
the experiment group says not to, and that may be contributing to some
unexpected load we're seeing. So this CL changes it to not do that.

It also adds some histograms to help measure the success rate and
sources of requests to the server.

[This is a resubmit of https://codereview.chromium.org/149353002 with a
compile error fixed]

BUG=335379
TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/150093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247954 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the onLocalDescriptionError callback is set before it can possibly
be called as a side-effect of webkitGetUserMedia().

BUG=339286
TEST=local build, run on desktop Linux

Review URL: https://codereview.chromium.org/149703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327087
TEST=Start chrome with the --google-profile-info flag, and a signed in
user. If you choose 'Users' for the top menu bar, the signed in user's
profile photo should be the same size as the other items.

Review URL: https://codereview.chromium.org/149513007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247952 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes some random dependencies to PathUtils and migrates to LocationInfo in that places. Also, most of the path utilities were removed.

TEST=Tested manually. Partly browser_tests.
BUG=320967

Review URL: https://codereview.chromium.org/148193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315414
TEST=affected tests removed

Review URL: https://codereview.chromium.org/147663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338303

Review URL: https://codereview.chromium.org/144303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247949 0039d316-1c4b-4281-b951-d872f2087c98

Previously, text output for time intervals always was rounded
down. For example, a time interval of 1 min 59 sec was
displayed as "1 min", which was confusing users in some cases.
This CL implements rounding to nearest integer. Some example
outputs are given below.

0.49 sec --> "0 secs"
0.5  sec --> "1 sec"
59.4 sec --> "59 secs"
59.5 sec --> "1 min"
89.9 sec --> "1 min"
90.0 sec --> "2 mins"
59 min   --> "59 mins"
60 min   --> "1 hour"
89 min   --> "1 hour"
90 min   --> "2 hours"
...

BUG=338631
TEST=unit tests updated

Review URL: https://codereview.chromium.org/143633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247948 0039d316-1c4b-4281-b951-d872f2087c98

Simplify and combine Dispatch{,Fabricated}KeyEventPostIME methods into one method.

TEST=Run unit_tests, ui_unittests, views_unittests.
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/142043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247947 0039d316-1c4b-4281-b951-d872f2087c98

Previously DriveSyncHandler#updateItem_ is called for 'in_progress' events and
DriveSyncHandler#removeItem_ is called for 'completed' events.

We should do updateItem_ and removeItem_ in this order but sometimes removeItem_
calls before updateItem_ is done becuase updateItem_ needs asynchronous
opeartion.

This CL serializes function calls of updateItem_ and removeItem_ by using
Promise.

BUG=339046
TEST=manually

Review URL: https://codereview.chromium.org/136783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247946 0039d316-1c4b-4281-b951-d872f2087c98

Removed preferences include:
- flag for incognito mode -- hotwording is now always off in incognito
- flag for 5 minute timeout -- hotwording now always times out after 5 minutes

Cleanup includes:
- Moved the pref from Search to Privacy
- Added confirm bubble for clicking the pref which adds hotword_confirm_overlay.{html,css}
- Changed the wording for the description (also added strings for the confirm/cancel buttons)


BUG=325439, 289023

Review URL: https://codereview.chromium.org/136693013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247945 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247944 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 247811 / e5fca450
Old Skia revision: 13227
New Skia revision: 13235
Control CL: https://codereview.chromium.org/148383016

This CL was created by Skia's roll_deps.py script.

Bypassing commit queue trybots:
NOTRY=true
R=rmistry@google.com

Review URL: https://codereview.chromium.org/149053007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247942 0039d316-1c4b-4281-b951-d872f2087c98

A newly initialized media player must enter fullscreen if there is a
pending request sent by a previous media player.

BUG=338670

Review URL: https://codereview.chromium.org/136113015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247941 0039d316-1c4b-4281-b951-d872f2087c98

It's already part of history items, so we should persist it.

BUG=334125
R=marja@chromium.org

Review URL: https://codereview.chromium.org/134813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247940 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/148223017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247939 0039d316-1c4b-4281-b951-d872f2087c98

Currently Guest mode always uses default value of
Preferences.PreferredInputMethod = "" (empty string) that
always leads to "us" keyboard layout (compiled-in default).

Guest sessions should have the following input methods/keyboards readily
available:
 - the VPD value (assuming the latin keyboard representing the underlying
   hardware; should be the default; e.g. French chromebook => azerty)
 - the additional input method/keyboard based on the locale (e.g. Japanese
   locale => should also add the Japanese IME; there are existing rules for
   this)


BUG=329018
TEST=unittest

Review URL: https://codereview.chromium.org/133273032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247938 0039d316-1c4b-4281-b951-d872f2087c98

This cl rename MediaStreamSourceExtraData to MediaStreamSource. This class is used as a common base class for MediaStreamAudioSource and MediaStreamVideoSource.

Further more it adds a specialization MediaStreamVideoSource called MediaStreamVideoCaptureDeviceSource. This is used for 
local video source such that can be created used GetUserMedia.

The cl hooks up the above classes to MediaStreamImpl to make sure they are used when gUM i used from JS.

BUG=334241

TBR jam for content_renderer.gypi
TBR=jam

Review URL: https://codereview.chromium.org/131763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
R=glider@chromium.org

Review URL: https://codereview.chromium.org/149433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247936 0039d316-1c4b-4281-b951-d872f2087c98

Breaks CrOS buildbots

http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28daisy%29&number=16073
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28amd64%29&number=13917
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Chromium%20OS%20%28x86%29%20ASAN&number=8064

> HID backend
> 
> BUG=290428
> 
> Review URL: https://codereview.chromium.org/143883005

TBR=ikarienator@chromium.org

Review URL: https://codereview.chromium.org/148183015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247934 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023

Review URL: https://codereview.chromium.org/149463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247933 0039d316-1c4b-4281-b951-d872f2087c98

Split LoaderController from ChangeListLoader.
SearchOperation obeys LoaderController.

BUG=260539
TEST=unit_tests

Review URL: https://codereview.chromium.org/150113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331988

Review URL: https://codereview.chromium.org/150043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247931 0039d316-1c4b-4281-b951-d872f2087c98

This prevents us getting stuck in smoothness mode if the embedding application
inhibits the View.computeScroll callback.

BUG=339245

Review URL: https://codereview.chromium.org/149963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247930 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247929 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/149413009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247928 0039d316-1c4b-4281-b951-d872f2087c98

The plan:
- mojo/public/{subdir} contains public headers and scripts (if any).
- mojo/public/{subdir}/lib contains private headers and .cc files (if any).
- mojo/public/{subdir}/tests contains test files.

Also, as part of this CL:

1- I simplified the TLS implementation in utility and hid it as an internal API. I'm not happy providing the API to third-parties as is. It was really intended to be used with LazyInstance, etc. Without that there is some subtlety with setup and teardown of the TLS slot. Hiding it avoids having to deal with this for now.

2- Deleted thread_local_unittest.cc as that was still coded against base/threading/thread_local.h (oops)! Besides that this test has a large dependency on base threading and synchronization primitives. It also isn't that useful to test our wrappers for TLS as they are such thin wrappers around the OS provided APIs.

3- Renamed environment/standalone to environment/lib for consistency. From the point of view of a third-party, lib is the better name for this directory.

Review URL: https://codereview.chromium.org/148013006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=290428

Review URL: https://codereview.chromium.org/143883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247926 0039d316-1c4b-4281-b951-d872f2087c98

It is necessary that the context created by copyCGLContextForPixelFormat
have a pixel format compatible with the one created by
copyCGLPixelFormatForDisplayMask. In particular, make
copyCGLPixelFormatForDisplayMask create the CGL equivalent of the pixel
format created in CompositingIOSurfaceContext.

BUG=338925

Review URL: https://codereview.chromium.org/142413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247925 0039d316-1c4b-4281-b951-d872f2087c98

Its okay for a trace to come back with no data in it. Right now,
this actually causes catastrophic failure.

R=tonyg

Review URL: https://codereview.chromium.org/141553009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247924 0039d316-1c4b-4281-b951-d872f2087c98