- 22 Apr, 2013 21 commits
-
-
tapted@chromium.org authored
More binaries at http://go/chromerev/7719014/ . theme/app_list.ico | Bin 43766 -> 0 bytes theme/chromium/app_list.ico | Bin 0 -> 26489 bytes theme/chromium/app_list_48.png | Bin 0 -> 1142 bytes theme/default_100_percent/win/app_list.png | Bin 1279 -> 0 bytes src-internal binaries: http://go/viewvc/chrome-internal?view=rev&revision=36431 src-internal DEPS roll: http://go/viewvc/chrome-internal?view=rev&revision=36446 BUG=180700 TEST=official Chrome installer built and icons checked with and without --chrome-sxs. App Launcher enabled via chrome://flags to verify icons used in taskbar. Review URL: https://codereview.chromium.org/13947002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195449 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
After we have introduced FakeDriveService, the code and test data for loading directory entries' json is not needed and not used. We should better remove them. Along the way, moved an EXPECT_EQ statement from the AddDirectory helper function to each test case to clarify the failure position. BUG=none Review URL: https://codereview.chromium.org/14392003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195448 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
Every change to job_info should be now triggering the notification to the observers. BUG=128079 Review URL: https://codereview.chromium.org/14367010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195447 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
(updated wrong perf) > Update perf expectations for small regression in r195190. > > BUG=234013 > TBR=cmp@chromium.org > > Review URL: https://codereview.chromium.org/14392004 TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/14398003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195446 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
Review URL: https://codereview.chromium.org/14320035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195445 0039d316-1c4b-4281-b951-d872f2087c98
-
yael.aharon@intel.com authored
Pass information to ppapi plugin if a mouse button was pressed during MouseMove event. This patch requiers a separate patch I submitted to blink. BUG=179054 TEST=Load the 2d or input example plugins and try to draw in them. Review URL: https://chromiumcodereview.appspot.com/14324006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195444 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
Modify AccessibilityTreeFormatter to build up an internal representation of the tree in the form of DictionaryValue et al. This may be used at a later stage to create a JSON representation of the tree. Also modify the Mac platform implementation to use the NSAccessibility attribute names rather than method names. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194775 Review URL: https://chromiumcodereview.appspot.com/13479003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195443 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
BUG=124218 TEST=existing browser_tests, autotests TBR=ben Review URL: https://codereview.chromium.org/13878010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195442 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
BUG=234013 TBR=cmp@chromium.org Review URL: https://codereview.chromium.org/14392004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195441 0039d316-1c4b-4281-b951-d872f2087c98
-
hashimoto@chromium.org authored
SetLargestChangestamp can fail when something is wrong with the disk. BUG=None Review URL: https://codereview.chromium.org/14189022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195439 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch is a further restyle of the auto-completion list and the search box input. TEST=Run with --file-manager-new-ui. BUG=226912 Review URL: https://codereview.chromium.org/14348017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195438 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
In addition: * Pipeline no longer owns the demuxer; clients are required to own it and keep it alive until Pipeline::Stop() completes. BUG=173313 Review URL: https://codereview.chromium.org/13813016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195437 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This patch introduces very basic restyle, which makes the gallery usable with the new ui. It addes the header which is draggable. This is quite tricky, since the header has to be outside of the iframe. -webkit-app-region: drag has no effect within an iframe. Along the way, a opacity animation has been added to thumbnails. TEST=Run with --file-manager-new-ui, click on a photo to get to the gallery. Try to move. BUG=233485 Review URL: https://codereview.chromium.org/14320020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195436 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/14339002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195435 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
Check that result of bmm.loadSubtree is still the selected item before applying disabled state to commands. BUG=230280 Review URL: https://chromiumcodereview.appspot.com/14064018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195434 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
This just passes it through from the main thread to the impl thread upon commit (and then to the renderer). BUG=155367 Review URL: https://chromiumcodereview.appspot.com/14092003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195433 0039d316-1c4b-4281-b951-d872f2087c98
-
kinuko@chromium.org authored
- Add MediaFileSystemMountPointProvider - Change CopyOrMoveFileValidatorUnittest not to rely on Media-FS types BUG=175936 TEST=content_unittests:CopyOrMoveValidatorTest.* Review URL: https://codereview.chromium.org/14352004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195432 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This is to explicitly set the SWP_HIDEWINDOW flag which it seems Windows might not set by default on future WM_WINDOWPOSCHANGED messages. Potentially resulting in the border widget being shown without the bubble contents. BUG=231687 Review URL: https://codereview.chromium.org/14267014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195431 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/14241013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195430 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
Numerous CrOS test failures: see http://crbug.com/234010 > roll clang 176256:179138 > > BUG=233709 > TBR=hans > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195220 > > Review URL: https://chromiumcodereview.appspot.com/14169006 TBR=thakis@chromium.org BUG=234010 Review URL: https://codereview.chromium.org/13871019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195429 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
Builder output from an asan tree closer: AutofillDialogCocoaBrowserTest.DisplayUI: dyld: warning, unknown environment variable: DYLD_NO_PIE Killed (timed out). I ran an asan build locally, and it popped up a modal dialog "browser_tests would like access to your Contacts". BUG=234008 TBR=sail@chromium.org, groby@chromium.org Review URL: https://codereview.chromium.org/13951021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195428 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Apr, 2013 12 commits
-
-
kkania@chromium.org authored
BUG=none TBR=chrisgao NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13901011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195426 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195425 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
It looks like some of the changes in r1614 - r1617 broke some of the chromium win builders, so I'm rolling back to r1611. TBR=cmp@chromium.org, scottmg@chromium.org, bradnelson@chromium.org BUG=233985 Review URL: https://codereview.chromium.org/13878025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195424 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195423 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This file was removed in r140913, and thus we don't need to make an exception for it anymore. BUG=125846 TEST=./tools/checkdeps/checkdeps.py - SUCCESS TBR=ben@chromium.org Review URL: https://codereview.chromium.org/13878023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195419 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195413 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
Removes chrome os ifdefs from SigninManager. SigninManagerBase provides all necessary functionality for that platform. I plan to change most callers of SigninManagerFactory::GetForProfile to use GetBaseForProfile in a follow up CL, and ultimately have the factory only create an SMB (versus a full SigninManager) on Chrome OS. TBR=sky@chromium.org for chrome/, chrome/browser, chrome/browser/ui, and chrome/test. TBR=zelidrag@chromium.org for chrome/browser/chromeos/login TBR=mpcomplete@chromium.org for chrome/browser/extensions/api/identity BUG=181451, 174927 Review URL: https://codereview.chromium.org/12502017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195410 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195409 0039d316-1c4b-4281-b951-d872f2087c98
-
nona@chromium.org authored
To making InputMethodDescriptor simple, let me remove operators. Also remove operator related tests because operator had been used only in tests. BUG=None TEST=ran all unit_tests. Review URL: https://codereview.chromium.org/14123005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195408 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
BUG=224018, 168224 TEST=On a Chrome for Android official build, launch Chrome, quit it and launch it again. Go to chrome://version and verify that the string "5a3c10b5" appears in the Variations list. (This corresponds to the server-controlled Test0PercentDefault field trial). NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13954011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195407 0039d316-1c4b-4281-b951-d872f2087c98
-
szym@chromium.org authored
After this CL, the effective address family will be determined by the UDP connect test rather than the last interface enumeration probe. BUG=223876 Review URL: https://codereview.chromium.org/14161008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195406 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
When a SPDY stream is stalled, always queue it up for resumption when the session send window goes positive, as it may end up being stalled by the session also. Add regression tests. BUG=233910 TBR=rch@chromium.org Review URL: https://codereview.chromium.org/14148007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195405 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Apr, 2013 7 commits
-
-
dharcourt@chromium.org authored
Changes code to use the images committed with http://crrev.com/14362011. BUG=232963 Review URL: https://codereview.chromium.org/14189012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195404 0039d316-1c4b-4281-b951-d872f2087c98
-
dharcourt@chromium.org authored
Since the text color changed, its backround color has to change also otherwise Label's GetReadableColor() will use a computed text color instead of the specified one. BUG=230068 Review URL: https://codereview.chromium.org/14298015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195403 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
Fails on Windows XP. This reverts commit 61feca81. TBR=bbudge@chromium.org BUG=79375 Review URL: https://codereview.chromium.org/13990006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195402 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=155363 R=msw@chromium.org,mukai@chromium.org Review URL: https://codereview.chromium.org/13879011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195401 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
BUG=79375 Review URL: https://codereview.chromium.org/14320023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195400 0039d316-1c4b-4281-b951-d872f2087c98
-
gavinp@chromium.org authored
The simple cache experiment control group will be "version 3" of the cache format, enforced on the index. This will cause users to drop their blockfile backend on startup in the control group, but keep their backend from session to session. R=felipeg@chromium.org,pasko@chromium.org BUG=231054 Review URL: https://chromiumcodereview.appspot.com/14129004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195399 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
BUG=230195 win_x64_rel busted. All other bots passed NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14318004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195398 0039d316-1c4b-4281-b951-d872f2087c98
-