GitLab

This will remove the dependence of these files on
chrome/browser/profiles/profile.h, in preparation for their move to extensions/browser/api/declarative.

BUG=352293

Review URL: https://codereview.chromium.org/535203003

Cr-Commit-Position: refs/heads/master@{#293384}

By design unrecognized extension messages should be silently dropped; printing them has the potential to adversely impact the reciever's performance, if unexpected messages are large.

Review URL: https://codereview.chromium.org/524843002

Cr-Commit-Position: refs/heads/master@{#293383}

Middle click on a bookmark in Bookmark Manager should open the bookmark in new
tab without pasting the contents of paste buffer. In Linux, since middle click
is used as 'paste', prevent it from pasting if the clicked item is a bookmark.
If clicked elsewhere in the Bookmark Manager window, do the default behaviour.

BUG=44811

R=bauerb@chromium.org

TEST=
1) Add few bookmarks and open Bookmark Manager.
2) Copy one or more bookmark item(s).
3) Middle click on a bookmark item and observe.
4) The clicked bookmark should open in new tab without pasting the copied bookmark
   inside the window.

Review URL: https://codereview.chromium.org/527923002

Cr-Commit-Position: refs/heads/master@{#293382}

This patches adds support to import autofill form data
from Firefox. Firefox stores form data in formhistory.sqlite
file and currently Chrome's firefox importer doesn't import data
from it.

With this patch, "Autofill form data" option is available in import
menu and allows user to import form data from Firefox. The imported
form data is stored in autofill table and is then used in forms for
autocomplete.

BUG=59087

Review URL: https://codereview.chromium.org/480953002

Cr-Commit-Position: refs/heads/master@{#293381}

Update smoothness.py to restore summarized results for metrics that don't care if some values are None:

mean_input_event_latency, input_event_latency_discrepancy, mean_scroll_update_latency, scroll_update_latency_discrepancy, first_gesture_scroll_update_latency

BUG=410018

Review URL: https://codereview.chromium.org/535783002

Cr-Commit-Position: refs/heads/master@{#293380}

Enable background networking for tab_switching measurements so we get some visibility into power impact.

BUG=None

Review URL: https://codereview.chromium.org/538963003

Cr-Commit-Position: refs/heads/master@{#293379}

These ended up having different bugs in different apps. In the
mojo_sample_app, we didn't pass a glResizeCHROMIUM() call on resize. In
mojo_demo_launcher, we weren't plumbing events from the aura window
hierarchy to the ServerView correctly.

BUG=393244

Review URL: https://codereview.chromium.org/536153002

Cr-Commit-Position: refs/heads/master@{#293378}

Fix a bug in QuicHttpStream::Close in which response_status_ was not being set. This would cause the ReadResponseHeaders method to return OK even though the response headers was NULL.

BUG=409871

Review URL: https://codereview.chromium.org/544773002

Cr-Commit-Position: refs/heads/master@{#293377}

Includes the following CLs:

Update to NSPR 4.10.7.
https://codereview.chromium.org/539213003/

R=rtenneti@chromium.org,zra@google.com
BUG=

Review URL: https://codereview.chromium.org/544743002

Cr-Commit-Position: refs/heads/master@{#293376}

Revert of NaCl: Update revision in DEPS, r13679 -> r13687 (patchset #1 id:1 of https://codereview.chromium.org/537003002/)

Reason for revert:
This breaks NaCl SDK tests on mac (presumably because that's the only one using the 32-bit IRT). See https://code.google.com/p/nativeclient/issues/detail?id=3935

Original issue's description:
> NaCl: Update revision in DEPS, r13679 -> r13687
>
> This pulls in the following Native Client changes:
>
> r13680: (bradnelson) Add back in android_tools, but in the right location.
> r13682: (dyen) Added irt extension support for supplying the nacl_irt_memory interface.
> r13683: (bradnelson) Disabling flaky test under asan.
> r13684: (hans) service_runtime_x86_64.gyp: pass /nologo to ml64.exe
> r13685: (mseaborn) Use uint32_t for untrusted pointer args: mmap() and munmap() syscalls
> r13686: (jfb) LLVM 3.5 merge: add missing dependencies to PNaCl build
> r13687: (dschuff) Build x86-32 IRT with PNaCl
>
> R=mseaborn@chromium.org,bradnelson@chromium.org
> BUG= https://code.google.com/p/nativeclient/issues/detail?id=3910
> TEST=browser_tests and nacl_integration
>
> Committed: https://chromium.googlesource.com/chromium/src/+/708bfbfe22cbc2bcd24a996211cd9a41da96e96e

TBR=bradnelson@chromium.org,mseaborn@chromium.org,bradnelson@google.com
NOTREECHECKS=true
NOTRY=true
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3910
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3935

Review URL: https://codereview.chromium.org/540163002

Cr-Commit-Position: refs/heads/master@{#293375}

BUG=410934
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/543493003

Cr-Commit-Position: refs/heads/master@{#293374}

Revert of This is a reland of ServiceWorkerCache::Keys. (patchset #3 id:70001 of https://codereview.chromium.org/528233003/)

Reason for revert:
Now getting a Valgrind leak that is likely due to this CL:

Suppression (error hash=#935FB14CBC8B5858#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Leak
fun:_Znw*
fun:_ZN9__gnu_cxx13new_allocatorIN10disk_cache20SimpleEntryOperationEE8allocateEmPKv
fun:_ZNSt11_Deque_baseIN10disk_cache20SimpleEntryOperationESaIS1_EE16_M_allocate_nodeEv
fun:_ZNSt5dequeIN10disk_cache20SimpleEntryOperationESaIS1_EE16_M_push_back_auxIJS1_EEEvDpOT_
fun:_ZNSt5dequeIN10disk_cache20SimpleEntryOperationESaIS1_EE12emplace_backIJS1_EEEvDpOT_
fun:_ZNSt5dequeIN10disk_cache20SimpleEntryOperationESaIS1_EE9push_backEOS1_
fun:_ZNSt5queueIN10disk_cache20SimpleEntryOperationESt5dequeIS1_SaIS1_EEE4pushEOS1_
fun:_ZN10disk_cache15SimpleEntryImpl5CloseEv
fun:_ZN10disk_cache12EntryDeleterclEPNS_5EntryE
fun:_ZN4base8internal15scoped_ptr_implIN10disk_cache5EntryENS2_12EntryDeleterEED2Ev
fun:_ZN10scoped_ptrIN10disk_cache5EntryENS0_12EntryDeleterEED2Ev
}

Original issue's description:
> This is a reland of ServiceWorkerCache::Keys.
>
> Reland of https://codereview.chromium.org/477973002/
>
> There was a memory leak.  EndEnumeration wasn't called on the iterator.
>
> Fixed and tested with ASAN.
>
> The leak was detected because SimpleCache doesn't clean up its enumerators on deletion, but it should.  See https://code.google.com/p/chromium/issues/detail?id=410276
>
> BUG=392621
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a3a3703b91203db3e2248d656b86cb26bf2e30e3

TBR=michaeln@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=392621

Review URL: https://codereview.chromium.org/538263002

Cr-Commit-Position: refs/heads/master@{#293373}

Added histograms "Network.Shill.Cellular.IPv6ConnectivityStatus" and
"Network.Shill.Wifi.IPv6ConnectivityStatus" for tracking the IPv6
connectivity status when network connection is established. This
allows us to know the readiness of IPv6 connectivity in the field.

Added histograms "Network.Shill.Cellular.NetworkConnectionIPType" and
"Network.Shill.Wifi.NetworkConnectionIPType" for tracking the types of
IP configuration use for establishing network connections. This allows
us to track the usage of the newly added IPv6 connection support.

BUG=chromium:207192

Review URL: https://codereview.chromium.org/539163003

Cr-Commit-Position: refs/heads/master@{#293372}

On android platform, it often fails to fetch searchdomaincheck url right
after network changes.
To fix the failure, this patch modifies GoogleURLTracker to listen to
OnNetworkChanged instead of OnIPAddressChanged.

BUG=407442

Review URL: https://codereview.chromium.org/512843002

Cr-Commit-Position: refs/heads/master@{#293371}

BUG=409867

Review URL: https://codereview.chromium.org/522023003

Cr-Commit-Position: refs/heads/master@{#293370}

A previous patch changed the scheduling policy so that scroll handlers
get more of a chance of completing in the same frame as the scroll
update ("best effort sync scrolling"). It turns out this went a little
too far by fully disabling prefer smoothness mode in the presense of
scroll handlers. For instance, this caused us to start synchronously
waiting for asynchronous texture upload completion, leading to skipped
frames.

This patch adjusts the logic so that scroll handlers are still given an
opportunity to complete within the same frame (i.e., the deadline isn't
triggered early), but the tree activation policy is to prefer existing
content over new content.

We also rename the smoothness mode in the scheduler to "impl latency
takes priority" to make its purpose clearer.

BUG=404267

Review URL: https://codereview.chromium.org/522903002

Cr-Commit-Position: refs/heads/master@{#293369}

A media task runner can receive tasks whose scheduling
depends on a media timestamp.
The balanced media task runner factory generates some media task
runners whose task schedulings are loosely synchronized between
each other. A direct application is to query audio and video frames
in a balanced way, which minimizes the memory used for muxed streams.

BUG=408189

Review URL: https://codereview.chromium.org/534893002

Cr-Commit-Position: refs/heads/master@{#293368}

Minor cleanup cl.

Review URL: https://codereview.chromium.org/519443002

Cr-Commit-Position: refs/heads/master@{#293367}

This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.

There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.

BUG=351636

Review URL: https://codereview.chromium.org/459553003

Cr-Commit-Position: refs/heads/master@{#293366}

1. Automate the selection of the proper channel to enable the verifier.
   Now the code is enabled at runtime.

2. Switch to a hash_map to track handles.

3. Intercept CloseHandle to detect the code that is closing handles owned
   by ScopedHandles. The initial implementation only covers chrome.exe/dll,
   but the plan is to extend that in the future to all modules loaded in the
   process.

BUG=362176

See https://codereview.chromium.org/490043002/ for the initial review.

Review URL: https://codereview.chromium.org/510633002

Cr-Commit-Position: refs/heads/master@{#293365}

Original CL: https://codereview.chromium.org/512693003/

This was reverted because LocationBarBrowserTest.PageActionUITest is flaky on
Mac. Resubmit this, but with the flaky test disabled on mac.

BUG=408261
BUG=410866

Review URL: https://codereview.chromium.org/543783002

Cr-Commit-Position: refs/heads/master@{#293364}

BUG=387069
R=bauerb@chromium.org, jochen@chromium.org
TEST=build succeeds

Review URL: https://codereview.chromium.org/538753003

Cr-Commit-Position: refs/heads/master@{#293363}

BUG=410029,  273089

Review URL: https://codereview.chromium.org/529203002

Cr-Commit-Position: refs/heads/master@{#293362}

BUG=408728,410593

Review URL: https://codereview.chromium.org/532913003

Cr-Commit-Position: refs/heads/master@{#293361}

It also hooks up libpdf which chrome requires at startup.

Adds the enable_hidpi and use_athena build flags.

Adds a locales list.

This makes the chrome target actually runnable from a GN build.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/541153002

Cr-Commit-Position: refs/heads/master@{#293360}

This is separated from https://chromiumcodereview.appspot.com/535373002/
just for CQ safety.

The first one was reverted because it has silly typo on file names.

TBR=yoz@chromium.org
TEST=None
BUG=407777

Review URL: https://codereview.chromium.org/541173002

Cr-Commit-Position: refs/heads/master@{#293359}

GLHelper has functionality for testing for appropriate GL readback
format support, caching this information where appropriate. This change
switches RendererGpuVideoAcceleratorFactories over to using that code
for supported format identification and glReadPixels in the desired
format. The code continues to do a software swizzle if necessary.

TEST=WebGL conformance tests
BUG=None

Review URL: https://codereview.chromium.org/456823002

Cr-Commit-Position: refs/heads/master@{#293358}

No fancy animations, this just adds basic functionality. In fullscreen mode,
the tabs are shifted over, and traffic light buttons are manually added in.

BUG=405564

Review URL: https://codereview.chromium.org/508313002

Cr-Commit-Position: refs/heads/master@{#293357}

BUG=352290

Review URL: https://codereview.chromium.org/522763002

Cr-Commit-Position: refs/heads/master@{#293356}

This reverts commit 5f5a7f3f.

TBR=yoz@chromium.org
TEST=None
BUG=407777

Review URL: https://codereview.chromium.org/541923002

Cr-Commit-Position: refs/heads/master@{#293355}

Start checking the following names:
- Method names
- Method parameter names
- Local variables

BUG=318404
TRB=qinmin@chromium.org
R=boliu@chromium.org, qinmin@chromium.org, tedchoc@chromium.org

Review URL: https://codereview.chromium.org/543553002

Cr-Commit-Position: refs/heads/master@{#293354}

The compositor makes it possible to customize the message loop proxy
both on the main and impl threads. However BlockingTaskRunner just uses
base::MessageLoopProxy::current() directly and thus overrides this
choice. Using the correct message loop proxy is important because
clients of BlockingTaskRunner have an implicit dependency on the
ordering of tasks posted to BlockingTaskRunner vs. all other tasks
posted to the task runner for that same thread.

This patch fixes the problem by removing the thread-local
BlockingTaskRunner::current() instance in favor of an explicitly
constructed instance which is given a specific SingleThreadTaskRunner
to use. The resource provider is changed to pass a Proxy-owned
blocking task runner to the clients which need one.

BUG=391005
TEST=1. Apply https://codereview.chromium.org/363383002
     2. out/Debug/chrome --disable-impl-side-painting --ignore-gpu-blacklist tools/perf/page_sets/tough_scheduling_cases/raf_canvas.html

Review URL: https://codereview.chromium.org/485043003

Cr-Commit-Position: refs/heads/master@{#293353}

We don't need to do deep copies -- shallow copies will do. However, for
structs and such, we need to carefully work around the shared_definition
nonsense.

R=jamesr@chromium.org
BUG=406156

Review URL: https://codereview.chromium.org/535333002

Cr-Commit-Position: refs/heads/master@{#293352}

BUG=409875
NOTRY=true

Review URL: https://codereview.chromium.org/536553003

Cr-Commit-Position: refs/heads/master@{#293351}

This broke due to r285254 (http://crbug.com/391008), the fix is trivial.

BUG=408809

Review URL: https://codereview.chromium.org/540583002

Cr-Commit-Position: refs/heads/master@{#293350}

This is separated from https://chromiumcodereview.appspot.com/535373002/
just for CQ safety.

TBR=yoz@chromium.org
TEST=None
BUG=407777

Review URL: https://codereview.chromium.org/536323005

Cr-Commit-Position: refs/heads/master@{#293349}

BUG=378035

Review URL: https://codereview.chromium.org/537083002

Cr-Commit-Position: refs/heads/master@{#293348}

Rework the seccomp_bpf compiler internals to work in terms of a single
general masked-equality condition instead of the variety of limited
condition operators previously supported.  All of the peephole
optimizations previously applied continue to be supported so similar
instructions should be emitted, but the handling of upper/lower words
is more cleanly structured now.

The old sandbox->Cond() interface continues to be supported for now so
that the old seccomp_bpf_unittests continue to give us assurances that
the new code generator is still correct.  Meanwhile, we provide a new
lower-level sandbox->CondMaskedEqual() method that bpf_dsl can now use.

BUG=408845
R=jln@chromium.org

Review URL: https://codereview.chromium.org/530133003

Cr-Commit-Position: refs/heads/master@{#293347}

Review URL: https://codereview.chromium.org/538733002

Cr-Commit-Position: refs/heads/master@{#293346}

BUG=409926

Review URL: https://codereview.chromium.org/520093002

Cr-Commit-Position: refs/heads/master@{#293345}