GitLab

BUG=381484
TEST=Tested on Windows.

Review URL: https://codereview.chromium.org/404613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284587 0039d316-1c4b-4281-b951-d872f2087c98

Add an app icon mask (16*16, or 32*32 for retina display) on the bottom right corner of notifications to indicate source of the notification. The app icon is displayed in a way that takes only the alpha channel of the image passed in, masks it with white foreground and grey background.

BUG=284592

Review URL: https://codereview.chromium.org/308053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284586 0039d316-1c4b-4281-b951-d872f2087c98

This is similar idea which was already applied in png_codec.cc.
https://codereview.chromium.org/397673002/
(Sorry for making another review request.)

BUG=none
R=erg@chromium.org, sky@chromium.org, dcheng@chromium.org
TEST(DONE&PASSED)=gfx_unittests --gtest_filter="JPEGCodec*"

Review URL: https://codereview.chromium.org/404793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284585 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Telemetry] Disable a Dromaeo benchmark on XP due to OOM. (https://codereview.chromium.org/271583003/)

Reason for revert:
The issue is probably fixed by Blink r176006.

Original issue's description:
> [Telemetry] Disable a Dromaeo benchmark on XP due to OOM.
> 
> BUG=323782
> NOTRY=True
> TBR=dtu@chromium.org
> NOTREECHECKS=True
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268666

NOTRY=true
BUG=323782
TBR=tonyg

Review URL: https://codereview.chromium.org/407023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284583 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
r284521 fixed the underlying problem.

Original issue's description:
> Disable a flaky test.
> 
> BUG=395726
> TEST=none
> TBR=miu
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284516

TBR=pkasting@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395726

Review URL: https://codereview.chromium.org/410563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284581 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284580 0039d316-1c4b-4281-b951-d872f2087c98

22b31e0  Adjust null object check
baca770  Fix remaining -Wdelete-non-virtual-dtor violations on Windows.

BUG=none
R=thestig@chromium.org
TBR=thestig

Review URL: https://codereview.chromium.org/410513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284579 0039d316-1c4b-4281-b951-d872f2087c98

This is based off of http://crrev.com/322523002

BUG=370033

Review URL: https://codereview.chromium.org/370463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284578 0039d316-1c4b-4281-b951-d872f2087c98

Revert of mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (https://codereview.chromium.org/402443003/)

Reason for revert:
Broke Mac ASan 64 Builder
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/7520

obj/chrome/browser/ui/cocoa/browser_ui.version_independent_window.o
../../chrome/browser/ui/cocoa/version_independent_window.mm:109:44:error: cannot initialize a parameter of type 'NSComparisonResult (*)(id, id, void *)' with an rvalue of type 'int (*)(id, id, void *)': different return type ('NSComparisonResult' (aka 'long') vs 'int')
      [superview sortSubviewsUsingFunction:&ReorderContentViewToBack
                                           ^~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:175:75: note: passing argument to parameter 'compare' here
- (void)sortSubviewsUsingFunction:(NSComparisonResult (*)(id, id, void *))compare context:(void *)context;


Original issue's description:
> mac: [Yosemite] Fix bug where zoom button causes fullscreen mode.
> 
> In Yosemite, holding down alt while clicking the fullscreen button is supposed
> to zoom the window. This doesn't work because Chrome violates unstated AppKit
> assumptions.
> 
> The problem seems to lie in hit testing the location of the zoom button.
> Reordering the subviews by moving the tab strip and the content view behind the
> zoom button fixes the problem.
> 
> BUG=393808
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284544

TBR=andresantoso@chromium.org,shess@chromium.org,erikchen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393808

Review URL: https://codereview.chromium.org/402323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284576 0039d316-1c4b-4281-b951-d872f2087c98

WaitForExitCode() closes the process handle itself.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/406953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381290

Review URL: https://codereview.chromium.org/390553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284574 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284573 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (https://codereview.chromium.org/407733005/)

Reason for revert:
Seems to be causing xss-DENIED-method-with-iframe-proto.html to time out on multiple bots; see http://crbug.com/395882 .

Original issue's description:
> Update V8 to version 3.28.30 (based on bleeding_edge revision r22489).
> 
> Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.
> 
> TBR=svenpanne@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284420

TBR=svenpanne@chromium.org,machenbach@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/405313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284572 0039d316-1c4b-4281-b951-d872f2087c98

double <br> elements, and adjust CSS to make it look good. Fix up a couple of
IDL files to just use newlines rather than <br> elements.

R=mangini@chromium.org, asargent@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/404203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284571 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/405273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284570 0039d316-1c4b-4281-b951-d872f2087c98

There's only one time of badge icon now, so
remove the enum that specifies the type.

BUG=394855

Review URL: https://codereview.chromium.org/401333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394898
NOTRY=true

Review URL: https://codereview.chromium.org/397293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284568 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add ExtensionsTestBrowserContext class for test. (https://codereview.chromium.org/355223002/)

Reason for revert:
This is breaking the Chrome OS valgrind bots:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20(valgrind)(5)

For example:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/28278

This is a problem with mixing tests that use TestingProfile and TestBrowserContext.  See crbug.com/395820

Original issue's description:
> Add ExtensionsTestBrowserContext class for test.
> and Use ExtensionTestBrowserContext for ImageLoader unittest.
> 
> ExtensionsTestBrowserContext class does 
> set TestExtensionsBrowserClient from constructor and
> call DestroyBrowserContextServices from destructor.
> 
> ExtensionTestBrowserContext will be used instead of TestingProfile.
> 
> R=yoz@chromium.org, rdevlin@chromium.org
> BUG=354046
> TEST=unit_tests --gtest_filter=ImageLoaderTest.DeleteExtensionWhileWaitingForCache
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284330

TBR=jamescook@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/406093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395739,395743
TBR=nednguyen@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/406093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284566 0039d316-1c4b-4281-b951-d872f2087c98

'WebURLRequest::TargetType' has been dropped in Blink in favor of
'RequestContext' and 'FrameType', matching the Fetch specification's
changes, and allowing both more granularity in various Blink-side checks
and more clarity around the thing that caused a request, and the frame
that the request affects.

This CL should have zero practical effect, as it's simply hoisting the
translation work that 'WebURLRequest::setTargetType' is already doing
up into the content layer to bring us one step closer to removing the
concept entirely.

BUG=390497

Review URL: https://codereview.chromium.org/407883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284565 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin@chromium.org
BUG=http://code.google.com/p/drmemory/issues/detail?id=1528
NOTRY=true

Review URL: https://codereview.chromium.org/401313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/409663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284563 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/408643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284562 0039d316-1c4b-4281-b951-d872f2087c98

This reintroduces change 283461 (issue 367153005) that has been reverted due to
memory leaks in some unit tests.
The memory leak was in a mock implementation of ProfileSyncComponentsFactory.
The factory is responsible for creating an instance of LocalDeviceInfoProvider,
which it does on demand and immediately transfer ownership of
LocalDeviceInfoProvider to the caller.
But due to the way mocking was implemented in ProfileSyncComponentsFactoryMock
a mock instance of LocalDeviceInfoProvider was created in the constructor and
if a test never called CreateLocalDeviceInfoProvider(), it would be leaked.

In this change I moved away from using ON_CALL mocking mechanism that resulted
in the leak to a custom implementation that avoids that problem.
See original changes in the patch #1 and the fix in the patch #2.

The original description copied from issue 367153005:

This change introduces a new class LocalDeviceInfoProvider that is responsible
for providing the local device specific DeviceInfo/cache_guid. It initializes
the data asynchronously and allows consumers to get notified when the data
becomes available.

LocalDeviceInfoProvider will allow to remove these responsibilities from
SyncedDeviceTracker / ProfileSyncService and loose coupling between
ProfileSyncService and a number of SyncableService and DataTypeController
derived classes.

LocalDeviceInfoProvider is hosted on the frontend thread. Since it needs
cache_guid to initialize DeviceInfo, which is currently available only on the
backend, I updated SyncBackendHostCore and SyncBackendHostImpl to pass
cache_guid to the frontend via OnBackendInitialized.

For the time being SyncedDeviceTracker remains unchanged
and continues to initialize the local device info too. The entire class will be
removed in the Part 2 of the change which will move SyncedDeviceTracker
functionality to a new SyncableService.

LocalDeviceInfoProvider also replaces SessionsSyncManager::SyncInternalApiDelegate
which was previously used to decouple SessionsSyncManager from the specifics of
of the local device info implementation.
SessionsSyncManager is changed to consume LocalDeviceInfoProvider instead of
SessionsSyncManager::SyncInternalApiDelegate.
SessionDataTypeController now also consumes LocalDeviceInfoProvider to make sure
that SESSIONS type model doesn't start before local device info becomes available.
A very similar approach will be used in the upcoming second part of the change
for DEVICE_INFO DataTypeController and SyncableType.

The change includes new unit tests for LocalDeviceInfoProvider and
SessionDataTypeController.

TBR=maniscalco@chromium.org,sky@chromium.org,zea@chromium.org
BUG=395349

Review URL: https://codereview.chromium.org/398423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284561 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn component_updater
user_manager

R=brettw@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/403103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284560 0039d316-1c4b-4281-b951-d872f2087c98

std::vector<>::data() is a C++11 feature and not available on all
toolchains. This uses &vector[0] instead.

Review URL: https://codereview.chromium.org/393583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=384897

Review URL: https://codereview.chromium.org/404613009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377852

Review URL: https://codereview.chromium.org/379293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284556 0039d316-1c4b-4281-b951-d872f2087c98

Fixing some of the strings that are used for permissions warnings to ensure their consistency.

BUG=362794
R=felt

Review URL: https://codereview.chromium.org/405653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284555 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284553 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/3d533ac917eaadf2fb3561f57d7266d8c0e665fd..ad1df153a16b7723d2d4afd13627919fc3ee87ce

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/404443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284552 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of https://codereview.chromium.org/402993002/ with an additional check to make sure that the DLLs exist before trying to copy them.

BUG=395183

Review URL: https://codereview.chromium.org/405983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393413

Review URL: https://codereview.chromium.org/387163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284549 0039d316-1c4b-4281-b951-d872f2087c98

Older versions of gcc, like 4.6.* (which is the default on ubuntu 12.04 LTS), throw build error for using const_iterator.
This has been documented here [1]

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57158

Review URL: https://codereview.chromium.org/401263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/407713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394821

Review URL: https://codereview.chromium.org/405693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284546 0039d316-1c4b-4281-b951-d872f2087c98

Also fix an issue with missing constriants logged at webrtc-internals.

See a snapshot of the UI at https://docs.google.com/a/google.com/presentation/d/1dL2flqsQj8h_dTO9t8BWOCjiwbLiZCN2Nt93FHqpM9o/edit?usp=sharing

BUG=304023

Review URL: https://codereview.chromium.org/405683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284545 0039d316-1c4b-4281-b951-d872f2087c98

In Yosemite, holding down alt while clicking the fullscreen button is supposed
to zoom the window. This doesn't work because Chrome violates unstated AppKit
assumptions.

The problem seems to lie in hit testing the location of the zoom button.
Reordering the subviews by moving the tab strip and the content view behind the
zoom button fixes the problem.

BUG=393808

Review URL: https://codereview.chromium.org/402443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284540 0039d316-1c4b-4281-b951-d872f2087c98

This broke linux builder:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Builder%20%28dbg%29&number=75554

[1147/10681 | 99.521] CXX
obj/net/disk_cache/simple/net.simple_net_log_parameters.o
FAILED: cd ../../chrome/test/data/nacl; python
../../../../native_client/build/build_nexe.py -t
../../../../out/Debug/gen/sdk/ --arch x86-32 --build newlib_translate
--root ../../../.. --name
../../../../out/Debug/ppapi_ppb_instance_pnacl_newlib_x32.nexe
"--link_flags=
-Wl,-L../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32"
../../../../out/Debug/nacl_test_data/pnacl/ppapi_ppb_instance_newlib_pnacl.pexe
/b/build/slave/Linux_Builder__dbg_/build/src/out/Debug/gen/sdk/linux_x86/pnacl_newlib/host_x86_32/bin/le32-nacl-ld.gold:error:
cannot open
../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32/libpnacl_irt_shim.a:
No such file or directory
/b/build/slave/Linux_Builder__dbg_/build/src/out/Debug/gen/sdk/linux_x86/pnacl_newlib/lib-x86-32/crtbegin.o:/mnt/data/b/build/slave/nacl-toolchain/build/native_client/toolchain_build/out/libs_support_native_x86_32_install/lib-x86-32/crtbegin.o---crtbegin.c---.expand.po:function
__pnacl_start:error: undefined reference to '_pnacl_wrapper_start'
../../../../out/Debug/gen/sdk/linux_x86/pnacl_newlib/bin/pnacl-translate
-arch x86-32
../../../../out/Debug/nacl_test_data/pnacl/ppapi_ppb_instance_newlib_pnacl.pexe
-o ../../../../out/Debug/ppapi_ppb_instance_pnacl_newlib_x32.nexe
-Wl,-L../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32
FAILED: Command
'['../../../../out/Debug/gen/sdk/linux_x86/pnacl_newlib/bin/pnacl-translate',
'-arch', 'x86-32',
'../../../../out/Debug/nacl_test_data/pnacl/ppapi_ppb_instance_newlib_pnacl.pexe',
'-o',
'../../../../out/Debug/ppapi_ppb_instance_pnacl_newlib_x32.nexe',
'-Wl,-L../../../../out/Debug/gen/tc_pnacl_translate/lib-x86-32']'
returned non-zero exit status 1
ninja: build stopped: subcommand failed.

> NaCl: Update revision in DEPS, r13456 -> r13506
> 
> This pulls in the following Native Client changes:
> 
> r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
> r13458: (noelallen) Update and add GN files to build sel_ldr.
> r13459: (jvoung) Remove env cleanser references to obsolete env vars.
> r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
> r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
> r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
> r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
> r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
> r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
> r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
> r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
> r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
> r13470: (dschuff) Update revision for PNaCl r13392->r13466
> r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
> r13472: (dschuff) Build PNaCl with mingw again
> r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
> r13474: (dschuff) Update revision for PNaCl r13466->r13472
> r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
> r13476: (sky) Changes scan_sources not to output on bogus directory
> r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
> r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13481: (hidehiko) Align at 16 bytes for stack for created thread.
> r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"
> r13485: (ncbray) Fix untrusted.gypi and build_nexe.py
> r13486: (teravest) Split nacl_defines to an importable .gni file.
> r13487: (dyen) Actually make package_version include logs when argument is set.
> r13488: (jfb) Update revision for PNaCl r13472->r13480
> r13489: (hidehiko) Wrap irt_interfaces.h by extern "C".
> r13490: (hidehiko) Non-SFI Mode: Implement irt_mprotect.
> r13493: (jvoung) Revert "Non-SFI Mode: Implement irt_mprotect."
> r13494: (noelallen) Add per-file OWNERS for .gn in this sub directory since per-file only works on the directory the OWNERS is in.
> r13495: (noelallen) Fix vc_toolchain.py paths.
> r13496: (noelallen) Revert of 7e955d3ab6159dc05a7f255c6daf03847809414a
> r13497: (dyen) Implemented Exists for pynacl.LocalStorageCache.
> r13500: (hidehiko) Non-SFI Mode: Make elf_loader usable from Chrome.
> r13503: (jvoung) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS
> r13504: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
> r13505: (dschuff) Roll PNaCl toolchain revision back to r13466
> r13506: (dschuff) Revert "Fix untrusted.gypi and build_nexe.py"
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build
> (omitting linux_rel_precise32 and linux_arm_cross_compile because they're currently broken)
> 
> Review URL: https://codereview.chromium.org/404663002

TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/409733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284539 0039d316-1c4b-4281-b951-d872f2087c98