GitLab

Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ

R=oilpan-reviews
BUG=455524

Review URL: https://codereview.chromium.org/955583002

git-svn-id: svn://svn.chromium.org/blink/trunk@190724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL contains some part of https://codereview.chromium.org/460343004/ by
sudarshan.p, which was reverted by a performance regression.

This CL simplifies form validation state handling code by
 - lazy update of m_isValid
   setNeedsValidityCheck just makes m_isValid dirty.
 - m_isValid takes care of willValidate state too.
   m_isValid = !willValidate() || valid()

We switched to invalidation sets for :valid and :invalid by Blink
r184392. Calling pseudoStateChanged() for unchanged validity state won't have so
bad performance. So, we can evaluate m_isValid lazily.

We need to change the meaning of m_isValid slightly so that it takes care of
willValidate(). This is necessary to clean m_validityIsDirty of associated
controls in HTMLFormElement::checkInvalidControlsAndCollectUnhandled.
Without this change, there would be a case where willValidate state
change won't invalidate :valid :invalid style of <form>.

This CL will have a few percent regression on blink_perf.dom:textarea-edit.
A fix for the performance regression will be landed soon.

BUG=

Review URL: https://codereview.chromium.org/943303002

git-svn-id: svn://svn.chromium.org/blink/trunk@190723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ

R=oilpan-reviews
BUG=455524

Review URL: https://codereview.chromium.org/941363003

git-svn-id: svn://svn.chromium.org/blink/trunk@190722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was added in 2006 <https://trac.webkit.org/changeset/12568> and was
accurate at the time.

Review URL: https://codereview.chromium.org/939303004

git-svn-id: svn://svn.chromium.org/blink/trunk@190721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a speculative attempt to fix Issue 456636.

CustomElementSyncMicrotaskRunQueue::dispatchIfAlive checks that the
object is alive when it starts running callbacks, but doesn't ensure
the object lives for the duration of the callbacks. Since the
callbacks can run author JavaScript, the assumption that whatever kept
the object alive will continue to do so might be too optimistic.

Additionally, strengthen the assertion that queue processing is
non-reentrant.

BUG=456636

Review URL: https://codereview.chromium.org/916403003

git-svn-id: svn://svn.chromium.org/blink/trunk@190720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ

Note to reviewers:
This CL is created manually, as DEFINE_TRACE macros doesn't support template methods.

R=oilpan-reviews
BUG=455524

Review URL: https://codereview.chromium.org/940293002

git-svn-id: svn://svn.chromium.org/blink/trunk@190719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The container's is already kept alive by a stack reference with Oilpan.

R=haraken
BUG=458776
NOTRY=true

Review URL: https://codereview.chromium.org/955573002

git-svn-id: svn://svn.chromium.org/blink/trunk@190718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=455253
TEST=fast/dom/HTMLAreaElement/area-cursor.html

Review URL: https://codereview.chromium.org/934563002

git-svn-id: svn://svn.chromium.org/blink/trunk@190717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The flakiness dashboard results after [1] shows the flakiness is not caused
by the flaky test itself, but caused by another test. The test logs say
xmlhttprequest-responseText-exception.html is the culprit.
This CL fixes the flakiness caused by repeated readystatechange events
on loading.
This CL makes the test use js-test.js, as recommended in [2].

1: https://src.chromium.org/viewvc/blink?view=rev&revision=190652
2: https://docs.google.com/document/d/1Yl4SnTLBWmY1O99_BTtQvuoffP8YM9HZx2YPkEsaduQ/edit#heading=h.ui2te0d6ongo

BUG=415872

Review URL: https://codereview.chromium.org/950063004

git-svn-id: svn://svn.chromium.org/blink/trunk@190716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All local frames being swapped in must be provisional local frames. The
other code path is completely unexercised outside of some unit tests.
Once the PlzNavigate work is closer to completion, the non-provisional
local frame path can be reintroduced and properly tested.

BUG=346764

Review URL: https://codereview.chromium.org/948143002

git-svn-id: svn://svn.chromium.org/blink/trunk@190715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Added code to fix visibility of select all option in context menu. (patchset #3 id:40001 of https://codereview.chromium.org/402403003/)

Reason for revert:
This CL is causing Issue 438135 and Issue 450540. So reverting this.

Original issue's description:
> Added code to fix visibility of select all option in context menu.
> 
> If context menu is appearing on some input field. Select all option
> should appear only if some text is present inside input field.
> 
> BUG=395994
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179636

TBR=darin@chromium.org,aelias@chromium.org,abarth@chromium.org,esprehn@chromium.org,ankit2.kumar@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=395994

Review URL: https://codereview.chromium.org/942183005

git-svn-id: svn://svn.chromium.org/blink/trunk@190714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The class was added to share RenderLayer with SVG (see
https://bugs.webkit.org/show_bug.cgi?id=86022) with the
goal of having composited SVG but no progress was ever
made in this direction so it's better to revert back to
a more simple strategy. Also slimming paint should
change the way we composite and thus remove some deep
assumption about how we composite.

Review URL: https://codereview.chromium.org/945803004

git-svn-id: svn://svn.chromium.org/blink/trunk@190713 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ

R=oilpan-reviews
BUG=455524

Review URL: https://codereview.chromium.org/940843003

git-svn-id: svn://svn.chromium.org/blink/trunk@190712 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is consistently used as a null check for mediaControls() and is no
more efficient, so keep only mediaControls().

toMediaControls() includes an equivalent null check and
ASSERT_WITH_SECURITY_IMPLICATION.

BUG=448795

Review URL: https://codereview.chromium.org/943333003

git-svn-id: svn://svn.chromium.org/blink/trunk@190711 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No change to generated code, as there are no checks to verify that a
non-nullable return type is never null.

BUG=460722

Review URL: https://codereview.chromium.org/950893002

git-svn-id: svn://svn.chromium.org/blink/trunk@190710 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ

Note to reviewers:
This is manually created patchpatches, as the automated migration script didn't support inline trace methods definitions made out of class.


R=oilpan-reviews
BUG=455524

Review URL: https://codereview.chromium.org/938283002

git-svn-id: svn://svn.chromium.org/blink/trunk@190709 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/947303002

git-svn-id: svn://svn.chromium.org/blink/trunk@190707 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The GC heuristics take into account the amount of objects allocated since
the last GC, in terms of the amount of Oilpan heap bytes allocated.

It does not consider the amount of external memory owned by an
Oilpan object. Allow objects to register such external allocations and
have the GC heuristics consider it -- if the heap isn't otherwise
considered worth GCing but it contains references to a large amount of
external memory, scheduling a GC may lessen the overall memory pressure
for the process.

Along with this, also add support for letting the outside world notify
Oilpan that a GC is now really worth considering. Intended used by other
allocators if they are running into near-OOM conditions.

R=haraken
BUG=456498

Review URL: https://codereview.chromium.org/875503003

git-svn-id: svn://svn.chromium.org/blink/trunk@190702 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=352856
TEST=
TBR=zmo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/944643005

git-svn-id: svn://svn.chromium.org/blink/trunk@190701 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Current re-entrancy inside WebPluginContainer::scriptableObject can cause
the plugin to be deleted, as well as the WebPluginContainer. This can cause
UAFs. This change holds a reference to the plugin container to prevent it from
being destroyed while in the function. This also prevents the WebPlugin
associated with it from being destroyed since the lifetime of WebPlugin is
managed by the WebPluginContainer.

BUG=458776

Review URL: https://codereview.chromium.org/933653004

git-svn-id: svn://svn.chromium.org/blink/trunk@190700 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- missing semicolon.
- typos.
- wrong indentation and line break.
- both test branches are passing. (there is no test failure.)

BUG=460615

Review URL: https://codereview.chromium.org/928073004

git-svn-id: svn://svn.chromium.org/blink/trunk@190699 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Two loops were recently added that used 'i' as an index variable, inside
an outer loop that also used 'i'. This isn't a bug, but can be
confusing. This change renames the inner 'i' variables to 'j'.

The variable shadowing was introduced in this change:
https://codereview.chromium.org/932033002

This was found by the /analyze builder

BUG=427616

Review URL: https://codereview.chromium.org/951603002

git-svn-id: svn://svn.chromium.org/blink/trunk@190698 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=461107
NOTRY=true

Review URL: https://codereview.chromium.org/954513004

git-svn-id: svn://svn.chromium.org/blink/trunk@190697 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=450612
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/951453003

git-svn-id: svn://svn.chromium.org/blink/trunk@190696 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Per the Web IDL spec [1]:

4.5.8. Operations: "The property has attributes {
[[Writable]]: B, [[Enumerable]]: true, [[Configurable]]: B
}, where B is false if the operation is unforgeable on the
interface, and true otherwise."

In other words, Object.getOwnPropertyDescriptor(i.p, 'm')
should have configurable: true, except for [Unforgeable]
which is already special-cased.

[1] http://heycam.github.io/webidl/#es-operations

BUG=138217,377476

Review URL: https://codereview.chromium.org/948583002

git-svn-id: svn://svn.chromium.org/blink/trunk@190695 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch includes a fix and refactoring on several layout tests for promise from AudioContext.suspend() and .resume().

|Audit| task runner handles the sequential execution of asynchrous test tasks.

BUG=460504

Review URL: https://codereview.chromium.org/945023002

git-svn-id: svn://svn.chromium.org/blink/trunk@190694 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first in a series of coordinate transformation cleanups.
Chiefly, I'd like to include pinch coordinate transforms in the FrameView
contentsToWindow type methods. In this patch I've looked just at "RootView"
There shouldn't be any functional change, this is all disambiguation and
renaming.

I looked at all callers of FrameView's:

    IntPoint rootViewToContents(const IntPoint&) const;
    IntPoint contentsToRootView(const IntPoint&) const;
    IntRect rootViewToContents(const IntRect&) const;
    IntRect contentsToRootView(const IntRect&) const;

Currently these methods for converting to/from RootView and Window in
FrameView do the same transformation, so it seems they've been used
interchangeably. They no longer mean the same thing, RootView is the root
FrameView which doesn't include scale and the pinch viewport offset.
Window (which I'll be renaming to viewport shortly) is the visible
viewport so it should include the pinch transformation. I've changed the
rootView version to window where the caller really means "viewport".
Also renamed "view" in coordinate cases to "frame" as I think it is
less ambiguous. e.g a call to contentsToRootView that actually wants
coordinates in the viewport space (i.e. DIP screen coordinates on Android,
DIP window coordinates on desktops) is now contentsToWindow and will soon
be contentsToViewport. A call to contentsToRootView that actually wants
coordinates in page coordinates (i.e. CSS pixels relative to the root
document) is now contentsToRootFrame.

There were external APIs that got or set coordinates in the RootView.
Again, these sometimes really meant viewport so I've renamed those as
appropriate as well. I've also made a few other coordinate related
cleanups along the way:
openPagePopup wasn't using the element rect param so I removed it.
I've renamed parameters like 'rect' and 'point' as I see them to make clear
what their coordinate space is.

BUG=371902

Review URL: https://codereview.chromium.org/919423002

git-svn-id: svn://svn.chromium.org/blink/trunk@190693 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=190682

BUG=453586
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/950083002

git-svn-id: svn://svn.chromium.org/blink/trunk@190692 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink Gardening.

BUG=461042
TEST=
TBR=zmo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/952703002

git-svn-id: svn://svn.chromium.org/blink/trunk@190691 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=450612
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/948063002

git-svn-id: svn://svn.chromium.org/blink/trunk@190690 bbb929c8-8fbe-4397-9dbb-9b2b20218538

PageScaleFactor isn't an InternalSetting so it doesn't make sense to reset it
here. The PageScaleFactor is reset in Internals::resetToConsistentState so this
should have no effect on current tests as these two are always called together.

BUG=

Review URL: https://codereview.chromium.org/945363006

git-svn-id: svn://svn.chromium.org/blink/trunk@190689 bbb929c8-8fbe-4397-9dbb-9b2b20218538

None of the implementations do anything with this argument.

R=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/952593003

git-svn-id: svn://svn.chromium.org/blink/trunk@190688 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink gardening.

BUG=461041
TEST=
TBR=zmo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/932243003

git-svn-id: svn://svn.chromium.org/blink/trunk@190687 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch implements elementsFromPoint from the following spec:
http://www.w3.org/TR/cssom-view/#extensions-to-the-document-interface

There are two changes in this patch:
1) HitTestResult's rect-based results have been converted into "list-
based" results. This required extracting out a mask for hit testing
with list-based results in HitTestRequest and making sure all
rect-based tests also pass HitTestRequest::ListBased when hit testing
(this is asserted in several places).

2) Document.elementsFromPoint has been implemented in a straightforward
way on top of #1. The test results match IE11 with one exception: IE11
does not ignore pointer-events none but this patch does (implied, but
not specified explicitly in the spec). Until
https://www.w3.org/Bugs/Public/show_bug.cgi?id=27829 is fixed, this
does not work on ShadowRoots, though the patch has been implemented
in TreeScope instead of Document to make adding ShadowRoot support trivial.

BUG=448529

Review URL: https://codereview.chromium.org/869813003

git-svn-id: svn://svn.chromium.org/blink/trunk@190686 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These methods are not used anymore.

Review URL: https://codereview.chromium.org/947213002

git-svn-id: svn://svn.chromium.org/blink/trunk@190685 bbb929c8-8fbe-4397-9dbb-9b2b20218538

An AudioBufferSourceNode that is looping should loop forever unless a
grain duration is explicitly given.  In particular, start(0, 0) should
still loop forever.

New test added, and updated one test in
audiobuffersource-loop-comprehensive to make it clear that the looping
source with duration stops at the right time.

Manual test added for handling the case where the AudioBufferSourceNode buffer is assigned after start() has been called. This is difficult to test properly using an offline context.


BUG=457099
TEST=audiobuffersource-loop-grain-no-duration.html

Review URL: https://codereview.chromium.org/912803005

git-svn-id: svn://svn.chromium.org/blink/trunk@190684 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=450612
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/951583002

git-svn-id: svn://svn.chromium.org/blink/trunk@190683 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Clip incremental invalidation rects for RenderBox (patchset #4 id:160001 of https://codereview.chromium.org/899813004/)

Reason for revert:
Suspected the original CL cause of the bug, but proved not.

Original issue's description:
> Revert of Clip incremental invalidation rects for RenderBox (patchset #3 id:40001 of https://codereview.chromium.org/548523005/)
> 
> Reason for revert:
> Haven't looked into the issue deeply, but in the future we won't care about the invalidation rects, so we can just revert this kind of optimizations.
> 
> BUG=453586
> 
> Original issue's description:
> > Clip incremental invalidation rects for RenderBox
> > 
> > RenderBox::incrementallyInvalidatePaint invalidates according to
> > border-box delta, not considering the bounds. If the bounds are
> > clipped by ancestor clipping, the incrementally invalidated rect
> > may exceed the ancestor clipping.
> > 
> > Clip the incremental invalidation rects by oldBounds and newBounds
> > to avoid invalidation on unrelated areas.
> > 
> > BUG=411420
> > TEST=fast/repaint/resize-with-border-clipped.html
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182081
> 
> TBR=jchaffraix@chromium.org,dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org
> BUG=411420
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189569

TBR=jchaffraix@chromium.org,dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org
BUG=453586,456176

Review URL: https://codereview.chromium.org/948513004

git-svn-id: svn://svn.chromium.org/blink/trunk@190682 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If the owning renderer gets resized, the scrollbar may be repositioned. Don't
rely on other reasons for invalidation (background, borders, child content
getting relaid out, etc.) to accidentally get the area covered by the
scrollbars invalidated, since there may very well be no other reason.

BUG=460434
R=jchaffraix@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/942963002

git-svn-id: svn://svn.chromium.org/blink/trunk@190681 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Invalidation sets which are empty stems from selector features only found
in the rightmost compound selector, and can only cause invalidation of
elements for which they are scheduled. When adding these sets, just mark
the element with a LocalStyleChange and do not schedule a style
invalidation for them.

Similarly, mark with a SubtreeStyleChange and clear all scheduled
invalidation sets for an element which gets a wholeSubtreeInvalid set
scheduled.

This fixes two sub-optimal behaviors in the code.

1. We avoid running style invalidation, hence traversing the DOM tree an
   extra time, if we only have local/subtree changes scheduled.
2. We avoid traversing subtrees checking against an empty invalidation set
   that will never match.

Note that we will still have to run the style invalidation step to clear
style invalidation bits on elements if there were invalidation sets
scheduled prior to a SubtreeStyleChange that nuked the entry in the
m_pendingInvalidationMap.

Added missing check for m_customPseudoInvalid in isEmpty and resetting it
in setWholeSubtreeInvalid() was added.

Since rules of type ".x {}" will not lead to a style invalidation pass
anymore, ".x .dummy {}" type rules have been added to the inspector tests
when testing style invalidation tracking.

Review URL: https://codereview.chromium.org/946993002

git-svn-id: svn://svn.chromium.org/blink/trunk@190680 bbb929c8-8fbe-4397-9dbb-9b2b20218538