- 08 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/902cf1e12a74..a6f07c5b5c7e git log 902cf1e12a74..a6f07c5b5c7e --date=short --no-merges --format='%ad %ae %s' 2019-10-08 benjaminwagner@google.com Reland "Use integer patchset and issue variables." Created with: gclient setdep -r src/third_party/skia@a6f07c5b5c7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I8feee4c4babe44e61c352fcae6c6138ada76501f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847322Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703684}
-
Julie Jeongeun Kim authored
This CL converts BeforeUnloadControl and MimeHandlerService from mime_handler.mojom using PendingReceiver, PendingRemote, Remote, and Receiver. Bug: 955171 Change-Id: Ia4ad1433553490f1288b766a75471b1599b8da19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846614 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#703683}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1167bff3e9a6..5a1a79c0e8de git log 1167bff3e9a6..5a1a79c0e8de --date=short --no-merges --format='%ad %ae %s' 2019-10-08 wl@gnu.org [woff2] Fix SFNT table checks. Created with: gclient setdep -r src/third_party/freetype/src@5a1a79c0e8de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Iff093d7a6c20b33515e69693260f0bcb2ca8c8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846756Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#703682}
-
Miyoung Shin authored
This change converts MediaDevicesDispatcherHost and MediaStreamDispatcherHost mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Ibe45f9fa4502812e43634ac18ab4defc8ed097c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844004Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#703681}
-
Mikhail Khokhlov authored
The old name is also supported for compatibility. Bug: 1011813 Change-Id: I513d316bea76c1355a2fdf6785acee6e6ca940af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847292Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#703680}
-
Marc Treib authored
FindBestMatches now returns the best matches in a vector, instead of in a map keyed by username. For now, FormFetcher[Impl] still sorts the matches by username; that'll be addressed in followup CLs. Bug: 1011399 Change-Id: I217aa7646bdc9eb9bf8cb2ff244f54f17b4f7a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844969 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#703679}
-
Julie Jeongeun Kim authored
This CL converts AppWindow in app_window.mojom using PendingReceiver, Remote, and ReceiverSet. Bug: 955171 Change-Id: I254824287a2dc520a8b1383bb34e9a829c7a9942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846637Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
-
Patrik Höglund authored
Tbr: skyostil@chromium.org Bug: 1012218 Change-Id: If238d6632769c3f4faa4fde81d53b26ba83bdf01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847293Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#703677}
-
Roman Aleksandrov authored
Bug: 1001484 Change-Id: I9e8ac8b51a197d807abe21b6c81546d5c9042f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823848Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#703676}
-
Julie Jeongeun Kim authored
This CL converts KeepAlive in keep_alive.mojom using PendingReceiver, ReceiverSet, and Receiver. Bug: 955171 Change-Id: I29b195d41000d185a3c7b45193794aac16ad0829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846413Reviewed-by:
-
Ioana Pandele authored
The type was left over from the export feature cleanup. Change-Id: I7d50256119f1467a36cafd33d385234f2ea06212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845768Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#703674}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a333b87cfcbe..199e8ee06a7a git log a333b87cfcbe..199e8ee06a7a --date=short --no-merges --format='%ad %ae %s' 2019-10-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src c18c9ff6bc30..3c7ff8d4f0a1 (1 commits) Created with: gclient setdep -r src/third_party/angle@199e8ee06a7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: Ifb9e9abe78ee56c8cddf8c73290a9b8810d2f849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847191Reviewed-by:
-
Fredrik Söderquist authored
Keep a cached value for the next "interesting"[1] time in a timed element. This cache is updated every time we get a new interval, change the end of an interval or trigger a repeat. This reduces the time spent in SMILTimeContainer::NextInterestingTime(), and lays the foundation for improved scheduling of interval updates in the future. The term "interesting" is replaced by "interval" in related function names and variables. [1] The next time that an interval either starts, ends or repeats. Bug: 998526 Change-Id: I082d37b2000bc8d691363d87c22309013823664b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844818 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703672}
-
Alexander Timin authored
R=ahemery@chromium.org Change-Id: Ib82b3c0861673822f79445df58db9429b3d72ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847333 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#703671}
-
Marc Treib authored
After https://crrev.com/c/1831873, a lot of code in the model is unused. Bug: 1007942 Change-Id: Ifc57c83d8cfd828836c704584c4c27c40b098565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835618 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#703670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66bd5d4deb12..482a6e85b167 Created with: gclient setdep -r src-internal@482a6e85b167 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If7ddcc39602d8facd72ad19e82ca436013085d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845890Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703669}
-
Julie Jeongeun Kim authored
This CL converts UDPSocketListener from udp_socket.mojom to new Mojo types using PendingReceiver, Receiver, PendingRemote, Remote and Receiver. Bug: 955171 Change-Id: I6ce6be80e58a485ba7674db40fe55b6d95452eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831961Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Christoph Schwering authored
Added copy and move constructors and move assignment operators to structs which had only a copy constructor defined. Set constructors to =default where applicable. Added |name_attribute|, |id_attribute| to FormData's comparison methods to be in line with FormFieldData's comparison methods. Bug: 1007974 Change-Id: I97cf61c8a5b3512b9d99f677f848fb74ca669041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844775 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d140f412..79eb4f5c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib1b6edbeeb7b92f47e718f9eac2bb0c28eddb8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703666}
-
W. James MacLean authored
Since we're still monitoring the performance of the new PDF codepaths and won't be removing the old codepath for at least one more milestone, extend the life of the histograms until M-81. Bug: 659750 Change-Id: I72c5d9d918ab885fdd41f8b151cb88bc5e1eb2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845874Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#703665}
-
Mikel Astiz authored
This allows verifying that the keys provided via Web correspond to the sync-ing user. Bug: 1000146 Change-Id: Ib6eed0d244679703d55b164d2f71432b43695e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847219Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703664}
-
Rune Lillesveen authored
When considering dirty nodes for style recalc roots, we did not consider nodes which were marked GetForceReattachLayoutTree(), but not marked for recalc, as dirty nodes. With the current code, it simply caused us to have the recalc root higher up the tree than strictly necessary, but with FlatTreeStyleRecalc enabled, it caused fullscreen test faillures. The reason is that Node::SetIsInTopLayer only marks node for forced reattach and since the Document node is no longer marked as ChildNeedsStyleRecalc(), a subsequent SetNeedsStyleRecalc on a descendant would walk all the way to the top without finding a dirty node or a child-dirty node. Bug: 972752 Change-Id: I640ce04afd86d8ca032460d72bd088418cee10c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844955 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#703663}
-
Cathie Chen authored
When scrollbar wider than the scrollar, the size of OverflowClipRect is negative which will affect the value of scroll offset. This patch make the size non-negative. Bug: 987566 Change-Id: I7fa80e4a17bc48303713a1a191230d0b3e7d0dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840492 Commit-Queue: cathie chen <cathiechen@igalia.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703662}
-
Kamila authored
This cl adds the following metrics for the new notifications UI on desktop: - Metric tracking how many people click on the “Show for site” button. - Metric tracking how many people click on the notifications indication icon. - Sliding icon - Static icon - Metric on how many people click “Manage” in the notifications bubble. Bug: 986737 Cq-Depend: chromium:1726092 Change-Id: I1ffedbb96a76185afcb9adbaade4f72da4e6259f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780736 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703661}
-
Maksim Sisov authored
SetVisibilityChangedAnimationsEnabled has default impl provided by PlatformWindow. At the moment, only Windows may have real impl of that method. Though, it is not clear if other platforms like Scenic can have animations. Bug: 990756 Change-Id: I3ba648f04e061643a855eb5b24808a1a29acc1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834348 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#703660}
-
Colin Blundell authored
Part of the effort to eliminate the legacy IPC system. Bug: 1007300 Change-Id: Idbe41f4be45af0be18eea4fd485bcf313dca480c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836494 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#703659}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/603e7a0e5a97..f91a82bb1624 git log 603e7a0e5a97..f91a82bb1624 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 eseckler@google.com Merge changes I18393bb3,Ib75271f7 Created with: gclient setdep -r src/third_party/perfetto@f91a82bb1624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I965eef965cf18a0044f9381501220b44866f11d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845918Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/496c95ad404c..0b1af463167a git log 496c95ad404c..0b1af463167a --date=short --no-merges --format='%ad %ae %s' 2019-10-08 perezju@chromium.org [Telemetry] Remove support for summary values Created with: gclient setdep -r src/third_party/catapult@0b1af463167a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:921000 Change-Id: Iee8eac3b4264aa5fc966e0b82d13ff93b7b6f7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847192Reviewed-by:
-
Michael Olbrich authored
Don't call surfaces_.erase() inside DCHECK(). Otherwise this is not executed when chromium is built without DCHECK. As a result deleted surfaces may be accessed. Call surfaces_.erase() unconditionally and only check the return value to fix this. Bug: 1006813 Change-Id: Id8f280afd0f92770dda1b7b66b892343d6939c02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845755Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#703656}
-
Yang Guo authored
Change-Id: I87d875c4ddc9fe23a7b9c200165443f84818623a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838193Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703655}
-
Jan Krcal authored
This CL changes the way we represent user's identity in the pill: we now show the user's first name (if available) and resort to email, otherwise. This CL also moves from Email specific naming of functions towards more generic "Identity" (as it is not always Name, either). Bug: 967317 Change-Id: Ibea8f2953687a32a54f70a8a59dbf147d4114db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832220 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#703654}
-
François Beaufort authored
Following WebGPU spec change https://github.com/gpuweb/gpuweb/pull/461, this CL removes NONE=0 flags/bits. Change-Id: I675d6cbd9df8f30138276cef94f9a24e9e33a008 Bug: 877147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845762 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#703653}
-
arthursonzogni authored
In the constructor: ~~~ explicit WebContentsTracker(bool track_fullscreen_rwhv); ~~~ |track_fullscreen_rwhv| is always false. So it must be removed, with its implementation. Bug: None. Change-Id: Icccac2143d6150cd00d040853cb2c610aba4aa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841340Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703652}
-
Jérôme Lebel authored
Adding kGoogleServicesSettingsViewIdentifier const variable for EarlGrey tests. Change-Id: Iea324479412bd7d5b3fbaf2df4dd5f7a719e616f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836504 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#703651}
-
Julian Watson authored
Change-Id: I81cd0f7ac56d381662a9c644bcbe9699f54b9e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840271 Auto-Submit: Julian Watson <juwa@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#703650}
-
Benedikt Meurer authored
In `Timeline.TimelineUIUtils.eventStyle()` we used to return either a `Timeline.TimelineUIUtils` instance or a custom object literal, we even put a custom type annotation here to make that pass Closure type checking. But it's better to just use `Timeline.TimelineRecordStyle` consistently here, and also faster. Change-Id: Ie8834b7a4f8862fde3d2d7c6d6c5ee04dec76b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845752 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703649}
-
Marc Treib authored
The DB was read, but nothing was ever written to it. Note: This CL *could* introduce behavior changes if some previous versions of Chrome/ium wrote data to the DB. But that doesn't seem like a case we'd want to continue supporting. Bug: 1007942 Change-Id: Iaaf6efaf96e0b853cf176d693c7049179276696e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831873Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703648}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd88df5d116c..902cf1e12a74 git log dd88df5d116c..902cf1e12a74 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5e9d4ee99ea1..a333b87cfcbe (8 commits) 2019-10-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@902cf1e12a74 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: I6e934b3230cd64137c44d273f68249a82c0f413e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845917Reviewed-by:
-
Patrik Höglund authored
On Linux and Mac (only seeing it there). Tbr: danakj@chromium.org Bug: 1012185 Change-Id: Ibe501f10b7fd6c43ca02e7fec68259ec8eddf590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845769Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining references to this interface using the old mojo types in tests. Bug: 955171, 978694 Change-Id: I2b4bb0701f3d932b830c06be945ea1e0cdb643f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840691Reviewed-by:
-
